Re: IGNITE-640: multimap initial implementation

2019-07-03 Thread Denis Magda
Hey Anton, Amir, Looks like we've abandoned the multimap support somewhere close to the finish line. What's left open? Should we find another contributor who can finish the feature? - Denis On Wed, Sep 5, 2018 at 2:33 AM Anton Vinogradov wrote: > Denis, > Discussion relocated to the issue. >

Re: IGNITE-640: multimap initial implementation

2018-09-05 Thread Anton Vinogradov
Denis, Discussion relocated to the issue. Amir is working on implementation now. ср, 5 сент. 2018 г. в 1:53, Denis Magda : > Amir, Anton, > > How is dev/review process going? Is there any chance we get this capability > into 2.7? > > -- > Denis > > On Mon, Jul 9, 2018 at 10:27 PM Amir Akhmedov

Re: IGNITE-640: multimap initial implementation

2018-09-04 Thread Denis Magda
Amir, Anton, How is dev/review process going? Is there any chance we get this capability into 2.7? -- Denis On Mon, Jul 9, 2018 at 10:27 PM Amir Akhmedov wrote: > Hi Anton, > > I checked your last comments in the ticket and left some responses. Please > check them and let me know > > Thanks,

Re: IGNITE-640: multimap initial implementation

2018-07-09 Thread Amir Akhmedov
Hi Anton, I checked your last comments in the ticket and left some responses. Please check them and let me know Thanks, Amir P.S. do you mind to have a chat/call through gitter/Skype to discuss the details? Sometimes 5 minutes of chat can be more productive than long running email chains.

Re: IGNITE-640: multimap initial implementation

2018-06-27 Thread Anton Vinogradov
Sure, Hope it will be tomorrow ср, 27 июн. 2018 г. в 18:11, Amir Akhmedov : > Anton V, > I put some comments into jira ticket. Can you please take a look once you > have a chance? > > Thanks, > Amir > > On Mon, Jun 18, 2018, 7:54 AM Anton Vinogradov wrote: > > > Amir, > > > > Everything is

Re: IGNITE-640: multimap initial implementation

2018-06-27 Thread Amir Akhmedov
Anton V, I put some comments into jira ticket. Can you please take a look once you have a chance? Thanks, Amir On Mon, Jun 18, 2018, 7:54 AM Anton Vinogradov wrote: > Amir, > > Everything is fine, I'll check changes this week. > > вс, 17 июн. 2018 г. в 6:09, Amir Akhmedov : > > > Anton, > > I

Re: IGNITE-640: multimap initial implementation

2018-06-18 Thread Anton Vinogradov
Amir, Everything is fine, I'll check changes this week. вс, 17 июн. 2018 г. в 6:09, Amir Akhmedov : > Anton, > I created a news PR [1]. Since it includes the same changes I did not run > TC tests on it. Please let me know if you think otherwise. > > [1]

Re: IGNITE-640: multimap initial implementation

2018-06-16 Thread Amir Akhmedov
Anton, I created a news PR [1]. Since it includes the same changes I did not run TC tests on it. Please let me know if you think otherwise. [1] https://github.com/apache/ignite/pull/4207 Thanks, Amir On Wed, Jun 13, 2018 at 8:38 AM Anton Vinogradov wrote: > Amir, > > Thanks for attempt. >

Re: IGNITE-640: multimap initial implementation

2018-06-13 Thread Anton Vinogradov
Amir, Thanks for attempt. As far as I can see you have all changes at this commit: https://github.com/apache/ignite/pull/3926/commits/cd0e50e05d3860788378ebf1a29dc0525460872a You can simply apply it to local branch based on master by patch

Re: IGNITE-640: multimap initial implementation

2018-06-05 Thread Amir Akhmedov
Dmitry P., Anton V., I made some changes and updated the ticket. Also as was asked I tried to squash the commits into one but looks like I screwed up everything and the PR now looks completely terrible. Since I'm not an advanced git user, could you please check the PR and let me know if anything

Re: IGNITE-640: multimap initial implementation

2018-05-29 Thread Dmitry Pavlov
Hi Amir, As far as I know, several Igniters provided some feedback in ticket. Are you agree? Sincerely, Dmitriy Pavlov чт, 10 мая 2018 г. в 20:01, Dmitry Pavlov : > Hi Amir, > > This is a very necessary contribution, the patch defenetely will not be > ignored. > > Igniters, > > Who can make a

Re: IGNITE-640: multimap initial implementation

2018-05-10 Thread Dmitry Pavlov
Hi Amir, This is a very necessary contribution, the patch defenetely will not be ignored. Igniters, Who can make a review from the committers? Sincerely, Dmitriy Pavlov вт, 8 мая 2018 г. в 5:52, Amir Akhmedov : > Hi Igniters, > > Can someone take a look at this PR

Re: IGNITE-640: multimap initial implementation

2018-05-07 Thread Amir Akhmedov
Hi Igniters, Can someone take a look at this PR please? Thanks, Amir On Mon, Apr 30, 2018 at 5:28 AM, Pavel Tupitsyn wrote: > Hi Amir, > > I have filed [1] for multimap in .NET, it will be done later. > In order to fix IgniteParityTest failures, please add the following

Re: IGNITE-640: multimap initial implementation

2018-04-30 Thread Pavel Tupitsyn
Hi Amir, I have filed [1] for multimap in .NET, it will be done later. In order to fix IgniteParityTest failures, please add the following to MissingMembers array there: "multimap" // IGNITE-8425 Thanks, Pavel [1] https://issues.apache.org/jira/browse/IGNITE-8425 On Sun, Apr 29, 2018 at