Re: TDE Implementation details.

2018-10-02 Thread Nikolay Izhikov
Hello, Dmitriy. Thank you for feedback! > 1) I suggest changing encrypt() and decrypt() method would take the same type > of parameters. > This uniformity will avoid implementors questions about why encrypt takes > byte[] but decrypt takes ByteBuffer. This is done by a reason. encrypt and

Re: TDE Implementation details.

2018-10-02 Thread Dmitriy Pavlov
Hi Igniters, I'm sorry I a little bit late to the party, but I found a couple of hours to take a look to TDE-1 implementation https://issues.apache.org/jira/browse/IGNITE-8485 . Nikolay kindly agreed to let me take a look. Most of the change was done well and I totally agree with it. Current

Re: TDE Implementation details.

2018-09-12 Thread Denis Magda
Hello Nikolay, Excellent progress, look forward to seeing the TDE released in 2.7! -- Denis On Wed, Sep 12, 2018 at 2:47 AM Nikolay Izhikov wrote: > Hello, Denis. > > > Could you please list the limitations of Phase 1? > > I'm curious what won't be supported in 2.7. > > 1. We will have

Re: TDE Implementation details.

2018-09-12 Thread Nikolay Izhikov
Hello, Denis. > Could you please list the limitations of Phase 1? > I'm curious what won't be supported in 2.7. 1. We will have ability to encrypt data stored on the disk for specific cache. - There is no limitation on API usage or something for an encrypted cache. - If some

Re: TDE Implementation details.

2018-09-11 Thread Denis Magda
Nikolay, Could you please list the limitations of Phase 1? I'm curious what won't be supported in 2.7. -- Denis On Tue, Sep 11, 2018 at 4:29 PM Nikolay Izhikov wrote: > > As I understand the plan is to get TDE Phase 1 released in 2.7, right? > > Yes. We will release TDE in 2.7 > > > Could you

Re: TDE Implementation details.

2018-09-11 Thread Nikolay Izhikov
> As I understand the plan is to get TDE Phase 1 released in 2.7, right? Yes. We will release TDE in 2.7 > Could you also list what needs to be done at Phase 2 and how much time it > might take. Yes, I think Dmitry Ryabov will send Phase 2 design В Вт, 11/09/2018 в 23:27 +0300, Nikolay

Re: TDE Implementation details.

2018-09-11 Thread Nikolay Izhikov
Hello, Denis. Yes, Vladimir made 2 rounds of review. I planning to fix all issues with implementation in a few days. В Вт, 11/09/2018 в 10:40 -0400, Denis Magda пишет: > Hi Nikolay, > > Has anybody started looking into your request? As I understand the plan is > to get TDE Phase 1 released in

Re: TDE Implementation details.

2018-09-11 Thread Denis Magda
Hi Nikolay, Has anybody started looking into your request? As I understand the plan is to get TDE Phase 1 released in 2.7, right? https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89067473 Could you also list what needs to be done at Phase 2 and how much time it might take. --