Re: Set default cache synchronization mode to FULL_SYNC

2017-08-04 Thread Дмитрий Рябов
I mean "set readFromBackup = false" (copy-paste was bad idea). 2017-08-04 14:21 GMT+03:00 Дмитрий Рябов : > +1 to change PRIMARY_SYNC to FULL_SYNC. > > I think it is not reasonable to set readFromBackup=true by default, > especially for replicated caches, but FULL_SYNCE will keep cache in > consi

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-04 Thread Anton Vinogradov
Dmitriy, > I think it is not reasonable to set readFromBackup=true by default, > especially for replicated caches, but FULL_SYNCE will keep cache in > consistent state. readFromBackup=true allows you to read from backup instead of making request to primary node, so it should be useful, especially

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-04 Thread Дмитрий Рябов
+1 to change PRIMARY_SYNC to FULL_SYNC. I think it is not reasonable to set readFromBackup=true by default, especially for replicated caches, but FULL_SYNCE will keep cache in consistent state. 2017-08-04 13:23 GMT+03:00 Anton Vinogradov : > +1 to change PRIMARY_SYNC to FULL_SYNC and keep readFr

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-04 Thread Anton Vinogradov
+1 to change PRIMARY_SYNC to FULL_SYNC and keep readFromBackup=true Dmitriy, Why should we wait for 3.0? This change looks safe for me. On Wed, Aug 2, 2017 at 9:51 PM, Dmitriy Setrakyan wrote: > We have to wait with any default changes to 3.0, unfortunately. > > On Wed, Aug 2, 2017 at 8:30 PM,

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-02 Thread Dmitriy Setrakyan
We have to wait with any default changes to 3.0, unfortunately. On Wed, Aug 2, 2017 at 8:30 PM, Vladimir Ozerov wrote: > Not sure about readFromBackup, but changing PRIMARY_SYNC to FULL_SYNC looks > safe to me. Any other thoughts? > > ср, 2 авг. 2017 г. в 21:10, Denis Magda : > > > +1 for both s

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-02 Thread Vladimir Ozerov
Not sure about readFromBackup, but changing PRIMARY_SYNC to FULL_SYNC looks safe to me. Any other thoughts? ср, 2 авг. 2017 г. в 21:10, Denis Magda : > +1 for both suggestions but I’m not sure we can do the change till 3.0. > > — > Denis > > > On Aug 2, 2017, at 1:27 AM, Vladimir Ozerov > wrote:

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-02 Thread Denis Magda
+1 for both suggestions but I’m not sure we can do the change till 3.0. — Denis > On Aug 2, 2017, at 1:27 AM, Vladimir Ozerov wrote: > > +1 for readFromBackup=false as well :-) Another example of default value > with subtle effects. > > On Wed, Aug 2, 2017 at 11:11 AM, Alexey Goncharuk < > ale

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-02 Thread Vladimir Ozerov
+1 for readFromBackup=false as well :-) Another example of default value with subtle effects. On Wed, Aug 2, 2017 at 11:11 AM, Alexey Goncharuk < alexey.goncha...@gmail.com> wrote: > Vladimir, > > Personally, I agree that we should put correctness over performance, > however (1) is not a correct

Re: Set default cache synchronization mode to FULL_SYNC

2017-08-02 Thread Alexey Goncharuk
Vladimir, Personally, I agree that we should put correctness over performance, however (1) is not a correct statement for TRANSACTIONAL caches. A transactional client always validates the result of an operation and throw a correct exception if operation failed. (1) is true for ATOMIC caches, thoug

Set default cache synchronization mode to FULL_SYNC

2017-08-02 Thread Vladimir Ozerov
Igniters, I want to re-iterate idea of changing default synchronization mode from PRIMARY_SYNC to FULL_SYNC. Motivation: 1) If user set [cacheMode=PARTITIONED, backups=1] he still could loose data silently. Because primary node could report success to the client and then crash before data is prop