Re: Static code analysis for Java

2018-04-02 Thread Dmitry Pavlov
According recent conversation 'Code Inspection' I would like to bump up this thread too. Igniters, who can advice if coverity has integration/ability to be run on TeamCity? Who can help to proof, that it is possible to be executed using maven. вт, 19 сент. 2017 г. в 14:27, Yakov Zhdanov : > Bas,

Re: Static code analysis for Java

2017-09-19 Thread Yakov Zhdanov
Bas, thanks for joining! Can you please point me to the page listing all types of issue LGTM can find (like this one - https://scan.coverity.com/faq#what-types-of-issues-tool-find)? LGTM really helped to find some bugs like incorrect key type when working with hash map instance, unnecessary boxi

Re: Static code analysis for Java

2017-09-18 Thread Jörn Franke
Why do not use all of the tools (well at least several). They are easy to be integrateable. In this way one would be less exposed to promote one commercial vendor over the other. This would also help in finding the right quality criteria instead of analyzing what is offered by only one solution

Re: Static code analysis for Java

2017-09-18 Thread Bas van Schaik
Hi all, My colleague Malcolm copied me in on this thread. Full disclosure: we're part of the team behind lgtm.com. Glad to hear that you guys like lgtm.com and the results we report for Ignite! We've only launched recently and are seeing a really quick growth in the number of users from the

Re: Static code analysis for Java

2017-09-14 Thread Dmitriy Setrakyan
Hm... LGTM tool looks nice! Check out all the errors it already found in Ignite :) https://lgtm.com/projects/g/apache/ignite/alerts/?mode=list&severity=error D. On Thu, Sep 14, 2017 at 9:21 AM, Pavel Tupitsyn wrote: > Yes, we can run IDEA inspections, and this is the simplest thing to do, > si

Re: Static code analysis for Java

2017-09-14 Thread Pavel Tupitsyn
Yes, we can run IDEA inspections, and this is the simplest thing to do, since TeamCity already has this step available. On Thu, Sep 14, 2017 at 7:05 PM, Alexey Kuznetsov wrote: > AFIK, we can run on TC same code analyzer that built in IDEA. > > See: > > CodeCoverageResults > > https://confluence

Re: Static code analysis for Java

2017-09-14 Thread Alexey Kuznetsov
AFIK, we can run on TC same code analyzer that built in IDEA. See: CodeCoverageResults https://confluence.jetbrains.com/display/TCD10/Working+with+Build+Results#WorkingwithBuildResults-CodeCoverageResults Code Inspection https://confluence.jetbrains.com/display/TCD10/Working+with+Build+Results

Re: Static code analysis for Java

2017-09-14 Thread Anton Vinogradov
Wow, Seems, that's what we were looking for! On Thu, Sep 14, 2017 at 6:26 PM, Malcolm Taylor wrote: > Yakov, > > You might also wish to consider lgtm.com, which is already analysing > Ignite > builds ( https://lgtm.com/projects/g/apache/ignite/ ). > It has found a number of issues, some of which

Re: Static code analysis for Java

2017-09-14 Thread Malcolm Taylor
Yakov, You might also wish to consider lgtm.com, which is already analysing Ignite builds ( https://lgtm.com/projects/g/apache/ignite/ ). It has found a number of issues, some of which have been fixed through https://issues.apache.org/jira/browse/IGNITE-5805 lgtm also supports the option of GitHub

Static code analysis for Java

2017-09-14 Thread Yakov Zhdanov
Guys, I remember we tried some static code analysis tools for Java (a bit awkward not having one yet), but we did not setup regular checks. I want to return to this. As result I would like to have code analysis tool running on TC on daily basis and also established process to review and fix code