Re: Timeout for ordered message

2017-01-23 Thread Valentin Kulichenko
Makes sense. I created a ticket: https://issues.apache.org/jira/browse/IGNITE-4595 -Val On Mon, Jan 23, 2017 at 3:05 AM, Yakov Zhdanov wrote: > Val, let's do the following. > > 1. We need to state in javadocs that we expect unordered msg handler to be > added in advance, otherwise message get i

Re: Timeout for ordered message

2017-01-23 Thread Yakov Zhdanov
Val, let's do the following. 1. We need to state in javadocs that we expect unordered msg handler to be added in advance, otherwise message get ignored. This may require user should have an ability to add listeners before start (same as in case with event listeners) - or can this be done in lifecy

Re: Timeout for ordered message

2017-01-12 Thread Valentin Kulichenko
Yakov, I'm talking only about user messages and public API. What is the purpose of the timeout in this case? I'm just trying to properly understand the semantics and at least fix the JavaDoc as it seems to be completely wrong now. -Val On Thu, Jan 12, 2017 at 2:41 AM, Yakov Zhdanov wrote: > N

Re: Timeout for ordered message

2017-01-12 Thread Yakov Zhdanov
Not sure what we are trying to achieve here. Unordered messages are simply ignored if there is no listener. We always expect unordered listeners to be installed before at least for internal messages, but this is not the case for some ordered messages, i.e. task session requests. --Yakov 2017-01-1

Re: Timeout for ordered message

2017-01-11 Thread Valentin Kulichenko
Yakov, So you confirm that my understanding is correct and JavaDoc is wrong, right? As for 'no listener' scenario, that's a good point, but it should be applicable to unordered messages as well then. The most confusing part here is that we have timeout only for unordered messages while there is n

Re: Timeout for ordered message

2017-01-11 Thread Yakov Zhdanov
If you send ordered messages to a node and listener on receiving side has not yet been added then timeout is still sufficient to clean up buffered messages. --Yakov 2017-01-10 23:36 GMT+03:00 Valentin Kulichenko < valentin.kuliche...@gmail.com>: > Yakov, > > I was actually asking about the publi

Re: Timeout for ordered message

2017-01-10 Thread Valentin Kulichenko
Yakov, I was actually asking about the public API for messaging (IgniteMessaging#sendOrdered method). Here is the JavaDoc: * The {@code timeout} parameter specifies how long an out-of-order message will stay in a queue, * waiting for messages that are ordered ahead of it to arrive. If timeout e

Re: Timeout for ordered message

2017-01-10 Thread Yakov Zhdanov
Val, timeout still makes sense for task sessions. It is possible that all jobs mapped to node have been completed, but node still receives attributes. Attributes are sent in ordered messages. It may happen so that node may start processing jobs for that task again and this way all the attributes wi

Timeout for ordered message

2017-01-05 Thread Valentin Kulichenko
Folks, Anyone knows what is the purpose of the timeout for IgniteMessaging#sendOrdered method? void sendOrdered(@Nullable Object topic, Object msg, long timeout); It seems to me that in current implementation messages are always ordered on communication level. I.e. if you send messages 1, 2 and