Re: IGNITE-4758 - introducing cache memory policies

2017-03-02 Thread Sergey Chugunov
Yes, they use the same PageMemory region. On Wed, Mar 1, 2017 at 10:34 PM, Dmitriy Setrakyan wrote: > When 2 caches share the same memory policy, does it mean that they are > using the same Page Memory offheap space? > > On Tue, Feb 28, 2017 at 11:49 PM, Sergey Chugunov <

Re: Additional SQL metrics

2017-03-02 Thread Vladimir Ozerov
Denis, Query execution is complex process involving different stages which are not very easy to match with each other. Especially provided that any node can leave topology at any time. Another problem is that engine evolves and metrics like "did a query do broadcast or unicast" may easily become

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
I checked it: jdk8u121_x64 - *fine* jdk8u91_x64 - *fail* It is strange. 2017-03-02 11:53 GMT+03:00 Sergey Kozlov : > I used Oracle JDK 1.8.0_91 > > On Thu, Mar 2, 2017 at 11:38 AM, Vyacheslav Daradur > wrote: > > > Denis, Sergey witch version of JDK8

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Anton Vinogradov
Folks, Right before vote I faced with compilation error at 1.8.0_121-b13, that's why this flag was added. Vyacheslav, at first message you told >> I got this exception with the lates jdk-8u121. at next one >> jdk8u121_x64 - *fine* >> jdk8u91_x64 - *fail* Which one is true? I have no

Re: REVIEW IGNITE-2552 EvictionPolicies refactored, logic changed

2017-03-02 Thread ALEKSEY KUZNETSOV
lets review code at github rather than upsource later on. Because, the later is too slow and bring no substantial benefits compared github ср, 1 мар. 2017 г. в 18:04, Andrey Gura : > Hi, Aleksey! > > Thank you for contribution! > > I've reviewed your changes and have some

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
Denis, Sergey witch version of JDK8 do you use? I got this exception with the lates jdk-8u121. Building with flag "-Dmaven.javadoc.skip=true" works fine. Look at "*New --allow-script-in-comments option for javadoc":* http://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
Guys, I found that. apache-ignite-1.9.0-src\parent\pom.xml line: 940 We need to remove flag "--allow-script-in-comments", it is new, and not capability with version less than jdk8u121_x64 I can create PR with fix, or you can just fix it yourself. 2017-03-02 12:35 GMT+03:00 Vyacheslav Daradur

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
>> Which one is true? This one true for https://dist.apache.org/repos/dist/dev/ignite/1.9.0-rc1: jdk8u121_x64 - *fine* jdk8u91_x64 - *fail 2017-03-02 12:52 GMT+03:00 Vyacheslav Daradur : > >> I got this exception with the lates jdk-8u121. > I had this problem earlier, not

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
>> I got this exception with the lates jdk-8u121. I had this problem earlier, not with RC. Sorry for misleading >> Which one is true? This one true for https://dist.apache.org/repos/dist/dev/ignite/1.9.0-rc1: jdk8u121_x64 - *fine* jdk8u91_x64 - *fail 2017-03-02 12:46 GMT+03:00 Anton

code refactoring suggestion

2017-03-02 Thread ALEKSEY KUZNETSOV
Hi all ! During pessimistic transaction we execute prepare phase at org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxLocal#commitAsync after executing prepareAsync(); We bind listener on prepare future. Perhaps its better initially bind listener and then execute

[jira] [Created] (IGNITE-4767) rollback exception hides the origin exception (e.g. commit)

2017-03-02 Thread Alexandr Kuramshin (JIRA)
Alexandr Kuramshin created IGNITE-4767: -- Summary: rollback exception hides the origin exception (e.g. commit) Key: IGNITE-4767 URL: https://issues.apache.org/jira/browse/IGNITE-4767 Project:

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Sergey Kozlov
I used Oracle JDK 1.8.0_91 On Thu, Mar 2, 2017 at 11:38 AM, Vyacheslav Daradur wrote: > Denis, Sergey witch version of JDK8 do you use? > > I got this exception with the lates jdk-8u121. > > Building with flag "-Dmaven.javadoc.skip=true" works fine. > > Look at "*New

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-02 Thread Kozlov Maxim
Andrey, Please review PR again. > 1 марта 2017 г., в 18:47, Andrey Gura написал(а): > > I think that it is ok. > > On Wed, Mar 1, 2017 at 6:34 PM, Kozlov Maxim wrote: >> Ok. What do you say for the rest? >> >>> 1 марта 2017 г., в 18:15, Andrey Gura

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-02 Thread Kozlov Maxim
Andrey, When removed parameter globalTime, in method: public IgniteUuid asGridUuid() { return new IgniteUuid(new UUID(((long)topVer << 32) | nodeOrderDrId, globalTime), order); } globalTime parameter replaced by something or remove this method? > 2 марта 2017 г., в 12:07, Kozlov Maxim

[jira] [Created] (IGNITE-4766) Relax worker thread wakeup logic in StipedExecutor

2017-03-02 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-4766: --- Summary: Relax worker thread wakeup logic in StipedExecutor Key: IGNITE-4766 URL: https://issues.apache.org/jira/browse/IGNITE-4766 Project: Ignite

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Anton Vinogradov
Vyacheslav, Do you have Ideas why we got [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.1:jar (module-javadoc) on project ignite-tools: MavenReportException: Error while creating archive: [ERROR] Exit code: 1 - javadoc: error - Argument for -bottom contains

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Anton Vinogradov
I found the reason, Thats because of tag content at parent/pom.xml:455 It contains !function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s); js.id=id;js.src=p+'://

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
Anton, I found it too. And I confirm, it is the main reason of building-error. If remove ., then: "mvn clean package -DskipTests" jdk1.8.0_121_x64 - fine jdk1.8.0_91_x64 - fine As I understood, this script create a link to Ignite-twitter. I think it is not very important. I am trying

[GitHub] ignite pull request #1585: IGNITE 4577 filter non reachable addresses

2017-03-02 Thread ezhuravl
GitHub user ezhuravl opened a pull request: https://github.com/apache/ignite/pull/1585 IGNITE 4577 filter non reachable addresses You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4577 Alternatively

[GitHub] ignite pull request #1550: IGNITE-2310: additional docs for affinity jobs

2017-03-02 Thread tledkov-gridgain
Github user tledkov-gridgain closed the pull request at: https://github.com/apache/ignite/pull/1550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Anton Vinogradov
Vyacheslav, I see strange spaces and newlines here, please make a pull request, to solve possible formation issues. On Thu, Mar 2, 2017 at 2:04 PM, Vyacheslav Daradur wrote: > Anton, a workaround solution: > > js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d. >

[GitHub] ignite pull request #1536: IGNITE-4577 Add sort for virtual interface addres...

2017-03-02 Thread ezhuravl
Github user ezhuravl closed the pull request at: https://github.com/apache/ignite/pull/1536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Anton Vinogradov
I propose to remove this script and keep only https://twitter.com/ApacheIgnite; class="twitter-follow-button" data-show-count="false" data-size="large">Follow @ApacheIgnite and fix this in proper way before next release. Thoughts? On Thu, Mar 2, 2017 at 1:05 PM, Anton Vinogradov

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
Anton, a workaround solution: 2017-03-02 13:39 GMT+03:00 Vyacheslav Daradur : > Anton, I found it too. > > And I confirm, it is the main reason of building-error. > > If remove ., then: > "mvn clean package -DskipTests" > jdk1.8.0_121_x64 - fine > jdk1.8.0_91_x64 -

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Anton Vinogradov
I've created the issue https://issues.apache.org/jira/browse/IGNITE-4770 On Thu, Mar 2, 2017 at 2:17 PM, Anton Vinogradov wrote: > Vyacheslav, > > I see strange spaces and newlines here, please make a pull request, to > solve possible formation issues. > > On Thu, Mar

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-02 Thread Alexey Goncharuk
Maxim, I see several usages of asGridUuid() method, so I would just remove global time and use nodeOrderDrId and topVer as different parts of high and low parts of the embedded UUID. --AG 2017-03-02 12:39 GMT+03:00 Kozlov Maxim : > Andrey, > > When removed parameter

[GitHub] ignite pull request #1586: IGNITE-4770

2017-03-02 Thread daradurvs
Github user daradurvs closed the pull request at: https://github.com/apache/ignite/pull/1586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (IGNITE-4769) Handle possibly duplicated discovery messages

2017-03-02 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-4769: --- Summary: Handle possibly duplicated discovery messages Key: IGNITE-4769 URL: https://issues.apache.org/jira/browse/IGNITE-4769 Project: Ignite Issue

[jira] [Created] (IGNITE-4770) Script inside javadoc bottom cause compilation error at 1.8.0_121-b13

2017-03-02 Thread Anton Vinogradov (JIRA)
Anton Vinogradov created IGNITE-4770: Summary: Script inside javadoc bottom cause compilation error at 1.8.0_121-b13 Key: IGNITE-4770 URL: https://issues.apache.org/jira/browse/IGNITE-4770

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
Anton, I think I found better way. Please, look at: https://github.com/apache/ignite/pull/1586/files 2017-03-02 15:19 GMT+03:00 Anton Vinogradov : > I've created the issue > https://issues.apache.org/jira/browse/IGNITE-4770 > > On Thu, Mar 2, 2017 at 2:17 PM, Anton

Re: IGNITE-4758 - introducing cache memory policies

2017-03-02 Thread Sergey Chugunov
Hello igniters, Working on the JIRA I found several situations not totally clear to me how to handle properly. First of all I introduced several validation rules for MemoryPolicy configurations: - If user doesn't specify any MemoryPolicy, a default one is created implicitly. - If user

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur
Anton, please be careful: my PR doesn't contain the flag "--allow-script-in-comments flag" 2017-03-02 15:26 GMT+03:00 Vyacheslav Daradur : > Anton, I think I found better way. > > Please, look at: > https://github.com/apache/ignite/pull/1586/files > > 2017-03-02 15:19

[jira] [Created] (IGNITE-4771) Building error - Apache Ignite 1.9.0 RC1

2017-03-02 Thread Vyacheslav Daradur (JIRA)
Vyacheslav Daradur created IGNITE-4771: -- Summary: Building error - Apache Ignite 1.9.0 RC1 Key: IGNITE-4771 URL: https://issues.apache.org/jira/browse/IGNITE-4771 Project: Ignite Issue

[GitHub] ignite pull request #1586: IGNITE-4770

2017-03-02 Thread daradurvs
GitHub user daradurvs opened a pull request: https://github.com/apache/ignite/pull/1586 IGNITE-4770 You can merge this pull request into a Git repository by running: $ git pull https://github.com/daradurvs/ignite ignite-4770 Alternatively you can review and apply these

Re: code refactoring suggestion

2017-03-02 Thread Andrey Gura
Aleksey, if you talk about fut.listen() then it doesn't make sense. listen() call checks whether future is already completed and if it completed invokes passed listener from current thread. On Thu, Mar 2, 2017 at 12:42 PM, ALEKSEY KUZNETSOV wrote: > Hi all ! During

Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.

2017-03-02 Thread Andrey Gura
+1 Removing of asGridUuid() method can lead to much code changes but it should be avoided on this step. On Thu, Mar 2, 2017 at 4:56 PM, Alexey Goncharuk wrote: > Maxim, > > I see several usages of asGridUuid() method, so I would just remove global > time and use

[GitHub] ignite pull request #1587: IGNITE-3939 Compact long zero values binary repre...

2017-03-02 Thread tledkov-gridgain
GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/1587 IGNITE-3939 Compact long zero values binary representation You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

Re: code refactoring suggestion

2017-03-02 Thread voipp
Hi all ! During pessimistic transaction we execute prepare phase at org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxLocal#commitAsync after executing prepareAsync(); We bind listener on prepare future. Perhaps its better initially bind listener and then execute

[VOTE] Apache Ignite 1.9.0 RC2

2017-03-02 Thread Anton Vinogradov
Dear Sirs! We have uploaded the 1.9.0 release candidate to https://dist.apache.org/repos/dist/dev/ignite/1.9.0-rc2/ Git tag name is 1.9.0-rc2 This release includes the following changes: Ignite: * Added Data streamer mode for DML * Added Discovery SPI Implementation for Ignite Kubernetes Pods

[jira] [Created] (IGNITE-4772) CPP: Add documentation for LoadCache feature

2017-03-02 Thread Igor Sapego (JIRA)
Igor Sapego created IGNITE-4772: --- Summary: CPP: Add documentation for LoadCache feature Key: IGNITE-4772 URL: https://issues.apache.org/jira/browse/IGNITE-4772 Project: Ignite Issue Type: Task

Re: [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Anton Vinogradov
This vote is closed. Issues fixed and will be provided as a part of RC2 at upcoming vote. On Thu, Mar 2, 2017 at 3:42 PM, Vyacheslav Daradur wrote: > Anton, please be careful: my PR doesn't contain the flag > "--allow-script-in-comments > flag" > > > > 2017-03-02 15:26

[CANCEL] [VOTE] Apache Ignite 1.9.0 RC1

2017-03-02 Thread Dmitriy Setrakyan
Officially cancelling the vote. On Thu, Mar 2, 2017 at 8:18 AM, Anton Vinogradov wrote: > This vote is closed. > Issues fixed and will be provided as a part of RC2 at upcoming vote. > > On Thu, Mar 2, 2017 at 3:42 PM, Vyacheslav Daradur > wrote: >

Re: Additional SQL metrics

2017-03-02 Thread Dmitriy Setrakyan
By the way, I am assuming that we are talking about per-query metrics, in which case we should specify metrics history size, so we don't keep all the queries in memory forever. I don't think it makes sense to have metrics aggregated across the queries. Just wanted to clarify this. On Thu, Mar 2,

Re: IGNITE-13

2017-03-02 Thread Вадим Опольский
Hi Valentin! I've created: new method strToUtf8BytesDirect in BinaryUtilsNew https://github.com/javaller/MyBenchmark/blob/master/src/ main/java/org/sample/BinaryUtilsNew.java new method doWriteStringDirect in BinaryWriterExImplNew https://github.com/javaller/MyBenchmark/blob/master/src/

Re: Additional SQL metrics

2017-03-02 Thread Vladimir Ozerov
Denis, The main problem with suggested metrics is that they implies that ceratin internal mechanics work in predefined way. For example, what is JOIN metrics? There are no guarantees that JOIN in user's query will be translated to a real physical join. What if several different query execution

Re: Additional SQL metrics

2017-03-02 Thread Dmitriy Setrakyan
Vladimir, are you talking about per-query metrics? On Thu, Mar 2, 2017 at 1:32 PM, Vladimir Ozerov wrote: > Denis, > > The main problem with suggested metrics is that they implies that ceratin > internal mechanics work in predefined way. For example, what is JOIN >

Re: Same Affinity For Same Key On All Caches

2017-03-02 Thread Denis Magda
What??? Unbelievable. It sounds like a design flaw to me. Any ideas how to fix? — Denis > On Mar 2, 2017, at 2:43 PM, Valentin Kulichenko > wrote: > > Adding back the dev list. > > Folks, > > Are there any opinions on the problem discussed here? Do we really

Re: Additional SQL metrics

2017-03-02 Thread Denis Magda
Vovan, When I’m speaking of JOIN metrics I’m simply assume that we need to add metrics relevant for queries with joins, metrics that will help us get more insights on non-collocated and collocated joins execution flow. > 1) Query exec count > 2) Query exec time (first define what "time" means)

Re: Same Affinity For Same Key On All Caches

2017-03-02 Thread Valentin Kulichenko
Adding back the dev list. Folks, Are there any opinions on the problem discussed here? Do we really need FairAffinityFunction if it can't guarantee cross-cache collocation? -Val On Thu, Mar 2, 2017 at 2:41 PM, vkulichenko wrote: > Hi Alex, > > I see your point.

Re: Additional SQL metrics

2017-03-02 Thread Denis Magda
Vovan, Your metrics make perfect sense to me. However, I see a high demand for JOINs based metrics especially from those who give a try to non-collocated joins in production and want to measure them somehow. This is why, personally, I prefer to see the metrics below in the top priority list

Re: IGNITE-4758 - introducing cache memory policies

2017-03-02 Thread Dmitriy Setrakyan
Sergey, my comments are below... On Thu, Mar 2, 2017 at 5:22 AM, Sergey Chugunov wrote: > Hello igniters, > > Working on the JIRA I found several situations not totally clear to me how > to handle properly. > > First of all I introduced several validation rules for

Re: [VOTE] Apache Ignite 1.9.0 RC2

2017-03-02 Thread Denis Magda
+1 (binding) — Denis > On Mar 2, 2017, at 9:02 AM, Anton Vinogradov wrote: > > Dear Sirs! > > We have uploaded the 1.9.0 release candidate to > https://dist.apache.org/repos/dist/dev/ignite/1.9.0-rc2/ > > Git tag name is > 1.9.0-rc2 > > This release includes the

Re: Renaming TcpDiscoverySpi.heartbeatsFrequency to TcpDiscoverySpi.metricsUpdateFrequency

2017-03-02 Thread Denis Magda
> On Mar 1, 2017, at 11:22 PM, Yakov Zhdanov wrote: > > I don't think new name makes things better. > > Btw, what if we remove metrics from heartbeats at all and make metrics > local and allow aggregations only via management console? > What’s about compute engine load

[GitHub] ignite pull request #1589: Ignite 4541c

2017-03-02 Thread iveselovskiy
GitHub user iveselovskiy opened a pull request: https://github.com/apache/ignite/pull/1589 Ignite 4541c You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4541c Alternatively you can review and apply

Re: Additional SQL metrics

2017-03-02 Thread Dmitriy Setrakyan
I think some of the metrics specified by Denis also make sense, so I would add them as well. See below... On Thu, Mar 2, 2017 at 12:36 AM, Vladimir Ozerov wrote: > Denis, > > Query execution is complex process involving different stages which are not > very easy to match

general question

2017-03-02 Thread ALEKSEY KUZNETSOV
Hi all ! What is the difference between local and near transactions -- *Best Regards,* *Kuznetsov Aleksey*

Re: [VOTE] Apache Ignite 1.9.0 RC2

2017-03-02 Thread Valentin Kulichenko
+1 (binding) -Val On Thu, Mar 2, 2017 at 11:33 AM, Denis Magda wrote: > +1 (binding) > > — > Denis > > > On Mar 2, 2017, at 9:02 AM, Anton Vinogradov > wrote: > > > > Dear Sirs! > > > > We have uploaded the 1.9.0 release candidate to > >

Re: IGNITE-13

2017-03-02 Thread Valentin Kulichenko
Vadim, Looks better now. Can you also try to modify the benchmark so that marshaller and writer are created outside of the measured method? I.e. the benchmark methods should be as simple as this: @Benchmark public void binaryHeapOutputStreamDirect() throws Exception {

[jira] [Created] (IGNITE-4768) Tx cache protocol change: notify client node from backups

2017-03-02 Thread Semen Boikov (JIRA)
Semen Boikov created IGNITE-4768: Summary: Tx cache protocol change: notify client node from backups Key: IGNITE-4768 URL: https://issues.apache.org/jira/browse/IGNITE-4768 Project: Ignite

[GitHub] ignite pull request #1588: ignite-4767

2017-03-02 Thread akuramshingg
GitHub user akuramshingg opened a pull request: https://github.com/apache/ignite/pull/1588 ignite-4767 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-4767 Alternatively you can review and apply

Re: Documenting Apache Ignite 1.9 Features

2017-03-02 Thread Denis Magda
Vovan, Alex P., I've cloned JDBC page for version 1.9 and made it hidden: https://apacheignite.readme.io/docs/jdbc-driver-19 Please add new properties added as a part of IGNITE-4169 to the properties table there. I would have done this on my own if I hadn't lost track of what we actually did :)

Re: IGNITE-603

2017-03-02 Thread Александр Меньшиков
Yakov, Okay. You can see result in JIRA https://issues.apache.org/jira/browse/IGNITE-603 2017-02-28 19:31 GMT+03:00 Yakov Zhdanov : > Denis, I can't say for sure, but the fact test was commented out for a long > time is suspicious. > > Alexander, can you please uncomment,