Re: Key type name and value type name for CREATE TABLE

2017-06-06 Thread Dmitriy Setrakyan
Vova, I am not sure I like the key type name the way it is. Can we add some separator between the table name and key name, like "_". To me "PERSON_KEY" reads a lot better than "PERSONKey". D. On Tue, Jun 6, 2017 at 4:00 AM, Sergi Vladykin wrote: > Unique suffix is a

IGNITE-5229 is ready for review

2017-06-06 Thread Roman Shtykh
Igniters, IGNITE-5229 is ready for review.Now Redis can have its default cache specified and used as a template when switching to other caches, as discussed earlier in this ml (please see the JIRA issue). [1] https://issues.apache.org/jira/browse/IGNITE-5229 -- Roman

Writing a helper for KafkaStreamer

2017-06-06 Thread Michael Griggs
We made a change [1] that required users to re-write code that uses KafkaStreamer to initialise tuple extractors. The re-write is not immediately obvious, and for simple use cases (streaming single tuples) it is easy to write a helper function that will make the transition easier. I intend

Re: Writing a helper for KafkaStreamer

2017-06-06 Thread Dmitriy Setrakyan
Thanks, Mike! Sounds great. On Tue, Jun 6, 2017 at 12:26 AM, Michael Griggs wrote: > We made a change [1] that required users to re-write code that uses > KafkaStreamer to initialise tuple extractors. The re-write is not > immediately obvious, and for simple use

Re: Data compression in Ignite 2.0

2017-06-06 Thread Dmitriy Setrakyan
Vladimir, I am not sure how to interpret the graphs? What are we looking at? On Tue, Jun 6, 2017 at 12:33 AM, Vyacheslav Daradur wrote: > Hi, Igniters. > > I've prepared some benchmarking. Results [1]. > > And I've prepared the evaluation in the form of diagrams [2]. > > I

[jira] [Created] (IGNITE-5415) Web console: Implement support of 2.1 configuration version.

2017-06-06 Thread Vasiliy Sisko (JIRA)
Vasiliy Sisko created IGNITE-5415: - Summary: Web console: Implement support of 2.1 configuration version. Key: IGNITE-5415 URL: https://issues.apache.org/jira/browse/IGNITE-5415 Project: Ignite

[GitHub] ignite pull request #2091: IGNITE-1553 Optimize transaction prepare step whe...

2017-06-06 Thread voipp
GitHub user voipp opened a pull request: https://github.com/apache/ignite/pull/2091 IGNITE-1553 Optimize transaction prepare step when store is enabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/voipp/ignite IGNITE-1553

Re: Data compression in Ignite 2.0

2017-06-06 Thread Vyacheslav Daradur
Hi, Igniters. I've prepared some benchmarking. Results [1]. And I've prepared the evaluation in the form of diagrams [2]. I hope that helps to interest the community and accelerates a reaction to this improvment :) [1]

Re: Data compression in Ignite 2.0

2017-06-06 Thread Vyacheslav Daradur
Dmitry, Excel-pages: 1). "Compression ratio (2)" - shows object size, with compression and without compression. (Conditions: literal text) 1st graph shows compression ratios of using different compression algrithms depending on size of compressed field. 2nd graph shows evaluation of size of

Re: Data compression in Ignite 2.0

2017-06-06 Thread Vyacheslav Daradur
All metrics are taken from app based on custom assembly of AI, containing the provided PR. 2017-06-06 11:28 GMT+03:00 Vyacheslav Daradur : > Dmitry, > > Excel-pages: > > 1). "Compression ratio (2)" - shows object size, with compression and > without compression. (Conditions:

Re: Data compression in Ignite 2.0

2017-06-06 Thread Антон Чураев
Vyacheslav, thank you! But could you please provide a conclusions or proposals based on this benchmarks? 2017-06-06 11:28 GMT+03:00 Vyacheslav Daradur : > Dmitry, > > Excel-pages: > > 1). "Compression ratio (2)" - shows object size, with compression and > without

[GitHub] ignite pull request #2092: IGNITE-5377 ODBC: Expose SqlFieldsQuery hints as ...

2017-06-06 Thread tledkov-gridgain
GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/2092 IGNITE-5377 ODBC: Expose SqlFieldsQuery hints as parameters You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite

[GitHub] ignite pull request #2092: IGNITE-5377 ODBC: Expose SqlFieldsQuery hints as ...

2017-06-06 Thread tledkov-gridgain
Github user tledkov-gridgain closed the pull request at: https://github.com/apache/ignite/pull/2092 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: "Review workflow" changes to prevent "broken review" issues.

2017-06-06 Thread Anton Vinogradov
Dmitry Pavlov, There is *HUGE *difference between "Devlist, please review my changes" and "Dmitry Pavlov, please review my changes". In case you're busy right now, you'll, most likely, ignore appeal to devlist, but, I'm pretty sure, you'll check appeal to yourself. Am I right? So, my idea is:

Re: "Review workflow" changes to prevent "broken review" issues.

2017-06-06 Thread Dmitry Pavlov
Anton, Thank you for explanation. Personal ask instead of group broadcast may really help. I understand the idea now. One argument against solution way 1) it may be not easy for contributor, especially newcomer, to find a right person. What do you think about way 2? Personally, I'm ready to

[jira] [Created] (IGNITE-5418) CPP: Add BINARY SQL type support for SQL queries

2017-06-06 Thread Igor Sapego (JIRA)
Igor Sapego created IGNITE-5418: --- Summary: CPP: Add BINARY SQL type support for SQL queries Key: IGNITE-5418 URL: https://issues.apache.org/jira/browse/IGNITE-5418 Project: Ignite Issue Type:

Only lateAffinityAssignment for 2.1

2017-06-06 Thread Semyon Boikov
Hi all, Currently in Igntie we have two modes for cache affinity changing (IgniteConfiguration.isLateAffinityAssignment=true/false). Late affinity assignment mode is enabled by default and I do not see when it can be useful to disable it. Does it make sense for 2.1 to deprecate property

[jira] [Created] (IGNITE-5422) CREATE TABLE command should support all-key fields case

2017-06-06 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-5422: --- Summary: CREATE TABLE command should support all-key fields case Key: IGNITE-5422 URL: https://issues.apache.org/jira/browse/IGNITE-5422 Project: Ignite

Re: Only lateAffinityAssignment for 2.1

2017-06-06 Thread Yakov Zhdanov
Absolutely agree. Please make sure that we switch affinity version only when partition N migrates from current node for all caches. Makes sense? --Yakov

Re: Key type name and value type name for CREATE TABLE

2017-06-06 Thread Sergi Vladykin
Unique suffix is a good idea. Sergi 2017-06-06 13:51 GMT+03:00 Vladimir Ozerov : > Igniters, > > In the very first implementation of CREATE TABLE we applied the following > rule to key and value type names: > keyTypeName == tableName + "Key" > valTypeName == tableName > >

[GitHub] ignite pull request #2093: IGNITE-5420

2017-06-06 Thread devozerov
GitHub user devozerov opened a pull request: https://github.com/apache/ignite/pull/2093 IGNITE-5420 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5420 Alternatively you can review and apply these

[GitHub] ignite pull request #2084: Ignite 5410

2017-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/2084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Data compression in Ignite 2.0

2017-06-06 Thread Vyacheslav Daradur
In short, During marshalling a fields is represented as BinaryFieldAccessor which manages its marshalling. It checks if the field is marked by annotation @BinaryCompression, in that case - binary representation of field (bytes array) will be compressed. It will be marked as compressed by types

Re: "Review workflow" changes to prevent "broken review" issues.

2017-06-06 Thread Anton Vinogradov
Igniters, Since we found that proposed approach can help, no one mind that I'll add text listed above to the wiki? On Tue, Jun 6, 2017 at 1:19 PM, Anton Vinogradov wrote: > Dmitry, > > 1) See my initial email, it contains instruction how to find a reviewer. > And it's

[jira] [Created] (IGNITE-5425) JDBC thin: support client info

2017-06-06 Thread Taras Ledkov (JIRA)
Taras Ledkov created IGNITE-5425: Summary: JDBC thin: support client info Key: IGNITE-5425 URL: https://issues.apache.org/jira/browse/IGNITE-5425 Project: Ignite Issue Type: Bug

Re: Data compression in Ignite 2.0

2017-06-06 Thread Антон Чураев
Looks good for me. Could You propose design of implementation in couple of sentences? So that we can estimate the completeness and complexity of the proposal. 2017-06-06 15:26 GMT+03:00 Vyacheslav Daradur : > Anton, > > Of course, the solution does not affect on existing

[jira] [Created] (IGNITE-5427) Add cluster activation/deactivation events

2017-06-06 Thread Alexey Goncharuk (JIRA)
Alexey Goncharuk created IGNITE-5427: Summary: Add cluster activation/deactivation events Key: IGNITE-5427 URL: https://issues.apache.org/jira/browse/IGNITE-5427 Project: Ignite Issue

[jira] [Created] (IGNITE-5428) Failed to build ignite-jta because a dependent library is not downloadable

2017-06-06 Thread Kengo Seki (JIRA)
Kengo Seki created IGNITE-5428: -- Summary: Failed to build ignite-jta because a dependent library is not downloadable Key: IGNITE-5428 URL: https://issues.apache.org/jira/browse/IGNITE-5428 Project:

Re: Key type name and value type name for CREATE TABLE

2017-06-06 Thread Valentin Kulichenko
Vova, If you add unique suffix losing human-readable type names, how will the builder approach work? Maybe it makes sense to add an API call that returns current type name for a table? -Val On Tue, Jun 6, 2017 at 7:43 PM Dmitriy Setrakyan wrote: > Vova, > > I am not

[GitHub] ignite pull request #2098: IGNITE-5229: Specify caches when using Redis prot...

2017-06-06 Thread shroman
GitHub user shroman opened a pull request: https://github.com/apache/ignite/pull/2098 IGNITE-5229: Specify caches when using Redis protocol. Implemented vi… …a SELECT command. You can merge this pull request into a Git repository by running: $ git pull

Re: Only lateAffinityAssignment for 2.1

2017-06-06 Thread Dmitriy Setrakyan
On Tue, Jun 6, 2017 at 4:23 AM, Semyon Boikov wrote: > Now affinity version is switched only when migration for new primaries > finishes for all partitions and for all caches. > Sounds great. Semyon, is there documentation that needs to be updated as well?

Re: Data compression in Ignite 2.0

2017-06-06 Thread Vyacheslav Daradur
Conclusion: Provided solution allows reduce size of an object in IgniteCache at the cost of throughput reduction (small - in some cases), it depends on part of object which will be compressed and compression algorithm. I mean, we can make more effective use of memory, and in some cases it can

[jira] [Created] (IGNITE-5423) Web Console: We need configure agents remotely

2017-06-06 Thread Alexey Kuznetsov (JIRA)
Alexey Kuznetsov created IGNITE-5423: Summary: Web Console: We need configure agents remotely Key: IGNITE-5423 URL: https://issues.apache.org/jira/browse/IGNITE-5423 Project: Ignite

Re: Data compression in Ignite 2.0

2017-06-06 Thread Антон Чураев
Vyacheslav, Is it possible to propose implementation that can be switched on on-demand? In this case it should not affect performance of current solution. I mean, that users should make decision what is more important for them: throutput or memory/net usage. May be they will be choose not all

is IGNITE-3142 actual now

2017-06-06 Thread Вадим Опольский
Hello guys! I want to resolve issue https://issues.apache.org/jira/browse/IGNITE-3142 Is it actual now? Vadim Opolski

[jira] [Created] (IGNITE-5424) GridServiceProxy does not unwraps exception message from InvocationTargetException

2017-06-06 Thread Dmitry Karachentsev (JIRA)
Dmitry Karachentsev created IGNITE-5424: --- Summary: GridServiceProxy does not unwraps exception message from InvocationTargetException Key: IGNITE-5424 URL: https://issues.apache.org/jira/browse/IGNITE-5424

Re: Data compression in Ignite 2.0

2017-06-06 Thread Vyacheslav Daradur
I wish to note, that the results of benchmarking shows metrics from stress-testing. I mean in real scenarios, for example business operations, which take milliseconds or seсonds, increase in time of put-get-operation will be insignificant. 2017-06-06 14:48 GMT+03:00 Vyacheslav Daradur

[GitHub] ignite pull request #2094: IGNITE-5306 persist sql flag

2017-06-06 Thread kdudkov
GitHub user kdudkov opened a pull request: https://github.com/apache/ignite/pull/2094 IGNITE-5306 persist sql flag You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-5306 Alternatively you can review

[GitHub] ignite pull request #2058: Example of API changes.

2017-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/2058 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #2036: Ignite 5075 pds snapshots

2017-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/2036 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ignite pull request #2031: Ignite 5075

2017-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/2031 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (IGNITE-5420) Table key type name and value type must be unique

2017-06-06 Thread Vladimir Ozerov (JIRA)
Vladimir Ozerov created IGNITE-5420: --- Summary: Table key type name and value type must be unique Key: IGNITE-5420 URL: https://issues.apache.org/jira/browse/IGNITE-5420 Project: Ignite

[jira] [Created] (IGNITE-5421) Web Console: Implement design how to handle lost connection

2017-06-06 Thread Vica Abramova (JIRA)
Vica Abramova created IGNITE-5421: - Summary: Web Console: Implement design how to handle lost connection Key: IGNITE-5421 URL: https://issues.apache.org/jira/browse/IGNITE-5421 Project: Ignite

Key type name and value type name for CREATE TABLE

2017-06-06 Thread Vladimir Ozerov
Igniters, In the very first implementation of CREATE TABLE we applied the following rule to key and value type names: keyTypeName == tableName + "Key" valTypeName == tableName E.g.: CREATE TABLE Person ... keyTypeName == PERSONKey valTypeName == PERSON After that user could potentially create

[GitHub] ignite pull request #2059: IGNITE-5075-pds

2017-06-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/2059 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: place for printing info about partition distribution (IGNITE-4756)

2017-06-06 Thread Taras Ledkov
According to the last Yakov's comments at the ticket: 1. Calculation and printing distribution deviation will be produced only for local node. 2. In this case it takes only one additional compare nodeID if we build statistic with the assignment calculation. 3. We have return injection of the

Re: "Review workflow" changes to prevent "broken review" issues.

2017-06-06 Thread Anton Vinogradov
Dmitry, 1) See my initial email, it contains instruction how to find a reviewer. And it's pretty easy to do when you have something to review (you did some code changes). I want to add following to our wiki: " Ask commiter to review changes. Check affected file's git history to find commiter

[jira] [Created] (IGNITE-5419) Try optimize on-heap cache maps created for caches in the same cache group

2017-06-06 Thread Semen Boikov (JIRA)
Semen Boikov created IGNITE-5419: Summary: Try optimize on-heap cache maps created for caches in the same cache group Key: IGNITE-5419 URL: https://issues.apache.org/jira/browse/IGNITE-5419 Project:

Re: is IGNITE-3142 actual now

2017-06-06 Thread Denis Magda
Vadim, Please try to run the reproducer attached. If the error pops up then the bug needs to be fixed. — Denis > On Jun 6, 2017, at 4:36 AM, Вадим Опольский wrote: > > Hello guys! > > I want to resolve issue https://issues.apache.org/jira/browse/IGNITE-3142 >

[GitHub] ignite pull request #2096: ignite-5383

2017-06-06 Thread daradurvs
GitHub user daradurvs opened a pull request: https://github.com/apache/ignite/pull/2096 ignite-5383 …inaryMarshaller is used" You can merge this pull request into a Git repository by running: $ git pull https://github.com/daradurvs/ignite ignite-5383 Alternatively you can

Re: Persistent Distributed Store Metrics

2017-06-06 Thread Denis Magda
> On Jun 5, 2017, at 8:02 PM, Konstantin Boudnik wrote: > > On Mon, Jun 05, 2017 at 07:41PM, Dmitriy Setrakyan wrote: >> On Mon, Jun 5, 2017 at 6:46 PM, Konstantin Boudnik wrote: >> >>> Wow, hold on - as far as I remember there was a VOTE to accept the >>>