Ignite and Java 9+

2020-06-02 Thread steve.hostett...@gmail.com
Hello, The method doWriteString(@Nullable String val) writes everything in UTF-8. This is a bit a waste because with Java 9+ , strings are optimised and if all chars are ISO-LATIN-1 all char are represented with 1 byte instead of two. I would consider

Re: Phani Introduction

2020-06-02 Thread Ivan Pavlukhin
Hi Phani, Welcome to Apache Ignite Community! I added your account to the contributors list. Now you can assign tickets to yourself. Please check this page out for commonly asked questions pertaining to the contribution process https://ignite.apache.org/community/contribute.html Do not

Re: IEP-46 Thin client - Service invocation

2020-06-02 Thread Alexey Goncharuk
Alexey, Hello, > > I've benchmarked 1-operation approach vs 2-operations approach and > published benchmark results on IEP page [1]. It looks like performance > almost the same, so the single-operation approach should be implemented. > Do I understand correctly that you suggest to remote the

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
> Current implementation StopNodeOrHaltFH uses Runtime#halt(). This method > doesn't cause shutdown hooks. Why we don't try to stop the node by > System#exit() before Runtime#halt()? And why we should try System.exit()? We invoke halt() because we don't want to invoke any code in shutdown hook.

Re: Ignite and Java 9+

2020-06-02 Thread steve.hostett...@gmail.com
Indeed, I misread the code and it already saves "str4e" on 5 bytes and "str4€" on 7 bytes. Sorry for the waste of time. -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

[DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread ткаленко кирилл
Hi, Igniters! At the moment to work with the control.sh we need to know exactly what the name of the command and its options are and so the user can often make mistakes when using it. So I think it would be useful to do control.sh more user-friendly by adding autocomplete as in modern

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Sergey Antonov
It would be a great usability improvement! +1 From me. вт, 2 июн. 2020 г. в 15:54, Zhenya Stanilovsky : > > > good catch ! it`s a little bit pain for now to working with it. > > > >Hi, Igniters! > > > >At the moment to work with the control.sh we need to know exactly what > the name of the

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Sergey Antonov
Andrey, Alexey, I can't agree with your position. Current implementation StopNodeOrHaltFH uses Runtime#halt(). This method doesn't cause shutdown hooks. Why we don't try to stop the node by System#exit() before Runtime#halt()? вт, 2 июн. 2020 г. в 17:18, Andrey Gura : > Sergey, Anton, Kirill,

[DISCUSS] Make AtomicConfiguration more flexible

2020-06-02 Thread Vladimir Pligin
Hi Igniters! It seems that AtomicConfiguration (https://ignite.apache.org/releases/latest/javadoc/org/apache/ignite/configuration/AtomicConfiguration.html) is not flexible enough to cover some reasonable use-cases. It's possible to configure only cache mode, group name, affinity and backups of

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Sergey Antonov
Andrey, > And why we should try System.exit()? Why we try to stop the node before invoke Runtime#halt()?) By the same reasons we should try to stop the process with shutdown hooks invocation before Runtime#halt(). вт, 2 июн. 2020 г. в 17:51, Andrey Gura : > > Current implementation

Re: IEP-46 Thin client - Service invocation

2020-06-02 Thread Alex Plehanov
Alexey, Yes, I've got almost the same performance (the difference is about 1%). I think proxy creation has a relatively low cost compared to 2-4 network hops required to invoke the service method. More precisely: First approach: create a service proxy on server-side each time, when a service

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Ivan Daschinsky
> By the way, according to README.md [1] the picocli is already using bythe Apache Ignite, right? :-) Yes, you are right, but a little bit outdated. > Would it be better going the `control.sh` extensions-way? Sounds good. Also, it would be great to incorporate in command line utilities some

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread ткаленко кирилл
Maxim I suggested moving control.sh in a separate module, are we talking about the same thing? 02.06.2020, 16:15, "Maxim Muzafarov" : > Folks, > > +1 > > However, AFAIK control.sh is the part of the ignite-core module with > zero dependencies from external resources. > Would it be better going

Re: IEP-46 Thin client - Service invocation

2020-06-02 Thread Alex Plehanov
Hello, I've benchmarked 1-operation approach vs 2-operations approach and published benchmark results on IEP page [1]. It looks like performance almost the same, so the single-operation approach should be implemented. One more question: do we need some parameter on the server-side to disable

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
Sergey, Anton, Kirill, I think we have to do not change anything in FH. At least without enough motivation. Now I see only assumption that it "could be helpful for administration purposes". It isn't enough, I believe. On Tue, Jun 2, 2020 at 4:59 PM ткаленко кирилл wrote: > > Hello, Alexey! > >

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Alexey Goncharuk
> > How exactly do you want to change the StopNodeFH? > I want to stop JVM with KILL_EXIT_CODE and add an option (constructor > argument of JVM option) for disabling JVM termination. > When the flag is enabled, the behavior is identical to StopNodeOrHaltFH with tryStop=false. In other words,

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread ткаленко кирилл
Hello, Alexey! I didn't quite understand about merge. If we use StopNodeOrHaltFailureHandler with tryStop=true, then if we don't stop node by timeout, we will terminate jvm. Or do you suggest only stopping the node in StopNodeFailureHandler and terminate jvm in StopNodeOrHaltFailureHandler?

[MTCGA]: new failures in builds [5348710] needs to be handled

2020-06-02 Thread dpavlov . tasks
Hi Igniters, I've detected some new issue on TeamCity to be handled. You are more than welcomed to help. If your changes can lead to this failure(s): We're grateful that you were a volunteer to make the contribution to this project, but things change and you may no longer be able to

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
>> And why we should try System.exit()? >> Why we try to stop the node before invoke Runtime#halt()?) By the same >> reasons we should try to stop the process with shutdown hooks >> invocation before Runtime#halt(). Once again: we can't be sure that node will be stopped because we don't manage

Re: Ignite and Java 9+

2020-06-02 Thread Ivan Pavlukhin
Hi Steve, Could you please describe in more details in what cases do you expect a profit? AFAIK UTF-8 requires 1 byte for Latin-1 characters. I did not learn in depth about aforementioned Java 9 compact strings but my understanding is that it is about reducing space taken by java.lang.String

Re: [DISCUSSION] IEP-47 Native persistence defragmentation

2020-06-02 Thread Ivan Bessonov
Hello Anton, I'd like to address your last message. First of all, it was already partially discussed in this thread: [1] To reiterate - expected performance degradation will be significant. There's no way that we can throttle it because free/reuse lists have to be maintained sorted all the time.

Re: Phani Introduction

2020-06-02 Thread phani adusumilli
Thanks Ivan. Thanks > On Jun 2, 2020, at 5:01 AM, Ivan Pavlukhin wrote: > > Hi Phani, > > Welcome to Apache Ignite Community! > > I added your account to the contributors list. Now you can assign > tickets to yourself. > > Please check this page out for commonly asked questions pertaining

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Sergey Antonov
Alexey, > How exactly do you want to change the StopNodeFH? I want to stop JVM with KILL_EXIT_CODE and add an option (constructor argument of JVM option) for disabling JVM termination. вт, 2 июн. 2020 г. в 12:54, Alexey Goncharuk : > Sergey, > > How exactly do you want to change the StopNodeFH?

Re: [DISCUSSION] IEP-47 Native persistence defragmentation

2020-06-02 Thread Anton Vinogradov
Folks, Modern OS never ask you to schedule defragmentation and turn your PC off, it performs it while you're browsing. Why we're going to implement distributed system defragmentation in the old (offline) way? All you need is to implement free/reuse-list sorting. They should provide pages closest

Re: [DISCUSSION] IEP-47 Native persistence defragmentation

2020-06-02 Thread Anton Vinogradov
Ivan, Thanks for hints. Invalidated memory cache was restored :) On Tue, Jun 2, 2020 at 2:55 PM Ivan Bessonov wrote: > Hello Anton, > > I'd like to address your last message. First of all, it was already > partially discussed > in this thread: [1] To reiterate - expected performance

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Ivan Daschinsky
+1 But this is not only usability improvement, but also a huge code improvement. With picocli developers can add custom command without writing a lot of boilerplate and error prone code to do a trivial task of parsing CLI arguments. Cleaner code, less bugs also matter. вт, 2 июн. 2020 г. в 16:02,

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Andrey Gura
Definitely agree with Alexey Goncharuk. Mentioned FH implementations don't terminate JVM. I think returning KILL_EXIT_CODE is bad idea because actually process wasn't terminated using SIGINT. So it contradicts to motivation described in proposal. Also how could it help to administrators. For

Re: [DISCUSS] Ignite process exit code on node stop by failure handler

2020-06-02 Thread Alexey Goncharuk
Sergey, How exactly do you want to change the StopNodeFH? The current behavior does not terminate the JVM and its exit code is totally out of our control; one of the use-cases we had in mind for this failure handler is that a user may have other processes running in the same JVM, so we do not

Re: Ignite and Java 9+

2020-06-02 Thread Ivan Pavlukhin
A note. I assumed that we talk about BinaryWriterExImpl.doWriteString. 2020-06-02 12:52 GMT+03:00, Ivan Pavlukhin : > Hi Steve, > > Could you please describe in more details in what cases do you expect > a profit? AFAIK UTF-8 requires 1 byte for Latin-1 characters. > > I did not learn in depth

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Maxim Muzafarov
Folks, +1 However, AFAIK control.sh is the part of the ignite-core module with zero dependencies from external resources. Would it be better going the `control.sh` extensions-way? By the way, according to README.md [1] the picocli is already using by the Apache Ignite, right? :-) > Picocli is

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Zhenya Stanilovsky
good catch ! it`s a little bit pain for now to working with it.   >Hi, Igniters! > >At the moment to work with the control.sh we need to know exactly what the >name of the command and its options are and so the user can often make >mistakes when using it. So I think it would be useful to do

[jira] [Created] (IGNITE-13107) ODBC: Memory leak in the tests

2020-06-02 Thread Igor Sapego (Jira)
Igor Sapego created IGNITE-13107: Summary: ODBC: Memory leak in the tests Key: IGNITE-13107 URL: https://issues.apache.org/jira/browse/IGNITE-13107 Project: Ignite Issue Type: Improvement

Re: maintenance on repository.apache.org - may have broken an ignite staging repository

2020-06-02 Thread Denis Magda
Igniters, Does anybody know what that staging repository is used for? Is it safe to drop it? Wes, let's for a couple of days and, in case of no response, you can go ahead and remove that staging. - Denis On Mon, Jun 1, 2020 at 1:55 PM Wes Wannemacher wrote: > Hello ignite folks. > > I