Re: TX SQL: SELECT FOR UPDATE implementation

[Vladimir Ozerov]

Agree. SELECT FOR UPDATE appears to be a command with the most loosly
defined locking semantics in SQL world. So I would start with something
safe, simple and straightforward. Let's add support for simple statements
(no joins, not subqueries) first. Then add support for co-located complex
queries. And at last add support for distributed joins*.

* Though, I think it doesn't make sense with current implementation of
distributed joins, as it is pretty limited and require significant rethink
from architectural perspective.

Vladimir.

On Thu, Feb 22, 2018 at 5:00 AM, Dmitriy Setrakyan 
wrote:

> Alexander, thanks for the detailed explanation. I would start simple,
> without JOINs. However, we should throw proper exceptions if unsupported
> SQL is used.
>
> D.
>
> On Tue, Feb 20, 2018 at 9:45 AM, Alexander Paschenko <
> alexander.a.pasche...@gmail.com> wrote:
>
> > Hello again, and here I go with some more thoughts on SELECT FOR UPDATE.
> > After having talking to Vlad, we returned again to question about how
> > SELECT FOR UPDATE should work with JOINs.
> >
> > It seems that distributed joins currently are better to be left aside
> > as long as rework of distributed queries and joins is a separate big
> > issue.
> > However, probably we still should think about what we could make work
> > after all with what we have in our hands now. And it seems that some
> > scenarios are pretty doable - say, when there's an ordinary JOIN of
> > few tables, we can simply append keys of those tables to list of
> > selected columns, and that would work in case of collocated data.
> >
> > * Alas, major vendors (Postgres, MySQL, Oracle) all also honor
> > subqueries in JOINs - say, like this:
> >
> > select p.id , c.id from person p inner join (select * from company) c
> > on p.company_id = c.id where p.id > 3 and p.id < 10 for update;
> >
> > Obviously, this is a bit corner case as such JOIN is not much
> > different from an ordinary multi-table one, but it gives overall idea
> > of what I'm talking about - major databases lock what's been selected
> > in subquery as well.
> >
> > That said, aforementioned case probably could also be processed as
> > suggested above - that is, we take innermost query, append key to list
> > of its selected columns, so that we can refer to that new column from
> > outer query, etc, etc. In principle we could process even
> > multiple-level nesting of queries with such approach.
> > Also no major vendors, except probably MySQL, support GROUP BY with
> > SELECT FOR UPDATE, and this simplifies our task a bit. :)
> >
> > If someone can think of an example of a query that cannot be processed
> > in the way described above, please write about it.
> >
> > * Also it looks like no major vendors out of three mentioned above
> > lock record from tables mentioned in subqueries in SELECT columns or
> > in WHERE - say, this query
> >
> > select p.id, (select count(*) from company) from person p
> >
> > will lock only records in Person table.
> >
> > Thoughts? Should we attempt to implement JOINs support right away? Or
> > would it be better to leave it be for (near) future and start with
> > simple implementation that would ban JOINs altogether?
> >
> > Regards,
> > Alex
> >
> >
> > 2018-01-25 10:58 GMT+03:00 Vladimir Ozerov :
> > > Alex,
> > >
> > > Thank you for detailed analysis. My 50 cents:
> > >
> > > 1) I would not allow GROUP BYs in the first place. These are good
> > > candidates for further iterations IMO
> > > 2) Same as p.1
> > > 3) In final TX SQL solution we woll lock rows, not keys
> > > (GridCacheMapEntry). Can we simply lock every row returned from the
> > query?
> > > 4) Same as p.1
> > > 5) Yes, it should work the same way we would implement it for normal
> > queries
> > >
> > > Also I am not quite understand why should we keep results on map node
> > until
> > > all keys are locked. This increases memory pressure on the server.
> > Instead,
> > > I would start sending batches to reducer immediately, but do not return
> > the
> > > very first result to the user until all results are collected. This way
> > > pressure is moved to the client what increases cluster stability. Will
> > that
> > > work?
> > >
> > > On Wed, Jan 24, 2018 at 6:23 PM, Alexander Paschenko <
> > > alexander.a.pasche...@gmail.com> wrote:
> > >
> > >> Hello Igniters,
> > >>
> > >> I'd like to bring up the discussion about implementation details of
> > >> https://issues.apache.org/jira/browse/IGNITE-6937 about
> > >> support of SELECT FOR UPDATE statements as a part of overall activity
> > >> on transactional SQL.
> > >>
> > >> That kind of statements allows the user proactively obtain row level
> > >> locks for the records that they may (or may not) want to
> > >> update in further statements of the same transaction.
> > >>
> > >> Suggested general approach to implementation is as follows:
> > >>
> > >> - Perform two-step SELECT as usual (e.g. split, map, reduce stages),
> 

Re: Welcome email: Kalashnikov

[Dmitry Pavlov]

Hi Ruchir,

You can sign up to apache JIRA by yourself.

Could you share your JIRA username afterwards?

Sincerely,
Dmitriy Pavlov

чт, 22 февр. 2018 г. в 10:19, Ruchir Choudhry :

> Hello Ignite team,
>
>
> I am not able to assign this ticket to my self,
>
> https://issues.apache.org/jira/browse/IGNITE-7759
>
>
>
> Can anyone help here,
>
> Thanks,
> Ruchir
>
> On Wed, Feb 21, 2018 at 2:31 AM, Dmitry Pavlov 
> wrote:
>
> > Hi Anton,
> >
> > Welcome to the Ignite Community!
> >
> > Could you please share your JIRA ID?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > P.S.
> > Please subscribe to both dev and user lists:
> > https://ignite.apache.org/community/resources.html#mail-lists
> >
> > Get familiar with Ignite development process described here:
> > https://cwiki.apache.org/confluence/display/IGNITE/Development+Process
> >
> > Instructions on how to contribute can be found here:
> > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >
> > Project setup in Intellij IDEA:
> > https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup
> >
> > ср, 21 февр. 2018 г. в 13:25, Антон Калашников :
> >
> > > Hello Ignite Community!
> > >
> > > I want to contribute to Apache Ignite and want to start with this
> issue -
> > > IGNITE-6552. Any help on this will be appreciated.
> > >
> > > Best regards,
> > > Anton Kalashnikov.
> > >
> > >
> >
>

Re: IGNITE-6005 is ready for review

[Dmitry Pavlov]

Thank you.

I am sure you now, by anyway: It is important to fail test in code, because
all muted tests are actually started in suite each run. And if some test
causes timeout it will cause it in both cases: muted and not muted.


чт, 22 февр. 2018 г. в 10:17, Nikolay Izhikov :

> Hello, Dmitry.
>
> OK, I'll rerun TC with muted test.
>
> В Чт, 22/02/2018 в 07:12 +, Dmitry Pavlov пишет:
> > Hi Nikolay,
> >
> > It seems Data structures test suite is still have timeout. Could you fail
> > test caused this timeout?
> >
> https://ci.ignite.apache.org/viewLog.html?buildId=1105706=buildResultsDiv=IgniteTests24Java8_IgniteDataStructures
> >
> > Data structures is most relevant suite so I suggest to re-run it after
> > failing problematic test.
> >
> > Most probably this test is
> >
> GridCachePartitionedDataStructuresFailoverSelfTest.testSemaphoreSingleNodeFailure.
> > And it can be failed with link to
> > https://issues.apache.org/jira/browse/IGNITE-5975
> >
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > чт, 22 февр. 2018 г. в 10:07, Nikolay Izhikov :
> >
> > > Andrey,
> > >
> > > I made TC run.
> > > Please, see my comment in JIRA.
> > >
> > >
> > >
> https://issues.apache.org/jira/browse/IGNITE-6005?focusedCommentId=16372502=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16372502
> > >
> > >
> > > В Ср, 21/02/2018 в 15:03 +0300, Andrey Gura пишет:
> > > > Nikolay,
> > > >
> > > > it doesn't matter. I just want to be sure that there are no new
> > > > failures in tests.
> > > >
> > > > On Wed, Feb 21, 2018 at 1:14 PM, Dmitry Pavlov <
> dpavlov@gmail.com>
> > >
> > > wrote:
> > > > > Hi, I didn't find any runs in our new TC suite group (project) for
> > >
> > > 2.4+:
> > > > >
> > >
> > >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll=buildTypeStatusDiv_IgniteTests24Java8=pull%2F2773%2Fhead
> > > > >
> > > > > So, Nikolay, I suggest to start RunAll in this suite group.
> > > > >
> > > > > I can check results later in compare with master.
> > > > >
> > > > > ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov  >:
> > > > >
> > > > > > Hello, Andrey.
> > > > > >
> > > > > > Do you run TC by yourself, or I as patch contributor should do
> it?
> > > > > >
> > > > > > В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
> > > > > > > I'll merge it if there are no any objections. But, the first,
> I'll
> > >
> > > run
> > > > > >
> > > > > > TC once again.
> > > > > > >
> > > > > > > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
> > > > > >
> > > > > > dpavlov@gmail.com> написал:
> > > > > > > > Hi Igniters,
> > > > > > > >
> > > > > > > > It seems this issue review process hang up.
> > > > > > > >
> > > > > > > > Andrey Gura had concerns about this implementation. In the
> same
> > >
> > > time
> > > > > >
> > > > > > Ilya L
> > > > > > > > checked this implementation and approves it.
> > > > > > > >
> > > > > > > > I didn't find points to improve and concerns are not clear
> for
> > >
> > > me. I
> > > > > >
> > > > > > didn't
> > > > > > > > managed to get more info in issue
> > > > > > > > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
> > > > > > > >
> > > > > > > > What can be our next step to solve this?
> > > > > > > >
> > > > > > > > Absence of this fix causes 100% timeout in Data Structures
> suite
> > >
> > > and
> > > > > >
> > > > > > wastes
> > > > > > > > agents for a long time.
> > > > > > > >
> > > > > > > > Sincerely,
> > > > > > > > Dmitriy Pavlov
> > > > > > > >
> > > > > > > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh <
> > >
> > > ilant...@gridgain.com>:
> > > > > > > >
> > > > > > > > > Hi Nikolay,
> > > > > > > > >
> > > > > > > > > Thanks for contribution!
> > > > > > > > >
> > > > > > > > > I will try to review your pull request by tomorrow.
> > > > > > > > >
> > > > > > > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov <
> > > > > >
> > > > > > nizhi...@apache.org>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Hello, Igniters.
> > > > > > > > > >
> > > > > > > > > > I've fix some relatively small issue(100 loc) IGNITE-6005
> > >
> > > [1], PR
> > > > > >
> > > > > > [2]
> > > > > > > > > > The fix in DataStructuresProcessor.java
> > > > > > > > > >
> > > > > > > > > > As far as I can see from git log Ilya Lantukh maintains
> this
> > >
> > > piece
> > > > > >
> > > > > > of
> > > > > > > > > code.
> > > > > > > > > >
> > > > > > > > > > Ilya, can you please take a look at the fix?
> > > > > > > > > >
> > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > > > > > > > > >
> > > > > > > > > > [2] https://github.com/apache/ignite/pull/2773
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Best regards,
> > > > > > > > > Ilya
> > > > > > > > >

Re: Welcome email: Kalashnikov

[Ruchir Choudhry]

Hello Ignite team,


I am not able to assign this ticket to my self,

https://issues.apache.org/jira/browse/IGNITE-7759



Can anyone help here,

Thanks,
Ruchir

On Wed, Feb 21, 2018 at 2:31 AM, Dmitry Pavlov 
wrote:

> Hi Anton,
>
> Welcome to the Ignite Community!
>
> Could you please share your JIRA ID?
>
> Sincerely,
> Dmitriy Pavlov
>
> P.S.
> Please subscribe to both dev and user lists:
> https://ignite.apache.org/community/resources.html#mail-lists
>
> Get familiar with Ignite development process described here:
> https://cwiki.apache.org/confluence/display/IGNITE/Development+Process
>
> Instructions on how to contribute can be found here:
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>
> Project setup in Intellij IDEA:
> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup
>
> ср, 21 февр. 2018 г. в 13:25, Антон Калашников :
>
> > Hello Ignite Community!
> >
> > I want to contribute to Apache Ignite and want to start with this issue -
> > IGNITE-6552. Any help on this will be appreciated.
> >
> > Best regards,
> > Anton Kalashnikov.
> >
> >
>

Re: IGNITE-6005 is ready for review

[Nikolay Izhikov]

Hello, Dmitry.

OK, I'll rerun TC with muted test.

В Чт, 22/02/2018 в 07:12 +, Dmitry Pavlov пишет:
> Hi Nikolay,
> 
> It seems Data structures test suite is still have timeout. Could you fail
> test caused this timeout?
> https://ci.ignite.apache.org/viewLog.html?buildId=1105706=buildResultsDiv=IgniteTests24Java8_IgniteDataStructures
> 
> Data structures is most relevant suite so I suggest to re-run it after
> failing problematic test.
> 
> Most probably this test is
> GridCachePartitionedDataStructuresFailoverSelfTest.testSemaphoreSingleNodeFailure.
> And it can be failed with link to
> https://issues.apache.org/jira/browse/IGNITE-5975
> 
> 
> Sincerely,
> Dmitriy Pavlov
> 
> чт, 22 февр. 2018 г. в 10:07, Nikolay Izhikov :
> 
> > Andrey,
> > 
> > I made TC run.
> > Please, see my comment in JIRA.
> > 
> > 
> > https://issues.apache.org/jira/browse/IGNITE-6005?focusedCommentId=16372502=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16372502
> > 
> > 
> > В Ср, 21/02/2018 в 15:03 +0300, Andrey Gura пишет:
> > > Nikolay,
> > > 
> > > it doesn't matter. I just want to be sure that there are no new
> > > failures in tests.
> > > 
> > > On Wed, Feb 21, 2018 at 1:14 PM, Dmitry Pavlov 
> > 
> > wrote:
> > > > Hi, I didn't find any runs in our new TC suite group (project) for
> > 
> > 2.4+:
> > > > 
> > 
> > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll=buildTypeStatusDiv_IgniteTests24Java8=pull%2F2773%2Fhead
> > > > 
> > > > So, Nikolay, I suggest to start RunAll in this suite group.
> > > > 
> > > > I can check results later in compare with master.
> > > > 
> > > > ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov :
> > > > 
> > > > > Hello, Andrey.
> > > > > 
> > > > > Do you run TC by yourself, or I as patch contributor should do it?
> > > > > 
> > > > > В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
> > > > > > I'll merge it if there are no any objections. But, the first, I'll
> > 
> > run
> > > > > 
> > > > > TC once again.
> > > > > > 
> > > > > > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
> > > > > 
> > > > > dpavlov@gmail.com> написал:
> > > > > > > Hi Igniters,
> > > > > > > 
> > > > > > > It seems this issue review process hang up.
> > > > > > > 
> > > > > > > Andrey Gura had concerns about this implementation. In the same
> > 
> > time
> > > > > 
> > > > > Ilya L
> > > > > > > checked this implementation and approves it.
> > > > > > > 
> > > > > > > I didn't find points to improve and concerns are not clear for
> > 
> > me. I
> > > > > 
> > > > > didn't
> > > > > > > managed to get more info in issue
> > > > > > > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
> > > > > > > 
> > > > > > > What can be our next step to solve this?
> > > > > > > 
> > > > > > > Absence of this fix causes 100% timeout in Data Structures suite
> > 
> > and
> > > > > 
> > > > > wastes
> > > > > > > agents for a long time.
> > > > > > > 
> > > > > > > Sincerely,
> > > > > > > Dmitriy Pavlov
> > > > > > > 
> > > > > > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh <
> > 
> > ilant...@gridgain.com>:
> > > > > > > 
> > > > > > > > Hi Nikolay,
> > > > > > > > 
> > > > > > > > Thanks for contribution!
> > > > > > > > 
> > > > > > > > I will try to review your pull request by tomorrow.
> > > > > > > > 
> > > > > > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov <
> > > > > 
> > > > > nizhi...@apache.org>
> > > > > > > > wrote:
> > > > > > > > 
> > > > > > > > > Hello, Igniters.
> > > > > > > > > 
> > > > > > > > > I've fix some relatively small issue(100 loc) IGNITE-6005
> > 
> > [1], PR
> > > > > 
> > > > > [2]
> > > > > > > > > The fix in DataStructuresProcessor.java
> > > > > > > > > 
> > > > > > > > > As far as I can see from git log Ilya Lantukh maintains this
> > 
> > piece
> > > > > 
> > > > > of
> > > > > > > > code.
> > > > > > > > > 
> > > > > > > > > Ilya, can you please take a look at the fix?
> > > > > > > > > 
> > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > > > > > > > > 
> > > > > > > > > [2] https://github.com/apache/ignite/pull/2773
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > --
> > > > > > > > Best regards,
> > > > > > > > Ilya
> > > > > > > > 

signature.asc
Description: This is a digitally signed message part

Re: IGNITE-6005 is ready for review

[Dmitry Pavlov]

Hi Nikolay,

It seems Data structures test suite is still have timeout. Could you fail
test caused this timeout?
https://ci.ignite.apache.org/viewLog.html?buildId=1105706=buildResultsDiv=IgniteTests24Java8_IgniteDataStructures

Data structures is most relevant suite so I suggest to re-run it after
failing problematic test.

Most probably this test is
GridCachePartitionedDataStructuresFailoverSelfTest.testSemaphoreSingleNodeFailure.
And it can be failed with link to
https://issues.apache.org/jira/browse/IGNITE-5975


Sincerely,
Dmitriy Pavlov

чт, 22 февр. 2018 г. в 10:07, Nikolay Izhikov :

> Andrey,
>
> I made TC run.
> Please, see my comment in JIRA.
>
>
> https://issues.apache.org/jira/browse/IGNITE-6005?focusedCommentId=16372502=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16372502
>
>
> В Ср, 21/02/2018 в 15:03 +0300, Andrey Gura пишет:
> > Nikolay,
> >
> > it doesn't matter. I just want to be sure that there are no new
> > failures in tests.
> >
> > On Wed, Feb 21, 2018 at 1:14 PM, Dmitry Pavlov 
> wrote:
> > > Hi, I didn't find any runs in our new TC suite group (project) for
> 2.4+:
> > >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll=buildTypeStatusDiv_IgniteTests24Java8=pull%2F2773%2Fhead
> > >
> > > So, Nikolay, I suggest to start RunAll in this suite group.
> > >
> > > I can check results later in compare with master.
> > >
> > > ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov :
> > >
> > > > Hello, Andrey.
> > > >
> > > > Do you run TC by yourself, or I as patch contributor should do it?
> > > >
> > > > В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
> > > > > I'll merge it if there are no any objections. But, the first, I'll
> run
> > > >
> > > > TC once again.
> > > > >
> > > > > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
> > > >
> > > > dpavlov@gmail.com> написал:
> > > > > > Hi Igniters,
> > > > > >
> > > > > > It seems this issue review process hang up.
> > > > > >
> > > > > > Andrey Gura had concerns about this implementation. In the same
> time
> > > >
> > > > Ilya L
> > > > > > checked this implementation and approves it.
> > > > > >
> > > > > > I didn't find points to improve and concerns are not clear for
> me. I
> > > >
> > > > didn't
> > > > > > managed to get more info in issue
> > > > > > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
> > > > > >
> > > > > > What can be our next step to solve this?
> > > > > >
> > > > > > Absence of this fix causes 100% timeout in Data Structures suite
> and
> > > >
> > > > wastes
> > > > > > agents for a long time.
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh <
> ilant...@gridgain.com>:
> > > > > >
> > > > > > > Hi Nikolay,
> > > > > > >
> > > > > > > Thanks for contribution!
> > > > > > >
> > > > > > > I will try to review your pull request by tomorrow.
> > > > > > >
> > > > > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov <
> > > >
> > > > nizhi...@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hello, Igniters.
> > > > > > > >
> > > > > > > > I've fix some relatively small issue(100 loc) IGNITE-6005
> [1], PR
> > > >
> > > > [2]
> > > > > > > > The fix in DataStructuresProcessor.java
> > > > > > > >
> > > > > > > > As far as I can see from git log Ilya Lantukh maintains this
> piece
> > > >
> > > > of
> > > > > > > code.
> > > > > > > >
> > > > > > > > Ilya, can you please take a look at the fix?
> > > > > > > >
> > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > > > > > > >
> > > > > > > > [2] https://github.com/apache/ignite/pull/2773
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Best regards,
> > > > > > > Ilya
> > > > > > >

Re: IGNITE-6005 is ready for review

[Nikolay Izhikov]

Andrey,

I made TC run.
Please, see my comment in JIRA.

https://issues.apache.org/jira/browse/IGNITE-6005?focusedCommentId=16372502=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16372502


В Ср, 21/02/2018 в 15:03 +0300, Andrey Gura пишет:
> Nikolay,
> 
> it doesn't matter. I just want to be sure that there are no new
> failures in tests.
> 
> On Wed, Feb 21, 2018 at 1:14 PM, Dmitry Pavlov  wrote:
> > Hi, I didn't find any runs in our new TC suite group (project) for 2.4+:
> > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll=buildTypeStatusDiv_IgniteTests24Java8=pull%2F2773%2Fhead
> > 
> > So, Nikolay, I suggest to start RunAll in this suite group.
> > 
> > I can check results later in compare with master.
> > 
> > ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov :
> > 
> > > Hello, Andrey.
> > > 
> > > Do you run TC by yourself, or I as patch contributor should do it?
> > > 
> > > В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
> > > > I'll merge it if there are no any objections. But, the first, I'll run
> > > 
> > > TC once again.
> > > > 
> > > > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
> > > 
> > > dpavlov@gmail.com> написал:
> > > > > Hi Igniters,
> > > > > 
> > > > > It seems this issue review process hang up.
> > > > > 
> > > > > Andrey Gura had concerns about this implementation. In the same time
> > > 
> > > Ilya L
> > > > > checked this implementation and approves it.
> > > > > 
> > > > > I didn't find points to improve and concerns are not clear for me. I
> > > 
> > > didn't
> > > > > managed to get more info in issue
> > > > > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
> > > > > 
> > > > > What can be our next step to solve this?
> > > > > 
> > > > > Absence of this fix causes 100% timeout in Data Structures suite and
> > > 
> > > wastes
> > > > > agents for a long time.
> > > > > 
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > > 
> > > > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh :
> > > > > 
> > > > > > Hi Nikolay,
> > > > > > 
> > > > > > Thanks for contribution!
> > > > > > 
> > > > > > I will try to review your pull request by tomorrow.
> > > > > > 
> > > > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov <
> > > 
> > > nizhi...@apache.org>
> > > > > > wrote:
> > > > > > 
> > > > > > > Hello, Igniters.
> > > > > > > 
> > > > > > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR
> > > 
> > > [2]
> > > > > > > The fix in DataStructuresProcessor.java
> > > > > > > 
> > > > > > > As far as I can see from git log Ilya Lantukh maintains this piece
> > > 
> > > of
> > > > > > code.
> > > > > > > 
> > > > > > > Ilya, can you please take a look at the fix?
> > > > > > > 
> > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > > > > > > 
> > > > > > > [2] https://github.com/apache/ignite/pull/2773
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > --
> > > > > > Best regards,
> > > > > > Ilya
> > > > > > 

signature.asc
Description: This is a digitally signed message part

[jira] [Created] (IGNITE-7784) Remove unnessary dependencies from WC front-end

[Alexander Kalinin (JIRA)]

Alexander Kalinin created IGNITE-7784:
-

 Summary: Remove unnessary dependencies from WC front-end
 Key: IGNITE-7784
 URL: https://issues.apache.org/jira/browse/IGNITE-7784
 Project: Ignite
  Issue Type: Task
Reporter: Alexander Kalinin
Assignee: Alexander Kalinin


There are some lageacy modules in packages.json (Like phantom.js). These should 
be deleted.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: TX SQL: SELECT FOR UPDATE implementation

[Dmitriy Setrakyan]

Alexander, thanks for the detailed explanation. I would start simple,
without JOINs. However, we should throw proper exceptions if unsupported
SQL is used.

D.

On Tue, Feb 20, 2018 at 9:45 AM, Alexander Paschenko <
alexander.a.pasche...@gmail.com> wrote:

> Hello again, and here I go with some more thoughts on SELECT FOR UPDATE.
> After having talking to Vlad, we returned again to question about how
> SELECT FOR UPDATE should work with JOINs.
>
> It seems that distributed joins currently are better to be left aside
> as long as rework of distributed queries and joins is a separate big
> issue.
> However, probably we still should think about what we could make work
> after all with what we have in our hands now. And it seems that some
> scenarios are pretty doable - say, when there's an ordinary JOIN of
> few tables, we can simply append keys of those tables to list of
> selected columns, and that would work in case of collocated data.
>
> * Alas, major vendors (Postgres, MySQL, Oracle) all also honor
> subqueries in JOINs - say, like this:
>
> select p.id , c.id from person p inner join (select * from company) c
> on p.company_id = c.id where p.id > 3 and p.id < 10 for update;
>
> Obviously, this is a bit corner case as such JOIN is not much
> different from an ordinary multi-table one, but it gives overall idea
> of what I'm talking about - major databases lock what's been selected
> in subquery as well.
>
> That said, aforementioned case probably could also be processed as
> suggested above - that is, we take innermost query, append key to list
> of its selected columns, so that we can refer to that new column from
> outer query, etc, etc. In principle we could process even
> multiple-level nesting of queries with such approach.
> Also no major vendors, except probably MySQL, support GROUP BY with
> SELECT FOR UPDATE, and this simplifies our task a bit. :)
>
> If someone can think of an example of a query that cannot be processed
> in the way described above, please write about it.
>
> * Also it looks like no major vendors out of three mentioned above
> lock record from tables mentioned in subqueries in SELECT columns or
> in WHERE - say, this query
>
> select p.id, (select count(*) from company) from person p
>
> will lock only records in Person table.
>
> Thoughts? Should we attempt to implement JOINs support right away? Or
> would it be better to leave it be for (near) future and start with
> simple implementation that would ban JOINs altogether?
>
> Regards,
> Alex
>
>
> 2018-01-25 10:58 GMT+03:00 Vladimir Ozerov :
> > Alex,
> >
> > Thank you for detailed analysis. My 50 cents:
> >
> > 1) I would not allow GROUP BYs in the first place. These are good
> > candidates for further iterations IMO
> > 2) Same as p.1
> > 3) In final TX SQL solution we woll lock rows, not keys
> > (GridCacheMapEntry). Can we simply lock every row returned from the
> query?
> > 4) Same as p.1
> > 5) Yes, it should work the same way we would implement it for normal
> queries
> >
> > Also I am not quite understand why should we keep results on map node
> until
> > all keys are locked. This increases memory pressure on the server.
> Instead,
> > I would start sending batches to reducer immediately, but do not return
> the
> > very first result to the user until all results are collected. This way
> > pressure is moved to the client what increases cluster stability. Will
> that
> > work?
> >
> > On Wed, Jan 24, 2018 at 6:23 PM, Alexander Paschenko <
> > alexander.a.pasche...@gmail.com> wrote:
> >
> >> Hello Igniters,
> >>
> >> I'd like to bring up the discussion about implementation details of
> >> https://issues.apache.org/jira/browse/IGNITE-6937 about
> >> support of SELECT FOR UPDATE statements as a part of overall activity
> >> on transactional SQL.
> >>
> >> That kind of statements allows the user proactively obtain row level
> >> locks for the records that they may (or may not) want to
> >> update in further statements of the same transaction.
> >>
> >> Suggested general approach to implementation is as follows:
> >>
> >> - Perform two-step SELECT as usual (e.g. split, map, reduce stages), BUT
> >> - Map nodes start giving away their first result pages for such query
> >> only after they have traversed whole their result set
> >> and have obtained locks for all keys corresponding to selected rows
> >> (e.g. rows matching WHERE clause).
> >>
> >> I've made some research on how some RDBMSs behave (MySQL, Oracle, Pg)
> >> and found that they all also consider SELECT FOR UPDATE
> >> finished and give away its result set only after all locks have been
> >> acquired, so in general suggested strategy is similar to
> >> what other databases do. Alas, everyone concerned is welcome to share
> >> their views on how this feature could work in Ignite - as well as on
> >> some stuff stated below. These are some caveats that I'd like to
> >> discuss in addition to overall approach.
> >>
> >> First: should we allow 

Re: [Apache Ignite Survey] Closed, results are attached

[Dmitriy Setrakyan]

Very useful.

BTW, here is the ticket for MultiMap implementation. It has a very nice
design proposal and looks fairly simple to implement.
https://issues.apache.org/jira/browse/IGNITE-640

Hope someone in the community can pick it up.

D.

On Wed, Feb 21, 2018 at 3:56 PM, Denis Magda  wrote:

> Igniters,
>
> The survey is off and here is a snapshot of the results:
> https://www.surveymonkey.com/results/SM-2T8S87DH8/
>
> Noteworthy observations:
>
>- 87% of respondents are software architects and engineers. These are
>the folks who help us to drive the project!
>
>
>- Most of Ignite use cases are in Banks and HighTech - this is what the
>consistency and in-memory speed are valued for!
>
>
>- Majority of the deployments store up to 100 GB of data in up to 20
>nodes clusters while 10% of deployments maintain hundreds and thousands
>nodes clusters - getting ready, community!
>
>
>- Ignite persistence is getting as valuable as the compute grid.
>
> Pay attention to the last question that contains a written individual
> feedback. It should guide our plans. For instance, I like this proposal:
>
> MultiMap support like in Guava is badly needed. Hazelcast has this and is
> highly used collection type, so much so this forces us to have to use
> Hazelcast over Ignite sadly in many apps
>
> --
> Denis
>

Re: Welcome email: Kalashnikov

[Denis Magda]

Welcome, Anton! Added you to the contributors' list.

--
Denis


On Wed, Feb 21, 2018 at 3:02 AM, Anton Kalashnikov 
wrote:

> Thank you, Dmitriy.
>
> My JIRA ID - akalashnikov
>
> --
> Best regards,
> Anton Kalashnikov
>
>
> 21.02.2018, 13:31, "Dmitry Pavlov" :
> > Hi Anton,
> >
> > Welcome to the Ignite Community!
> >
> > Could you please share your JIRA ID?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > P.S.
> > Please subscribe to both dev and user lists:
> > https://ignite.apache.org/community/resources.html#mail-lists
> >
> > Get familiar with Ignite development process described here:
> > https://cwiki.apache.org/confluence/display/IGNITE/Development+Process
> >
> > Instructions on how to contribute can be found here:
> > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
> >
> > Project setup in Intellij IDEA:
> > https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup
> >
> > ср, 21 февр. 2018 г. в 13:25, Антон Калашников :
> >
> >>  Hello Ignite Community!
> >>
> >>  I want to contribute to Apache Ignite and want to start with this
> issue -
> >>  IGNITE-6552. Any help on this will be appreciated.
> >>
> >>  Best regards,
> >>  Anton Kalashnikov.
>

[Rank up] Prove there are many Ignite users and developers

[Denis Magda]

Igniters,

I've come across an interesting article [1] that suggests measuring
project/product state and its community grows by putting together
information from LinkedIn.

Personally, I'm totally for this metric -- it's simple and vivid.

However, we were so busy deploying our Ignite applications or making it
better that forgot to speak out that we are skilled Ignite users and
developers. Help Ignite to catch up by going to your LinkedIn profiles and
adding "Apache Ignite" as a skill ;) Show that there are many of us who
keep moving Ignite forward!

[1] http://davebrimley.com/blog/IMDG-Skills-Jobs-Index-2018/

--
Denis

[Apache Ignite Survey] Closed, results are attached

[Denis Magda]

Igniters,

The survey is off and here is a snapshot of the results:
https://www.surveymonkey.com/results/SM-2T8S87DH8/

Noteworthy observations:

   - 87% of respondents are software architects and engineers. These are
   the folks who help us to drive the project!


   - Most of Ignite use cases are in Banks and HighTech - this is what the
   consistency and in-memory speed are valued for!


   - Majority of the deployments store up to 100 GB of data in up to 20
   nodes clusters while 10% of deployments maintain hundreds and thousands
   nodes clusters - getting ready, community!


   - Ignite persistence is getting as valuable as the compute grid.

Pay attention to the last question that contains a written individual
feedback. It should guide our plans. For instance, I like this proposal:

MultiMap support like in Guava is badly needed. Hazelcast has this and is
highly used collection type, so much so this forces us to have to use
Hazelcast over Ignite sadly in many apps

--
Denis

Re: Change TC trigger from Run All to per-project basis

[Dmitry Pavlov]

Hi Pavel,

Tests are passing now.

I've inluded
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_IgnitePlatformNetCoreLinux_IgniteTests24Java8=%3Cdefault%3E=buildTypeStatusDiv
to
Build Basic chain to run suite on per commit basis.

Let's see if it tests would be stable

Sincerely,
Dmitriy Pavlov

ср, 21 февр. 2018 г. в 10:26, Pavel Tupitsyn :

> Dmitry, thanks for the explanation, this makes sense.
>
> 1) Certainly can be helpful.
> 2) I would include "Platform .NET Core Linux": does not require win agent,
> runs 15 min, covers most functionality.
>
> Pavel
>
> On Wed, Feb 21, 2018 at 12:12 AM, Dmitry Pavlov 
> wrote:
>
> > Hi Pavel,
> >
> > WDYT,
> > 1) is it needed to prepare wiki article describing tests and chains we
> > have, e.g. describe
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_
> > RunBasicTests
> > and
> > its difference with RunAll; which chain to use in each case?
> >
> > 2) Which .Net test suite may be applicable to be included into 'run basic
> > tests' (requires <30 min to run, no failed test, no flaky test with fail
> > rate >1%) ?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пн, 19 февр. 2018 г. в 0:39, Pavel Tupitsyn :
> >
> > > Igniters,
> > >
> > > Currently we have a TeamCity trigger only on Run All aggregating
> project:
> > >
> > > https://ci.ignite.apache.org/admin/editTriggers.html?id=
> > buildType:IgniteTests24Java8_RunAll
> > >
> > > Each change triggers it's own full run. If new changes are added while
> > some
> > > builds are queued,
> > > these changes are not picked up, and a separate run is scheduled.
> > >
> > > At this very moment I see over 600 queued builds, all on master branch
> > from
> > > some trigger.
> > > Previously we had a trigger per-project, which seems to be more
> > efficient.
> > >
> > > Thoughts?
> > >
> > > Pavel
> > >
> >
>

[jira] [Created] (IGNITE-7783) Thin Client lib: PHP

[Alexey Kosenchuk (JIRA)]

Alexey Kosenchuk created IGNITE-7783:


 Summary: Thin Client lib: PHP
 Key: IGNITE-7783
 URL: https://issues.apache.org/jira/browse/IGNITE-7783
 Project: Ignite
  Issue Type: New Feature
  Components: thin client
Reporter: Alexey Kosenchuk
Assignee: Alexey Kosenchuk


Implement Thin (lightweight) Client lib in PHP programming language for Ignite 
Binary Client Protocol 
https://apacheignite.readme.io/docs/binary-client-protocol



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-7782) Thin Client lib: Python

[Alexey Kosenchuk (JIRA)]

Alexey Kosenchuk created IGNITE-7782:


 Summary: Thin Client lib: Python
 Key: IGNITE-7782
 URL: https://issues.apache.org/jira/browse/IGNITE-7782
 Project: Ignite
  Issue Type: New Feature
  Components: thin client
Reporter: Alexey Kosenchuk
Assignee: Alexey Kosenchuk


Implement Thin (lightweight) Client lib in Python programming language for 
Ignite Binary Client Protocol 
https://apacheignite.readme.io/docs/binary-client-protocol



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

FINAL REMINDER: CFP for Apache EU Roadshow Closes 25th February

[Sharan F]

Hello Apache Supporters and Enthusiasts

This is your FINAL reminder that the Call for Papers (CFP) for the 
Apache EU Roadshow is closing soon. Our Apache EU Roadshow will focus on 
Cloud, IoT, Apache Tomcat, Apache Http and will run from 13-14 June 2018 
in Berlin.
Note that the CFP deadline has been extended to *25*^*th* *February *and 
it will be your final opportunity to submit a talk for thisevent.


Please make your submissions at http://apachecon.com/euroadshow18/

Also note that early bird ticket registrations to attend FOSS Backstage 
including the Apache EU Roadshow, have also been extended and will be 
available until 23^rd February. Please register at 
https://foss-backstage.de/tickets


We look forward to seeing you in Berlin!

Thanks
Sharan Foga, VP Apache Community Development

PLEASE NOTE: You are receiving this message because you are subscribed 
to a user@ or dev@ list of one or more Apache Software Foundation projects.

[GitHub] ignite pull request #3555: IGNITE-7780 Fixed test ClientConnectorConfigurati...

[pvinokurov]

GitHub user pvinokurov opened a pull request:

https://github.com/apache/ignite/pull/3555

IGNITE-7780 Fixed test 
ClientConnectorConfigurationValidationSelfTest#testJdbcCon…



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7780

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3555.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3555


commit 9a01ac90cef25638c4d9829d39f830ea1c9469c8
Author: pvinokurov 
Date:   2018-02-21T16:48:56Z

Fixed test 
ClientConnectorConfigurationValidationSelfTest#testJdbcConnectionDisabledForDaemon




---

[jira] [Created] (IGNITE-7780) Fix ClientConnectorConfigurationValidationSelfTest#testJdbcConnectionDisabledForDaemon

[Pavel Vinokurov (JIRA)]

Pavel Vinokurov created IGNITE-7780:
---

 Summary: Fix 
ClientConnectorConfigurationValidationSelfTest#testJdbcConnectionDisabledForDaemon
 Key: IGNITE-7780
 URL: https://issues.apache.org/jira/browse/IGNITE-7780
 Project: Ignite
  Issue Type: Test
Reporter: Pavel Vinokurov
Assignee: Pavel Vinokurov






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ignite pull request #3554: IGNITE-5555: reproducing JVM crash (probably prot...

[dspavlov]

GitHub user dspavlov opened a pull request:

https://github.com/apache/ignite/pull/3554

IGNITE-: reproducing JVM crash (probably protected with assert) i…

…n reproducing suite

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3554


commit f1530738ab6530f7b965dea621646b1e2f2c9a93
Author: dpavlov 
Date:   2018-02-21T16:26:58Z

IGNITE-: reproducing JVM crash (probably protected with assert) in 
reproducing suite




---

[GitHub] ignite pull request #3553: Ignite 7776 - long constants calculation

[abeliak]

GitHub user abeliak opened a pull request:

https://github.com/apache/ignite/pull/3553

Ignite 7776 - long constants calculation

Big L pull request with intL * int * int calculation of long constants

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7776

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3553


commit 6a057a0356714e01aded0f38dbeac4b6db53e4ce
Author: Alexander Belyak 
Date:   2018-02-21T13:45:29Z

ignite-7776: fix memory configuration docs and minor assertion fixes

commit af31159c1237ee8d47aa1dc39352dc66283d4d66
Author: Alexander Belyak 
Date:   2018-02-21T14:52:54Z

ignite-7776: use L after first multiplier in long constants calculation in 
tests

commit ad1dc6e625fb853761f01caf1b7034771ae36950
Author: Alexander Belyak 
Date:   2018-02-21T14:55:04Z

ignite-7776: use L after first multiplier in long constants calculation in 
tests




---

[GitHub] ignite pull request #3552: IGNITE-7362: Fixed PDO issue when working with OD...

[isapego]

GitHub user isapego opened a pull request:

https://github.com/apache/ignite/pull/3552

IGNITE-7362: Fixed PDO issue when working with ODBC



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7362

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3552


commit 37a23e76ebe45933e149d0399d5831c6bf133f02
Author: Igor Sapego 
Date:   2018-01-30T17:26:34Z

IGNITE-7362: Added deprecated driver info support

commit 345c3f9f84dc646e1dbf8338c78416201c48cf4d
Author: Igor Sapego 
Date:   2018-02-07T14:06:01Z

IGNITE-7362: Adjusted buffers writing

commit 04ecaf6978ca75fa6d2ec9214209fc8c3505dbad
Author: Igor Sapego 
Date:   2018-02-12T15:29:28Z

IGNITE-7362: Re-worked columns fetching

commit 6f1c9d2e344005d21160bc2541c15ae66e87e3bc
Author: Igor Sapego 
Date:   2018-02-13T10:10:42Z

IGNITE-7362: Fixes

commit 1333927954d39dcbbaa5ceb1c1a8d4da806a6d69
Author: Igor Sapego 
Date:   2018-02-21T13:43:56Z

IGNITE-7362: Fixed errors.




---

[GitHub] ignite pull request #3551: ignite-7383

[ilantukh]

GitHub user ilantukh opened a pull request:

https://github.com/apache/ignite/pull/3551

ignite-7383



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilantukh/ignite ignite-7383

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3551


commit 2724ca1b3b3dec14e3689407053c9d5d55c504dd
Author: Ilya Lantukh 
Date:   2018-02-19T14:51:39Z

ignite-7383 : Reproducer.

commit 9d2d5c06511b6f413f2dedc42b174815d68aecbc
Author: Ilya Lantukh 
Date:   2018-02-21T14:01:56Z

ignite-7383 : Read persisted cache configs on node start.




---

[jira] [Created] (IGNITE-7779) Ignite fails to start with a custom GridSecurityProcessor and enabled assertions

[Robert Wruck (JIRA)]

Robert Wruck created IGNITE-7779:


 Summary: Ignite fails to start with a custom GridSecurityProcessor 
and enabled assertions
 Key: IGNITE-7779
 URL: https://issues.apache.org/jira/browse/IGNITE-7779
 Project: Ignite
  Issue Type: Bug
  Components: general
Affects Versions: 2.3
Reporter: Robert Wruck


When a custom GridSecurityProcessor is installed, ServerImpl.joinTopology will 
call localAuthentication, which asserts that the passed SecurityCredentials are 
not null.

Problem 1: There is no good way to set the SecurityCredentials for the local 
node. The GridGain implementation for example does this by "somehow" obtaining 
the GridKernalContext and directly setting the magic ATTR_SECURITY_CREDENTIALS 
attribute.

Problem 2: Whether a GridSecurityProcessor accepts a null SecurityCredentials 
instance should not be decided in localAuthentication anyway.

Please provide a documented way for GridSecurityProcessors to set set the 
SecurityCredentials and remove the assertion - it works just fine with null.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ignite pull request #3550: IGNITE-7756: IgniteUuid added to predefined types...

[nizhikov]

GitHub user nizhikov opened a pull request:

https://github.com/apache/ignite/pull/3550

IGNITE-7756: IgniteUuid added to predefined types.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nizhikov/ignite IGNITE-7756

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3550.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3550


commit cbc9179b70f32391888de8fdc9eacc2df13c5965
Author: Nikolay Izhikov 
Date:   2018-02-21T13:03:06Z

IGNITE-7756: IgniteUuid added to predefined types to resolve indexing issue.




---

[jira] [Created] (IGNITE-7778) User's authentication data must be persisted on cluster with disabled persistence

[Taras Ledkov (JIRA)]

Taras Ledkov created IGNITE-7778:


 Summary: User's authentication data must be persisted on cluster 
with disabled persistence
 Key: IGNITE-7778
 URL: https://issues.apache.org/jira/browse/IGNITE-7778
 Project: Ignite
  Issue Type: Task
Reporter: Taras Ledkov


The ticket is related to the: IGNITE-7436 (introduce users in Ignite)
{{IgniteAuthenticationProcessor}} uses metastorage to persist user data. But 
metastorage works only with persistent cluster. We have to support user 
authentication for in-memory cluster.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: IgniteDataStreamer silently fails on a server node

[Anton Vinogradov]

Nikolay,

I checked your reproducer and it looks like retry helps data streamer to
solve this.
I
set 
org.apache.ignite.internal.processors.datastreamer.DataStreamerImpl#DFLT_MAX_REMAP_CNT
to zero and see test fails now.

Looks like second attempt is successful for such case.

On Wed, Feb 21, 2018 at 1:36 PM, Dmitriy Setrakyan 
wrote:

> On Wed, Feb 21, 2018 at 12:10 AM, Nikolay Izhikov 
> wrote:
>
> > Hello, Igniters.
> >
> > > Does this exception happen because IgniteUuid class is not correctly
> > > handled?
> >
> > Yes. I've fixed it.
> > But story doesn't end :)
> >
> > > As far as propagating exceptions, addData(...) is asynchronous
> operation
> > > and returns IgniteFuture.
> >
> > Thank you, my bad.
> >
> > But, I can't understand when returned future should complete?
> >
> > Javadocs or documentation doesn't explain it.
> > Also, I can't find any tests that checks future returned from addData.
> >
> > Can someone explan it to me?
> >
>
> The returned future should complete either when the data is successfully
> stored in cache, or whenever the failure occurs.
>

Re: Ignite Thin clients for Node.js, Python, PHP

[Alexey Kosenchuk]

Denis, Alexey, Pavel, Sergey, thanks for info.

We will start from Node.js lib.
I've created Jira (https://issues.apache.org/jira/browse/IGNITE-) to 
track it's scope and status.


Sure, we will provide the main ideas / API for review first, etc. 
according to the process.


-Alexey

20.02.2018 1:09, Denis Magda пишет:

Hi Alexey and welcome to all of you! Look forward to seeing the clients in
Ignite codebase ;)

Granted contributors access to all of you in JIRA. Feel free to assign
existing tickets to yourself or create new ones.

However, before you're getting down to the implementation, please share the
design and architectural ideas around the clients. Plus, it will be
reasonable to start with one client first and then add the rest once you
find out how the community works and Ignite is architectured.

Pavel T., Alex K., as creators of .NET and Java thin clients, please share
pointers that might be useful for Alexey.

--
Denis


On Mon, Feb 19, 2018 at 1:23 PM, Alexey Kosenchuk <
alexey.kosenc...@nobitlost.com> wrote:


Hi All!

Let us join the party, please ;)

As we see, there is Binary Client Protocol to communicate with Ignite
cluster and a concept of Thin (lightweight) client.

If there are no objections or duplicated plans, we would like to develop
Thin Client libs for:
- Node.js
- Python
- PHP

Please add us as contributors and provide access to the Ignite Jira
components.

Usernames in the Apache Jira:
alexey.kosenchuk
ekaterina.vergizova
pavel.petroshenko

Thanks!
-Alexey

[jira] [Created] (IGNITE-7777) Thin Client lib: Node.js

[Alexey Kosenchuk (JIRA)]

Alexey Kosenchuk created IGNITE-:


 Summary: Thin Client lib: Node.js
 Key: IGNITE-
 URL: https://issues.apache.org/jira/browse/IGNITE-
 Project: Ignite
  Issue Type: New Feature
  Components: thin client
Reporter: Alexey Kosenchuk
Assignee: Alexey Kosenchuk


Implement Thin (lightweight) Client lib in Node.js programming language for 
Ignite Binary Client Protocol 
https://apacheignite.readme.io/docs/binary-client-protocol

Examples of other Thin Clients:
.net 
https://github.com/apache/ignite/tree/master/modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client
java 
https://github.com/gridgain/apache-ignite/tree/ignite-7421/modules/thinclient

Scope of work
-

Functionality:
Support all operations of the Ignite Binary Client Protocol 2.4.
Support name/password authentication - TBD (not in the protocol yet).
Support optional SSL/TLS communication - TBD (not in the protocol yet).
Support optional failover/reconnect - TBD.

Minimal Node.js version - TBD.
Synch ops emulation - callbacks, or Promises, or asynch/await - TBD.

Examples:
Cover all basic features - Key-value API, SQL, Scan queries, Cluster 
configuration/management, Authentication, SSL/TLS.

Tests:
Jasmine tests for all API methods and all basic features.
Simple Jasmine tests to start examples.
How to emulate node failure to test failover/reconnect? - TBD.

Docs:
Auto-generated API spec from comments. JSdoc, or javadoc, or what? - TBD.
Readme for the lib.
Simple instruction to setup/run examples.
Simple instruction to setup/run Jasmine tests.

Docs format - .md in the repo, or dash.readme.io ? - TBD.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: IGNITE-6005 is ready for review

[Andrey Gura]

Nikolay,

it doesn't matter. I just want to be sure that there are no new
failures in tests.

On Wed, Feb 21, 2018 at 1:14 PM, Dmitry Pavlov  wrote:
> Hi, I didn't find any runs in our new TC suite group (project) for 2.4+:
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll=buildTypeStatusDiv_IgniteTests24Java8=pull%2F2773%2Fhead
>
> So, Nikolay, I suggest to start RunAll in this suite group.
>
> I can check results later in compare with master.
>
> ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov :
>
>> Hello, Andrey.
>>
>> Do you run TC by yourself, or I as patch contributor should do it?
>>
>> В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
>> > I'll merge it if there are no any objections. But, the first, I'll run
>> TC once again.
>> >
>> > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
>> dpavlov@gmail.com> написал:
>> > > Hi Igniters,
>> > >
>> > > It seems this issue review process hang up.
>> > >
>> > > Andrey Gura had concerns about this implementation. In the same time
>> Ilya L
>> > > checked this implementation and approves it.
>> > >
>> > > I didn't find points to improve and concerns are not clear for me. I
>> didn't
>> > > managed to get more info in issue
>> > > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
>> > >
>> > > What can be our next step to solve this?
>> > >
>> > > Absence of this fix causes 100% timeout in Data Structures suite and
>> wastes
>> > > agents for a long time.
>> > >
>> > > Sincerely,
>> > > Dmitriy Pavlov
>> > >
>> > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh :
>> > >
>> > > > Hi Nikolay,
>> > > >
>> > > > Thanks for contribution!
>> > > >
>> > > > I will try to review your pull request by tomorrow.
>> > > >
>> > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov <
>> nizhi...@apache.org>
>> > > > wrote:
>> > > >
>> > > > > Hello, Igniters.
>> > > > >
>> > > > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR
>> [2]
>> > > > > The fix in DataStructuresProcessor.java
>> > > > >
>> > > > > As far as I can see from git log Ilya Lantukh maintains this piece
>> of
>> > > > code.
>> > > > >
>> > > > > Ilya, can you please take a look at the fix?
>> > > > >
>> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
>> > > > >
>> > > > > [2] https://github.com/apache/ignite/pull/2773
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Best regards,
>> > > > Ilya
>> > > >

[jira] [Created] (IGNITE-7776) Check calculated values in javadoc

[Alexander Belyak (JIRA)]

Alexander Belyak created IGNITE-7776:


 Summary: Check calculated values in javadoc
 Key: IGNITE-7776
 URL: https://issues.apache.org/jira/browse/IGNITE-7776
 Project: Ignite
  Issue Type: Bug
  Components: documentation
Affects Versions: 2.3, 2.2, 2.1, 2.0
Reporter: Alexander Belyak
Assignee: Alexander Belyak


We have two issue with calculated value in javadoc:

1) wrong numbers, for example: #\{5 * 1024 * 102 * 1024}

2) overflow int type, for example: #\{5 * 1024 * 1024 * 1024}

Need to check as many places as possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Welcome email: Kalashnikov

[Anton Kalashnikov]

Thank you, Dmitriy.

My JIRA ID - akalashnikov

-- 
Best regards,
Anton Kalashnikov


21.02.2018, 13:31, "Dmitry Pavlov" :
> Hi Anton,
>
> Welcome to the Ignite Community!
>
> Could you please share your JIRA ID?
>
> Sincerely,
> Dmitriy Pavlov
>
> P.S.
> Please subscribe to both dev and user lists:
> https://ignite.apache.org/community/resources.html#mail-lists
>
> Get familiar with Ignite development process described here:
> https://cwiki.apache.org/confluence/display/IGNITE/Development+Process
>
> Instructions on how to contribute can be found here:
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute
>
> Project setup in Intellij IDEA:
> https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup
>
> ср, 21 февр. 2018 г. в 13:25, Антон Калашников :
>
>>  Hello Ignite Community!
>>
>>  I want to contribute to Apache Ignite and want to start with this issue -
>>  IGNITE-6552. Any help on this will be appreciated.
>>
>>  Best regards,
>>  Anton Kalashnikov.

[jira] [Created] (IGNITE-7775) Web console. Error in log on second click by cancel on profile page.

[Vasiliy Sisko (JIRA)]

Vasiliy Sisko created IGNITE-7775:
-

 Summary: Web console. Error in log on second click by cancel on 
profile page.
 Key: IGNITE-7775
 URL: https://issues.apache.org/jira/browse/IGNITE-7775
 Project: Ignite
  Issue Type: Bug
Reporter: Vasiliy Sisko
Assignee: Dmitriy Shabalin


Opening of base page on Cancel click spend a lot of time. 
If Cancel button is pressed second time error message will be printed into 
console:
Transition Rejection($id: 52 type: 2, message: The transition has been 
superseded by a different transition, detail: Transition#73( 
'base.settings.profile'{} -> 'base.configuration.clusters'{} ))



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: IgniteDataStreamer silently fails on a server node

[Dmitriy Setrakyan]

On Wed, Feb 21, 2018 at 12:10 AM, Nikolay Izhikov 
wrote:

> Hello, Igniters.
>
> > Does this exception happen because IgniteUuid class is not correctly
> > handled?
>
> Yes. I've fixed it.
> But story doesn't end :)
>
> > As far as propagating exceptions, addData(...) is asynchronous operation
> > and returns IgniteFuture.
>
> Thank you, my bad.
>
> But, I can't understand when returned future should complete?
>
> Javadocs or documentation doesn't explain it.
> Also, I can't find any tests that checks future returned from addData.
>
> Can someone explan it to me?
>

The returned future should complete either when the data is successfully
stored in cache, or whenever the failure occurs.

Re: Welcome email: Kalashnikov

[Dmitry Pavlov]

Hi Anton,

Welcome to the Ignite Community!

Could you please share your JIRA ID?

Sincerely,
Dmitriy Pavlov

P.S.
Please subscribe to both dev and user lists:
https://ignite.apache.org/community/resources.html#mail-lists

Get familiar with Ignite development process described here:
https://cwiki.apache.org/confluence/display/IGNITE/Development+Process

Instructions on how to contribute can be found here:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute

Project setup in Intellij IDEA:
https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup

ср, 21 февр. 2018 г. в 13:25, Антон Калашников :

> Hello Ignite Community!
>
> I want to contribute to Apache Ignite and want to start with this issue -
> IGNITE-6552. Any help on this will be appreciated.
>
> Best regards,
> Anton Kalashnikov.
>
>

[jira] [Created] (IGNITE-7774) Missing Google Cloud libraries at binary release

[Roman Guseinov (JIRA)]

Roman Guseinov created IGNITE-7774:
--

 Summary: Missing Google Cloud libraries at binary release
 Key: IGNITE-7774
 URL: https://issues.apache.org/jira/browse/IGNITE-7774
 Project: Ignite
  Issue Type: Bug
  Components: build
 Environment: * Ubuntu 16.04.3 LTS
* Apache Ignite 2.3.0
Reporter: Roman Guseinov


It looks like following libraries aren't included in the build:
 * google-http-client-1.22.0.jar
 * google-http-client-jackson2-1.22.0.jar
 * google-oauth-client-1.22.0.jar

Steps to reproduce:
 # Download apache-ignite-fabric-2.3.0-bin.zip 
([http://apache-mirror.rbc.ru/pub/apache//ignite/2.3.0/apache-ignite-fabric-2.3.0-bin.zip]).
2. Unzip archive.
2. Move ignite-gce from /libs/optional to /libs
3. Update IgniteConfiguration in default-config.xml:

{code:xml}

  

  




  

  

{code}
4. Copy  into $IGNITE_HOME
5. Run bin/ignite.sh
6. Log:
{code:java}
class org.apache.ignite.IgniteException: Failed to instantiate Spring XML 
application context (make sure all classes used in Spring configuration are 
present at CLASSPATH) 
[springUrl=file:/home/roman/Desktop/releases/gridgain-professional-fabric-2.3.3/config/default-config.xml]
 at 
org.apache.ignite.internal.util.IgniteUtils.convertException(IgniteUtils.java:966)
 at org.apache.ignite.Ignition.start(Ignition.java:350)
 at 
org.apache.ignite.startup.cmdline.CommandLineStartup.main(CommandLineStartup.java:302)
Caused by: class org.apache.ignite.IgniteCheckedException: Failed to 
instantiate Spring XML application context (make sure all classes used in 
Spring configuration are present at CLASSPATH) 
[springUrl=file:/home/roman/Desktop/releases/gridgain-professional-fabric-2.3.3/config/default-config.xml]
 at 
org.apache.ignite.internal.util.spring.IgniteSpringHelperImpl.applicationContext(IgniteSpringHelperImpl.java:387)
 at 
org.apache.ignite.internal.util.spring.IgniteSpringHelperImpl.loadConfigurations(IgniteSpringHelperImpl.java:104)
 at 
org.apache.ignite.internal.util.spring.IgniteSpringHelperImpl.loadConfigurations(IgniteSpringHelperImpl.java:98)
 at 
org.apache.ignite.internal.IgnitionEx.loadConfigurations(IgnitionEx.java:673)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:874)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:783)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:653)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:622)
 at org.apache.ignite.Ignition.start(Ignition.java:347)
 ... 1 more
Caused by: org.springframework.beans.factory.BeanCreationException: Error 
creating bean with name 'org.apache.ignite.configuration.IgniteConfiguration#0' 
defined in URL 
[file:/home/roman/Desktop/releases/gridgain-professional-fabric-2.3.3/config/default-config.xml]:
 Cannot create inner bean 
'org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi#65e2dbf3' of type 
[org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi] while setting bean 
property 'discoverySpi'; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi#65e2dbf3' 
defined in URL 
[file:/home/roman/Desktop/releases/gridgain-professional-fabric-2.3.3/config/default-config.xml]:
 Cannot create inner bean 
'org.apache.ignite.spi.discovery.tcp.ipfinder.gce.TcpDiscoveryGoogleStorageIpFinder#1d16f93d'
 of type 
[org.apache.ignite.spi.discovery.tcp.ipfinder.gce.TcpDiscoveryGoogleStorageIpFinder]
 while setting bean property 'ipFinder'; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 
'org.apache.ignite.spi.discovery.tcp.ipfinder.gce.TcpDiscoveryGoogleStorageIpFinder#1d16f93d'
 defined in URL 
[file:/home/roman/Desktop/releases/gridgain-professional-fabric-2.3.3/config/default-config.xml]:
 Instantiation of bean failed; nested exception is 
org.springframework.beans.BeanInstantiationException: Failed to instantiate 
[org.apache.ignite.spi.discovery.tcp.ipfinder.gce.TcpDiscoveryGoogleStorageIpFinder]:
 No default constructor found; nested exception is 
java.lang.NoClassDefFoundError: 
com/google/api/client/http/AbstractInputStreamContent
 at 
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveInnerBean(BeanDefinitionValueResolver.java:313)
 at 
org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:122)
 at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1531)
 at 
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1276)
 at 

Welcome email: Kalashnikov

[Антон Калашников]

Hello Ignite Community!

I want to contribute to Apache Ignite and want to start with this issue - 
IGNITE-6552. Any help on this will be appreciated.

Best regards,
Anton Kalashnikov.

Re: IGNITE-6005 is ready for review

[Dmitry Pavlov]

Hi, I didn't find any runs in our new TC suite group (project) for 2.4+:
https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll=buildTypeStatusDiv_IgniteTests24Java8=pull%2F2773%2Fhead

So, Nikolay, I suggest to start RunAll in this suite group.

I can check results later in compare with master.

ср, 21 февр. 2018 г. в 11:48, Nikolay Izhikov :

> Hello, Andrey.
>
> Do you run TC by yourself, or I as patch contributor should do it?
>
> В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
> > I'll merge it if there are no any objections. But, the first, I'll run
> TC once again.
> >
> > 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
> dpavlov@gmail.com> написал:
> > > Hi Igniters,
> > >
> > > It seems this issue review process hang up.
> > >
> > > Andrey Gura had concerns about this implementation. In the same time
> Ilya L
> > > checked this implementation and approves it.
> > >
> > > I didn't find points to improve and concerns are not clear for me. I
> didn't
> > > managed to get more info in issue
> > > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
> > >
> > > What can be our next step to solve this?
> > >
> > > Absence of this fix causes 100% timeout in Data Structures suite and
> wastes
> > > agents for a long time.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh :
> > >
> > > > Hi Nikolay,
> > > >
> > > > Thanks for contribution!
> > > >
> > > > I will try to review your pull request by tomorrow.
> > > >
> > > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov <
> nizhi...@apache.org>
> > > > wrote:
> > > >
> > > > > Hello, Igniters.
> > > > >
> > > > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR
> [2]
> > > > > The fix in DataStructuresProcessor.java
> > > > >
> > > > > As far as I can see from git log Ilya Lantukh maintains this piece
> of
> > > > code.
> > > > >
> > > > > Ilya, can you please take a look at the fix?
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > > > >
> > > > > [2] https://github.com/apache/ignite/pull/2773
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Ilya
> > > >

[GitHub] ignite pull request #3549: Test run. config option to use off-heap map inste...

[xtern]

GitHub user xtern opened a pull request:

https://github.com/apache/ignite/pull/3549

Test run. config option to use off-heap map instead of CHM 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xtern/ignite IGNITE-7565

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/3549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3549


commit ebb84a057a3fe4ca8ecd5b0e00b2b503550a6ddf
Author: pereslegin-pa 
Date:   2018-02-16T16:34:44Z

IGNITE-7565 Introduced collection configuration option to use 
GridOffHeapMap instead of CHM.

commit cd303c1a9c5424974f41bf672515cec19d48956c
Author: pereslegin-pa 
Date:   2018-02-21T09:21:50Z

IGNITE-7565 Tests.




---

Re: IGNITE-6005 is ready for review

[Nikolay Izhikov]

Hello, Andrey.

Do you run TC by yourself, or I as patch contributor should do it?

В Ср, 21/02/2018 в 11:42 +0300, Andrey Gura пишет:
> I'll merge it if there are no any objections. But, the first, I'll run TC 
> once again.
> 
> 21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" 
>  написал:
> > Hi Igniters,
> > 
> > It seems this issue review process hang up.
> > 
> > Andrey Gura had concerns about this implementation. In the same time Ilya L
> > checked this implementation and approves it.
> > 
> > I didn't find points to improve and concerns are not clear for me. I didn't
> > managed to get more info in issue
> > https://issues.apache.org/jira/browse/IGNITE-6005 comments.
> > 
> > What can be our next step to solve this?
> > 
> > Absence of this fix causes 100% timeout in Data Structures suite and wastes
> > agents for a long time.
> > 
> > Sincerely,
> > Dmitriy Pavlov
> > 
> > пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh :
> > 
> > > Hi Nikolay,
> > >
> > > Thanks for contribution!
> > >
> > > I will try to review your pull request by tomorrow.
> > >
> > > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov 
> > > wrote:
> > >
> > > > Hello, Igniters.
> > > >
> > > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR [2]
> > > > The fix in DataStructuresProcessor.java
> > > >
> > > > As far as I can see from git log Ilya Lantukh maintains this piece of
> > > code.
> > > >
> > > > Ilya, can you please take a look at the fix?
> > > >
> > > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > > >
> > > > [2] https://github.com/apache/ignite/pull/2773
> > >
> > >
> > >
> > >
> > > --
> > > Best regards,
> > > Ilya
> > >

signature.asc
Description: This is a digitally signed message part

Re: IGNITE-6005 is ready for review

[Andrey Gura]

I'll merge it if there are no any objections. But, the first, I'll run TC
once again.

21 февр. 2018 г. 12:28 AM пользователь "Dmitry Pavlov" <
dpavlov@gmail.com> написал:

> Hi Igniters,
>
> It seems this issue review process hang up.
>
> Andrey Gura had concerns about this implementation. In the same time Ilya L
> checked this implementation and approves it.
>
> I didn't find points to improve and concerns are not clear for me. I didn't
> managed to get more info in issue
> https://issues.apache.org/jira/browse/IGNITE-6005 comments.
>
> What can be our next step to solve this?
>
> Absence of this fix causes 100% timeout in Data Structures suite and wastes
> agents for a long time.
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 12 февр. 2018 г. в 17:54, Ilya Lantukh :
>
> > Hi Nikolay,
> >
> > Thanks for contribution!
> >
> > I will try to review your pull request by tomorrow.
> >
> > On Mon, Feb 12, 2018 at 11:45 AM, Nikolay Izhikov 
> > wrote:
> >
> > > Hello, Igniters.
> > >
> > > I've fix some relatively small issue(100 loc) IGNITE-6005 [1], PR [2]
> > > The fix in DataStructuresProcessor.java
> > >
> > > As far as I can see from git log Ilya Lantukh maintains this piece of
> > code.
> > >
> > > Ilya, can you please take a look at the fix?
> > >
> > > [1] https://issues.apache.org/jira/browse/IGNITE-6005
> > >
> > > [2] https://github.com/apache/ignite/pull/2773
> >
> >
> >
> >
> > --
> > Best regards,
> > Ilya
> >
>

Re: IgniteDataStreamer silently fails on a server node

[Nikolay Izhikov]

Hello, Igniters.

> Does this exception happen because IgniteUuid class is not correctly
> handled? 

Yes. I've fixed it. 
But story doesn't end :)

> As far as propagating exceptions, addData(...) is asynchronous operation
> and returns IgniteFuture.

Thank you, my bad.

But, I can't understand when returned future should complete?

Javadocs or documentation doesn't explain it.
Also, I can't find any tests that checks future returned from addData.

Can someone explan it to me?

В Пн, 19/02/2018 в 21:47 -0600, Dmitriy Setrakyan пишет:
> Nikolay,
> 
> Does this exception happen because IgniteUuid class is not correctly
> handled? If that's the case, we should fix it. Would be great if you could
> do it.
> 
> As far as propagating exceptions, addData(...) is asynchronous operation
> and returns IgniteFuture. The exception should be propagated to that
> future. Do you not see it there?
> 
> D.
> 
> On Mon, Feb 19, 2018 at 1:00 PM, Nikolay Izhikov 
> wrote:
> 
> > Hello, Igniters.
> > 
> > While working on IGNITE-7727 I found strange behavior of
> > IgniteDataStreamer:
> > 
> > If we have IgniteUuid as an indexed type update silently brokes on a
> > server node.
> > Client doesn't have any notification about fails.
> > All calls of `addData`, `close`, etc. succeed on a client side but fails
> > on server side.
> > 
> > I see 2 issue here:
> > 
> > 1. The fail itself - it certainly a bug, I think I can fix it.
> > 
> > 2. Lack of client notification. Is it OK when client doesn't know about
> > fails of streamer updates?
> > Do we have this documented? I briefly looked at streamer docs but can't
> > find description of such behavior.
> > 
> > 
> > Reproducer [1]
> > 
> > ```
> > public void testStreamer() throws Exception {
> > Ignite client = grid("client");
> > 
> > CacheConfiguration ccfg = new CacheConfiguration("UUID_CACHE");
> > 
> > ccfg.setIndexedTypes(IgniteUuid.class, String.class);
> > 
> > client.createCache(ccfg);
> > 
> > try(IgniteDataStreamer cache =
> > client.dataStreamer("UUID_CACHE")) {
> > 
> > for(Integer i=0; i<2; i++)
> > cache.addData(IgniteUuid.randomUuid().toString(),
> > i.toString());
> > }
> > }
> > ```
> > 
> > Server node stack trace [2]:
> > 
> > ```
> > Caused by: class org.apache.ignite.IgniteCheckedException: Failed to
> > update index, incorrect key class [expCls=org.apache.ignite.
> > lang.IgniteUuid,
> > actualCls=org.apache.ignite.internal.binary.BinaryObjectImpl]
> > at org.apache.ignite.internal.processors.query.GridQueryProcessor.
> > typeByValue(GridQueryProcessor.java:1954)
> > at org.apache.ignite.internal.processors.query.
> > GridQueryProcessor.store(GridQueryProcessor.java:1877)
> > at org.apache.ignite.internal.processors.cache.query.
> > GridCacheQueryManager.store(GridCacheQueryManager.java:403)
> > at org.apache.ignite.internal.processors.cache.
> > IgniteCacheOffheapManagerImpl$CacheDataStoreImpl.finishUpdate(
> > IgniteCacheOffheapManagerImpl.java:1343)
> > at org.apache.ignite.internal.processors.cache.
> > IgniteCacheOffheapManagerImpl$CacheDataStoreImpl.invoke(
> > IgniteCacheOffheapManagerImpl.java:1207)
> > at org.apache.ignite.internal.processors.cache.
> > IgniteCacheOffheapManagerImpl.invoke(IgniteCacheOffheapManagerImpl.
> > java:345)
> > at org.apache.ignite.internal.processors.cache.
> > GridCacheMapEntry.storeValue(GridCacheMapEntry.java:3527)
> > at org.apache.ignite.internal.processors.cache.GridCacheMapEntry.
> > initialValue(GridCacheMapEntry.java:2735)
> > at org.apache.ignite.internal.processors.datastreamer.
> > DataStreamerImpl$IsolatedUpdater.receive(DataStreamerImpl.java:2113)
> > ... 11 more
> > ```
> > 
> > [1] https://gist.github.com/nizhikov/2e70a73c7b74a50fc89d270e9af1e1ca
> > 
> > [2] https://gist.github.com/nizhikov/c491c8f2b45aa59458b37b42b4b8dab4

signature.asc
Description: This is a digitally signed message part