Re: Addressing usability issues with JDK 9-11

[Dmitriy Pavlov]

I don't see too much difference in taking master as is (e.g. today) vs 2.7
branch. Originally proposed release probably can be named as 2.7.1.

Ignite compress also is in master, so for 2.8 it is natural to be master
based.

Moreover, please take a look at
https://issues.apache.org/jira/browse/IGNITE-11461
We can make some our jars modular without API changes (some will require
breaking changes and 3.0).

Also, please don't be confused about if we have Java 11 support or not.
Provided that we bypass a couple of usability issues, we still don't have
Java 9 full support since we don't test code there. Farther from the master
state, more problem users will have.


вт, 5 мар. 2019 г. в 10:37, Denis Magda :

> It can take more than a month to release from the master. Decent Java 11
> support is crucial - the more we delay all the existing usability
> improvements, the more users we are losing. Check my original email -
> everyone stumbles upon those gaps.
>
> -
> Denis
>
>
> On Mon, Mar 4, 2019 at 10:51 PM Dmitriy Pavlov  wrote:
>
> > Previously we've discussed that 2.8 will be a separate release with
> > services redesign.
> >
> > I feel it makes more sense to take master because is contain a number of
> > features, e.g. services, new hibernate version support, more
> stabilization
> > done.
> >
> > So I suggest taking the master as our base branch for 2.8.
> >
> > вт, 5 мар. 2019 г. в 07:25, Denis Magda :
> >
> > > Dmitriy and Dev,
> > >
> > > Let's release Java 9 - 11 improvements that are already merged? In my
> > > understanding, they address or soothe usability issues reported in the
> > > original email.
> > >
> > > I would take Ignite 2.7, merge the changes there and roll out 2.8 as
> soon
> > > as we can.
> > >
> > > -
> > > Denis
> > >
> > >
> > > On Tue, Feb 5, 2019 at 10:23 AM Denis Magda  wrote:
> > >
> > > > Dmitry,
> > > >
> > > > Here is the ticket:
> https://issues.apache.org/jira/browse/IGNITE-11216
> > > >
> > > > Artem Budnikov reproduced the issue on Linux.
> > > >
> > > > -
> > > > Denis
> > > >
> > > >
> > > > On Mon, Feb 4, 2019 at 8:07 AM Dmitriy Pavlov 
> > > wrote:
> > > >
> > > >> Igniters,
> > > >>
> > > >> I've created https://issues.apache.org/jira/browse/IGNITE-11189 as
> > the
> > > >> main
> > > >> task to link particular steps to be done. 'Blocked by' link type is
> > for
> > > >> mandatory changes, 'relates to' - for desirable.
> > > >>
> > > >> BTW, examples seem to be running, the only reason they failed was
> > missed
> > > >> dependencies in standalone-pom. I've added notice into Github MD
> about
> > > it:
> > > >>
> > > >>
> > >
> >
> https://github.com/apache/ignite/tree/master/examples#contributing-to-examples
> > > >>
> > > >> Denis,
> > > >>
> > > >> I will not be able to hunt/recruit individuals to contribute, so
> > > 'driving'
> > > >> is better to treat as 'contributing'. About your failure at MAC OS,
> > > could
> > > >> you please create a separate issue for this? You can link it with
> the
> > > >> umbrella.
> > > >>
> > > >> Sincerely,
> > > >> Dmitriy Pavlov
> > > >>
> > > >> пт, 1 февр. 2019 г. в 22:40, Denis Magda :
> > > >>
> > > >> > Dmitry, thanks for driving this.
> > > >> >
> > > >> > 1. Startup of a node using both ignite.sh and ignite.bat works for
> > > >> Windows,
> > > >> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by
> > MAC
> > > OS
> > > >> > > Users.
> > > >> >
> > > >> >
> > > >> > That's easy to reproduce - you need a machine with Mac OS Mojave
> and
> > > >> latest
> > > >> > Oracle JDK - "java version "11.0.2" 2019-01-15 LTS".
> > > >> >
> > > >> > By some reason, the script fails to set JVM_OPT parameters. If I
> do
> > > >> "export
> > > >> > JVM_OPT={parameters from the doc}" then everything starts working.
> > > >> >
> > > >> > -
> > > >> > Denis
> > > >> >
> > > >> >
> > > >> > On Fri, Feb 1, 2019 at 5:53 AM Dmitriy Pavlov  >
> > > >> wrote:
> > > >> >
> > > >> > > Hi Igniters,
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > > 0. Results of TC Nightly Run All on Java 11 can be found here
> > > >> > >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://ci.ignite.apache.org/viewLog.html?buildId=2963881=IgniteTests24Java8_RunAll
> > > >> > > <
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll_IgniteTests24Java8=ignite-11155=buildTypeStatusDiv
> > > >> > > >
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > > 19 suites & 580 tests failed. So we need to do one-by-one
> research
> > > for
> > > >> > > occurred problems.
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > > 1. Startup of a node using both ignite.sh and ignite.bat works
> for
> > > >> > Windows,
> > > >> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by
> > MAC
> > > OS
> > > >> > > Users.
> > > >> > >
> > > >> > > Control.sh https://issues.apache.org/jira/browse/IGNITE-11153
> > needs
> > > >> to
> > > >> > be
> > > >> > > fixed. I hope Peter I. will pick up 

Re: Addressing usability issues with JDK 9-11

[Denis Magda]

It can take more than a month to release from the master. Decent Java 11
support is crucial - the more we delay all the existing usability
improvements, the more users we are losing. Check my original email -
everyone stumbles upon those gaps.

-
Denis


On Mon, Mar 4, 2019 at 10:51 PM Dmitriy Pavlov  wrote:

> Previously we've discussed that 2.8 will be a separate release with
> services redesign.
>
> I feel it makes more sense to take master because is contain a number of
> features, e.g. services, new hibernate version support, more stabilization
> done.
>
> So I suggest taking the master as our base branch for 2.8.
>
> вт, 5 мар. 2019 г. в 07:25, Denis Magda :
>
> > Dmitriy and Dev,
> >
> > Let's release Java 9 - 11 improvements that are already merged? In my
> > understanding, they address or soothe usability issues reported in the
> > original email.
> >
> > I would take Ignite 2.7, merge the changes there and roll out 2.8 as soon
> > as we can.
> >
> > -
> > Denis
> >
> >
> > On Tue, Feb 5, 2019 at 10:23 AM Denis Magda  wrote:
> >
> > > Dmitry,
> > >
> > > Here is the ticket: https://issues.apache.org/jira/browse/IGNITE-11216
> > >
> > > Artem Budnikov reproduced the issue on Linux.
> > >
> > > -
> > > Denis
> > >
> > >
> > > On Mon, Feb 4, 2019 at 8:07 AM Dmitriy Pavlov 
> > wrote:
> > >
> > >> Igniters,
> > >>
> > >> I've created https://issues.apache.org/jira/browse/IGNITE-11189 as
> the
> > >> main
> > >> task to link particular steps to be done. 'Blocked by' link type is
> for
> > >> mandatory changes, 'relates to' - for desirable.
> > >>
> > >> BTW, examples seem to be running, the only reason they failed was
> missed
> > >> dependencies in standalone-pom. I've added notice into Github MD about
> > it:
> > >>
> > >>
> >
> https://github.com/apache/ignite/tree/master/examples#contributing-to-examples
> > >>
> > >> Denis,
> > >>
> > >> I will not be able to hunt/recruit individuals to contribute, so
> > 'driving'
> > >> is better to treat as 'contributing'. About your failure at MAC OS,
> > could
> > >> you please create a separate issue for this? You can link it with the
> > >> umbrella.
> > >>
> > >> Sincerely,
> > >> Dmitriy Pavlov
> > >>
> > >> пт, 1 февр. 2019 г. в 22:40, Denis Magda :
> > >>
> > >> > Dmitry, thanks for driving this.
> > >> >
> > >> > 1. Startup of a node using both ignite.sh and ignite.bat works for
> > >> Windows,
> > >> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by
> MAC
> > OS
> > >> > > Users.
> > >> >
> > >> >
> > >> > That's easy to reproduce - you need a machine with Mac OS Mojave and
> > >> latest
> > >> > Oracle JDK - "java version "11.0.2" 2019-01-15 LTS".
> > >> >
> > >> > By some reason, the script fails to set JVM_OPT parameters. If I do
> > >> "export
> > >> > JVM_OPT={parameters from the doc}" then everything starts working.
> > >> >
> > >> > -
> > >> > Denis
> > >> >
> > >> >
> > >> > On Fri, Feb 1, 2019 at 5:53 AM Dmitriy Pavlov 
> > >> wrote:
> > >> >
> > >> > > Hi Igniters,
> > >> > >
> > >> > >
> > >> > >
> > >> > > 0. Results of TC Nightly Run All on Java 11 can be found here
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> https://ci.ignite.apache.org/viewLog.html?buildId=2963881=IgniteTests24Java8_RunAll
> > >> > > <
> > >> > >
> > >> >
> > >>
> >
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll_IgniteTests24Java8=ignite-11155=buildTypeStatusDiv
> > >> > > >
> > >> > >
> > >> > >
> > >> > >
> > >> > > 19 suites & 580 tests failed. So we need to do one-by-one research
> > for
> > >> > > occurred problems.
> > >> > >
> > >> > >
> > >> > >
> > >> > > 1. Startup of a node using both ignite.sh and ignite.bat works for
> > >> > Windows,
> > >> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by
> MAC
> > OS
> > >> > > Users.
> > >> > >
> > >> > > Control.sh https://issues.apache.org/jira/browse/IGNITE-11153
> needs
> > >> to
> > >> > be
> > >> > > fixed. I hope Peter I. will pick up it, fix is quite simple.
> > >> > >
> > >> > > Details about illegal access and its warning can be found here:
> > >> > > http://openjdk.java.net/jeps/261#Relaxed-strong-encapsulation
> > >> > >
> > >> > >
> > >> > >
> > >> > > 2. Ignition.start warnings:
> > >> > > https://issues.apache.org/jira/browse/IGNITE-11155
> > >> > >
> > >> > >
> > >> > >
> > >> > > 3. I’ve done some fixes in the
> > >> > > https://issues.apache.org/jira/browse/IGNITE-11140 for examples,
> > and
> > >> I’m
> > >> > > going to validate results once our Release is passing. Today’s
> build
> > >> > failed
> > >> > >
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> https://ci.ignite.apache.org/viewLog.html?buildId=2965908=Releases_NightlyRelease_RunApacheIgniteNightlyRelease=artifacts_Releases_NightlyRelease=%3Cdefault%3E
> > >> > >
> > >> > >
> > >> > >
> > >> > > Sincerely,
> > >> > >
> > >> > > Dmitriy Pavlov
> > >> > >
> > >> > >
> > >> > > пт, 1 февр. 2019 г. в 00:18, Dmitriy Pavlov :
> > >> > >
> > >> > > > Hi Denis,
> > >> > > >
> > >> 

Storing short/empty strings in Ignite

[Valentin Kulichenko]

Hey folks,

While working with Ignite users, I keep seeing data models where a single
object (row) might contain many fields (100, 200, more...), and most of
them are strings.

Correct me if I'm wrong, but per my understanding, for every such field we
store an integer value to represent its length. This is significant
overhead - with 200 fields we spend 800 bytes only for this.

Now here is the catch: vast majority of those strings are actually empty or
very short (several chars), therefore we don't really need 4 bytes to their
length.

My suggestions is to introduce another data type, e.g. STRING_SHORT, use it
for all strings that are 255 chars or less, and therefore use a single byte
to encode length. We can go even further, and also introduce STRING_EMPTY,
which obviously doesn't need any length information at all.

What do you guys think?

-Val

Re: Addressing usability issues with JDK 9-11

[Dmitriy Pavlov]

Previously we've discussed that 2.8 will be a separate release with
services redesign.

I feel it makes more sense to take master because is contain a number of
features, e.g. services, new hibernate version support, more stabilization
done.

So I suggest taking the master as our base branch for 2.8.

вт, 5 мар. 2019 г. в 07:25, Denis Magda :

> Dmitriy and Dev,
>
> Let's release Java 9 - 11 improvements that are already merged? In my
> understanding, they address or soothe usability issues reported in the
> original email.
>
> I would take Ignite 2.7, merge the changes there and roll out 2.8 as soon
> as we can.
>
> -
> Denis
>
>
> On Tue, Feb 5, 2019 at 10:23 AM Denis Magda  wrote:
>
> > Dmitry,
> >
> > Here is the ticket: https://issues.apache.org/jira/browse/IGNITE-11216
> >
> > Artem Budnikov reproduced the issue on Linux.
> >
> > -
> > Denis
> >
> >
> > On Mon, Feb 4, 2019 at 8:07 AM Dmitriy Pavlov 
> wrote:
> >
> >> Igniters,
> >>
> >> I've created https://issues.apache.org/jira/browse/IGNITE-11189 as the
> >> main
> >> task to link particular steps to be done. 'Blocked by' link type is for
> >> mandatory changes, 'relates to' - for desirable.
> >>
> >> BTW, examples seem to be running, the only reason they failed was missed
> >> dependencies in standalone-pom. I've added notice into Github MD about
> it:
> >>
> >>
> https://github.com/apache/ignite/tree/master/examples#contributing-to-examples
> >>
> >> Denis,
> >>
> >> I will not be able to hunt/recruit individuals to contribute, so
> 'driving'
> >> is better to treat as 'contributing'. About your failure at MAC OS,
> could
> >> you please create a separate issue for this? You can link it with the
> >> umbrella.
> >>
> >> Sincerely,
> >> Dmitriy Pavlov
> >>
> >> пт, 1 февр. 2019 г. в 22:40, Denis Magda :
> >>
> >> > Dmitry, thanks for driving this.
> >> >
> >> > 1. Startup of a node using both ignite.sh and ignite.bat works for
> >> Windows,
> >> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by MAC
> OS
> >> > > Users.
> >> >
> >> >
> >> > That's easy to reproduce - you need a machine with Mac OS Mojave and
> >> latest
> >> > Oracle JDK - "java version "11.0.2" 2019-01-15 LTS".
> >> >
> >> > By some reason, the script fails to set JVM_OPT parameters. If I do
> >> "export
> >> > JVM_OPT={parameters from the doc}" then everything starts working.
> >> >
> >> > -
> >> > Denis
> >> >
> >> >
> >> > On Fri, Feb 1, 2019 at 5:53 AM Dmitriy Pavlov 
> >> wrote:
> >> >
> >> > > Hi Igniters,
> >> > >
> >> > >
> >> > >
> >> > > 0. Results of TC Nightly Run All on Java 11 can be found here
> >> > >
> >> > >
> >> >
> >>
> https://ci.ignite.apache.org/viewLog.html?buildId=2963881=IgniteTests24Java8_RunAll
> >> > > <
> >> > >
> >> >
> >>
> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll_IgniteTests24Java8=ignite-11155=buildTypeStatusDiv
> >> > > >
> >> > >
> >> > >
> >> > >
> >> > > 19 suites & 580 tests failed. So we need to do one-by-one research
> for
> >> > > occurred problems.
> >> > >
> >> > >
> >> > >
> >> > > 1. Startup of a node using both ignite.sh and ignite.bat works for
> >> > Windows,
> >> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by MAC
> OS
> >> > > Users.
> >> > >
> >> > > Control.sh https://issues.apache.org/jira/browse/IGNITE-11153 needs
> >> to
> >> > be
> >> > > fixed. I hope Peter I. will pick up it, fix is quite simple.
> >> > >
> >> > > Details about illegal access and its warning can be found here:
> >> > > http://openjdk.java.net/jeps/261#Relaxed-strong-encapsulation
> >> > >
> >> > >
> >> > >
> >> > > 2. Ignition.start warnings:
> >> > > https://issues.apache.org/jira/browse/IGNITE-11155
> >> > >
> >> > >
> >> > >
> >> > > 3. I’ve done some fixes in the
> >> > > https://issues.apache.org/jira/browse/IGNITE-11140 for examples,
> and
> >> I’m
> >> > > going to validate results once our Release is passing. Today’s build
> >> > failed
> >> > >
> >> > >
> >> > >
> >> >
> >>
> https://ci.ignite.apache.org/viewLog.html?buildId=2965908=Releases_NightlyRelease_RunApacheIgniteNightlyRelease=artifacts_Releases_NightlyRelease=%3Cdefault%3E
> >> > >
> >> > >
> >> > >
> >> > > Sincerely,
> >> > >
> >> > > Dmitriy Pavlov
> >> > >
> >> > >
> >> > > пт, 1 февр. 2019 г. в 00:18, Dmitriy Pavlov :
> >> > >
> >> > > > Hi Denis,
> >> > > >
> >> > > > yes, I definitely will close some of these points, I hope Peter I
> >> will
> >> > > > help with control.sh fix.
> >> > > >
> >> > > > Point 0. in my plan is to check TeamCity results for Java 11 Run.
> >> > > >
> >> > > > Unfortunately, I don't have MAC OS so I would appreciate some of
> MAC
> >> > > users
> >> > > > may double check launch issue. Please note it may be just a
> warning
> >> > about
> >> > > > illegal-access, even if it is set =permit. After this warning (it
> is
> >> > > > unavoidable for 1st time), everything should be ok.
> >> > > >
> >> > > > Sincerely,
> >> > > > Dmitriy Pavlov
> >> > > >
> >> > > > чт, 31 янв. 2019 

Re: Addressing usability issues with JDK 9-11

[Denis Magda]

Dmitriy and Dev,

Let's release Java 9 - 11 improvements that are already merged? In my
understanding, they address or soothe usability issues reported in the
original email.

I would take Ignite 2.7, merge the changes there and roll out 2.8 as soon
as we can.

-
Denis


On Tue, Feb 5, 2019 at 10:23 AM Denis Magda  wrote:

> Dmitry,
>
> Here is the ticket: https://issues.apache.org/jira/browse/IGNITE-11216
>
> Artem Budnikov reproduced the issue on Linux.
>
> -
> Denis
>
>
> On Mon, Feb 4, 2019 at 8:07 AM Dmitriy Pavlov  wrote:
>
>> Igniters,
>>
>> I've created https://issues.apache.org/jira/browse/IGNITE-11189 as the
>> main
>> task to link particular steps to be done. 'Blocked by' link type is for
>> mandatory changes, 'relates to' - for desirable.
>>
>> BTW, examples seem to be running, the only reason they failed was missed
>> dependencies in standalone-pom. I've added notice into Github MD about it:
>>
>> https://github.com/apache/ignite/tree/master/examples#contributing-to-examples
>>
>> Denis,
>>
>> I will not be able to hunt/recruit individuals to contribute, so 'driving'
>> is better to treat as 'contributing'. About your failure at MAC OS, could
>> you please create a separate issue for this? You can link it with the
>> umbrella.
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> пт, 1 февр. 2019 г. в 22:40, Denis Magda :
>>
>> > Dmitry, thanks for driving this.
>> >
>> > 1. Startup of a node using both ignite.sh and ignite.bat works for
>> Windows,
>> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by MAC OS
>> > > Users.
>> >
>> >
>> > That's easy to reproduce - you need a machine with Mac OS Mojave and
>> latest
>> > Oracle JDK - "java version "11.0.2" 2019-01-15 LTS".
>> >
>> > By some reason, the script fails to set JVM_OPT parameters. If I do
>> "export
>> > JVM_OPT={parameters from the doc}" then everything starts working.
>> >
>> > -
>> > Denis
>> >
>> >
>> > On Fri, Feb 1, 2019 at 5:53 AM Dmitriy Pavlov 
>> wrote:
>> >
>> > > Hi Igniters,
>> > >
>> > >
>> > >
>> > > 0. Results of TC Nightly Run All on Java 11 can be found here
>> > >
>> > >
>> >
>> https://ci.ignite.apache.org/viewLog.html?buildId=2963881=IgniteTests24Java8_RunAll
>> > > <
>> > >
>> >
>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_RunAll_IgniteTests24Java8=ignite-11155=buildTypeStatusDiv
>> > > >
>> > >
>> > >
>> > >
>> > > 19 suites & 580 tests failed. So we need to do one-by-one research for
>> > > occurred problems.
>> > >
>> > >
>> > >
>> > > 1. Startup of a node using both ignite.sh and ignite.bat works for
>> > Windows,
>> > > OpenJDK 10.0.2. Failure from Denis still needs to be checked by MAC OS
>> > > Users.
>> > >
>> > > Control.sh https://issues.apache.org/jira/browse/IGNITE-11153 needs
>> to
>> > be
>> > > fixed. I hope Peter I. will pick up it, fix is quite simple.
>> > >
>> > > Details about illegal access and its warning can be found here:
>> > > http://openjdk.java.net/jeps/261#Relaxed-strong-encapsulation
>> > >
>> > >
>> > >
>> > > 2. Ignition.start warnings:
>> > > https://issues.apache.org/jira/browse/IGNITE-11155
>> > >
>> > >
>> > >
>> > > 3. I’ve done some fixes in the
>> > > https://issues.apache.org/jira/browse/IGNITE-11140 for examples, and
>> I’m
>> > > going to validate results once our Release is passing. Today’s build
>> > failed
>> > >
>> > >
>> > >
>> >
>> https://ci.ignite.apache.org/viewLog.html?buildId=2965908=Releases_NightlyRelease_RunApacheIgniteNightlyRelease=artifacts_Releases_NightlyRelease=%3Cdefault%3E
>> > >
>> > >
>> > >
>> > > Sincerely,
>> > >
>> > > Dmitriy Pavlov
>> > >
>> > >
>> > > пт, 1 февр. 2019 г. в 00:18, Dmitriy Pavlov :
>> > >
>> > > > Hi Denis,
>> > > >
>> > > > yes, I definitely will close some of these points, I hope Peter I
>> will
>> > > > help with control.sh fix.
>> > > >
>> > > > Point 0. in my plan is to check TeamCity results for Java 11 Run.
>> > > >
>> > > > Unfortunately, I don't have MAC OS so I would appreciate some of MAC
>> > > users
>> > > > may double check launch issue. Please note it may be just a warning
>> > about
>> > > > illegal-access, even if it is set =permit. After this warning (it is
>> > > > unavoidable for 1st time), everything should be ok.
>> > > >
>> > > > Sincerely,
>> > > > Dmitriy Pavlov
>> > > >
>> > > > чт, 31 янв. 2019 г. в 22:38, Denis Magda :
>> > > >
>> > > >> Alright,
>> > > >>
>> > > >> That's what needs to be done:
>> > > >>
>> > > >>1. Fix sh/bat scripts work - fails on my Mac OS Mojave and
>> latest
>> > > >> Oracle
>> > > >>JDK - java version "11.0.2" 2019-01-15 LTS
>> > > >>2. Change command line startup to output warning to stdout and
>> logs
>> > > to
>> > > >>add necessary params to JVM
>> > > >>3. Make sure that examples can be compiled and run with Java 11
>> > > >>4. Make Ignite buildable with Java 11
>> > > >>
>> > > >> Points 1-3 are quick. Dmitriy are you the one who is looking into
>> it?
>> > > When
>> > > >> can we release Ignite 2.8. We 

Re: Flaky tests

[Stanislav Kozlovski]

Thank you for clarifying everybody, this is valuable expertise.

On 2019/02/27 09:01:00, Ilya Kasnacheev  wrote: 
> Hello!> 
> 
> We also have this wonderful tool: https://mtcga.gridgain.com/> 
> 
> It keeps track of tests which are currently flaky or under investigation,> 
> and given your change it will report non-flaky tests that failed, skipping> 
> all problematic tests.> 
> 
> It talks to TeamCity so it can run tests for you, check their results and> 
> comment JIRA with "Bot Visa", see:> 
> https://issues.apache.org/jira/browse/IGNITE-11299 comment from "Ignite TC> 
> Bot"> 
> 
> Since we don't have too many flaky tests thanks to Make TeamCity Green> 
> Again movement, it works reasonably well.> 
> 
> A year ago we did not have any of this but now we do, and we were able to> 
> shave 80% of test-checking busy work. This is mostly thanks to Dmitry> 
> Pavlov.> 
> 
> Regards,> 
> -- > 
> Ilya Kasnacheev> 
> 
> 
> ср, 27 февр. 2019 г. в 01:39, Stanislav Kozlovski <> 
> stanislav_kozlov...@outlook.com>:> 
> 
> > Hey there Ignite community,> 
> >> 
> > I contribute to a fellow open-source project - Apache Kafka - and there we> 
> > have been fighting flaky tests a lot. We run Java 8 and Java 11 builds on> 
> > every Pull Request and due to test flakiness, almost all of them turn out> 
> > red with 1 or 2 tests (completely unrelated to the change in the PR)> 
> > failing. This has resulted in committers either ignoring them and merging> 
> > the changes or in the worst case rerunning the hour-long build until it> 
> > becomes green.> 
> > This test flakiness has also slowed down our releases significantly.> 
> >> 
> > In general, I was just curious to understand if this is a problem that> 
> > your project faces as well. Does your project have a lot of intermittently> 
> > failing tests, do you have any active process of addressing such tests> 
> > (during the initial review, after realizing it is flaky, etc). Any 
> > pointers> 
> > will be greatly appreciated!> 
> >> 
> > Thanks,> 
> > Stanislav> 
> >> 
> >> 
> > > 
> >> 
> 

Re: Apache Ignite: ignite-core dependecies

[Dmitriy Pavlov]

Denis, Ivan, thank you for replies.

Ok, if sources are there, can we rename this artifact to
org.apache.ignite.smem?

Sincerely,
Dmitriy Pavlov

пн, 4 мар. 2019 г. в 22:59, Павлухин Иван :

> Hi,
>
> My bit here is that I build sources from ipc/shmem and launched Ignite
> with freshly built library on Linux.
>
> пн, 4 мар. 2019 г. в 21:51, Denis Magda :
> >
> > Dmitry,
> >
> > Here are the sources, it's used to enable shared memory for communication
> > SPI: https://github.com/apache/ignite/tree/master/ipc/shmem
> >
> > Don't remember all of the details why the binary is hosted in GridGain
> > repository but see nothing wrong here as long as the lib is licensed
> under
> > Apache 2.0. In general, talk to your GridGain-mates to get more details
> and
> > feel free to share a summary with a broader community.
> >
> > -
> > Denis
> >
> >
> > On Mon, Mar 4, 2019 at 6:54 AM Dmitriy Pavlov 
> wrote:
> >
> > > Hi Igniters,
> > >
> > > Because nobody is reacted here, I'm going to remove this dependency
> and all
> > > dependent classes (if any) by lazy consensus after 72 h.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пт, 1 мар. 2019 г. в 22:46, Dmitriy Pavlov :
> > >
> > > > Full dependency tree you can find here
> > > >
> > > >
> > >
> https://github.com/apache/ignite/blob/ignite-11461-java11/modules/dev-utils/ignite-modules-test/deps.txt#L18
> > > >
> > > >
> > > >
> > > > пт, 1 мар. 2019 г. в 22:23, Dmitriy Pavlov :
> > > >
> > > >> Hi,
> > > >>
> > > >> Why ignite-core depends to org.gridgain:ignite-shmem:1.0.0 ? Is it
> ok
> > > for
> > > >> Apache projects to be dependent on proprietary software?
> > > >>
> > > >> As I can see license is Apache 2.0, but where can I find sources?
> > > >>
> > > >> Sincerely,
> > > >> Dmitriy Pavlov
> > > >>
> > > >
> > >
>
>
>
> --
> Best regards,
> Ivan Pavlukhin
>

Re: Apache Ignite: ignite-core dependecies

[Павлухин Иван]

Hi,

My bit here is that I build sources from ipc/shmem and launched Ignite
with freshly built library on Linux.

пн, 4 мар. 2019 г. в 21:51, Denis Magda :
>
> Dmitry,
>
> Here are the sources, it's used to enable shared memory for communication
> SPI: https://github.com/apache/ignite/tree/master/ipc/shmem
>
> Don't remember all of the details why the binary is hosted in GridGain
> repository but see nothing wrong here as long as the lib is licensed under
> Apache 2.0. In general, talk to your GridGain-mates to get more details and
> feel free to share a summary with a broader community.
>
> -
> Denis
>
>
> On Mon, Mar 4, 2019 at 6:54 AM Dmitriy Pavlov  wrote:
>
> > Hi Igniters,
> >
> > Because nobody is reacted here, I'm going to remove this dependency and all
> > dependent classes (if any) by lazy consensus after 72 h.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пт, 1 мар. 2019 г. в 22:46, Dmitriy Pavlov :
> >
> > > Full dependency tree you can find here
> > >
> > >
> > https://github.com/apache/ignite/blob/ignite-11461-java11/modules/dev-utils/ignite-modules-test/deps.txt#L18
> > >
> > >
> > >
> > > пт, 1 мар. 2019 г. в 22:23, Dmitriy Pavlov :
> > >
> > >> Hi,
> > >>
> > >> Why ignite-core depends to org.gridgain:ignite-shmem:1.0.0 ? Is it ok
> > for
> > >> Apache projects to be dependent on proprietary software?
> > >>
> > >> As I can see license is Apache 2.0, but where can I find sources?
> > >>
> > >> Sincerely,
> > >> Dmitriy Pavlov
> > >>
> > >
> >



-- 
Best regards,
Ivan Pavlukhin

Re: Apache Ignite: ignite-core dependecies

[Denis Magda]

Dmitry,

Here are the sources, it's used to enable shared memory for communication
SPI: https://github.com/apache/ignite/tree/master/ipc/shmem

Don't remember all of the details why the binary is hosted in GridGain
repository but see nothing wrong here as long as the lib is licensed under
Apache 2.0. In general, talk to your GridGain-mates to get more details and
feel free to share a summary with a broader community.

-
Denis


On Mon, Mar 4, 2019 at 6:54 AM Dmitriy Pavlov  wrote:

> Hi Igniters,
>
> Because nobody is reacted here, I'm going to remove this dependency and all
> dependent classes (if any) by lazy consensus after 72 h.
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 1 мар. 2019 г. в 22:46, Dmitriy Pavlov :
>
> > Full dependency tree you can find here
> >
> >
> https://github.com/apache/ignite/blob/ignite-11461-java11/modules/dev-utils/ignite-modules-test/deps.txt#L18
> >
> >
> >
> > пт, 1 мар. 2019 г. в 22:23, Dmitriy Pavlov :
> >
> >> Hi,
> >>
> >> Why ignite-core depends to org.gridgain:ignite-shmem:1.0.0 ? Is it ok
> for
> >> Apache projects to be dependent on proprietary software?
> >>
> >> As I can see license is Apache 2.0, but where can I find sources?
> >>
> >> Sincerely,
> >> Dmitriy Pavlov
> >>
> >
>

[jira] [Created] (IGNITE-11471) JDBC: Thin driver should start with a random server to connect

[Stanislav Lukyanov (JIRA)]

Stanislav Lukyanov created IGNITE-11471:
---

 Summary: JDBC: Thin driver should start with a random server to 
connect
 Key: IGNITE-11471
 URL: https://issues.apache.org/jira/browse/IGNITE-11471
 Project: Ignite
  Issue Type: Improvement
  Components: jdbc
Reporter: Stanislav Lukyanov


Thin JDBC driver uses a list of server addresses to connect to. Connections 
created in a single JVM will use round-robin to choose the server to connect, 
yielding a uniform distribution. However, the round-robin always starts from 
the first server in the list. It means that multiple JVMs with the same JDBC 
connection URL and one connection each will all connect to the same server.

Need to choose the first server randomly to have a better distribution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-11470) Views don't show in Dbeaver

[Yury Gerzhedovich (JIRA)]

Yury Gerzhedovich created IGNITE-11470:
--

 Summary: Views don't show in Dbeaver
 Key: IGNITE-11470
 URL: https://issues.apache.org/jira/browse/IGNITE-11470
 Project: Ignite
  Issue Type: Task
  Components: sql
Reporter: Yury Gerzhedovich
Assignee: Yury Gerzhedovich
 Fix For: 2.8


At Database navigator tab we can see no a views. As of now we should see at 
least SQL system views.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-11469) Support Automatic modules for ignite-rest-http: resolve package inference between Jetty & Tomcat

[Dmitriy Pavlov (JIRA)]

Dmitriy Pavlov created IGNITE-11469:
---

 Summary: Support Automatic modules for ignite-rest-http: resolve 
package inference between Jetty & Tomcat
 Key: IGNITE-11469
 URL: https://issues.apache.org/jira/browse/IGNITE-11469
 Project: Ignite
  Issue Type: Sub-task
Reporter: Dmitriy Pavlov


{noformat}
error: the unnamed module reads package javax.servlet.http from both 
javax.servlet.api and tomcat.servlet.api
error: the unnamed module reads package javax.servlet.descriptor from both 
javax.servlet.api and tomcat.servlet.api
error: the unnamed module reads package javax.servlet.annotation from both 
javax.servlet.api and tomcat.servlet.api
error: the unnamed module reads package javax.servlet from both 
javax.servlet.api and tomcat.servlet.api
{noformat}

Exclude of tomcat dependency solves the problem
{code}
 compile(group: 'org.apache.ignite', name: 'ignite-rest-http', version: ignVer) 
{
exclude group: 'org.apache.tomcat'
// to remove "javax.servlet.http, javax.servlet.descriptor, 
javax.servlet.annotation, javax.servlet" package conflicts.
}
{code}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Please re-commit 3 last changes in the master

[Vladimir Ozerov]

Looks like everything is good now - all three commits were returned.

On Mon, Mar 4, 2019 at 2:04 PM Dmitriy Pavlov  wrote:

> Thanks, Ivan, these commits are in sync in GitHub & GitBox. Only one commit
> remained, Vladimir O., please chime in
>
> пн, 4 мар. 2019 г. в 14:03, Ivan Rakov :
>
> > Thanks for keeping track of it, I've re-applied the following commits:
> >
> > IGNITE-11199 Add extra logging for client-server connections in TCP
> > discovery - Fixes #6048. Andrey Kalinin* 04.03.2019 2:11
> > IGNITE-11322 [USABILITY] Extend Node FAILED message by add consistentId
> > if it exist - Fixes #6180. Andrey Kalinin* 04.03.2019 2:03
> >
> > Best Regards,
> > Ivan Rakov
> >
> > On 04.03.2019 13:56, Dmitriy Pavlov wrote:
> > > Thanks to Alexey Plehanov for noticing and Infra Team for fixing the
> > issue:
> > > https://issues.apache.org/jira/browse/INFRA-17950
> > >
> > > пн, 4 мар. 2019 г. в 13:53, Dmitriy Pavlov :
> > >
> > >> Hi Developers,
> > >>
> > >> Because of the sync issue, the following 3 commits were lost.
> > >>
> > >> Please re-apply it to the master.
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=b26bbb29d5fdd9d4de5187042778ebe3b8c6c42e
> > >>
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=6c562a997c0beb3a3cd9dd2976e016759a808f0c
> > >>
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=45c4dc98e0eac33cccd2e24acb3e9882f098cad1
> > >>
> > >>
> > >> Sorry for the inconvenience.
> > >>
> > >> Sincerely,
> > >> Dmitriy Pavlov
> > >>
> >
>

[MTCGA]: new failures in builds [2992125] needs to be handled

[dpavlov . tasks]

Hi Igniters,

 I've detected some new issue on TeamCity to be handled. You are more than 
welcomed to help.

 If your changes can lead to this failure(s): We're grateful that you were a 
volunteer to make the contribution to this project, but things change and you 
may no longer be able to finalize your contribution.
 Could you respond to this email and indicate if you wish to continue and fix 
test failures or step down and some committer may revert you commit. 

 *Recently contributed test failed in master 
continuous.GridEventConsumeSelfTest 
https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=8424773320931186667=%3Cdefault%3E=testDetails
 No changes in the build

 - Here's a reminder of what contributors were agreed to do 
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute 
 - Should you have any questions please contact dev@ignite.apache.org 

Best Regards,
Apache Ignite TeamCity Bot 
https://github.com/apache/ignite-teamcity-bot
Notification generated at 17:56:31 04-03-2019 

Re: Apache Ignite: ignite-core dependecies

[Dmitriy Pavlov]

Hi Igniters,

Because nobody is reacted here, I'm going to remove this dependency and all
dependent classes (if any) by lazy consensus after 72 h.

Sincerely,
Dmitriy Pavlov

пт, 1 мар. 2019 г. в 22:46, Dmitriy Pavlov :

> Full dependency tree you can find here
>
> https://github.com/apache/ignite/blob/ignite-11461-java11/modules/dev-utils/ignite-modules-test/deps.txt#L18
>
>
>
> пт, 1 мар. 2019 г. в 22:23, Dmitriy Pavlov :
>
>> Hi,
>>
>> Why ignite-core depends to org.gridgain:ignite-shmem:1.0.0 ? Is it ok for
>> Apache projects to be dependent on proprietary software?
>>
>> As I can see license is Apache 2.0, but where can I find sources?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>

[jira] [Created] (IGNITE-11468) System caches should not survive client reconnect

[Alexey Goncharuk (JIRA)]

Alexey Goncharuk created IGNITE-11468:
-

 Summary: System caches should not survive client reconnect
 Key: IGNITE-11468
 URL: https://issues.apache.org/jira/browse/IGNITE-11468
 Project: Ignite
  Issue Type: Improvement
Reporter: Alexey Goncharuk


After IGNITE-10898 it became clear that system caches surviving client 
reconnect lead are error-prone: there are too many specific code paths leading 
to logic duplication and exclusions. At the same time, the benefit of system 
caches survival is not tangible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Plugins in tests

[Maxim Muzafarov]

Igniters,

It seems that our pre-configured list of plugins a bit grow up.
The full list of them for now:

 TestReconnectPlugin 1.0
 StanByClusterTestProvider 1.0
 PageMemory tracker plugin 1.0
 TestDistibutedConfigurationPlugin 1.0
 NodeValidationPluginProvider 1.0

I think we should move them to separate modules, as mentioned Yakov in
the first message.
I've left a new comment in JIRA [1], so hopefully, we do not forget to do so.

[1] https://issues.apache.org/jira/browse/IGNITE-7679

On Fri, 7 Sep 2018 at 13:54, Maxim Muzafarov  wrote:
>
> Alex,
>
> Thank you.
>
> I've added an additional comment in IGNITE-7679 about PageMemory tracker 
> plugin, so we can move
> all plugins within a single ticket and do not miss anything.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-7679
>
> On Fri, 7 Sep 2018 at 09:39 Alex Plehanov  wrote:
>>
>> Hello Maxim,
>>
>> I miss this conversation and ticket when implementing PageMemory tracker
>> plugin. By default, it's disabled (every method do nothing), but plugin
>> instance created anyway.
>>
>> If we want to get clear Ignite instances in the testing framework in the
>> core module, PageMemory tracker plugin also should be moved to another
>> module.
>>
>> чт, 6 сент. 2018 г. в 19:50, Maxim Muzafarov :
>>
>> > Folks,
>> >
>> > I've found another plugin - `PageMemory tracker plugin 1.0`. It contains
>> > `IGNITE_ENABLE_PAGE_MEMORY_TRACKER`
>> > which is `false` by default, so it doesn't participate in current tests.
>> >
>> > But I think we should also move it to `extdata` module too. Am I right?
>> > Should we update JIRA [1] description regarding newly available plugin?
>> >
>> > [1] https://issues.apache.org/jira/browse/IGNITE-7679
>> >
>> >
>> > On Mon, 12 Feb 2018 at 19:57 Dmitriy Govorukhin <
>> > dmitriy.govoruk...@gmail.com> wrote:
>> >
>> > >  Yakov,
>> > >
>> > > Agree, I created the issue for this. I will try to do it in the near
>> > > future.
>> > >
>> > > IGNITE-7679 
>> > >
>> > >
>> > > On Tue, Jan 30, 2018 at 8:40 AM, Yakov Zhdanov 
>> > > wrote:
>> > >
>> > > > Guys,
>> > > >
>> > > > When running tests from core module I see that Ignite has 2 plugins
>> > > > configured by default (because they are available in classpath):
>> > > >
>> > > > -TestReconnectPlugin 1.0
>> > > > -StanByClusterTestProvider 1.0
>> > > >
>> > > > It seems they were introduced by Dmitry Karachentsev and Dmitry
>> > > Govorukhin.
>> > > > Guys, can you please move the plugins to extdata project similar to
>> > > > PlatformTestPlugin and configure them only when needed. This is not
>> > > correct
>> > > > that each test we run for Ignite runs with plugins configured. By
>> > default
>> > > > Ignite does not have any plugin.
>> > > >
>> > > > --Yakov
>> > > >
>> > >
>> > --
>> > --
>> > Maxim Muzafarov
>> >
>
> --
> --
> Maxim Muzafarov

[jira] [Created] (IGNITE-11467) Support Automatic modules for ignite-spring: Move of classes to a separate package or jar

[Dmitriy Pavlov (JIRA)]

Dmitriy Pavlov created IGNITE-11467:
---

 Summary: Support Automatic modules for ignite-spring: Move of 
classes to a separate package or jar
 Key: IGNITE-11467
 URL: https://issues.apache.org/jira/browse/IGNITE-11467
 Project: Ignite
  Issue Type: Sub-task
Reporter: Dmitriy Pavlov


Provided that [IGNITE-11464] is fixed and lucene is excluded from dependencies, 
we still need refactor following packages to avoid packages conflicts:
{noformat}
error: the unnamed module reads package org.apache.ignite from both 
ignite.spring and ignite.core
error: the unnamed module reads package org.apache.ignite.internal.util.spring 
from both ignite.spring and ignite.core
error: the unnamed module reads package 
org.apache.ignite.internal.processors.resource from both ignite.spring and 
ignite.core
{noformat}

One from class in conflicting packages is org.apache.ignite.IgniteSpringBean, 
which may be referenced outside of Ignite.

It mentioned at least here 
http://qaru.site/questions/14880736/how-to-connect-apache-ignite-node-by-static-ip-address
 with full class name:




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Prewarming of page memory after node restart

[Дмитрий Сорокин]

Hi Igniters!



I want to propose the new feature for Ignite - prewarming of page memory.



The essence of prewarming feature is that after restarting the node is to
load into memory those pages that were loaded before last shutdown. I have
implemented the PoC of prewarming of page memory, which makes dump of IDs
of loaded pages before node shutdown and, optionally, at runtime. When node
restarts, special worker loads the pages with saved IDs in memory, and
restore phase depending on configuration may or may not to wait the end of
prewarming process. Persentage of hottest loaded pages may be configured,
if dumping of all of ones is not need. Prewarming process is multithreaded
(optionally) and has heuristical throttling algorithm.
PrewarmingConfiguration is the only change of public API, and was added as
property of DataRegionConfiguration, which non-null value enables the
prewarming feature.

Link to the Jira ticket: https://issues.apache.org/jira/browse/IGNITE-11457

Link to the PR: https://github.com/apache/ignite/pull/6223.



I would like to receive feedback on this prewarming feature concept.

[jira] [Created] (IGNITE-11466) MVCC: Remove irrelevant tests from mvcc suites.

[Andrew Mashenkov (JIRA)]

Andrew Mashenkov created IGNITE-11466:
-

 Summary: MVCC: Remove irrelevant tests from mvcc suites.
 Key: IGNITE-11466
 URL: https://issues.apache.org/jira/browse/IGNITE-11466
 Project: Ignite
  Issue Type: Test
  Components: mvcc
Reporter: Andrew Mashenkov
 Fix For: 2.8


For now we have 300+ muted tests related to Mvcc support for LOCAL caches.
As IGNITE-9530 has been closed with "wont fix" we have to
 # Cleanup code and remove test clones like 
IgniteCacheGroupsTest.testCacheIteratorMvccTxLocal
 # Add LOCAL cache test classes to ignore list in Mvcc suites.
 # Other tests should be disabled in Mvcc mode with Assumption and meaningful 
message.
 # All these tests should be unmuted on TC.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Code inspection

[Maxim Muzafarov]

Ivan,

I like that Jetbrains inspections are integrated with IDE and TC out
of the box, but currently, they are working not well enough on TC.
Actually, they are not checking our source code at all.

Let's try a bit another approach and try to be IDE-agnostic with code
style checking. I've checked popular java projects: hadoop, kafka,
spark, hive, netty. All of them are using maven-checkstyle-plugin in
their  section by default, so why don't we? It sounds
reasonable for me at least to try so.

Can you take a look at my changes below?


Igniters,

PR [2] has been prepared. All the details I've mentioned in my comment
in JIRA [4].
Can anyone take a look at my changes?

JIRA: [1]
PR: [2]
Upsource: [3]

Questions to discuss:
1) There is no analogue for inspections RedundantSuppression and
SizeReplaceableByIsEmpty (all code style checks [5]). Propose to merge
without them.
2) Checkstyle plugin has it's own maven profile and enabled by
default. It can be turned off for prototype branches.
3) I've removed the inspections configuration for the TC suite and
propose to disable it as not working.


[1] https://issues.apache.org/jira/browse/IGNITE-11277
[2] https://github.com/apache/ignite/pull/6119
[3] https://reviews.ignite.apache.org/ignite/review/IGNT-CR-1018
[4] 
https://issues.apache.org/jira/browse/IGNITE-11277?focusedCommentId=16771200=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16771200
[5] http://checkstyle.sourceforge.net/checks.html

On Thu, 14 Feb 2019 at 16:21, Павлухин Иван  wrote:
>
> Nikolay,
>
> > All community members are forced to follow code style. It's harder to 
> > achieve it with dedicated suite.
> Why it is easier to follow code style with use of maven checkstyle
> plugin? Is it integrated into IDEA out of box? As I got it additional
> IDEA plugin is needed as well. Who will enforce everybody to install
> it?
>
> Also, as I see a common good practice today is using TC Bot visa. Visa
> includes result from running inspections job.
>
> чт, 14 февр. 2019 г. в 16:08, Nikolay Izhikov :
> >
> > Ivan,
> >
> > > Could you please outline the benefits you see of failing compilation and
> > skipping tests execution if inspections detect a problem?
> >
> > All community members are forced to follow code style.
> > It's harder to achieve it with dedicated suite.
> >
> >
> > чт, 14 февр. 2019 г. в 15:21, Павлухин Иван :
> >
> > > Nikolay,
> > >
> > > > Should the community spend TC resources for  prototype?
> > > Why not? I think it is not bad idea to run all tests against some
> > > changes into core classes. If I have a clever idea which is easy to
> > > test drive I can do couple of prototype-test iterations. If tests
> > > shows me that everything is bad then the idea was not so clever and
> > > easy. But if I was lucky then I should discuss the idea with other
> > > Igniters. I think it is the cheapest way to check the idea because the
> > > check is fully automated. Requiring a human feedback is much more
> > > expensive in my opinion.
> > > > But, If our code style is not convinient for every day coding for many
> > > contributors, should you initiate discussion to change it?
> > > Generally I am fine with our codestyle requirements.
> > >
> > > Also, I would like to keep a focus on the subject. Could you please
> > > outline the benefits you see of failing compilation and skipping tests
> > > execution if inspections detect a problem?
> > >
> > > чт, 14 февр. 2019 г. в 14:14, Nikolay Izhikov :
> > > >
> > > > Hello, Ivan.
> > > >
> > > > > Requirements for a prototype code are not the same as for a patch 
> > > > > ready
> > > > to merge
> > > >
> > > > True.
> > > >
> > > > > I do not see much need in writing good javadocs for prototype.
> > > >
> > > > We, as a community, can't force you to do it.
> > > >
> > > > > Why should I stub it to be able run any build on TC?
> > > >
> > > > Should the community spend TC resources for  prototype?
> > > > You always can check tests for your prototype locally.
> > > >
> > > > And when it's ready, at least from code style point of view run it on 
> > > > TC.
> > > >
> > > > I, personally, always try to follow project code style, even for
> > > prototypes.
> > > > But, If our code style is not convinient for every day coding for many
> > > > contributors, should you initiate discussion to change it?
> > > >
> > > >
> > > > ср, 13 февр. 2019 г. в 16:45, Павлухин Иван :
> > > >
> > > > > Maxim,
> > > > >
> > > > > Oh, my poor tabs.. Joke.
> > > > >
> > > > > I am totally ok with currently enabled checks. But I am mostly
> > > > > concerned about a general approach. I would like to outline one thing.
> > > > > Requirements for a prototype code are not the same as for a patch
> > > > > ready to merge (see a little bit more in the end of that message).
> > > > >
> > > > > We have a document defining code style which every contributor should
> > > > > follow [1]. And many points can be checked automatically. Personally,
> > > > > I 

Re: Website link update

[Dmitriy Pavlov]

Hi Denis,

Could you please chime in? I had not practiced website updates yet.

Sincerely,
Dmitriy Pavlov

сб, 2 мар. 2019 г. в 04:34, 李玉珏 <18624049...@163.com>:

> Hi,
>
> As for Ignite's chinese document, it was previously located on a cloud
> note-taking page with the address of:
>
> https://www.zybuluo.com/liyuj/note/230739
>
> Because of the limited functionality and user experience, it has been
> migrated to the following address:
>
> https://liyuj.gitee.io
>
> The new site has a much better look and experience than it used to be.
>
>
> Can someone help me modify the link on ignite. apache. org?
> Thank you very much.

Re: Issue assignment

[Dmitriy Pavlov]

Hi Suraj,

I've added your account to the list of contributors, so now you can pick
and assign any issue you like. You can pick up unassigned issues, as well,
as assigned issues. For an assigned issue it is required to ask assignee if
he/she is going to continue to contribute or not.

You can find a short guide here
https://github.com/apache/ignite/blob/master/CONTRIBUTING.md#contributing-to-apache-ignite
and
full here
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute

Welcome to Apache Ignite community.

Sincerely,
Dmitriy Pavlov

вс, 3 мар. 2019 г. в 15:19, Suraj Singh :

> Hi there,
>
> I want to pick one or two issues from newbie labeled issues. Following are
> what I picked up:
> 1. https://issues.apache.org/jira/browse/IGNITE-11312
> 2. https://issues.apache.org/jira/browse/IGNITE-11131
> 3. https://issues.apache.org/jira/browse/IGNITE-11120
> 4. https://issues.apache.org/jira/browse/IGNITE-11080
> 5. https://issues.apache.org/jira/browse/IGNITE-10791
>
> Please assign me a few bases your comfortability. My jira id :- surajsn
>
> Thanks,
> Suraj
>

Re: Please re-commit 3 last changes in the master

[Dmitriy Pavlov]

Thanks, Ivan, these commits are in sync in GitHub & GitBox. Only one commit
remained, Vladimir O., please chime in

пн, 4 мар. 2019 г. в 14:03, Ivan Rakov :

> Thanks for keeping track of it, I've re-applied the following commits:
>
> IGNITE-11199 Add extra logging for client-server connections in TCP
> discovery - Fixes #6048. Andrey Kalinin* 04.03.2019 2:11
> IGNITE-11322 [USABILITY] Extend Node FAILED message by add consistentId
> if it exist - Fixes #6180. Andrey Kalinin* 04.03.2019 2:03
>
> Best Regards,
> Ivan Rakov
>
> On 04.03.2019 13:56, Dmitriy Pavlov wrote:
> > Thanks to Alexey Plehanov for noticing and Infra Team for fixing the
> issue:
> > https://issues.apache.org/jira/browse/INFRA-17950
> >
> > пн, 4 мар. 2019 г. в 13:53, Dmitriy Pavlov :
> >
> >> Hi Developers,
> >>
> >> Because of the sync issue, the following 3 commits were lost.
> >>
> >> Please re-apply it to the master.
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=b26bbb29d5fdd9d4de5187042778ebe3b8c6c42e
> >>
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=6c562a997c0beb3a3cd9dd2976e016759a808f0c
> >>
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=45c4dc98e0eac33cccd2e24acb3e9882f098cad1
> >>
> >>
> >> Sorry for the inconvenience.
> >>
> >> Sincerely,
> >> Dmitriy Pavlov
> >>
>

Re: Please re-commit 3 last changes in the master

[Ivan Rakov]

Thanks for keeping track of it, I've re-applied the following commits:

IGNITE-11199 Add extra logging for client-server connections in TCP 
discovery - Fixes #6048. Andrey Kalinin* 04.03.2019 2:11
IGNITE-11322 [USABILITY] Extend Node FAILED message by add consistentId 
if it exist - Fixes #6180. Andrey Kalinin* 04.03.2019 2:03


Best Regards,
Ivan Rakov

On 04.03.2019 13:56, Dmitriy Pavlov wrote:

Thanks to Alexey Plehanov for noticing and Infra Team for fixing the issue:
https://issues.apache.org/jira/browse/INFRA-17950

пн, 4 мар. 2019 г. в 13:53, Dmitriy Pavlov :


Hi Developers,

Because of the sync issue, the following 3 commits were lost.

Please re-apply it to the master.

https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=b26bbb29d5fdd9d4de5187042778ebe3b8c6c42e


https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=6c562a997c0beb3a3cd9dd2976e016759a808f0c


https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=45c4dc98e0eac33cccd2e24acb3e9882f098cad1


Sorry for the inconvenience.

Sincerely,
Dmitriy Pavlov

Re: Please re-commit 3 last changes in the master

[Dmitriy Pavlov]

Thanks to Alexey Plehanov for noticing and Infra Team for fixing the issue:
https://issues.apache.org/jira/browse/INFRA-17950

пн, 4 мар. 2019 г. в 13:53, Dmitriy Pavlov :

> Hi Developers,
>
> Because of the sync issue, the following 3 commits were lost.
>
> Please re-apply it to the master.
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=b26bbb29d5fdd9d4de5187042778ebe3b8c6c42e
>
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=6c562a997c0beb3a3cd9dd2976e016759a808f0c
>
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=45c4dc98e0eac33cccd2e24acb3e9882f098cad1
>
>
> Sorry for the inconvenience.
>
> Sincerely,
> Dmitriy Pavlov
>

Please re-commit 3 last changes in the master

[Dmitriy Pavlov]

Hi Developers,

Because of the sync issue, the following 3 commits were lost.

Please re-apply it to the master.
https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=b26bbb29d5fdd9d4de5187042778ebe3b8c6c42e

https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=6c562a997c0beb3a3cd9dd2976e016759a808f0c

https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=45c4dc98e0eac33cccd2e24acb3e9882f098cad1


Sorry for the inconvenience.

Sincerely,
Dmitriy Pavlov