Re: [VOTE][EXTENSION] Release Apache Ignite spring-tx-ext, spring-cache-ext extensions 1.0.0 RC1

2021-10-31 Thread Nikita Amelchev
Hi Igniters, PMCs,

Remind you that according to ASF policy [1] for a release vote to
pass, a minimum of three positive votes (full binding +1, not
fractions) and more positive than negative votes must be cast.

I suggest continuing the vote until there are enough votes for a
resolution. The policy allows this.

[1] https://www.apache.org/foundation/voting.html#ReleaseVotes

вс, 31 окт. 2021 г. в 13:46, Mikhail Petrov :
>
> Ilya, for Ignite 2.10 versions and earlier spring-tx and spring-cache
> integrations are stored in the ignite-spring module. Initially, there
> were no dedicated modules for them. As I see, we cannot fully migrate
> the ignite-spring module as it is responsible for parsing Ignite XML
> configurations and included in binary release. Therefore, if the users
> want to use the mentioned above extensions with Ignite 2.10 or earlier
> they can get two copies of the Ignite extension classes in their
> classpath - one from extension dependency and one from ignite-spring.
> This problem cannot be solved by excluding some modules - only by
> shading or specifying some classes before others in the classpath.
>
> WDYT?
>
>
> --
> Mikhail
>
>
> On 31.10.2021 01:13, Ilya Kasnacheev wrote:
> > Hello!
> >
> > + 0.5
> >
> >> Apache Ignite 2.10.0 and earlier the ignite-spring-cache-ext dependency
> > must be added to classpath before ignite-spring, due to duplication of
> > Spring Cache integration classes.
> >
> > I think this recommendation does not have much sense - the order of
> > classpath and maven dependency resolution is not something you may count
> > on. We could teach our users to do proper maven exclusion instead (what is
> > the module which they need to exclude - is it spring-cache? which classes
> > are duplicated?)
> >
> > But otherwise maybe we should get it out of door and finish the migration.
> >
> > Regards,



-- 
Best wishes,
Amelchev Nikita


Re: [VOTE][EXTENSION] Release Apache Ignite spring-tx-ext, spring-cache-ext extensions 1.0.0 RC1

2021-10-31 Thread Mikhail Petrov
Ilya, for Ignite 2.10 versions and earlier spring-tx and spring-cache 
integrations are stored in the ignite-spring module. Initially, there 
were no dedicated modules for them. As I see, we cannot fully migrate 
the ignite-spring module as it is responsible for parsing Ignite XML 
configurations and included in binary release. Therefore, if the users 
want to use the mentioned above extensions with Ignite 2.10 or earlier 
they can get two copies of the Ignite extension classes in their 
classpath - one from extension dependency and one from ignite-spring. 
This problem cannot be solved by excluding some modules - only by 
shading or specifying some classes before others in the classpath.


WDYT?


--
Mikhail


On 31.10.2021 01:13, Ilya Kasnacheev wrote:

Hello!

+ 0.5


Apache Ignite 2.10.0 and earlier the ignite-spring-cache-ext dependency

must be added to classpath before ignite-spring, due to duplication of
Spring Cache integration classes.

I think this recommendation does not have much sense - the order of
classpath and maven dependency resolution is not something you may count
on. We could teach our users to do proper maven exclusion instead (what is
the module which they need to exclude - is it spring-cache? which classes
are duplicated?)

But otherwise maybe we should get it out of door and finish the migration.

Regards,