Emmanouil,
All looks good to me as well. Thanks for your contribution!
Sergey, would you merge the PR as the primary reviewer?
-
Denis
On Sat, Feb 22, 2020 at 9:53 AM Emmanouil Gkatziouras
wrote:
> Hi!
>
> With regards to the PR review if there is anything I can do please tell me.
>
> Kind
Hi!
With regards to the PR review if there is anything I can do please tell me.
Kind Regards
*Emmanouil Gkatziouras*
https://egkatzioura.com/ | https://www.linkedin.com/in/gkatziourasemmanouil/
https://github.com/gkatzioura
On Tue, 28 Jan 2020 at 08:03, Sergey Chugunov
wrote:
> Denis,
Denis, Emmanouil,
Sure, I'll take a look at the code shortly.
--
Thank you,
Sergey.
On Mon, Jan 27, 2020 at 8:59 PM Denis Magda wrote:
> I support the idea of triggering such tests on demand. We can create a wiki
> page with instructions on how to run the tests. Unless there is a more
>
I support the idea of triggering such tests on demand. We can create a wiki
page with instructions on how to run the tests. Unless there is a more
elegant solution.
Sergey, would you be able to review Emmanouil's changes in the IP Finder
source code?
Hi all!
I do believe being able to execute some AWS integration tests on demand
would be of value, especially for reviewers who cannot have an AWS stack
created on demand.
More than happy to help on that.
Kind regards
*Emmanouil Gkatziouras*
https://egkatzioura.com/ |
Hello Emmanouil,
It would be great if we have at least basic integration tests in real AWS
environment. Even though they may require more work to keep them green (I
mean here AWS quotas and additional configuration/reconfiguration efforts)
it worth it because these tests can also be useful as an
Hi all!
Yes It seems possible to get some free quota for integration tests on AWS
[1] however most probably they are not gonna last forever.
[1]
https://aws.amazon.com/blogs/opensource/aws-promotional-credits-open-source-projects/
King Regards
*Emmanouil Gkatziouras*
https://egkatzioura.com/ |
Hi Emmanouil,
Thanks for preparing a pull-request for Application Load Balancer:
https://issues.apache.org/jira/browse/IGNITE-8617
Igniters, who is willing to step in as a primary reviewer?
As for automated testing on AWS, are you aware of any sponsorship program
of AWS for open source projects
Hi all!
I have spinned up an Application Load Balancer and an autoscaling group on
AWS and the Ignite discovery using TcpDiscoveryAlbIpFinder works as
expected.
- On startup nodes discover each other.
- On ec2 node down, connection is lost and the cluster decreases.
- On an extra node
Hi Emmanouil,
Agree, let's check that the IP finder functions normally in the cloud
environment and the mock tests can be used for regular testing on Team
City. That's the way we tested other environment-specific IP finders
including the Kubernetes one.
Let us know once the IP finder is tested
Hi all!
With regards to the `Node Discovery Using AWS Application ELB` issue [1]
I made this pull request to fix the merge conflicts [2].
Will also check if the concerns described on the mailing list topic
`Volunteer needed: AWS Elastic Load Balancer IP Finders implemented` are
addressed [3]
Excellent, thanks for finding time for that. Ping us if you have any
questions/suggestions and would like to expedite the review process.
-
Denis
On Fri, Jan 10, 2020 at 9:28 AM Emmanouil Gkatziouras
wrote:
> Hi Denis,
>
> More than happy to help.
> Will get into context and see what I can do
12 matches
Mail list logo
