Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Denis Magda]

Wonderful, thanks Nikolay!

--
Denis

On Fri, Apr 27, 2018 at 11:50 PM, Nikolay Izhikov 
wrote:

> Hell, Denis.
>
> I've done review and merge yersteday.
>
> master commit - https://github.com/apache/ignite/commit/
> fcc4d4a357413eb4856ca5c72d301738568060e2
> 2.5 commit - https://github.com/apache/ignite/commit/
> 2679cc5a18eb00599c9f00b0f46dbcaa6352c0cb
>
> The task is in resolved state.
>
> В Пт, 27/04/2018 в 23:32 -0700, Denis Magda пишет:
> > Akmal, Nikolay,
> >
> > Do you have any progress on this? Let's finish with this ticket within
> 2.5
> > scope and merge it there.
> >
> > --
> > Denis
> >
> > On Thu, Apr 19, 2018 at 10:07 PM, Akmal Chaudhri <
> > akmal.chaud...@gridgain.com> wrote:
> >
> > > Nikolay,
> > >
> > > Ok. I _think_ it should be better now, so we can try again.
> > >
> > > 1. I removed the 3 pull requests.
> > > 2. I renamed the Java code files with a "Java" prefix.
> > > 3. I created a test file for the Java code, using the existing test
> file
> > > for the Scala code.
> > > 4. I updated the TestSuite with bullet #3 above.
> > > 5. I combined all changes into a single pull request.
> > >
> > > Note that one of the tests still fails locally due to the path issue. I
> > > have no idea how to fix this, although the code works fine.
> > >
> > > Thank you.
> > >
> > >
> > >
> > > On 19 April 2018 at 22:41, Nikolay Izhikov 
> wrote:
> > >
> > > > Hello, Akmal.
> > > >
> > > > 1. As a first step. Let's combine all changes you want to merge into
> a
> > > > single pull request.
> > > >
> > > > I suggest that your changes relates only to "examples" module.
> > > >
> > > > 2. So, when you will have one pull request, please, run "Examples"
> test
> > > > suite on Team City for your branch.
> > > > After that, attach link to execution into issue.
> > > >
> > > > After completing step 1 I will be able to review your changes.
> > > > After completing step 2 and review we will be to merge your changes
> to
> > > > master.
> > > >
> > > > В Чт, 19/04/2018 в 15:30 +0100, Akmal Chaudhri пишет:
> > > > > Nikolay,
> > > > >
> > > > > The code is the same for the attached version to the ticket, as
> well as
> > > >
> > > > the
> > > > > pull version. The tests are also the same as those provided for the
> > >
> > > Scala
> > > > > DF examples. I have checked and they work correctly with the
> exception
> > >
> > > of
> > > > > the path issue which I previously mentioned on the dev list.
> > > > >
> > > > > I'm afraid I am new to this whole process, so need someone in the
> > > >
> > > > community
> > > > > to assist.
> > > > >
> > > > > To summarise,
> > > > >
> > > > > 1. The Java Spark DF code is equivalent in functionality to the
> Scala
> > > >
> > > > Spark
> > > > > DF code. These Java examples were requested by Denis Magda, since
> only
> > > > > Scala examples were previously available.
> > > > > 2. The tests scripts provided with the Scala DF code work just fine
> > >
> > > with
> > > > > the Java code.
> > > > > 3. There is a problem with a path issue in test #2, where the code
> > >
> > > reads
> > > > a
> > > > > JSON file. Since the Java code is equivalent to the Scala code, I
> don't
> > > > > know how the Scala code passed this test.
> > > > >
> > > > >
> > > > >
> > > > > On 18 April 2018 at 22:11, Nikolay Izhikov 
> > >
> > > wrote:
> > > > >
> > > > > > Hello, Akmal.
> > > > > >
> > > > > > I see 3 pull requests attached to the ticket [1], [2], [3].
> > > > > > I see 3 java files attached to the ticket, also.
> > > > > >
> > > > > > Which changes you want to be reviewed and merge? Please, clarify.
> > > > > >
> > > > > > Delete all unnecessary pull requests link from the ticket.
> > > > > > Add new examples to the tests so we can test it on the Team City.
> > > > > > You can take IgniteDataFrameSelfTest as an example.
> > > > > >
> > > > > > I also suggest to rename java examples with "Java" prefix.
> > > > > >
> > > > > > IgniteDataFrameWriteExample.java ->
> JavaIgniteDataFrameWriteExampl
> > > >
> > > > e.java
> > > > > >
> > > > > > [1] https://github.com/apache/ignite/pull/3857
> > > > > > [2] https://github.com/apache/ignite/pull/3858I
> > > > > > [3] https://github.com/apache/ignite/pull/3859
> > > > > > [4] https://github.com/apache/ignite/blob/master/examples/
> > > > > > src/test/spark/org/apache/ignite/spark/examples/
> > > > > > IgniteDataFrameSelfTest.java
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> > > > > > > If any community members have time, please review the code.
> Three
> > > >
> > > > Java
> > > > > > > files are attached to the Jira ticket:
> > > > > > >
> > > > > > > https://issues.apache.org/jira/browse/IGNITE-7909
> > > > > > >
> > > > > > > The code should be functionally equivalent to the Scala Data
> Frames
> > > >
> > > > code
> > > > > > > that was shipped in 2.4.
> > > > > > >
> > > > > > > Data Frame documentation is 

Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Nikolay Izhikov]

Hell, Denis.

I've done review and merge yersteday.

master commit - 
https://github.com/apache/ignite/commit/fcc4d4a357413eb4856ca5c72d301738568060e2
2.5 commit - 
https://github.com/apache/ignite/commit/2679cc5a18eb00599c9f00b0f46dbcaa6352c0cb

The task is in resolved state.

В Пт, 27/04/2018 в 23:32 -0700, Denis Magda пишет:
> Akmal, Nikolay,
> 
> Do you have any progress on this? Let's finish with this ticket within 2.5
> scope and merge it there.
> 
> --
> Denis
> 
> On Thu, Apr 19, 2018 at 10:07 PM, Akmal Chaudhri <
> akmal.chaud...@gridgain.com> wrote:
> 
> > Nikolay,
> > 
> > Ok. I _think_ it should be better now, so we can try again.
> > 
> > 1. I removed the 3 pull requests.
> > 2. I renamed the Java code files with a "Java" prefix.
> > 3. I created a test file for the Java code, using the existing test file
> > for the Scala code.
> > 4. I updated the TestSuite with bullet #3 above.
> > 5. I combined all changes into a single pull request.
> > 
> > Note that one of the tests still fails locally due to the path issue. I
> > have no idea how to fix this, although the code works fine.
> > 
> > Thank you.
> > 
> > 
> > 
> > On 19 April 2018 at 22:41, Nikolay Izhikov  wrote:
> > 
> > > Hello, Akmal.
> > > 
> > > 1. As a first step. Let's combine all changes you want to merge into a
> > > single pull request.
> > > 
> > > I suggest that your changes relates only to "examples" module.
> > > 
> > > 2. So, when you will have one pull request, please, run "Examples" test
> > > suite on Team City for your branch.
> > > After that, attach link to execution into issue.
> > > 
> > > After completing step 1 I will be able to review your changes.
> > > After completing step 2 and review we will be to merge your changes to
> > > master.
> > > 
> > > В Чт, 19/04/2018 в 15:30 +0100, Akmal Chaudhri пишет:
> > > > Nikolay,
> > > > 
> > > > The code is the same for the attached version to the ticket, as well as
> > > 
> > > the
> > > > pull version. The tests are also the same as those provided for the
> > 
> > Scala
> > > > DF examples. I have checked and they work correctly with the exception
> > 
> > of
> > > > the path issue which I previously mentioned on the dev list.
> > > > 
> > > > I'm afraid I am new to this whole process, so need someone in the
> > > 
> > > community
> > > > to assist.
> > > > 
> > > > To summarise,
> > > > 
> > > > 1. The Java Spark DF code is equivalent in functionality to the Scala
> > > 
> > > Spark
> > > > DF code. These Java examples were requested by Denis Magda, since only
> > > > Scala examples were previously available.
> > > > 2. The tests scripts provided with the Scala DF code work just fine
> > 
> > with
> > > > the Java code.
> > > > 3. There is a problem with a path issue in test #2, where the code
> > 
> > reads
> > > a
> > > > JSON file. Since the Java code is equivalent to the Scala code, I don't
> > > > know how the Scala code passed this test.
> > > > 
> > > > 
> > > > 
> > > > On 18 April 2018 at 22:11, Nikolay Izhikov 
> > 
> > wrote:
> > > > 
> > > > > Hello, Akmal.
> > > > > 
> > > > > I see 3 pull requests attached to the ticket [1], [2], [3].
> > > > > I see 3 java files attached to the ticket, also.
> > > > > 
> > > > > Which changes you want to be reviewed and merge? Please, clarify.
> > > > > 
> > > > > Delete all unnecessary pull requests link from the ticket.
> > > > > Add new examples to the tests so we can test it on the Team City.
> > > > > You can take IgniteDataFrameSelfTest as an example.
> > > > > 
> > > > > I also suggest to rename java examples with "Java" prefix.
> > > > > 
> > > > > IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExampl
> > > 
> > > e.java
> > > > > 
> > > > > [1] https://github.com/apache/ignite/pull/3857
> > > > > [2] https://github.com/apache/ignite/pull/3858I
> > > > > [3] https://github.com/apache/ignite/pull/3859
> > > > > [4] https://github.com/apache/ignite/blob/master/examples/
> > > > > src/test/spark/org/apache/ignite/spark/examples/
> > > > > IgniteDataFrameSelfTest.java
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> > > > > > If any community members have time, please review the code. Three
> > > 
> > > Java
> > > > > > files are attached to the Jira ticket:
> > > > > > 
> > > > > > https://issues.apache.org/jira/browse/IGNITE-7909
> > > > > > 
> > > > > > The code should be functionally equivalent to the Scala Data Frames
> > > 
> > > code
> > > > > > that was shipped in 2.4.
> > > > > > 
> > > > > > Data Frame documentation is here:
> > > > > > 
> > > > > > https://apacheignite-fs.readme.io/docs/ignite-data-frame
> > > > > > 
> > > > > > Thank you!

signature.asc
Description: This is a digitally signed message part

Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Denis Magda]

Akmal, Nikolay,

Do you have any progress on this? Let's finish with this ticket within 2.5
scope and merge it there.

--
Denis

On Thu, Apr 19, 2018 at 10:07 PM, Akmal Chaudhri <
akmal.chaud...@gridgain.com> wrote:

> Nikolay,
>
> Ok. I _think_ it should be better now, so we can try again.
>
> 1. I removed the 3 pull requests.
> 2. I renamed the Java code files with a "Java" prefix.
> 3. I created a test file for the Java code, using the existing test file
> for the Scala code.
> 4. I updated the TestSuite with bullet #3 above.
> 5. I combined all changes into a single pull request.
>
> Note that one of the tests still fails locally due to the path issue. I
> have no idea how to fix this, although the code works fine.
>
> Thank you.
>
>
>
> On 19 April 2018 at 22:41, Nikolay Izhikov  wrote:
>
> > Hello, Akmal.
> >
> > 1. As a first step. Let's combine all changes you want to merge into a
> > single pull request.
> >
> > I suggest that your changes relates only to "examples" module.
> >
> > 2. So, when you will have one pull request, please, run "Examples" test
> > suite on Team City for your branch.
> > After that, attach link to execution into issue.
> >
> > After completing step 1 I will be able to review your changes.
> > After completing step 2 and review we will be to merge your changes to
> > master.
> >
> > В Чт, 19/04/2018 в 15:30 +0100, Akmal Chaudhri пишет:
> > > Nikolay,
> > >
> > > The code is the same for the attached version to the ticket, as well as
> > the
> > > pull version. The tests are also the same as those provided for the
> Scala
> > > DF examples. I have checked and they work correctly with the exception
> of
> > > the path issue which I previously mentioned on the dev list.
> > >
> > > I'm afraid I am new to this whole process, so need someone in the
> > community
> > > to assist.
> > >
> > > To summarise,
> > >
> > > 1. The Java Spark DF code is equivalent in functionality to the Scala
> > Spark
> > > DF code. These Java examples were requested by Denis Magda, since only
> > > Scala examples were previously available.
> > > 2. The tests scripts provided with the Scala DF code work just fine
> with
> > > the Java code.
> > > 3. There is a problem with a path issue in test #2, where the code
> reads
> > a
> > > JSON file. Since the Java code is equivalent to the Scala code, I don't
> > > know how the Scala code passed this test.
> > >
> > >
> > >
> > > On 18 April 2018 at 22:11, Nikolay Izhikov 
> wrote:
> > >
> > > > Hello, Akmal.
> > > >
> > > > I see 3 pull requests attached to the ticket [1], [2], [3].
> > > > I see 3 java files attached to the ticket, also.
> > > >
> > > > Which changes you want to be reviewed and merge? Please, clarify.
> > > >
> > > > Delete all unnecessary pull requests link from the ticket.
> > > > Add new examples to the tests so we can test it on the Team City.
> > > > You can take IgniteDataFrameSelfTest as an example.
> > > >
> > > > I also suggest to rename java examples with "Java" prefix.
> > > >
> > > > IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExampl
> > e.java
> > > >
> > > > [1] https://github.com/apache/ignite/pull/3857
> > > > [2] https://github.com/apache/ignite/pull/3858I
> > > > [3] https://github.com/apache/ignite/pull/3859
> > > > [4] https://github.com/apache/ignite/blob/master/examples/
> > > > src/test/spark/org/apache/ignite/spark/examples/
> > > > IgniteDataFrameSelfTest.java
> > > >
> > > >
> > > >
> > > >
> > > > В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> > > > > If any community members have time, please review the code. Three
> > Java
> > > > > files are attached to the Jira ticket:
> > > > >
> > > > > https://issues.apache.org/jira/browse/IGNITE-7909
> > > > >
> > > > > The code should be functionally equivalent to the Scala Data Frames
> > code
> > > > > that was shipped in 2.4.
> > > > >
> > > > > Data Frame documentation is here:
> > > > >
> > > > > https://apacheignite-fs.readme.io/docs/ignite-data-frame
> > > > >
> > > > > Thank you!
> >
>

Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Akmal Chaudhri]

Nikolay,

Ok. I _think_ it should be better now, so we can try again.

1. I removed the 3 pull requests.
2. I renamed the Java code files with a "Java" prefix.
3. I created a test file for the Java code, using the existing test file
for the Scala code.
4. I updated the TestSuite with bullet #3 above.
5. I combined all changes into a single pull request.

Note that one of the tests still fails locally due to the path issue. I
have no idea how to fix this, although the code works fine.

Thank you.



On 19 April 2018 at 22:41, Nikolay Izhikov  wrote:

> Hello, Akmal.
>
> 1. As a first step. Let's combine all changes you want to merge into a
> single pull request.
>
> I suggest that your changes relates only to "examples" module.
>
> 2. So, when you will have one pull request, please, run "Examples" test
> suite on Team City for your branch.
> After that, attach link to execution into issue.
>
> After completing step 1 I will be able to review your changes.
> After completing step 2 and review we will be to merge your changes to
> master.
>
> В Чт, 19/04/2018 в 15:30 +0100, Akmal Chaudhri пишет:
> > Nikolay,
> >
> > The code is the same for the attached version to the ticket, as well as
> the
> > pull version. The tests are also the same as those provided for the Scala
> > DF examples. I have checked and they work correctly with the exception of
> > the path issue which I previously mentioned on the dev list.
> >
> > I'm afraid I am new to this whole process, so need someone in the
> community
> > to assist.
> >
> > To summarise,
> >
> > 1. The Java Spark DF code is equivalent in functionality to the Scala
> Spark
> > DF code. These Java examples were requested by Denis Magda, since only
> > Scala examples were previously available.
> > 2. The tests scripts provided with the Scala DF code work just fine with
> > the Java code.
> > 3. There is a problem with a path issue in test #2, where the code reads
> a
> > JSON file. Since the Java code is equivalent to the Scala code, I don't
> > know how the Scala code passed this test.
> >
> >
> >
> > On 18 April 2018 at 22:11, Nikolay Izhikov  wrote:
> >
> > > Hello, Akmal.
> > >
> > > I see 3 pull requests attached to the ticket [1], [2], [3].
> > > I see 3 java files attached to the ticket, also.
> > >
> > > Which changes you want to be reviewed and merge? Please, clarify.
> > >
> > > Delete all unnecessary pull requests link from the ticket.
> > > Add new examples to the tests so we can test it on the Team City.
> > > You can take IgniteDataFrameSelfTest as an example.
> > >
> > > I also suggest to rename java examples with "Java" prefix.
> > >
> > > IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExampl
> e.java
> > >
> > > [1] https://github.com/apache/ignite/pull/3857
> > > [2] https://github.com/apache/ignite/pull/3858I
> > > [3] https://github.com/apache/ignite/pull/3859
> > > [4] https://github.com/apache/ignite/blob/master/examples/
> > > src/test/spark/org/apache/ignite/spark/examples/
> > > IgniteDataFrameSelfTest.java
> > >
> > >
> > >
> > >
> > > В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> > > > If any community members have time, please review the code. Three
> Java
> > > > files are attached to the Jira ticket:
> > > >
> > > > https://issues.apache.org/jira/browse/IGNITE-7909
> > > >
> > > > The code should be functionally equivalent to the Scala Data Frames
> code
> > > > that was shipped in 2.4.
> > > >
> > > > Data Frame documentation is here:
> > > >
> > > > https://apacheignite-fs.readme.io/docs/ignite-data-frame
> > > >
> > > > Thank you!
>

Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Nikolay Izhikov]

Hello, Akmal.

1. As a first step. Let's combine all changes you want to merge into a single 
pull request.

I suggest that your changes relates only to "examples" module.

2. So, when you will have one pull request, please, run "Examples" test suite 
on Team City for your branch.
After that, attach link to execution into issue.

After completing step 1 I will be able to review your changes.
After completing step 2 and review we will be to merge your changes to master.

В Чт, 19/04/2018 в 15:30 +0100, Akmal Chaudhri пишет:
> Nikolay,
> 
> The code is the same for the attached version to the ticket, as well as the
> pull version. The tests are also the same as those provided for the Scala
> DF examples. I have checked and they work correctly with the exception of
> the path issue which I previously mentioned on the dev list.
> 
> I'm afraid I am new to this whole process, so need someone in the community
> to assist.
> 
> To summarise,
> 
> 1. The Java Spark DF code is equivalent in functionality to the Scala Spark
> DF code. These Java examples were requested by Denis Magda, since only
> Scala examples were previously available.
> 2. The tests scripts provided with the Scala DF code work just fine with
> the Java code.
> 3. There is a problem with a path issue in test #2, where the code reads a
> JSON file. Since the Java code is equivalent to the Scala code, I don't
> know how the Scala code passed this test.
> 
> 
> 
> On 18 April 2018 at 22:11, Nikolay Izhikov  wrote:
> 
> > Hello, Akmal.
> > 
> > I see 3 pull requests attached to the ticket [1], [2], [3].
> > I see 3 java files attached to the ticket, also.
> > 
> > Which changes you want to be reviewed and merge? Please, clarify.
> > 
> > Delete all unnecessary pull requests link from the ticket.
> > Add new examples to the tests so we can test it on the Team City.
> > You can take IgniteDataFrameSelfTest as an example.
> > 
> > I also suggest to rename java examples with "Java" prefix.
> > 
> > IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExample.java
> > 
> > [1] https://github.com/apache/ignite/pull/3857
> > [2] https://github.com/apache/ignite/pull/3858I
> > [3] https://github.com/apache/ignite/pull/3859
> > [4] https://github.com/apache/ignite/blob/master/examples/
> > src/test/spark/org/apache/ignite/spark/examples/
> > IgniteDataFrameSelfTest.java
> > 
> > 
> > 
> > 
> > В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> > > If any community members have time, please review the code. Three Java
> > > files are attached to the Jira ticket:
> > > 
> > > https://issues.apache.org/jira/browse/IGNITE-7909
> > > 
> > > The code should be functionally equivalent to the Scala Data Frames code
> > > that was shipped in 2.4.
> > > 
> > > Data Frame documentation is here:
> > > 
> > > https://apacheignite-fs.readme.io/docs/ignite-data-frame
> > > 
> > > Thank you!

signature.asc
Description: This is a digitally signed message part

Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Akmal Chaudhri]

Nikolay,

The code is the same for the attached version to the ticket, as well as the
pull version. The tests are also the same as those provided for the Scala
DF examples. I have checked and they work correctly with the exception of
the path issue which I previously mentioned on the dev list.

I'm afraid I am new to this whole process, so need someone in the community
to assist.

To summarise,

1. The Java Spark DF code is equivalent in functionality to the Scala Spark
DF code. These Java examples were requested by Denis Magda, since only
Scala examples were previously available.
2. The tests scripts provided with the Scala DF code work just fine with
the Java code.
3. There is a problem with a path issue in test #2, where the code reads a
JSON file. Since the Java code is equivalent to the Scala code, I don't
know how the Scala code passed this test.



On 18 April 2018 at 22:11, Nikolay Izhikov  wrote:

> Hello, Akmal.
>
> I see 3 pull requests attached to the ticket [1], [2], [3].
> I see 3 java files attached to the ticket, also.
>
> Which changes you want to be reviewed and merge? Please, clarify.
>
> Delete all unnecessary pull requests link from the ticket.
> Add new examples to the tests so we can test it on the Team City.
> You can take IgniteDataFrameSelfTest as an example.
>
> I also suggest to rename java examples with "Java" prefix.
>
> IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExample.java
>
> [1] https://github.com/apache/ignite/pull/3857
> [2] https://github.com/apache/ignite/pull/3858I
> [3] https://github.com/apache/ignite/pull/3859
> [4] https://github.com/apache/ignite/blob/master/examples/
> src/test/spark/org/apache/ignite/spark/examples/
> IgniteDataFrameSelfTest.java
>
>
>
>
> В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> > If any community members have time, please review the code. Three Java
> > files are attached to the Jira ticket:
> >
> > https://issues.apache.org/jira/browse/IGNITE-7909
> >
> > The code should be functionally equivalent to the Scala Data Frames code
> > that was shipped in 2.4.
> >
> > Data Frame documentation is here:
> >
> > https://apacheignite-fs.readme.io/docs/ignite-data-frame
> >
> > Thank you!
>

Re: [IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Nikolay Izhikov]

Hello, Akmal.

I see 3 pull requests attached to the ticket [1], [2], [3].
I see 3 java files attached to the ticket, also.

Which changes you want to be reviewed and merge? Please, clarify.

Delete all unnecessary pull requests link from the ticket.
Add new examples to the tests so we can test it on the Team City.
You can take IgniteDataFrameSelfTest as an example.

I also suggest to rename java examples with "Java" prefix.

IgniteDataFrameWriteExample.java -> JavaIgniteDataFrameWriteExample.java

[1] https://github.com/apache/ignite/pull/3857
[2] https://github.com/apache/ignite/pull/3858I
[3] https://github.com/apache/ignite/pull/3859
[4] 
https://github.com/apache/ignite/blob/master/examples/src/test/spark/org/apache/ignite/spark/examples/IgniteDataFrameSelfTest.java




В Ср, 18/04/2018 в 17:20 +0100, Akmal Chaudhri пишет:
> If any community members have time, please review the code. Three Java
> files are attached to the Jira ticket:
> 
> https://issues.apache.org/jira/browse/IGNITE-7909
> 
> The code should be functionally equivalent to the Scala Data Frames code
> that was shipped in 2.4.
> 
> Data Frame documentation is here:
> 
> https://apacheignite-fs.readme.io/docs/ignite-data-frame
> 
> Thank you!

signature.asc
Description: This is a digitally signed message part

[IGNITE-7909]: Java code examples are needed for Spark Data Frames.

[Akmal Chaudhri]

If any community members have time, please review the code. Three Java
files are attached to the Jira ticket:

https://issues.apache.org/jira/browse/IGNITE-7909

The code should be functionally equivalent to the Scala Data Frames code
that was shipped in 2.4.

Data Frame documentation is here:

https://apacheignite-fs.readme.io/docs/ignite-data-frame

Thank you!

Re: Fwd: [jira] [Created] (IGNITE-7909) Java code examples are needed for Spark Data Frames.

[Dmitry Pavlov]

I see now. Thank you for clarification.

пн, 12 мар. 2018 г., 13:12 Nikolay Izhikov <nizhi...@apache.org>:

> Hello, Dmitry.
>
> Examples I create written in scala [1].
>
> The goal of task is to rewrite these examples in java.
>
> [1]
> https://github.com/apache/ignite/blob/master/examples/src/main/spark/org/apache/ignite/examples/spark/IgniteDataFrameExample.scala
>
> В Пн, 12/03/2018 в 10:07 +, Dmitry Pavlov пишет:
> > Hi Nikolay,
> >
> > Сan your examples, that you have done recently, come up as a solution to
> > this ticket?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > -- Forwarded message -
> > From: Akmal Chaudhri (JIRA) <j...@apache.org>
> > Date: вс, 11 мар. 2018 г. в 2:24
> > Subject: [jira] [Created] (IGNITE-7909) Java code examples are needed for
> > Spark Data Frames.
> > To: <dev@ignite.apache.org>
> >
> >
> > Akmal Chaudhri created IGNITE-7909:
> > --
> >
> >  Summary: Java code examples are needed for Spark Data
> Frames.
> >  Key: IGNITE-7909
> >  URL: https://issues.apache.org/jira/browse/IGNITE-7909
> >  Project: Ignite
> >   Issue Type: Improvement
> >   Components: spark
> > Affects Versions: 2.5
> > Reporter: Akmal Chaudhri
> > Assignee: Akmal Chaudhri
> >  Attachments: JavaIgniteCatalogExample.java,
> > JavaIgniteDataFrameExample.java, JavaIgniteDataFrameWriteExample.java
> >
> > Existing Scala code examples have been developed to illustrate Ignite
> > support for Spark Data Frames. But Java code examples are also required.
> > Some Java code has already been developed but requires further testing.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v7.6.3#76005)

Re: Fwd: [jira] [Created] (IGNITE-7909) Java code examples are needed for Spark Data Frames.

[Nikolay Izhikov]

Hello, Dmitry.

Examples I create written in scala [1].

The goal of task is to rewrite these examples in java.

[1] 
https://github.com/apache/ignite/blob/master/examples/src/main/spark/org/apache/ignite/examples/spark/IgniteDataFrameExample.scala

В Пн, 12/03/2018 в 10:07 +, Dmitry Pavlov пишет:
> Hi Nikolay,
> 
> Сan your examples, that you have done recently, come up as a solution to
> this ticket?
> 
> Sincerely,
> Dmitriy Pavlov
> 
> -- Forwarded message -
> From: Akmal Chaudhri (JIRA) <j...@apache.org>
> Date: вс, 11 мар. 2018 г. в 2:24
> Subject: [jira] [Created] (IGNITE-7909) Java code examples are needed for
> Spark Data Frames.
> To: <dev@ignite.apache.org>
> 
> 
> Akmal Chaudhri created IGNITE-7909:
> --
> 
>  Summary: Java code examples are needed for Spark Data Frames.
>  Key: IGNITE-7909
>  URL: https://issues.apache.org/jira/browse/IGNITE-7909
>  Project: Ignite
>   Issue Type: Improvement
>   Components: spark
> Affects Versions: 2.5
> Reporter: Akmal Chaudhri
> Assignee: Akmal Chaudhri
>  Attachments: JavaIgniteCatalogExample.java,
> JavaIgniteDataFrameExample.java, JavaIgniteDataFrameWriteExample.java
> 
> Existing Scala code examples have been developed to illustrate Ignite
> support for Spark Data Frames. But Java code examples are also required.
> Some Java code has already been developed but requires further testing.
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)

signature.asc
Description: This is a digitally signed message part

Fwd: [jira] [Created] (IGNITE-7909) Java code examples are needed for Spark Data Frames.

[Dmitry Pavlov]

Hi Nikolay,

Сan your examples, that you have done recently, come up as a solution to
this ticket?

Sincerely,
Dmitriy Pavlov

-- Forwarded message -
From: Akmal Chaudhri (JIRA) <j...@apache.org>
Date: вс, 11 мар. 2018 г. в 2:24
Subject: [jira] [Created] (IGNITE-7909) Java code examples are needed for
Spark Data Frames.
To: <dev@ignite.apache.org>


Akmal Chaudhri created IGNITE-7909:
--

 Summary: Java code examples are needed for Spark Data Frames.
 Key: IGNITE-7909
 URL: https://issues.apache.org/jira/browse/IGNITE-7909
 Project: Ignite
  Issue Type: Improvement
  Components: spark
Affects Versions: 2.5
Reporter: Akmal Chaudhri
Assignee: Akmal Chaudhri
 Attachments: JavaIgniteCatalogExample.java,
JavaIgniteDataFrameExample.java, JavaIgniteDataFrameWriteExample.java

Existing Scala code examples have been developed to illustrate Ignite
support for Spark Data Frames. But Java code examples are also required.
Some Java code has already been developed but requires further testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (IGNITE-7909) Java code examples are needed for Spark Data Frames.

[Akmal Chaudhri (JIRA)]

Akmal Chaudhri created IGNITE-7909:
--

 Summary: Java code examples are needed for Spark Data Frames.
 Key: IGNITE-7909
 URL: https://issues.apache.org/jira/browse/IGNITE-7909
 Project: Ignite
  Issue Type: Improvement
  Components: spark
Affects Versions: 2.5
Reporter: Akmal Chaudhri
Assignee: Akmal Chaudhri
 Attachments: JavaIgniteCatalogExample.java, 
JavaIgniteDataFrameExample.java, JavaIgniteDataFrameWriteExample.java

Existing Scala code examples have been developed to illustrate Ignite support 
for Spark Data Frames. But Java code examples are also required. Some Java code 
has already been developed but requires further testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)