Re: Contributions that are waiting for review

2016-03-19 Thread Denis Magda
Looks great, thanks! On 3/17/2016 3:55 PM, Anton Vinogradov wrote: Done, https://cwiki.apache.org/confluence/display/IGNITE/Issues+waiting+for+review On Thu, Mar 17, 2016 at 3:46 PM, Denis Magda wrote: Pavel, Anton, Can we simply create a page on Apache wiki that will

Re: Contributions that are waiting for review

2016-03-19 Thread Anton Vinogradov
Done, https://cwiki.apache.org/confluence/display/IGNITE/Issues+waiting+for+review On Thu, Mar 17, 2016 at 3:46 PM, Denis Magda wrote: > Pavel, Anton, > > Can we simply create a page on Apache wiki that will show a result of the > specific JIRA filter execution? This can

Re: Contributions that are waiting for review

2016-03-19 Thread Denis Magda
Pavel, Anton, Can we simply create a page on Apache wiki that will show a result of the specific JIRA filter execution? This can be the first improvement we can do in this direction. -- Denis On 3/4/2016 4:14 PM, Anton Vinogradov wrote: Pavel, I think that script should be stored inside

Re: Contributions that are waiting for review

2016-03-04 Thread Anton Vinogradov
Pavel, I think that script should be stored inside TeamCity task. On Fri, Mar 4, 2016 at 3:56 PM, Pavel Tupitsyn wrote: > Anton, good idea, the script can be stored in git this way. Dmitriy, what > do you think? > > Another question is the email account to send from.

Re: Contributions that are waiting for review

2016-03-04 Thread Pavel Tupitsyn
Anton, good idea, the script can be stored in git this way. Dmitriy, what do you think? Another question is the email account to send from. Do we have something suitable already? On Fri, Mar 4, 2016 at 3:34 PM, Anton Vinogradov wrote: > Folks, > > we can create

Re: Contributions that are waiting for review

2016-03-04 Thread Anton Vinogradov
Folks, we can create TeamCity task with special trigger (eg. once a day). This task can contains any script. On Fri, Mar 4, 2016 at 3:18 PM, Pavel Tupitsyn wrote: > Raul, I'm not good with shell scripts. As a .net person I was thinking > about a scheduled C# script on

Re: Contributions that are waiting for review

2016-03-04 Thread Pavel Tupitsyn
Raul, I'm not good with shell scripts. As a .net person I was thinking about a scheduled C# script on one of our TeamCity win machines, but Dmitry prefers Jenkins. On Fri, Mar 4, 2016 at 2:52 PM, Raul Kripalani wrote: > I believe all we need is a shell script in our source

Re: Contributions that are waiting for review

2016-03-04 Thread Raul Kripalani
I believe all we need is a shell script in our source tree that queries the JIRA API and produces an output on stdout. We can then schedule an overnight job with, e.g. a 0 23 * * * cron expression, and configure the output to be sent to the ML, as indicated here:

Re: Contributions that are waiting for review

2016-03-03 Thread Dmitriy Setrakyan
My preference would be Jenkins. Raul, do you know how to set it up? On Thu, Mar 3, 2016 at 10:08 AM, Raul Kripalani wrote: > Cool! Do you think you can host it at GridGain? > > Else, we could run it as a Jenkins job in the ASF Jenkins. > > Regards, > > *Raúl Kripalani* > PMC &

Re: Contributions that are waiting for review

2016-03-03 Thread Raul Kripalani
Cool! Do you think you can host it at GridGain? Else, we could run it as a Jenkins job in the ASF Jenkins. Regards, *Raúl Kripalani* PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and Messaging Engineer http://about.me/raulkripalani |

Re: Contributions that are waiting for review

2016-03-03 Thread Pavel Tupitsyn
+1 for Raul, great idea. We can also include a column with "days since last update" to see how long each issue has been waiting. I have some experience with JIRA REST API, so maybe I could help with this. On Thu, Mar 3, 2016 at 6:24 PM, Raul Kripalani wrote: > How about a

Re: Contributions that are waiting for review

2016-03-03 Thread Raul Kripalani
How about a nightly job that fetches all tickets from JIRA which are unresolved and have Patch Available = true, and (1) sends them to the dev ML or (2) posts it in Gitter? Will it help raise awareness and put them on the radar? Raúl. On 2 Mar 2016 20:47, "Denis Magda"

Re: Contributions that are waiting for review

2016-03-02 Thread Denis Magda
I would better ask contributors to ping committers on the dev list when a patch is available asking for review. It can happen that committers missed or forgot to do the review and a contributor can remind them sending one more email to the dev list. I don't see anything wrong with this

Re: Contributions that are waiting for review

2016-03-02 Thread Denis Magda
Roman, Please send the message directly to the dev list when you need a review. Quite often people who open an issue are not eligible for review and thus don't provide any feedback. Regards, Denis On 3/2/2016 4:08 PM, Roman Shtykh wrote: I have also asked for review of the following

Re: Contributions that are waiting for review

2016-03-02 Thread Anton Vinogradov
Denis, We have a special status at Ignite JIRA - PATCH AVAILABLE which means that issue ready to be reviewed. Currently 59 issues has such status according to https://issues.apache.org/jira/issues/?filter=-2=project%20%3D%20Ignite%20and%20status%20%3D%20%22Patch%20Available%22 I think we have to

Re: Contributions that are waiting for review

2016-03-02 Thread Roman Shtykh
I have also asked for review of the following tickets but failed to get a feedback. They are not complicated, but I would appreciate a quick review. Thank you! [IGNITE-2563] Queries: ArrayIndexOutOfBoundsException when using BOOL_AND https://issues.apache.org/jira/browse/IGNITE-2563

Contributions that are waiting for review

2016-03-02 Thread Denis Magda
Ignite committers, There is a number of contributions that have to be reviewed. Please pick them up basing on your experience and provide your review notes. Ignite 2718: Missing ZookeeperIpFinder dependencies IGNITE-2693: withKeepBinary and