Re: Refactoring of IgniteKernal ack methods

Dmitry, In my experience refactoring without a reasons often produces more harm than benefits. Especially: 1) You may brake compatibility. E.g. moving anonymous inner class to the top level will cause renames of all other anonymous classes. 2) This may interfere severely with other people's work.

Re: Refactoring of IgniteKernal ack methods

IgniteKernal and some other classes have more places to refactor. At least for better readable form or to remove inner class [1]. May be create some tickets for refactoring such complex places? I mean to create main ticket like [2] or [3], and when someone see something complex *and* the way to

Re: Refactoring of IgniteKernal ack methods

On Wed, Oct 11, 2017 at 7:44 AM, Иван Федотов wrote: > Hello, Igniters! > > I found, that in several places of IgniteKernal class code blocks are huge > and hard to understand and in other places methods have the same context > and could be placed in their own class. For

Refactoring of IgniteKernal ack methods

Hello, Igniters! I found, that in several places of IgniteKernal class code blocks are huge and hard to understand and in other places methods have the same context and could be placed in their own class. For example methods: “ackAsciiLogo”, “ackConfigUrl”, “ackDaemon”, “ackOsInfo”,