Re: abbrevation rules plugin

2018-05-15 Thread Vyacheslav Daradur
; approve >> > > > change of file headers and making this tool fully opensource. >> > > > >> > > > So please proceed with distributive build. >> > > > >> > > > Best Regards, >> > > > Dmitriy Palvov >&

Re: abbrevation rules plugin

2018-05-14 Thread Dmitry Pavlov
y Palvov > > > > > > > > > > > > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dpavlov@gmail.com > > > > > > wrote: > > > > > > > >> > > > >> > > > >> -- Forwarded message --

Re: abbrevation rules plugin

2018-05-14 Thread Anton Vinogradov
Palvov > > > > > > > > > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dpavlov....@gmail.com> > > > wrote: > > > > > >> > > >> > > >> -- Forwarded message - > > >> From:

Re: abbrevation rules plugin

2018-05-14 Thread Dmitry Pavlov
gt; > > > > > On Mon, May 14, 2018 at 6:28 PM Dmitry Pavlov <dpavlov@gmail.com> > > wrote: > > > >> > >> > >> ------ Forwarded message - > >> From: Andrey Gura <ag...@apache.org> > >> Date: ср, 4 апр. 2

Re: abbrevation rules plugin

2018-05-14 Thread Dmitriy Pavlov
lov@gmail.com> wrote: > > > -- Forwarded message - > From: Andrey Gura <ag...@apache.org> > Date: ср, 4 апр. 2018 г. в 12:05 > Subject: Re: abbrevation rules plugin > To: <dev@ignite.apache.org> > > > Both prefixes "Grid" and

Re: abbrevation rules plugin

2018-04-04 Thread Andrey Gura
Both prefixes "Grid" and "Ignite" in class names are redundant for most cases. So there is no any rules for this. вт, 3 апр. 2018 г., 19:28 Vyacheslav Daradur : > Hi, Igniters! > > I got into the task [1] in agreement with Dmitry. > > I’ve prepared the PR [2] with following

Re: abbrevation rules plugin

2018-04-03 Thread Dmitry Pavlov
Anton, I also agree here. Personal github repo is ok for very beginning of tool development, but eventually apache repo is better. вт, 3 апр. 2018 г. в 19:46, Anton Vinogradov : > Awesome! > > Dmitriy, > please confirm donation and apply the patch. > > BTW, we can relocate

Re: abbrevation rules plugin

2018-04-03 Thread Dmitry Pavlov
Thank you, Vyaceslav. Excellent patch, I've applied PR to https://github.com/dspavlov/ignite-abbrev-plugin If we want code style will be learned by all contributors, this donation is unavoidable. Dmitriy S, what do you think? Lets keep current code base in my github and add build and link to

Re: abbrevation rules plugin

2018-04-03 Thread Anton Vinogradov
Awesome! Dmitriy, please confirm donation and apply the patch. BTW, we can relocate plugin to apache repo like we did for release scripts [1]. [1] https://github.com/apache/ignite-release 2018-04-03 19:28 GMT+03:00 Vyacheslav Daradur : > Hi, Igniters! > > I got into the

Re: abbrevation rules plugin

2018-04-03 Thread Vyacheslav Daradur
Hi, Igniters! I got into the task [1] in agreement with Dmitry. I’ve prepared the PR [2] with following changes: - added Apache 2.0 license to the header of each file - replaced prefix ‘Grid’ by ‘Ignite’ in class names - added README.md with a simple description - changed version 2.6.3 -> 3.0.0

Re: abbrevation rules plugin

2017-07-05 Thread Denis Magda
Dmitriy P., Does it sound good to you? If yes, please make sure the plugin is available via a public GitHub repo and refer to it from the doc. — Denis > On Jul 5, 2017, at 4:43 PM, Dmitriy Setrakyan wrote: > > On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda

Re: abbrevation rules plugin

2017-07-05 Thread Dmitriy Setrakyan
On Wed, Jul 5, 2017 at 4:41 PM, Denis Magda wrote: > Ok, what if we make sure the plugin is available on GitHub (not Ignite) > and give a link to it on the documentation page? This seems to be the > easiest way to handle the topic. I think this will work.

Re: abbrevation rules plugin

2017-07-05 Thread Denis Magda
Ok, what if we make sure the plugin is available on GitHub (not Ignite) and give a link to it on the documentation page? This seems to be the easiest way to handle the topic. — Denis > On Jul 5, 2017, at 4:37 PM, Dmitriy Setrakyan wrote: > > On Wed, Jul 5, 2017 at

Re: abbrevation rules plugin

2017-07-05 Thread Dmitriy Setrakyan
On Wed, Jul 5, 2017 at 4:35 PM, Denis Magda wrote: > Dmitriy, > > I’m not suggesting to add the JAR to the source code or to any binary > package but rather treat it as a third party plugin developed by someone > for Ignite’s development simplification. It’s similar to the way

Re: abbrevation rules plugin

2017-07-05 Thread Denis Magda
Dmitriy, I’m not suggesting to add the JAR to the source code or to any binary package but rather treat it as a third party plugin developed by someone for Ignite’s development simplification. It’s similar to the way the community uses Intellij IDEA’s plugins or Team City or many other maven

Re: abbrevation rules plugin

2017-07-05 Thread Dmitriy Setrakyan
Denis, Apache cannot have any binary files anywhere in its code bases. All binary JARs must be produced from a build process. If we are adding this plugin, then the source for it needs to be committed to AI code base and the JAR should be generated from the build. Once the JAR is generated, only

Re: abbrevation rules plugin

2017-07-05 Thread Denis Magda
Guys, Let’s make things simple and attach the jar of the plugin to the wiki page that refers to it: https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules This should be fine from ASF standpoint. — Denis >

Re: abbrevation rules plugin

2017-07-05 Thread Dmitriy Setrakyan
Hi Dmitriy, The answer is No. We should put it as a source code and integrate it into our build procedure. D. On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov wrote: > Hi Igniters, > > Could you please share your opinion about this topic? > > The question is as follows: Is

Re: abbrevation rules plugin

2017-07-05 Thread Dmitry Pavlov
Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698 for this task. It is not clear for me yet how to publish correctly - is it possible to publish JAR. ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV : > Yeah, it would be very helpful. > > вт, 4 июл.

Re: abbrevation rules plugin

2017-07-05 Thread ALEKSEY KUZNETSOV
Yeah, it would be very helpful. вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov : > Hi, Val, > > No, this plugin is not available in apache-ignite code base. > May be we should remove reference from JIRA or add this plugin (and also > other code inspections) into AI code base. >

Re: abbrevation rules plugin

2017-07-04 Thread Dmitry Pavlov
Hi, Val, No, this plugin is not available in apache-ignite code base. May be we should remove reference from JIRA or add this plugin (and also other code inspections) into AI code base. Thoughts? Sincerely, Dmitriy Pavlov вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko <

abbrevation rules plugin

2017-07-03 Thread ALEKSEY KUZNETSOV
Igntrs! There is a plugin , mentioned in Abbreviation Rules page that performs on-the-fly check.Is somebody going to add it some day? -- *Best Regards,* *Kuznetsov Aleksey*