Re: Re: Re: ORC scanner - points for discussion

2018-03-28 Thread Tim Armstrong
It looks like the review is converging, so hopefully we can get this in soon and people can play around with it in their development environments some more. Also, I wanted to call out all of the bugs that Quanlong has found and been fixing in the ORC C++ library - he's found a whole bunch of pre-e

Re: Re: Re: ORC scanner - points for discussion

2018-02-12 Thread Tim Armstrong
Maybe it would make sense to create an Epic in JIRA for ORC scanner enhancements, following on from the initial implementation. I don't really feel strongly as long as the related JIRAs are linked together somehow. On Mon, Feb 12, 2018 at 1:42 PM, Quanlong Huang wrote: > Dimitris, as the first s

Re:Re: Re: ORC scanner - points for discussion

2018-02-12 Thread Quanlong Huang
Dimitris, as the first step, this patch only supports reading primitive types from ORC files. I just created two follow-up JIRAs for reading complex types (IMPALA-6503) and writing to ORC tables (IMPALA-6504). Will work on them later. Tim, I also created some follow-on JIRAs as you suggest in th

Re: Re: ORC scanner - points for discussion

2018-02-12 Thread Tim Armstrong
Putting it behind a flag sounds good to me too. Hopefully we can get feedback from Hulu and other users of Impala that will try out the experimental version. On Mon, Feb 12, 2018 at 10:26 AM, Dimitris Tsirogiannis < dtsirogian...@cloudera.com> wrote: > Does the patch also implement an ORC writer?

Re: Re: ORC scanner - points for discussion

2018-02-12 Thread Dimitris Tsirogiannis
Does the patch also implement an ORC writer? Dimitris On Mon, Feb 12, 2018 at 8:48 AM, Jim Apple wrote: > I agree with the previous comments on this thread. Thank you for > contributing, Quanlong! >

Re: Re: ORC scanner - points for discussion

2018-02-12 Thread Jim Apple
I agree with the previous comments on this thread. Thank you for contributing, Quanlong!

Re: ORC scanner - points for discussion

2018-02-09 Thread Todd Lipcon
On Fri, Feb 9, 2018 at 5:05 PM, Tim Armstrong wrote: > Quanlong has done a bunch of work implementing an ORC scanner. I've been > playing around with it and it works pretty nicely - I can load and run > TPC-H with no problem! > > It's a big addition to Impala and the integration with the external