[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-08-26 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new change for review. http://gerrit.cloudera.org:8080/4144 Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670: Support multiple partitions in

[Impala-ASF-CR] IMPALA-3938: Disallow implicit references between nested collections.

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3938: Disallow implicit references between nested collections. .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4079 To

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#4). Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters in the coordinator Before this patch,

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has abandoned this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Abandoned Wrong change-id. Uploaded the right one after. -- To view, visit

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. Patch Set 2: (15 comments) http://gerrit.cloudera.org:8080/#/c/4066/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-3610: Account for memory used by filters in the coordinator

2016-08-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/4143 Change subject: IMPALA-3610: Account for memory used by filters in the coordinator .. IMPALA-3610: Account for memory used by filters

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Abandoned different change id -- To view, visit http://gerrit.cloudera.org:8080/4137 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 10: (5 comments)

[Impala-ASF-CR] CDH-35265: specify a CM API version in deploy.py (take two)

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has submitted this change and it was merged. Change subject: CDH-35265: specify a CM API version in deploy.py (take two) .. CDH-35265: specify a CM API version in deploy.py (take two) This commit was accidentally

[Impala-ASF-CR] CDH-35265: specify a CM API version in deploy.py (take two)

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: CDH-35265: specify a CM API version in deploy.py (take two) .. Patch Set 1: Verified+1 Manually merging since does not affect any test or product code. -- To

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-08-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3671: Add query option to limit scratch space usage .. Patch Set 5: (20 comments)

[Impala-ASF-CR] IMPALA-3671: Add query option to limit scratch space usage

2016-08-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3671: Add query option to limit scratch space usage .. IMPALA-3671: Add query option to limit scratch space usage Currently we can only disable spilling

[Impala-ASF-CR] CDH-35265: specify a CM API version in deploy.py (take two)

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: CDH-35265: specify a CM API version in deploy.py (take two) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4136 To unsubscribe,

[Impala-ASF-CR] IMPALA-3938: Disallow implicit references between nested collections.

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3938: Disallow implicit references between nested collections. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4079 To

[Impala-ASF-CR] IMPALA-3938: Disallow implicit references between nested collections.

2016-08-26 Thread Christopher Channing (Code Review)
Christopher Channing has posted comments on this change. Change subject: IMPALA-3938: Disallow implicit references between nested collections. .. Patch Set 6: Alex (or someone), could you +2 this again please? I just rebased

[Impala-ASF-CR] IMPALA-2932: Extend DistributedPlanner to account for hash table build cost

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2932: Extend DistributedPlanner to account for hash table build cost .. Patch Set 4: Verified+1 -- To view, visit

Re: [Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-26 Thread Thomas Tauber-Marshall
After poking around some more, I think this job: http://golden.jenkins.cloudera.com/job/CDH5-Packaging-On-Demand/ is what I need, so I'm going to see if I can get that to kick off the bvt On Fri, Aug 26, 2016 at 1:59 PM Thomas Tauber-Marshall < tmarsh...@cloudera.com> wrote: > > > On Fri, Aug

[Impala-ASF-CR] IMPALA-3905: Add single-threaded scan node.

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. .. Patch Set 1: (28 comments) http://gerrit.cloudera.org:8080/#/c/4113/1/be/src/exec/hdfs-avro-scanner.h File

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-08-26 Thread Brock Noland (Code Review)
Brock Noland has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 4: (1 comment)

[Impala-ASF-CR] CDH-35265: specify a CM API version in deploy.py (take two)

2016-08-26 Thread Adar Dembo (Code Review)
Hello Matthew Jacobs, Dimitris Tsirogiannis, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4136 to review the following change. Change subject: CDH-35265: specify a CM API version in deploy.py (take two)

Re: [Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-26 Thread Thomas Tauber-Marshall
On Fri, Aug 26, 2016 at 1:45 PM Jim Apple wrote: > https://wiki.cloudera.com/display/engineering/Impala+BVT+Tests Sure, I saw that. The linked job hasn't been run in 8 months. Any idea if it still works or how to use it? > > > On Fri, Aug 26, 2016 at 1:34 PM, Thomas

[Impala-CR](cdh5-trunk) CDH-35265: specify a CM API version in deploy.py (take two)

2016-08-26 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. Change subject: CDH-35265: specify a CM API version in deploy.py (take two) .. Abandoned Whoops, I should be using the new Impala-ASF gerrit project. -- To view, visit

[Impala-CR](cdh5-trunk) CDH-35265: specify a CM API version in deploy.py (take two)

2016-08-26 Thread Adar Dembo (Code Review)
Hello Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4135 to review the following change. Change subject: CDH-35265: specify a CM API version in deploy.py (take two) ..

Re: [Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-26 Thread Jim Apple
https://wiki.cloudera.com/display/engineering/Impala+BVT+Tests On Fri, Aug 26, 2016 at 1:34 PM, Thomas Tauber-Marshall wrote: > Harrison or Shiraz: > > Given that I have a successful run of the packaging kob: > >

Re: [Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-26 Thread Thomas Tauber-Marshall
Harrison or Shiraz: Given that I have a successful run of the packaging kob: http://golden.jenkins.cloudera.com/job/CDH5-Packaging-Impala-On-Demand/347/ How would I go about running BVT on it? Thanks. On Fri, Aug 26, 2016 at 10:54 AM Dan Hecht (Code Review) < ger...@cloudera.org> wrote: >

Re: [VOTE] Bylaw change to make branch creation or deletion lazy consensus

2016-08-26 Thread Daniel Hecht
+1 (binding) On Thu, Aug 25, 2016 at 3:39 PM, Tim Armstrong wrote: > +1 (Binding) > > On Thu, Aug 25, 2016 at 3:18 PM, Matthew Jacobs wrote: > > > +1 (binding) > > > > On Thu, Aug 25, 2016 at 3:01 PM, Marcel Kornacker > > wrote:

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 11: Sorry for the flood of patchsets. The last one finally makes the tests pass, so I don't

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4078 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3938: Disallow implicit references between nested collections.

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3938: Disallow implicit references between nested collections. .. Patch Set 5: Code-Review+2 Thanks for replacing it. To clarify, my version had 100+ fewer

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-08-26 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-08-26 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 2: > > It passed the packaging build: > >

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-08-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu

[Impala-ASF-CR] IMPALA-3776: fix 'describe formatted' for Avro tables

2016-08-26 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables .. IMPALA-3776: fix 'describe formatted' for Avro tables For Avro tables the column information in

[Impala-ASF-CR] IMPALA-3776: fix 'describe formatted' for Avro tables

2016-08-26 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables .. Patch Set 2: Code-Review+2 Carry earlier +2 -- To view, visit http://gerrit.cloudera.org:8080/4126 To

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4094 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2932: Extend DistributedPlanner to account for hash table build cost

2016-08-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4098 to look at the new patch set (#4). Change subject: IMPALA-2932: Extend DistributedPlanner to account for hash table build cost

[Impala-ASF-CR] IMPALA-3776: fix 'describe formatted' for Avro tables

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4126 To unsubscribe,

[Impala-ASF-CR] IMPALA-3973: add position and occurrence to instr()

2016-08-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3973: add position and occurrence to instr() .. Patch Set 1: (7 comments) Thank you for the change. Please see my comments.

[Impala-ASF-CR] IMPALA-1659: Netezza compatibility functions: metadata

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-1659: Netezza compatibility functions: metadata .. IMPALA-1659: Netezza compatibility functions: metadata Added the SQL functions

[Impala-ASF-CR] IMPALA-1659: Netezza compatibility functions: metadata

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-1659: Netezza compatibility functions: metadata .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4063 To unsubscribe,

[Impala-ASF-CR] IMPALA-3481: Use Kudu ScanToken API for scan ranges

2016-08-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3481: Use Kudu ScanToken API for scan ranges .. Patch Set 1: (1 comment)

[Impala-CR](cdh5-trunk) IMPALA-3823: Add timer to measure Parquet footer reads

2016-08-26 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3823: Add timer to measure Parquet footer reads .. Patch Set 5: what's going on with this? -- To view, visit http://gerrit.cloudera.org:8080/3576 To

[Impala-ASF-CR] IMPALA-4027:Memory leak with ExprCtxs not free

2016-08-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4027:Memory leak with ExprCtxs not free .. Patch Set 1: Code-Review+1 The change looks good to me, nice catch. Have you submitted a license agreement to

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Zoltan Ivanfi (Code Review)
Hello Michael Ho, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4078 to look at the new patch set (#11). Change subject: IMPALA-4006: dangerous rm -rf statements in scripts

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Zoltan Ivanfi (Code Review)
Hello Michael Ho, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4078 to look at the new patch set (#10). Change subject: IMPALA-4006: dangerous rm -rf statements in scripts

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Zoltan Ivanfi (Code Review)
Hello Michael Ho, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4078 to look at the new patch set (#9). Change subject: IMPALA-4006: dangerous rm -rf statements in scripts

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-08-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-08-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 4: Alex, can you please do the +2 review? Thanks. -- To view, visit

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-08-26 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal() .. Patch Set 4: Code-Review+1 Thanks for the review Matt. Carrying +1 -- To view,

[Impala-ASF-CR] IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

2016-08-26 Thread Bharath Vissapragada (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4125 to look at the new patch set (#4). Change subject: IMPALA-3949: Log the error message in FileSystemUtil.copyToLocal()

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Zoltan Ivanfi (Code Review)
Hello Michael Ho, Internal Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4078 to look at the new patch set (#8). Change subject: IMPALA-4006: dangerous rm -rf statements in scripts

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-26 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3776: fix 'describe formatted' for Avro tables

2016-08-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables .. Patch Set 2: Code-Review+1 (3 comments) Thank you for the review. I addressed the comments and will

[Impala-ASF-CR] IMPALA-3776: fix 'describe formatted' for Avro tables

2016-08-26 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4126 to look at the new patch set (#2). Change subject: IMPALA-3776: fix 'describe formatted' for Avro tables ..

[Impala-ASF-CR] IMPALA-3938: Disallow implicit references between nested collections.

2016-08-26 Thread Christopher Channing (Code Review)
Christopher Channing has uploaded a new patch set (#5). Change subject: IMPALA-3938: Disallow implicit references between nested collections. .. IMPALA-3938: Disallow implicit references between nested collections. The Bug:

[Impala-ASF-CR] IMPALA-4027:Memory leak with ExprCtxs not free

2016-08-26 Thread hewenting (Code Review)
hewenting has uploaded a new change for review. http://gerrit.cloudera.org:8080/4132 Change subject: IMPALA-4027:Memory leak with ExprCtxs not free .. IMPALA-4027:Memory leak with ExprCtxs not free Change-Id:

[Impala-ASF-CR] IMPALA-3938: Disallow implicit references between nested collections.

2016-08-26 Thread Christopher Channing (Code Review)
Christopher Channing has posted comments on this change. Change subject: IMPALA-3938: Disallow implicit references between nested collections. .. Patch Set 4: Thanks for the feedback, so are you asking me to replace what I