Internal Jenkins has posted comments on this change.
Change subject: Remove dead and untested code
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3989
To unsubscribe, visit
Internal Jenkins has submitted this change and it was merged.
Change subject: Remove dead and untested code
..
Remove dead and untested code
Remove some code that the code coverage build revealed was untested.
It is all dead,
Tim Armstrong has posted comments on this change.
Change subject: Remove dead and untested code
..
Patch Set 1:
I did manually verify that the functions didn't have any callsites, so I'm
convinced it's actually dead.
Jim Apple has posted comments on this change.
Change subject: Remove dead and untested code
..
Patch Set 1:
With and without shared objects? With clang and gcc for all of the modes? With
and without the gold linker?
This may
Tim Armstrong has posted comments on this change.
Change subject: Remove dead and untested code
..
Patch Set 1:
It builds on ASAN, debug and release. Did you have any other compilation modes
in mind?
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: Remove dead and untested code
..
Patch Set 1: Code-Review+2
Nice!
--
To view, visit http://gerrit.cloudera.org:8080/3989
To unsubscribe, visit
Jim Apple has posted comments on this change.
Change subject: Remove dead and untested code
..
Patch Set 1:
If this build under all of our different compilation modes, I'm happy with it.
--
To view, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3989
Change subject: Remove dead and untested code
..
Remove dead and untested code
Remove some code that the code coverage build revealed
