[GitHub] jixuan1989 merged pull request #3: fix time zone bug in different region

jixuan1989 merged pull request #3: fix time zone bug in different region URL: https://github.com/apache/incubator-iotdb/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log

Re: Skipping tests

Hi, Now we have to use `-Dmaven.test.skip=true` to skip all the Tests (but the command will also skip compiling all the Test java files). I also think that let `-DskipTests` works is important, because it just skips Tests while still compiling the Test files first. In this way, we can find

Re: ASF Headers including Year ...

Hi, I think you can solve that by just adding “.git" to RAT exclusions. [1] Thanks, Justin 1. http://creadur.apache.org/rat/apache-rat/

Re: ASF Headers including Year ...

I use rat plugin and run `mvn clean rat:check`, it failed and its output is: [ERROR] Failed to execute goal org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check (default-cli) on project root: Too many unapproved licenses: 63 -> [Help 1] I check rat file under target directory, there are

Re: ASF Headers including Year ...

Can rat-Maven-plugin append header to java file? I check the document, it seems that rat plugin is used to check header? Xu Yi On 1/19/2019 00:52，Christofer Dutz wrote： Generally I had already setup everything correctly for Apache incubator projects, so just place the header Justin posted and

Re: ASF Headers including Year ...

Generally I had already setup everything correctly for Apache incubator projects, so just place the header Justin posted and use that. And probably replace the header plugin with the rat-Maven-plugin. Chris Outlook for Android herunterladen

Re: ASF Headers including Year ...

Hi, > Does maven provide some plugins to append header? Please take care when doing this you do not want to replace any 3rd parties files headers, they must be left intact. Thanks, Justin

Re: ASF Headers including Year ...

Hi Does maven provide some plugins to append header? I used the following plugin before, but it will add line break character which cannot pass code style check. com.mycila license-maven-plugin 3.0 | | 徐毅 | | xuyith...@126.com | 签名由网易邮箱大师定制 On 1/19/2019 00:30，Justin Mclean wrote： HI,

Re: [BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

Hi, > I have create a pull request from my forked repo, will it trigger the jenkins > pipeline? If you are one of the initial committers of the project it would be best to work in a branch not a fork of the project. Thanks, Justin

Re: ASF Headers including Year ...

HI, That the wrong header. You need to use this header[1], it explicitly doesn't contain a copyright line. Thanks, Justin 1. https://www.apache.org/legal/src-headers.html#headers

Re: [BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

Oh, I see. Thank you for your patience. On 1/18/2019 23:40，Christofer Dutz wrote： Hi Xu, Well the thing is, in order to be able to run the PRs of any user, we would need to provide user credentials of a user in Jenkins as the ASF has so many API calls with Github that we can't use the anonymous

Re: [BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

Hi Xu, Well the thing is, in order to be able to run the PRs of any user, we would need to provide user credentials of a user in Jenkins as the ASF has so many API calls with Github that we can't use the anonymous API access. It's not desirable that we have to do this. I would personally not do

Re: [BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

So we should create a new branch in apache/incubator-iotdb and create a pr to master. Only in this circumstance, it will trigger jenkins? On 1/18/2019 23:19，Christofer Dutz wrote： Nope ... only code in the official Apache repo will trigger builds. We discussed this on the build@apache list and I

[GitHub] MyXOF commented on issue #3: fix time zone bug in different region

MyXOF commented on issue #3: fix time zone bug in different region URL: https://github.com/apache/incubator-iotdb/pull/3#issuecomment-455585166 Can anyone review and approve this pr? This is an automated message from the

Re: [BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

Nope ... only code in the official Apache repo will trigger builds. We discussed this on the build@apache list and I wouldn't want to run outside build-jobs on Apache infrastructure. If you want that, you could probably ask Infra to enable travis integration ... I will gladly provide a

Re: [BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

Hi, I have create a pull request from my forked repo, will it trigger the jenkins pipeline? Thanks Xu Yi | | On 1/18/2019 22:54，Christofer Dutz wrote： OK ... so now you guys should be setup ... Jenkins automatically builds all branches that contain a Jenkinsfile. So if you branch off

Re: Time-Zone sensitive tests?

Hi, I create a pull request to fix this problem. I'am sorry that I didn't test in different regions in last modification. Now it will work in every region around the world. Thanks Xu Yi On 1/18/2019 16:32，徐毅 wrote： Hi It seem to be a bug,wait a moment. I'll fix the problem right away.

[GitHub] MyXOF opened a new pull request #3: fix time zone bug in different region

MyXOF opened a new pull request #3: fix time zone bug in different region URL: https://github.com/apache/incubator-iotdb/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

OK ... so now you guys should be setup ... Jenkins automatically builds all branches that contain a Jenkinsfile. So if you branch off master, this will automatically be built and tested. - You can find all IoTDB jobs here [1] - The master build is here [2] - Snapshots are deployed here [3] (As

Re: ASF Headers including Year ...

Yeah, that's for lawyers.  :-) On 1/18/2019 9:30 AM, Christofer Dutz wrote: > Hi Kevin, > > Well if you set the Inception-Year in the pom, > maven generates this line in the generated artifacts. > I have never seen the year appear in every file header. > > Chris > > > > Am 18.01.19, 15:28

[BUILD-UNSTABLE]: Job 'IoTDB-Pipeline/master [master] [1]'

BUILD-UNSTABLE: Job 'IoTDB-Pipeline/master [master] [1]': Check console output at "https://builds.apache.org/job/IoTDB-Pipeline/job/master/1/;>IoTDB-Pipeline/master [master] [1]"

Skipping tests

Hi all, After encountering the time-zone problem I wanted to run the build without tests. However this wasn’t directly possible. Even if I clicked on “skip tests” in IntelliJ tests were executed, so I manually added “-DskipTests”, but still the tests were executed. Looking at projects like

Re: ASF Headers including Year ...

I just had a look at PLC4X. So we have the inception.year set in the pom and every artifact maven builds and hereby every artifact we release contains a META-INF/NOTICE file with this content: -- PLC4J: Utils: WireShark Utils Copyright 2017-2019 The Apache Software Foundation This

Re: Time-Zone sensitive tests?

Hi It seem to be a bug,wait a moment. I'll fix the problem right away. Thanks Xu Yi | | 徐毅 | | xuyith...@126.com | 签名由网易邮箱大师定制 On 1/18/2019 15:19，Christofer Dutz wrote： Hi, I’m getting these test errors when trying to build the current version: [ERROR] Failures: [ERROR]

Re: ASF Headers including Year ...

Hi Kevin, Well if you set the Inception-Year in the pom, maven generates this line in the generated artifacts. I have never seen the year appear in every file header. Chris Am 18.01.19, 15:28 schrieb "Kevin A. McGrail" : On 1/18/2019 9:17 AM, Christofer Dutz wrote: > Hi all, >

Re: ASF Headers including Year ...

On 1/18/2019 9:17 AM, Christofer Dutz wrote: > Hi all, > > as I was setting up things so Jenkins will build the project, I noticed that > you have some strange plugin in the build that enforces headers quite > strictly. > I don’t have any objections to that, however it marked my usual ASF

Re: ASF Headers including Year ...

Hi, We have a asf.header file in our project, we use this as asf header in codes. Maybe we omit some files to use header like "Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)". Are there many files use old header? I can help to delete them. Thanks Xu Yi On 1/18/2019

Time-Zone sensitive tests?

Hi, I’m getting these test errors when trying to build the current version: [ERROR] Failures: [ERROR] DatetimeUtilsTest.testConvertDatetimeStrToLongWithMS:106 expected:<1546413207689> but was:<1546438407689> [ERROR] DatetimeUtilsTest.testConvertDatetimeStrToLongWithoutMS:83

ASF Headers including Year ...

Hi all, as I was setting up things so Jenkins will build the project, I noticed that you have some strange plugin in the build that enforces headers quite strictly. I don’t have any objections to that, however it marked my usual ASF headers as invalid because they didn’t have the first line in

Re: ask for webhooks for iotdb repository

So I'm currently setting IoTDB up that it will build on Asf Jenkins As this is the only option for having the build deploy SNAPSHOTs of IoTDB Chris Am 18.01.19, 07:23 schrieb "徐毅" : Hi, I cannot find secret of CodeCov, it only provides a upload token which is

Re: Permissions about confluence

Thanks, I have the permission now. hxd is me, which is short to Huang XiangDong. :D Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Christofer Dutz 于2019年1月18日周五 下午9:00写道： > Done, > > I also added hxd a he/she wasn't on the

Re: Permissions about confluence

Done, I also added hxd a he/she wasn't on the list yet. Chris Am 18.01.19, 13:46 schrieb "Xiangdong Huang" : Hi, If possible, could you give one of us (`zhaoxinyi`, `qiaojialin` or `hxd`) the permission temporarily so that we can organize the document catalog on the

[GitHub] jixuan1989 commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo

jixuan1989 commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo URL: https://github.com/apache/incubator-iotdb/pull/2#discussion_r249033480 ## File path: Readme.md ## @@ -1,10 +1,10 @@ # IoTDB

[GitHub] jixuan1989 commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo

jixuan1989 commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo URL: https://github.com/apache/incubator-iotdb/pull/2#discussion_r249031122 ## File path: Readme.md ## @@ -1,10 +1,10 @@ # IoTDB

Re: Permissions about confluence

Hi, If possible, could you give one of us (`zhaoxinyi`, `qiaojialin` or `hxd`) the permission temporarily so that we can organize the document catalog on the sidebar well. Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院

[GitHub] MyXOF commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo

MyXOF commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo URL: https://github.com/apache/incubator-iotdb/pull/2#discussion_r248965909 ## File path: Readme.md ## @@ -1,10 +1,10 @@ # IoTDB

[GitHub] MyXOF commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo

MyXOF commented on a change in pull request #2: change release, repo size and download label in readme after migrating to apache repo URL: https://github.com/apache/incubator-iotdb/pull/2#discussion_r248965909 ## File path: Readme.md ## @@ -1,10 +1,10 @@ # IoTDB

[GitHub] MyXOF commented on a change in pull request #2: change some labels in readme after migrating to apache repo

MyXOF commented on a change in pull request #2: change some labels in readme after migrating to apache repo URL: https://github.com/apache/incubator-iotdb/pull/2#discussion_r248965231 ## File path: Readme.md ## @@ -1,10 +1,10 @@ # IoTDB [![Build

Re: Permissions about confluence

Hi all, I just had a look and it seems only Administrators have the permissions to change the side bar ... so far I added all new people as normal "Developers". Should I give everyone full permissions? Chris Am 18.01.19, 08:50 schrieb "Justin Mclean" : Hi, > 2. Lack of

[GitHub] wujysh commented on a change in pull request #2: change some labels in readme after migrating to apache repo

wujysh commented on a change in pull request #2: change some labels in readme after migrating to apache repo URL: https://github.com/apache/incubator-iotdb/pull/2#discussion_r248959368 ## File path: Readme.md ## @@ -1,10 +1,10 @@ # IoTDB [![Build

[GitHub] Beyyes commented on a change in pull request #2: change some labels in readme after migrating to apache repo

Beyyes commented on a change in pull request #2: change some labels in readme after migrating to apache repo URL: https://github.com/apache/incubator-iotdb/pull/2#discussion_r248958645 ## File path: Readme.md ## @@ -1,10 +1,10 @@ # IoTDB [![Build