Re: [DISCUSS] Add the components definition in JIRA template

2020-01-24 Thread Xiangdong Huang
+ 1 jincheng sun 于2020年1月24日 周五下午12:33写道: > I would like to bring up a VOTE mail to make the final decision If there no > objections. > > What do you think? > > Best, > Jincheng > - > Twitter: https://twitter.com/sunjincheng121 > - > > > jincheng sun 于2020年1月17日周五

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-24 Thread Jialin Qiao
Hi, +1 for a vote -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院 > -原始邮件- > 发件人: "jincheng sun" > 发送时间: 2020-01-24 12:32:22 (星期五) > 收件人: dev@iotdb.apache.org > 抄送: > 主题: Re: [DISCUSS] Add the components definition in JIRA template &

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-16 Thread jincheng sun
Great thanks for adding more relationship info about `Merge` and `Storage`. @Xiangdong ! As : > (now query engine is in the storage engine..) Merge is a submodule of storage engine and query engine. I think `query engine` and `storage engine` is make sense to me. Here only a suggestion that

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-16 Thread Xiangdong Huang
Hi, Thanks jincheng and jialin. Sorry for absence of the discussion because of busy work these days.. Some comments: > Core > Core/TsFile > Core/Merge > Core/Storage > Core/WAL Not so clearly.. maybe TsFile, WAL, Storage Engine, Query Engine? (now query engine is in the storage engine..)

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-16 Thread Jialin Qiao
Hi Jincheng, Thank you! Looks good :) jincheng sun 于2020年1月16日周四 下午4:01写道: > Thanks for your explanation! @Jialin > > I thought about the composition of our components from the external system, > the user level, to the IoTDB bottom-level implementation to the auxiliary > tools, and I adjusted

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-16 Thread jincheng sun
Thanks for your explanation! @Jialin I thought about the composition of our components from the external system, the user level, to the IoTDB bottom-level implementation to the auxiliary tools, and I adjusted a little based on yours. as follows: 1. --Connectors- Connectors

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-15 Thread Jialin Qiao
Hi, WAL has an independent physical layout that has nothing to do with TsFile. It is used in the writing process and recovering in IoTDB. It could be merged into Storage components. I'm not sure whether I leave out some components, so I add an Other and therefore can not give an example...

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-15 Thread jincheng sun
Sorry for the late reply, I just came back from team outing. Thanks for adding more detail information. I have two questions then: - Is WAL a write strategy for TsFlie, can WAL be incorporated into other components and what is the reason for being a separate component? - Can you give an example

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-09 Thread Jialin Qiao
Hi, Sure, maybe a bit more... - TsFile : A columnar file format that has flexible schema and data management for time series. - Storage : The storage engine of IoTDB, including writing to memtable (buffer), flushing, system recovery, and memtable management. - Query : The query process in

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-09 Thread jincheng sun
Hi, @Xiangdong thank you for helping to clarify my original intention. you are right, I really want to list some components to let users choose which component the given issue belongs to. @Jialin I think approach 4 would be more meaningful for IoTDB. Could you please add the detailed description

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-09 Thread Xiangdong Huang
> No that is not the Apache Way. No one should be in charge of an area I think Jincheng's mean is, we can list some components to let users choose which component the given issue belongs to. As for which components should be listed, we need to have a discussion. > No one should be in charge of

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-09 Thread jincheng sun
> No that is not the Apache Way. No one should be in charge of an area. Oh, great thanks for correcting me Justin, maybe it's my language expression problems. I mean some contributors and committers will be very interested in some components, then spend more time, and be more familiar with the

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-09 Thread Jialin Qiao
Hi, Attaching a component of each issue will help contributors quickly locate the problem. This has nothing to do with specifying someone in a certain area, it just a classification of issues :) I would like to give an approach 4 - TsFile (module: tsfile) - Storage (StorageEngine in server

Re: [DISCUSS] Add the components definition in JIRA template

2020-01-09 Thread Justin Mclean
Hi, > When our community grows stronger, each\ module may have some specific person > in charge. No that is not the Apache Way. No one should be in charge of an area. Thanks, Justin

[DISCUSS] Add the components definition in JIRA template

2020-01-09 Thread jincheng sun
Hi folks, Currently we can not select one components when create a JIRA. [1]. At present, this problem is not obvious because there are not many contributors of IoTDB, and the active committers need to have a certain understanding of each module. When our community grows stronger, each module may