Re: rename some classes in source codes before releasing

2022-06-25 Thread Jialin Qiao
Hi, Some parameters are changed for consistent iotdb-engine.properties: rpc_address -> rpc_ip iotdb-confignode.properties: target_confignode -> config_nodes Column of Show Cluster and Show Regions: HostAdress -> Host https://github.com/apache/iotdb/pull/6447 Please take a look. Thanks,

Re: rename some classes in source codes before releasing

2022-06-25 Thread Jialin Qiao
Hi, Here are some could be renamed: server module -> datanode module iotdb-engine.properties -> iotdb-datanode.properties start-new-server.sh -> start-standalone.sh stop-new-server.sh -> stop-standalone.sh Thanks, — Jialin Qiao Apache IoTDB PMC Yuan Tian 于2022年6月26日周日

Re: rename some classes in source codes before releasing

2022-06-25 Thread Yuan Tian
Hi, Capitalizing MPP may be better. On Sat, Jun 25, 2022 at 11:58 PM Jialin Qiao wrote: > > Hi, > > I'm renaming the DataBlockManager related, please leave this for me > > dataBlockManagerEndPoint -> mppDataExchangeEndPoint > > Thanks, > — > Jialin Qiao > Apache IoTDB PMC > > >

Re: rename some classes in source codes before releasing

2022-06-25 Thread Jialin Qiao
Hi, I'm renaming the DataBlockManager related, please leave this for me dataBlockManagerEndPoint -> mppDataExchangeEndPoint Thanks, — Jialin Qiao Apache IoTDB PMC Xiangdong Huang 于2022年6月25日周六 23:19写道: > Hi, > > When reading the source codes on the master branch, > I noticed

rename some classes in source codes before releasing

2022-06-25 Thread Xiangdong Huang
Hi, When reading the source codes on the master branch, I noticed that some classes and fields names can be renamed for better understanding. Better to rename these names before releasing because I am not sure whether the generated thrift codes are compatible if we modify them later. e.g.,