Hi, Chris
In the latest version of thrift, there are some improvements we'd like to make,
For example, https://issues.apache.org/jira/browse/THRIFT-5502 will down-cycled
"connection reset" warn logs.
+1 for upgrading thrift.
Thanks
Xinyu Tan
> 2023年7月31日 19:50，Christofer Dutz
Ok .. and now I know why we’re at 0.14.1.
Turns out 0.17.0 has an issue in its MANIFEST.mf which causes our build to fail.
According to Maven-Central do all older versions till 0.14.1 have known
vulnerabilities, so we shouldn’t choose any of those.
Turns out that 0.14.1 is the sweet spot where
So, inspecting all versions between 0.14.1 and 0.18.1 it turns out 0.17.0 was
the last one able to be used in Java 8 applications.
I therefore updated my branch to that version.
Chris
Von: Christofer Dutz
Datum: Montag, 31. Juli 2023 um 15:53
An: dev@iotdb.apache.org
Betreff: AW: [DISCUSS]
Hi all,
well … cancel that …
it seems that Thrift 0.18.1 is compiled with newer java versions and we can no
longer, consume the jar in the Java 8 build.
Chris
Von: Christofer Dutz
Datum: Montag, 31. Juli 2023 um 15:50
An: dev@iotdb.apache.org
Betreff: AW: [DISCUSS] Updating to a newer Thrift
Aaaah … ok
That’s an explanation … I did try the build in my branch with 0.18.1 and it
worked nicely.
Chris
Von: Yuan Tian
Datum: Montag, 31. Juli 2023 um 14:45
An: dev@iotdb.apache.org
Betreff: Re: [DISCUSS] Updating to a newer Thrift version?
Hi Chris,
I remember that we tried to upgrade
Hi Chris,
I remember that we tried to upgrade to 0.15.X before, but the performance
declined. I'm not sure about that? Anyone else remember?
Best,
---
Yuan Tian
Hi all,
While working on the cleanup of the build, I noticed we’re working with Thrift
in version 0.14.1 however the latest version is 0.18.1
Is there a reason we’re sticking to a two-year older version than the newest?
If not: with the pom-cleanup refactoring it should be a thing of minutes
And again sorry,
turns out I selected the branches the wrong way around …
this is the right PR:
https://github.com/apache/iotdb/pull/10742
Chris
Von: Christofer Dutz
Datum: Montag, 31. Juli 2023 um 09:33
An: dev@iotdb.apache.org
Betreff: AW: [DISCUSS] Refactor the way we're building/using
Hi Folks,
So, I’ve literally spent all weekend working on my refactoring and must admit
I’m quite happy with the results.
However, did I decide to take the PR out of this repo and work on a fork in my
GitHub account as I didn’t want to swamp you folks with build failure emails.
So, I closed
