SPI observation: EventFilter lifecycle

2007-11-01 Thread Julian Reschke
Hi, here are some thoughts about the current SPI EventFilter interface: Proposal: document that getEvents only needs to accept EventFilter objects created by the same SPI implementation for the same SessionInfo (this reflects reality in JCR2SPI) Proposal: remove special case in getEvents

[OCM] Dynamic Mixin Support

2007-11-01 Thread Padraic Hannon
I have been reviewing the implementation I submitted for mixin support in JCR-1100 and am struggling with how to proceed. On the one hand I think the implementation that was submitted is nice since it has some amount of type safety and gives the developer the ability to cast objects. On

Re: [jira] Commented: (JCR-1154) Database Data Store

2007-11-01 Thread Esteban Franqueiro
Hi Thomas. - please use spaces, not tabs (Jackrabbit consistently uses spaces) - please don't use import ...* - byte b[] byte[] b - public is not required in interfaces - return does not require (..) To fix such problems, I use Checkstyle. If you like I can post the configuration I use.

Re: SPI observation: EventFilter lifecycle

2007-11-01 Thread Jukka Zitting
Hi, On 11/1/07, Julian Reschke [EMAIL PROTECTED] wrote: Proposal: document that getEvents only needs to accept EventFilter objects created by the same SPI implementation for the same SessionInfo (this reflects reality in JCR2SPI) +1 There's no guarantee that a remote implementation can