[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1331043735 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStore.java: ## @@ -38,12 +38,13 @@ public class FlatFileStore

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1331040826 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/MultithreadedTraverseWithSortStrategy.java: ## @@ -234,18 +230,42 @@ p

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1331036903 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/MergeIncrementalFlatFileStore.java: ## @@ -0,0 +1,155 @@ +/* +

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
amit-jain commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330971336 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static St

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
amit-jain commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330971336 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static St

[GitHub] [jackrabbit-oak] amit-jain commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
amit-jain commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330962413 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java: ## @@ -207,6 +212,29 @@ private List buildFla

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330636256 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalFlatFileStoreStrategy.java: ## @@ -0,0 +1,181 @@ +/

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1329681323 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseWithSortStrategy.java: ## @@ -92,17 +93,22 @@ class TraverseWi

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330619473 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static Stri

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330618196 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -244,73 +255,83 @@ public FlatFil

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330598752 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/NodeStateEntryWriter.java: ## @@ -118,14 +122,53 @@ public static Stri

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1330588714 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java: ## @@ -244,73 +255,83 @@ public FlatFil

[GitHub] [jackrabbit-oak] fabriziofortino opened a new pull request, #1127: OAK-10449: bump zookeeper to v3.6.2 (aligned with solrj version)

2023-09-19 Thread via GitHub
fabriziofortino opened a new pull request, #1127: URL: https://github.com/apache/jackrabbit-oak/pull/1127 Update is needed because there are 2 major vulnerabilities in 3.4.10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jackrabbit-oak] mbaedke commented on pull request #1126: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-19 Thread via GitHub
mbaedke commented on PR #1126: URL: https://github.com/apache/jackrabbit-oak/pull/1126#issuecomment-1725335651 @mreutegg, I hope this addresses your change requests. I messed up the old PR#1051 by merging trunk with rebase. -- This is an automated message from the Apache Git Service. To r

[GitHub] [jackrabbit-oak] mbaedke closed pull request #1051: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-19 Thread via GitHub
mbaedke closed pull request #1051: OAK-10377: Checked-out state of non-versionable nodes is not handled … URL: https://github.com/apache/jackrabbit-oak/pull/1051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [jackrabbit-oak] mbaedke opened a new pull request, #1126: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-19 Thread via GitHub
mbaedke opened a new pull request, #1126: URL: https://github.com/apache/jackrabbit-oak/pull/1126 …correctly Added versionability check, test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [jackrabbit-oak] sonarcloud[bot] commented on pull request #1051: OAK-10377: Checked-out state of non-versionable nodes is not handled …

2023-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #1051: URL: https://github.com/apache/jackrabbit-oak/pull/1051#issuecomment-1725272897 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1329889181 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalStoreBuilder.java: ## @@ -0,0 +1,152 @@ +/* + * Lic

[GitHub] [jackrabbit-oak] mbaedke merged pull request #1125: Merging trunk

2023-09-19 Thread via GitHub
mbaedke merged PR #1125: URL: https://github.com/apache/jackrabbit-oak/pull/1125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrab

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1329859861 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalFlatFileStoreStrategy.java: ## @@ -0,0 +1,181 @@ +/

[GitHub] [jackrabbit-oak] mbaedke opened a new pull request, #1125: Merging trunk

2023-09-19 Thread via GitHub
mbaedke opened a new pull request, #1125: URL: https://github.com/apache/jackrabbit-oak/pull/1125 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1329857417 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/StoreAndSortStrategy.java: ## @@ -42,31 +45,36 @@ import static org.

[jira] [Updated] (JCRVLT-718) DocumentViewXmlValidator.validateEnd(...) called with wrong nodePath

2023-09-19 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/JCRVLT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated JCRVLT-718: --- Resolution: Fixed Status: Resolved (was: Patch Available) Fixed in https://github.c

[GitHub] [jackrabbit-filevault] kwin merged pull request #313: JCRVLT-718 fix DocViewParserHandler.endDocViewNode's nodePath argument

2023-09-19 Thread via GitHub
kwin merged PR #313: URL: https://github.com/apache/jackrabbit-filevault/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackra

[GitHub] [jackrabbit-oak] thomasmueller commented on pull request #1094: OAK-10424 add support for INSECURE RESULT SIZE and INSECURE FACETS query options and rep:insecureQueryOptions privilege

2023-09-19 Thread via GitHub
thomasmueller commented on PR #1094: URL: https://github.com/apache/jackrabbit-oak/pull/1094#issuecomment-1725148719 We discussed this in the team today, and came to the conclusion that we also need somebody from the security component to review the change, before we can deploy it. I'm sorr

[jira] [Assigned] (JCR-4954) Problem with WebDav Client and Repository Server Deployment Model

2023-09-19 Thread Manfred Baedke (Jira)
[ https://issues.apache.org/jira/browse/JCR-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke reassigned JCR-4954: --- Assignee: Manfred Baedke (was: Claus Köll) > Problem with WebDav Client and Repository Server

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
nit0906 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1329800056 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalStoreBuilder.java: ## @@ -0,0 +1,152 @@ +/* + * Lic

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #1123: OAK-10429: Implementation for IncrementalFFS

2023-09-19 Thread via GitHub
tihom88 commented on code in PR #1123: URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1329681323 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/TraverseWithSortStrategy.java: ## @@ -92,17 +93,22 @@ class TraverseWi