[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529463
]
Ard Schrijvers commented on JCR-1064:
-
Sorry for not getting back to you sooner. I was distracted with other work
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529468
]
Marcel Reutegger commented on JCR-1064:
---
I attached the patch with the previous comment ;)
I already did some
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529478
]
Marcel Reutegger commented on JCR-1064:
---
IndexFormatVersion now contains the logic to decide which format
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528684
]
Ard Schrijvers commented on JCR-1064:
-
Have been thinking this issue over, since I think it is quite important
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524655
]
Ard Schrijvers commented on JCR-1064:
-
I just found another issue with the MultiIndex. The recovery code also
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524081
]
Ard Schrijvers commented on JCR-1064:
-
We could move the code for the index format check to the multiIndex
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523173
]
Marcel Reutegger commented on JCR-1064:
---
I am doing the tests, with the parent index in old format, and the
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523176
]
Ard Schrijvers commented on JCR-1064:
-
well, that just means that there is no appropriate test
You mean that
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523202
]
Marcel Reutegger commented on JCR-1064:
---
You mean that the tests just happen to work with new and old format by
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523205
]
Ard Schrijvers commented on JCR-1064:
-
Ah, I see. That's where the misunderstanding is. Unless otherwise
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523228
]
Ard Schrijvers commented on JCR-1064:
-
Implemented the new indexing format again. There is a subtle difficulty
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522978
]
Ard Schrijvers commented on JCR-1064:
-
Marcel Reutegger wrote:
One more thing, pleaseinclude a check in
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523020
]
Marcel Reutegger commented on JCR-1064:
---
Just a couple of minor issues that need to be resolved first:
- Please
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523033
]
Ard Schrijvers commented on JCR-1064:
-
Aaah I am sorry for the system.out. I replaced a patch and did put a
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522724
]
Bertrand Delacretaz commented on JCR-1064:
--
...ps : is it possible to mark the current patch as deprecated
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522443
]
Ard Schrijvers commented on JCR-1064:
-
Don't think it is much critics :-)
I'll try to do your suggested changes
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522442
]
Christoph Kiehl commented on JCR-1064:
--
I like the patch so far. Just a few comments:
LuceneQueryBuilder:
- I
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522461
]
Marcel Reutegger commented on JCR-1064:
---
Ard, thanks a lot for the patch, good work.
Here are some more
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522466
]
Ard Schrijvers commented on JCR-1064:
-
Not closing SearchIndex.getIndexReader(), that is an ugly mistake. Correct
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522467
]
Ard Schrijvers commented on JCR-1064:
-
ps : is it possible to mark the current patch as deprecated or something?
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522481
]
Ard Schrijvers commented on JCR-1064:
-
I am now creating a new IndexFormatVersion class (think IndexFormatVersion
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522508
]
Ard Schrijvers commented on JCR-1064:
-
Hmmm, having a problem.
When the index is empty at startup, the
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522526
]
Marcel Reutegger commented on JCR-1064:
---
ps : is it possible to mark the current patch as deprecated or
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522529
]
Ard Schrijvers commented on JCR-1064:
-
Added patch again.
The problem is that in de SearchIndex in the doInti()
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522535
]
Marcel Reutegger commented on JCR-1064:
---
We should probably extract the initial index logic from the MultiIndex.
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522536
]
Marcel Reutegger commented on JCR-1064:
---
One more thing, please include a check in SearchIndex.doInit(), which
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522537
]
Ard Schrijvers commented on JCR-1064:
-
Just had my patch ready (again :-) )
Is it an idea to add the patch, and
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522540
]
Ard Schrijvers commented on JCR-1064:
-
I am now testing for the parent query handler indexFormatVersion. If they
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522547
]
Ard Schrijvers commented on JCR-1064:
-
By the way: Are you really sure that it matters wether the parent query
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522092
]
Ard Schrijvers commented on JCR-1064:
-
According the thread in [1], we have chosen to implement the backwards
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522113
]
Ard Schrijvers commented on JCR-1064:
-
IndexingConfiguration might be null when not configured, so the above
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522132
]
Ard Schrijvers commented on JCR-1064:
-
AFAICS, the matchAllScorer won't be needed anymore with the new index
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522147
]
Ard Schrijvers commented on JCR-1064:
-
1 note:
In LuceneQueryBuilder.createQuery:
public static Query
[
https://issues.apache.org/jira/browse/JCR-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519975
]
Marcel Reutegger commented on JCR-1064:
---
You should be just fine. Only the field FieldNames.FULLTEXT is packaged
34 matches
Mail list logo
