AW: [VOTE] Release Apache Jackrabbit 2.15.8

2017-11-14 Thread KÖLL Claus 
+1

greets
claus

Re: [VOTE] Release Apache Jackrabbit 2.15.8

2017-11-14 Thread Amit Jain 
+1 Release this package as Apache Jackrabbit 2.15.8

Thanks
Amit

On Sun, Nov 12, 2017 at 8:17 PM, Julian Reschke  wrote:
> A candidate for the Jackrabbit 2.15.8 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/2.15.8/
>
> The release candidate is a zip archive of the sources in:
>
> https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.15.8/
>
> The SHA1 checksum of the archive is
> b9d455fc1ed2f4e9294de6120038f0f9faaab8cf.
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
> $ sh check-release.sh 2.15.8 b9d455fc1ed2f4e9294de6120038f0f9faaab8cf
>
> Please vote on releasing this package as Apache Jackrabbit 2.15.8.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
> [ ] +1 Release this package as Apache Jackrabbit 2.15.8
> [ ] -1 Do not release this package because...
>
> Best regards, Julian

Re: [VOTE] Release Apache Jackrabbit 2.15.8

2017-11-14 Thread Robert Munteanu 
On Sun, 2017-11-12 at 15:47 +0100, Julian Reschke wrote:
> Please vote on releasing this package as Apache Jackrabbit 2.15.8.

+1

[INFO] 

[INFO] Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T10:58:13+03:00)
[INFO] OS name: "linux", version: "4.13.11-0-default", arch: "amd64",
family: "unix"
[INFO] Java version: 1.8.0_151, vendor: Oracle Corporation
[INFO] 


Robert

[jira] [Commented] (JCR-4213) It is useful to return an error code with DataStoreException when a record is not found

2017-11-14 Thread Vikas Saurabh (JIRA) 

[ 
https://issues.apache.org/jira/browse/JCR-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251169#comment-16251169
 ] 

Vikas Saurabh commented on JCR-4213:


[~reschke],
bq. Does this have to be done before we branch 2.16? (Scheduled Nov 20)
I'm almost convinced that we don't need this at all - but if we do, then yes, 
it would need to be done before the cut (so, that it can be included in 
OAK-6925).

> It is useful to return an error code with DataStoreException when a record is 
> not found
> ---
>
> Key: JCR-4213
> URL: https://issues.apache.org/jira/browse/JCR-4213
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-data
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 2.16
>
> Attachments: JCR-4213.patch
>
>
> To help with cases like OAK-6935, it would be useful if 
> {{DataStoreException}}, on best effort basis, provides and error code too.
> An example stack that OAK-6935 logs currently looks like:
> {noformat}
>  
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl
>  Exception occurred while attempting to delete blob 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f#4694
> org.apache.jackrabbit.core.data.DataStoreException: Record 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f does not 
> exist
>   at 
> org.apache.jackrabbit.core.data.AbstractDataStore.getRecord(AbstractDataStore.java:58)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.OakFileDataStore.getRecordForId(OakFileDataStore.java:259)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getRecordForId(DataStoreBlobStore.java:519)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.countDeleteChunks(DataStoreBlobStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl.purgeBlobsDeleted(ActiveDeletedBlobCollectorFactory.java:224)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService.lambda$initializeActiveBlobCollector$0(LuceneIndexProviderService.java:760)
> ...
> ...
> {noformat}
> /cc [~amjain]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JCR-4213) It is useful to return an error code with DataStoreException when a record is not found

2017-11-14 Thread Vikas Saurabh (JIRA) 

[ 
https://issues.apache.org/jira/browse/JCR-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251220#comment-16251220
 ] 

Vikas Saurabh commented on JCR-4213:


bq. Is this an API change? Otherwise I don't see why we couldn't easily 
backport it...
Not completely sure. We're adding a new method (getErrorCode) and a few ctors 
to DataStoreException. DataStoreException is available in oak (to be consumed) 
- so, my guess is that it's indeed an API. But, yeah, if at all, it won't be a 
major bump.

> It is useful to return an error code with DataStoreException when a record is 
> not found
> ---
>
> Key: JCR-4213
> URL: https://issues.apache.org/jira/browse/JCR-4213
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-data
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 2.16
>
> Attachments: JCR-4213.patch
>
>
> To help with cases like OAK-6935, it would be useful if 
> {{DataStoreException}}, on best effort basis, provides and error code too.
> An example stack that OAK-6935 logs currently looks like:
> {noformat}
>  
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl
>  Exception occurred while attempting to delete blob 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f#4694
> org.apache.jackrabbit.core.data.DataStoreException: Record 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f does not 
> exist
>   at 
> org.apache.jackrabbit.core.data.AbstractDataStore.getRecord(AbstractDataStore.java:58)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.OakFileDataStore.getRecordForId(OakFileDataStore.java:259)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getRecordForId(DataStoreBlobStore.java:519)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.countDeleteChunks(DataStoreBlobStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl.purgeBlobsDeleted(ActiveDeletedBlobCollectorFactory.java:224)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService.lambda$initializeActiveBlobCollector$0(LuceneIndexProviderService.java:760)
> ...
> ...
> {noformat}
> /cc [~amjain]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (JCR-4213) It is useful to return an error code with DataStoreException when a record is not found

2017-11-14 Thread Vikas Saurabh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/JCR-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vikas Saurabh updated JCR-4213:
---
Attachment: JCR-4213.patch

[~amjain], I'm attaching [^JCR-4213.patch] for completeness. But, while working 
on this (and OAK-6935), it seemed to me that we can probably skip this one as 
"Won't fix" or later.

> It is useful to return an error code with DataStoreException when a record is 
> not found
> ---
>
> Key: JCR-4213
> URL: https://issues.apache.org/jira/browse/JCR-4213
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-data
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 2.16
>
> Attachments: JCR-4213.patch
>
>
> To help with cases like OAK-6935, it would be useful if 
> {{DataStoreException}}, on best effort basis, provides and error code too.
> An example stack that OAK-6935 logs currently looks like:
> {noformat}
>  
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl
>  Exception occurred while attempting to delete blob 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f#4694
> org.apache.jackrabbit.core.data.DataStoreException: Record 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f does not 
> exist
>   at 
> org.apache.jackrabbit.core.data.AbstractDataStore.getRecord(AbstractDataStore.java:58)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.OakFileDataStore.getRecordForId(OakFileDataStore.java:259)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getRecordForId(DataStoreBlobStore.java:519)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.countDeleteChunks(DataStoreBlobStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl.purgeBlobsDeleted(ActiveDeletedBlobCollectorFactory.java:224)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService.lambda$initializeActiveBlobCollector$0(LuceneIndexProviderService.java:760)
> ...
> ...
> {noformat}
> /cc [~amjain]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JCRVLT-177) jcr:content and its children not overwritten during installation of Simple File Aggregate

2017-11-14 Thread Konrad Windszus (JIRA) 

[ 
https://issues.apache.org/jira/browse/JCRVLT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251264#comment-16251264
 ] 

Konrad Windszus commented on JCRVLT-177:


This issue also affects vlt:definition nodes below subpackages (as subpackages 
created through the maven-plugin are a binary ZIP file only).

> jcr:content and its children not overwritten during installation of Simple 
> File Aggregate
> -
>
> Key: JCRVLT-177
> URL: https://issues.apache.org/jira/browse/JCRVLT-177
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: Packaging
>Affects Versions: 3.1.38
>Reporter: Konrad Windszus
>Assignee: Tobias Bocanegra
> Fix For: 3.1.40
>
>
> For simple file aggregates in a package, the child node {{jcr:content}} is 
> not correctly overwritten.
> Example
> State in repository
> {code}
> + content
>   + test
> + thumbnail.png [nt:file]
>   +  jcr:content [nt:resource]
> + dam:thumbnails [nt:folder]
> {code}
> In my package I have the filter
> {code}
> 
> 
> 
> {code}
> And the package content consists of only the binary file 
> {{/content/test/thumbnail.png}}.
> Once I install that package it will not remove/recreate 
> {{/content/test/thumbnail.png/jcr:content}} and also leave the child node 
> {{dam:thumbnails}} in place.
> I would expect that 
> {{/content/test/thumbnail.png/jcr:content/dam:thumbnails}} is removed with 
> the installation of the package.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (JCR-4213) It is useful to return an error code with DataStoreException when a record is not found

2017-11-14 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/JCR-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251210#comment-16251210
 ] 

Julian Reschke commented on JCR-4213:
-

Is this an API change? Otherwise I don't see why we couldn't easily backport 
it...

> It is useful to return an error code with DataStoreException when a record is 
> not found
> ---
>
> Key: JCR-4213
> URL: https://issues.apache.org/jira/browse/JCR-4213
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-data
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 2.16
>
> Attachments: JCR-4213.patch
>
>
> To help with cases like OAK-6935, it would be useful if 
> {{DataStoreException}}, on best effort basis, provides and error code too.
> An example stack that OAK-6935 logs currently looks like:
> {noformat}
>  
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl
>  Exception occurred while attempting to delete blob 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f#4694
> org.apache.jackrabbit.core.data.DataStoreException: Record 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f does not 
> exist
>   at 
> org.apache.jackrabbit.core.data.AbstractDataStore.getRecord(AbstractDataStore.java:58)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.OakFileDataStore.getRecordForId(OakFileDataStore.java:259)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getRecordForId(DataStoreBlobStore.java:519)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.countDeleteChunks(DataStoreBlobStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl.purgeBlobsDeleted(ActiveDeletedBlobCollectorFactory.java:224)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService.lambda$initializeActiveBlobCollector$0(LuceneIndexProviderService.java:760)
> ...
> ...
> {noformat}
> /cc [~amjain]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (JCR-4213) It is useful to return an error code with DataStoreException when a record is not found

2017-11-14 Thread Vikas Saurabh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/JCR-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vikas Saurabh resolved JCR-4213.

   Resolution: Later
Fix Version/s: (was: 2.16)

As discussed in OAK-6935, this is no longer required immediately. Resolving as 
later.

> It is useful to return an error code with DataStoreException when a record is 
> not found
> ---
>
> Key: JCR-4213
> URL: https://issues.apache.org/jira/browse/JCR-4213
> Project: Jackrabbit Content Repository
>  Issue Type: Improvement
>  Components: jackrabbit-data
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Attachments: JCR-4213.patch
>
>
> To help with cases like OAK-6935, it would be useful if 
> {{DataStoreException}}, on best effort basis, provides and error code too.
> An example stack that OAK-6935 logs currently looks like:
> {noformat}
>  
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl
>  Exception occurred while attempting to delete blob 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f#4694
> org.apache.jackrabbit.core.data.DataStoreException: Record 
> df38cfbdccbe27dba778679befd74b10e40c3eb46f96e58ee4bb6c2c6b993d3f does not 
> exist
>   at 
> org.apache.jackrabbit.core.data.AbstractDataStore.getRecord(AbstractDataStore.java:58)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.OakFileDataStore.getRecordForId(OakFileDataStore.java:259)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getRecordForId(DataStoreBlobStore.java:519)
>   at 
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.countDeleteChunks(DataStoreBlobStore.java:425)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ActiveDeletedBlobCollectorFactory$ActiveDeletedBlobCollectorImpl.purgeBlobsDeleted(ActiveDeletedBlobCollectorFactory.java:224)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService.lambda$initializeActiveBlobCollector$0(LuceneIndexProviderService.java:760)
> ...
> ...
> {noformat}
> /cc [~amjain]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (JCR-4214) OAK 1.6 uses varying and outdated Tika versions

2017-11-14 Thread Julian Reschke (JIRA) 
Julian Reschke created JCR-4214:
---

 Summary: OAK 1.6 uses varying and outdated Tika versions
 Key: JCR-4214
 URL: https://issues.apache.org/jira/browse/JCR-4214
 Project: Jackrabbit Content Repository
  Issue Type: Task
Affects Versions: 1.6.5
Reporter: Julian Reschke
Priority: Minor


These should be consistent and recent...:

oak-examples/standalone/pom.xml
38:1.7
131:  ${tika.version}

oak-examples/standalone/vn dq
38:1716836chetanm 1.7
131:1716836chetanm   ${tika.version}

oak-examples/webapp/pom.xml
39:1.7
56:  ${tika.version}

oak-lucene/pom.xml
36:1.5
183:  ${tika.version}
321:  ${tika.version}

oak-pojosr/pom.xml
36:1.5
206:  ${tika.version}
212:  ${tika.version}

oak-solr-core/pom.xml
36:1.5
191:${tika.version}
265:${tika.version}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Jackrabbit 2.15.8

2017-11-14 Thread Andrei Dulceanu 
[X] +1 Release this package as Apache Jackrabbit 2.15.8

where

[INFO]

[INFO] Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T21:39:06+02:00)
[INFO] OS name: "mac os x", version: "10.12.6", arch: "x86_64", family:
"mac"
[INFO] Java version: 1.8.0_65, vendor: Oracle Corporation
[INFO]


Regards,
Andrei

2017-11-12 15:47 GMT+01:00 Julian Reschke :

> A candidate for the Jackrabbit 2.15.8 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/2.15.8/
>
> The release candidate is a zip archive of the sources in:
>
> https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.15.8/
>
> The SHA1 checksum of the archive is b9d455fc1ed2f4e9294de6120038f0
> f9faaab8cf.
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
> $ sh check-release.sh 2.15.8 b9d455fc1ed2f4e9294de6120038f0f9faaab8cf
>
> Please vote on releasing this package as Apache Jackrabbit 2.15.8.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
> [ ] +1 Release this package as Apache Jackrabbit 2.15.8
> [ ] -1 Do not release this package because...
>
> Best regards, Julian
>

[jira] [Created] (JCR-4215) Use a recent Tika version

2017-11-14 Thread Julian Reschke (JIRA) 
Julian Reschke created JCR-4215:
---

 Summary: Use a recent Tika version
 Key: JCR-4215
 URL: https://issues.apache.org/jira/browse/JCR-4215
 Project: Jackrabbit Content Repository
  Issue Type: Task
  Components: parent
Reporter: Julian Reschke
Assignee: Julian Reschke
 Fix For: 2.18






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

BUILD FAILURE: Jackrabbit Oak (ManyChildNodesIT) - Build # 23 - Failure (ManyChildNodesIT)

2017-11-14 Thread Apache Jenkins Server 
The Apache Jenkins build system has built Jackrabbit Oak (ManyChildNodesIT) 
(build #23)

Status: Failure

Check console output at 
https://builds.apache.org/job/Jackrabbit%20Oak%20(ManyChildNodesIT)/23/ to view 
the results.

Changes:
[catholicon] OAK-6882: ObservationQueueFullWarnTest.testQueueFullThenFlushing 
failing

[angela] OAK-6938 : Add package export version for spi.xml

[angela] OAK-6939 : Non-existing package o.a.j.oak.util is exported twice

[angela] OAK-6934 : Add test coverage of plugins.tree package (wip)

[catholicon] OAK-6935: Active deletion logs warn messages when it tries to 
delete blobs already purged by DSGC

[mduerig] OAK-6931: Enable the -Dcache of offline compaction
Pass the value of the cache system property to the compactor tool

[reschke] OAK-6937: use Tika version consistent with other modules

[reschke] OAK-6353: fix nullability annotation

 

Test results:
No tests ran.

Re: Intent to backport to 1.6 OAK-6931

2017-11-14 Thread Francesco Mari 
+1

On Tue, Nov 14, 2017 at 12:19 PM, Michael Dürig  wrote:
> https://issues.apache.org/jira/browse/OAK-6931
>
> This fixes an issue in the offline compaction tool, which prevents the cache
> size to be set via the command line.
>
> Michael

BUILD FAILURE: Jackrabbit Oak - Build # 973 - Still Failing

2017-11-14 Thread Apache Jenkins Server 
The Apache Jenkins build system has built Jackrabbit Oak (build #973)

Status: Still Failing

Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/973/ to 
view the results.

Changes:
[catholicon] OAK-6905: Query engine: support coalesce function as in-built 
method

Implement coalesce in lucene index

[catholicon] OAK-6905: Query engine: support coalesce function as in-built 
method

Implement coalesce parsing in query engine

 

Test results:
All tests passed

[m12n] Module oak-spi-core defines no export versions

2017-11-14 Thread Angela Schreiber 
Hi Devs

Looking at OAK-3919  I
noticed that most packages in the new _core-spi_ module still don't have
export versions properly handled.

I guess this is an oversight that we missed during the modularisation.
Unless someone objects I would go ahead adding those (see also OAK-6942
 for the corresponding
JIRA ticket).

Any preference wrt the initial version number?

Kind regards
Angela

Intent to backport to 1.6 OAK-6931

2017-11-14 Thread Michael Dürig 

https://issues.apache.org/jira/browse/OAK-6931

This fixes an issue in the offline compaction tool, which prevents the 
cache size to be set via the command line.


Michael

Re: [m12n] Module oak-spi-core defines no export versions

2017-11-14 Thread Angela Schreiber 
Hi Robert

Ok... I will add 1.0.0 and go ahead tomorrow unless someone objects.

Kind regards
Angela

On 14/11/17 17:23, "Robert Munteanu"  wrote:

>On Tue, 2017-11-14 at 13:51 +, Angela Schreiber wrote:
>> Any preference wrt the initial version number?
>
>The initial version number should be 1.0.0 IMO.
>
>Robert

BUILD FAILURE: Jackrabbit Oak - Build # 971 - Failure

2017-11-14 Thread Apache Jenkins Server 
The Apache Jenkins build system has built Jackrabbit Oak (build #971)

Status: Failure

Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/971/ to 
view the results.

Changes:
[angela] OAK-6938 : Add package export version for spi.xml

[angela] OAK-6939 : Non-existing package o.a.j.oak.util is exported twice

 

Test results:
All tests passed

Re: [m12n] Module oak-spi-core defines no export versions

2017-11-14 Thread Robert Munteanu 
On Tue, 2017-11-14 at 13:51 +, Angela Schreiber wrote:
> Any preference wrt the initial version number?

The initial version number should be 1.0.0 IMO.

Robert

BUILD FAILURE: Jackrabbit Oak - Build # 972 - Still Failing

2017-11-14 Thread Apache Jenkins Server 
The Apache Jenkins build system has built Jackrabbit Oak (build #972)

Status: Still Failing

Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/972/ to 
view the results.

Changes:
[catholicon] OAK-6882: ObservationQueueFullWarnTest.testQueueFullThenFlushing 
failing

 

Test results:
All tests passed

Re: [m12n] Module oak-spi-core defines no export versions

2017-11-14 Thread Chetan Mehrotra 
Do we want to have explicit version for all packages in oak-core-spi
or should we only do it for packages which we expect code outside of
Oak codebase would be using? As once we version it we cannot change in
backward incompatible way easily
Chetan Mehrotra


On Tue, Nov 14, 2017 at 10:05 PM, Angela Schreiber
 wrote:
> Hi Robert
>
> Ok... I will add 1.0.0 and go ahead tomorrow unless someone objects.
>
> Kind regards
> Angela
>
> On 14/11/17 17:23, "Robert Munteanu"  wrote:
>
>>On Tue, 2017-11-14 at 13:51 +, Angela Schreiber wrote:
>>> Any preference wrt the initial version number?
>>
>>The initial version number should be 1.0.0 IMO.
>>
>>Robert
>

Re: [m12n] Module oak-spi-core defines no export versions

2017-11-14 Thread Angela Schreiber 
Hi Chetan

Well... I would have excepted that one goal of the m12n was to get a clear
separation between public API and internals and everything that we target
as API/SPI should be public IMO.

And I definitely hope that we after that can stop making incompatible
changes as that separations allows us to stop exporting things that are
meant to be internal...

Angela

On 14/11/17 18:10, "Chetan Mehrotra"  wrote:

>Do we want to have explicit version for all packages in oak-core-spi
>or should we only do it for packages which we expect code outside of
>Oak codebase would be using? As once we version it we cannot change in
>backward incompatible way easily
>Chetan Mehrotra
>
>
>On Tue, Nov 14, 2017 at 10:05 PM, Angela Schreiber
> wrote:
>> Hi Robert
>>
>> Ok... I will add 1.0.0 and go ahead tomorrow unless someone objects.
>>
>> Kind regards
>> Angela
>>
>> On 14/11/17 17:23, "Robert Munteanu"  wrote:
>>
>>>On Tue, 2017-11-14 at 13:51 +, Angela Schreiber wrote:
 Any preference wrt the initial version number?
>>>
>>>The initial version number should be 1.0.0 IMO.
>>>
>>>Robert
>>