Jenkins build is back to normal : JMeter-trunk #1592

2011-10-23 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org

Build failed in Jenkins: JMeter-trunk #1591

2011-10-23 Thread Apache Jenkins Server
See Changes: [milamber] Synchronized not needed -- [...truncated 592 lines...] compile-monitor-components: [javac] Compiling 13 source files to

Re: svn commit: r1187947 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/gui/ src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/gui/util/ src/core/org/apache/jmeter/images/

2011-10-23 Thread Milamber
Le 23/10/2011 19:02, Philippe Mouawad a ecrit : > Hello, > Is there a reason for making IconToolbarBean getter methods synchronized ? > No. (yes: my "Generate Getters/Setters" helper in Eclipse with synchronized ckecked) Fixed. Thanks. Milamber > Regards > Philippe > > On Sun, Oct 23, 201

Re: svn commit: r1187947 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/gui/ src/core/org/apache/jmeter/gui/action/ src/core/org/apache/jmeter/gui/util/ src/core/org/apache/jmeter/images/

2011-10-23 Thread Philippe Mouawad
Hello, Is there a reason for making IconToolbarBean getter methods synchronized ? Regards Philippe On Sun, Oct 23, 2011 at 8:41 PM, wrote: > Author: milamber > Date: Sun Oct 23 18:41:08 2011 > New Revision: 1187947 > > URL: http://svn.apache.org/viewvc?rev=1187947&view=rev > Log: > Bug 52040 -

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread sebb
On 23 October 2011 12:34, Philippe Mouawad wrote: > Kind of getNextAlias method in DefaultKeyStore ? Yes, or just getAlias() as we had originally. > > On Sun, Oct 23, 2011 at 1:23 PM, sebb wrote: > >> On 23 October 2011 12:05, Philippe Mouawad >> wrote: >> > But In this case , alias will run i

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread Philippe Mouawad
Kind of getNextAlias method in DefaultKeyStore ? On Sun, Oct 23, 2011 at 1:23 PM, sebb wrote: > On 23 October 2011 12:05, Philippe Mouawad > wrote: > > But In this case , alias will run in the same order for different callers > > during the test no ? > > I had assumed that as the parent is a s

Re: Question about our use of HttpClient

2011-10-23 Thread sebb
On 23 October 2011 12:19, Philippe Mouawad wrote: > Hello, > I was wondering why we chose in the different implementations of Samplers > using HttpClient 3 and 4 to use an instance per Thread in ThreadLocal zone > instead of using : > >   - ThreadSafeClientConnManager for HC4 >   - MultiThreadedHt

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread sebb
On 23 October 2011 12:05, Philippe Mouawad wrote: > But In this case , alias will run in the same order for different callers > during the test no ? I had assumed that as the parent is a singleton, the nested class would be a singleton too, but I see now that is not correct. This needs futher in

Question about our use of HttpClient

2011-10-23 Thread Philippe Mouawad
Hello, I was wondering why we chose in the different implementations of Samplers using HttpClient 3 and 4 to use an instance per Thread in ThreadLocal zone instead of using : - ThreadSafeClientConnManager for HC4 - MultiThreadedHttpConnectionManager for HC3.1 (see http://pro-programmers.

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread Philippe Mouawad
But In this case , alias will run in the same order for different callers during the test no ? While currently as field is static there is more randomizing . On Sun, Oct 23, 2011 at 1:01 PM, sebb wrote: > On 23 October 2011 11:53, Philippe Mouawad > wrote: > > I looked in a bit more detail, > >

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread sebb
On 23 October 2011 11:53, Philippe Mouawad wrote: > I looked in a bit more detail, > static is needed Not if one moves the field to the WrappedX509KeyManager class, which is what I will do. > I think AtomicInteger won't do it because we need to increment and % > aliasCount in the same time, don'

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread Philippe Mouawad
I looked in a bit more detail, static is needed I think AtomicInteger won't do it because we need to increment and % aliasCount in the same time, don't know if we can do that so maybe just a custom lock for this static field would do it. On Sun, Oct 23, 2011 at 12:49 PM, sebb wrote: > On 23 Oct

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread sebb
On 23 October 2011 11:38, Philippe Mouawad wrote: > Hello, > Regarding this last commit,  I think there is an issue in last_user either > being static or being synchronized on this. > > In my opinion, as it seems JsseSSLManager is a singleton, last_user should > be instance variable. > If it's not

Re: svn commit: r1187840 - in /jakarta/jmeter/trunk: bin/ src/core/org/apache/jmeter/util/ src/core/org/apache/jmeter/util/keystore/ xdocs/

2011-10-23 Thread Philippe Mouawad
Hello, Regarding this last commit, I think there is an issue in last_user either being static or being synchronized on this. In my opinion, as it seems JsseSSLManager is a singleton, last_user should be instance variable. If it's not the case, then synchronized block in getNextIndex should be on

Bug report for JMeter [2011/10/23]

2011-10-23 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned