Re: Toolbar suggested changes

Le 24/10/2011 12:04, sebb a ecrit : > The icons look really good, and should make JMeter easier to use. > > But I think the code could be improved further: > > 1) IconToolbarBean uses ";" to separate most icon fields, but uses " " > to separate the optional pressed icon. > > I think it might be c

Jenkins build is back to normal : JMeter-trunk #1597

See - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org

Build failed in Jenkins: JMeter-trunk #1596

See -- [...truncated 726 lines...] [anakia] Output: [anakia] Input: usermanual/glossary.xml [anakia

Build failed in Jenkins: JMeter-trunk #1595

See Changes: [sebb] Generic for loops [sebb] Generic for loops [sebb] Generic for loops [sebb] Generic for loops [sebb] Generic for loops [sebb] Generic for loops [sebb] Generic for loops [sebb] Generic for loops [sebb] Only need t

Jenkins build is back to normal : JMeter-trunk #1594

See - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org

Build failed in Jenkins: JMeter-trunk #1593

See Changes: [sebb] Document generics warning [sebb] Avoid boxing/unboxing [sebb] Missing @Override [sebb] Fix generics warning [sebb] Clarify exception messages -- [...truncated 322 lines...] _

Toolbar suggested changes

The icons look really good, and should make JMeter easier to use. But I think the code could be improved further: 1) IconToolbarBean uses ";" to separate most icon fields, but uses " " to separate the optional pressed icon. I think it might be clearer to use a single separator for all the fields