Re: Issue 51861

2011-10-20 Thread sebb
On 20 October 2011 11:18, Philippe Mouawad wrote: > Hello Sebb, > Did you have some time to review patch for issue 51861 ? If yes Are you OK > if I commit it ? I had a look, and I think it is better, but I suspect that there are still some edge cases that may cause issues. As the

Issue 51861

2011-10-20 Thread Philippe Mouawad
Hello Sebb, Did you have some time to review patch for issue 51861 ? If yes Are you OK if I commit it ? In fact I am doing some load tests on GWT and it is really difficult to work without it. Hope you have some time to take it into account. Regards Philippe

Re: [JMeter] Issue 51861 - Improve HTTP Request GUI to better show parameters without name (Raw Body)

2011-10-16 Thread Philippe Mouawad
Hello Sebb, I submitted a new version of patch that takes into account the folliwing: - if the raw flag is set, we don't do a merge; otherwise keep current behaviour (I noticed that if there is only one parameter in request with no name and there are parameters in request default, only p

Re: [JMeter] Issue 51861 - Improve HTTP Request GUI to better show parameters without name (Raw Body)

2011-10-15 Thread Philippe Mouawad
On Tue, Oct 11, 2011 at 2:38 PM, sebb wrote: > On 9 October 2011 10:41, Philippe Mouawad > wrote: > > Hello Sebb, > > Regarding this, if we add a checkbox in Request Sampler GUI to indicate > to > > user that merge will occur on request. > > This would be checked by default unless user switches

Re: [JMeter] Issue 51861 - Improve HTTP Request GUI to better show parameters without name (Raw Body)

2011-10-11 Thread sebb
On 9 October 2011 10:41, Philippe Mouawad wrote: > Hello Sebb, > Regarding this, if we add a checkbox in Request Sampler GUI to indicate to > user that merge will occur on request. > This would be checked by default unless user switches to RAW body, if switch > is accepted, checkbox is unchecked >

Re: [JMeter] Issue 51861 - Improve HTTP Request GUI to better show parameters without name (Raw Body)

2011-10-09 Thread Philippe Mouawad
Hello Sebb, Regarding this, if we add a checkbox in Request Sampler GUI to indicate to user that merge will occur on request. This would be checked by default unless user switches to RAW body, if switch is accepted, checkbox is unchecked So we would have this behaviour: - RAW body used, no mer

Re: [JMeter] Issue 51861 - Improve HTTP Request GUI to better show parameters without name (Raw Body)

2011-09-28 Thread sebb
On 28 September 2011 19:59, Philippe Mouawad wrote: > Hello Sebb, > Thanks for the analysis. > I agree with you and will try to handle these cases, do you prefer a > discussion in mailing list or in issue ? Mailing list. - To un

Re: [JMeter] Issue 51861 - Improve HTTP Request GUI to better show parameters without name (Raw Body)

2011-09-28 Thread Philippe Mouawad
Hello Sebb, Thanks for the analysis. I agree with you and will try to handle these cases, do you prefer a discussion in mailing list or in issue ? No problem for me if it is not taken into account in this release provided it is in next or not too far in the future so that patches are still valid :

[JMeter] Issue 51861 - Improve HTTP Request GUI to better show parameters without name (Raw Body)

2011-09-28 Thread sebb
If HttpDefaults and HttpRequest both use Parameters, then the body is created from both sets of parameters. When the body is being built, if any of the parameters have names, only named parameters are kept. Any unnamed parameters are ignored. It's not possible to mix named and unnamed parameters;

Re: Issue 51861

2011-09-27 Thread Philippe Mouawad
Hello Sebb, I submitted a new patch version in 51861. Regards Philippe On Tue, Sep 27, 2011 at 4:23 PM, Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hello Sebb, > Did you have some time to look at patch for issue 51861 ? > Are there any pending problems in submitted pa

Issue 51861

2011-09-27 Thread Philippe Mouawad
Hello Sebb, Did you have some time to look at patch for issue 51861 ? Are there any pending problems in submitted patch ? Thank you Regards Philippe