Re: Bug in SortedDataBag?

On 16/03/17 15:47, Chris Dollin wrote: (Was offline yesterday) Similar in result, at least. Having SortedBindingIterator.close() close the underlying iterator -- which at this point should be empty since it's been the source of the bindings to sort -- should be harmless, and ensure that that

Re: Bug in SortedDataBag?

(Was offline yesterday) Similar in result, at least. Having SortedBindingIterator.close() close the underlying iterator -- which at this point should be empty since it's been the source of the bindings to sort -- should be harmless, and ensure that that iterator /does/ get closed. What I'm not

Re: Remove get and updateEntity methods from TextIndex interface in jena-text?

Okay, that's what I thought you meant and I'm +1 to that. --- A. Soroka The University of Virginia Library > On Mar 16, 2017, at 11:42 AM, Andy Seaborne wrote: > > This is already a roadbump for jena-text. There is only so much development > bandwidth so if it is already a

Re: Remove get and updateEntity methods from TextIndex interface in jena-text?

On 16/03/17 15:42, Andy Seaborne wrote: This is already a roadbump for jena-text. There is only so much development bandwidth so if it is already a version that jena-text users are going to have to get involved in, so making considered small API changes at the same time seems the right thing

Re: Remove get and updateEntity methods from TextIndex interface in jena-text?

This is already a roadbump for jena-text. There is only so much development bandwidth so if it is already a version that jena-text users are going to have to get involved in, so making considered small API changes at the same time seems the right thing to do. Deprecation only goes so far

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928283#comment-15928283 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106451444 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation

Re: Remove get and updateEntity methods from TextIndex interface in jena-text?

Sorry for my thickness, Andy, but are you saying that it makes sense to go ahead and make all the changes together, to avoid presenting a moving target for any longer than we have to? --- A. Soroka The University of Virginia Library > On Mar 16, 2017, at 11:20 AM, Andy Seaborne

Re: Remove get and updateEntity methods from TextIndex interface in jena-text?

This is a major jump for jena-text so getting in changes in the next version makes sense to me. Andy On 16/03/17 10:50, Osma Suominen wrote: Hi, In the process of developing the Elasticsearch backend for jena-text (JENA-1305), Anuj and I noticed that the methods "get" and "updateEntity"

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/227 @anujgandharv, the first place to look is at the actual `jena-integration-tests` module. You will see there that the tests follow the same form as in other Jena modules (explicitly linked together in

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928194#comment-15928194 ] ASF GitHub Bot commented on JENA-1305: -- Github user ajs6f commented on the issue:

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on the issue: https://github.com/apache/jena/pull/227 Thanks @ajs6f for the Maven ElasticSearch Plugin link. Looks like this would enable us to spin up a fully functional Single Node ES for our integration tests. Can you share some more light as to

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928167#comment-15928167 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928172#comment-15928172 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on the issue:

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106431068 --- Diff: jena-text/text-config.ttl --- @@ -50,6 +50,7 @@ text:TextIndexLucene rdfs:subClassOf text:TextIndex . <#indexLucene> a

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928166#comment-15928166 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106431036 --- Diff: jena-text/testing/TextQuery/text-config.ttl --- @@ -31,6 +31,7 @@ text:TextIndexLucene rdfs:subClassOf text:TextIndex .

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928162#comment-15928162 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106430285 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106429946 --- Diff: jena-text/pom.xml --- @@ -81,6 +81,51 @@ lucene-queryparser + + org.elasticsearch +

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928159#comment-15928159 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106429891 --- Diff: jena-parent/pom.xml --- @@ -275,6 +276,75 @@ ${ver.spatial4j} + + +

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106429678 --- Diff: jena-text/pom.xml --- @@ -115,6 +160,7 @@ **/TS_*.java +

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928150#comment-15928150 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928152#comment-15928152 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928156#comment-15928156 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106429631 --- Diff: jena-text/src/main/java/examples/JenaESTextExample.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106429441 --- Diff: jena-text/src/main/java/examples/JenaESTextExample.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928149#comment-15928149 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928147#comment-15928147 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106428753 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928142#comment-15928142 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106428563 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928135#comment-15928135 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928137#comment-15928137 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106428124 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106428015 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106427299 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928129#comment-15928129 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/227 I'm just catching up with this PR, so apologies if I turn out to have missed part of the conversation! If there is difficulty getting tests integrated into the Maven lifecycle within one

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928087#comment-15928087 ] ASF GitHub Bot commented on JENA-1305: -- Github user ajs6f commented on the issue:

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106420753 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/TestTextIndexES.java --- @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928054#comment-15928054 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on a diff in the pull

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927933#comment-15927933 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927923#comment-15927923 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927937#comment-15927937 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927931#comment-15927931 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927926#comment-15927926 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927928#comment-15927928 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927934#comment-15927934 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927936#comment-15927936 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927930#comment-15927930 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927932#comment-15927932 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927938#comment-15927938 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927939#comment-15927939 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927924#comment-15927924 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927935#comment-15927935 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927929#comment-15927929 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927925#comment-15927925 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927927#comment-15927927 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on a diff in the pull request:

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106403820 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106403936 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106403179 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106404596 --- Diff: jena-text/testing/TextQuery/text-config.ttl --- @@ -31,6 +31,7 @@ text:TextIndexLucene rdfs:subClassOf text:TextIndex . <#indexLucene> a

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106404182 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106401814 --- Diff: jena-text/pom.xml --- @@ -81,6 +81,51 @@ lucene-queryparser + + org.elasticsearch +

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106404542 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/TestTextIndexES.java --- @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106402731 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,427 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106404092 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106401743 --- Diff: jena-parent/pom.xml --- @@ -275,6 +276,75 @@ ${ver.spatial4j} + + +org.elasticsearch

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106401876 --- Diff: jena-text/pom.xml --- @@ -115,6 +160,7 @@ **/TS_*.java +-Dtests.security.manager=false

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106406514 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/TestTextIndexES.java --- @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106404607 --- Diff: jena-text/text-config.ttl --- @@ -50,6 +50,7 @@ text:TextIndexLucene rdfs:subClassOf text:TextIndex . <#indexLucene> a text:TextIndexLucene ;

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106405506 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/TestTextIndexES.java --- @@ -0,0 +1,184 @@ +/** + * Licensed to the Apache Software

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106404329 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java --- @@ -0,0 +1,394 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106402500 --- Diff: jena-text/src/main/java/examples/JenaESTextExample.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] jena pull request #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on a diff in the pull request: https://github.com/apache/jena/pull/227#discussion_r106402651 --- Diff: jena-text/src/main/java/examples/JenaESTextExample.java --- @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927848#comment-15927848 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on the issue:

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on the issue: https://github.com/apache/jena/pull/227 Thanks @osma. I think the Index will becoe much simpler if we remove the non-used methods --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927828#comment-15927828 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on the issue:

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on the issue: https://github.com/apache/jena/pull/227 I asked advice about what to do with those methods on the `dev` list: http://jena.markmail.org/thread/pgeigsya7f5xda6h --- If your project is set up for it, you can reply to this email and have your

Remove get and updateEntity methods from TextIndex interface in jena-text?

Hi, In the process of developing the Elasticsearch backend for jena-text (JENA-1305), Anuj and I noticed that the methods "get" and "updateEntity" in the TextIndex interface in jena-text are never called from within Jena (not even from unit tests). Is there a reason for keeping them, or

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927818#comment-15927818 ] ASF GitHub Bot commented on JENA-1305: -- Github user osma commented on the issue:

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user osma commented on the issue: https://github.com/apache/jena/pull/227 Hi @anujgandharv, thanks for the update, I will do a new review soon. Regarding `TextIndex.get`, excellent question! I was actually wondering the same when I did the review yesterday, but didn't

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927738#comment-15927738 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on the issue:

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on the issue: https://github.com/apache/jena/pull/227 Hi @osma I need one more favour from you. I need to understand the scenario when the 'get' method of TextIndex gets called. Can you provide me an example Sparql query which I can run from my

[jira] [Commented] (JENA-1305) Elastic Search Support for Apache Jena Text

[ https://issues.apache.org/jira/browse/JENA-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927712#comment-15927712 ] ASF GitHub Bot commented on JENA-1305: -- Github user anujgandharv commented on the issue:

[GitHub] jena issue #227: JENA-1305 | Elastic search support for Jena Text

Github user anujgandharv commented on the issue: https://github.com/apache/jena/pull/227 @osma Can you review now. I have made the changes to the Add and Delete API so that they are executed as a single REST call. I think we already have consensus on the Multilingual aspect. If not,