Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-177313470
Sorry on both counts. `SimpleMap*` is leakage from JENA-1084. My Git-fu
failed. I thought I had kept that work separate.
---
If your project is set up for it, you can repl
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-177312482
Merged after fixing up:
1/ I used "git pull --no-commit" and got some compile errors (imports of
`TriOperator.Operator3` etc) in files `SimpleMap*`. These classes are
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-174581614
@afs I've renamed/moved types according to proposal 1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-172877393
I'm happy to do whatever will get this merged and move on. I chose the
prefix names and not the numerical suffix names because that is what Java does
in (e.g.) `java.util.fu
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-172391107
This is now quite inconsistent. There too many names and both locations
and naming are mixed up.
Let's simplify for jena-base. What you call things in the "mem" pack
Github user ocymum commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-172378843
@afs, I've put the new types in their own package and renamed away from
using `Quad` as the prefix. Let me know what you think. I'd very much like to
use this code to addre
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49275522
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/tuple/QuadConsumer.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundatio
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49250282
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/tuple/QuadConsumer.java ---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-170033484
Reformatted license headers.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-170022965
I've changed `TupleMap` back to `final`, with concomitant changes to the
subclasses of `PMapTupleTable`.
---
If your project is set up for it, you can reply to this email a
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49192464
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java ---
@@ -37,13 +39,29 @@
* use.
*
*/
-public abstract cla
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49173865
--- Diff:
jena-base/src/main/java/org/apache/jena/atlas/lib/tuple/TupleMap.java ---
@@ -46,7 +46,6 @@
* {@code 0<-1, 1<-2, 2<-0}
* and the "putTransfor
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49173681
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java ---
@@ -37,13 +39,29 @@
* use.
*
*/
-public abstract class
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/120#discussion_r49172355
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/OrderedTupleTable.java
---
@@ -0,0 +1,140 @@
+/*
--- End diff --
The license head
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-169393952
Oops! Adding a last commit to keep all the ordering machinery more
centralized.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/120#issuecomment-169384106
Third time is the charm!
I think this time I have a good factoring that begins to separate the
notion of ordering from the kind of data structure which stores the no
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/120
JENA-1083: Factoring tuple ordering into TupleMap
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1083
Alternatively you can review
18 matches
Mail list logo
