[GitHub] jena pull request: Jena-text multilingual alternative implementati...
Github user osma commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-103778663 with a minus before to exclude filled values Ah, I see. Sorry for the confusion. I had different expectations and the expression is a bit hard to read. I think this is fine, though it could be a bit clearer. And I now see that you also test for 'lang:none'. Is there a required formatting on the message ? ps: I will also mention the refactoring to obtain their advices on it. No, just explain what this is about. Copying and pasting the still-relevant explanations from your comments here should work. I know these comments already get echoed to the dev list, but it's probably difficult to follow since we've been discussing this quite a lot already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: contract tests
On 19/05/15 20:25, Claude Warren wrote: There is a set of contract tests (and test helpers) on the add-contract-tests branch. That branch works and has minimal change from the current tests. Those changes are adding the junit-contract runner and plugins. It makes no change to the execution. The problem that I am having is keeping it up to date with the current change rate of the Jena packages. Granted the contract tests are only implemented for the jena-core module, we have been keeing the entire suite up to date. Is there anyone that has any objection to moving the contract tests to the main code branch? Seems like a good idea - would this be in parallel to the existing tests, or a partial replacement? Andy Claude
[GitHub] jena pull request: Kill dead things
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-103970036 Changes based the ideas here have been applied to the codebase (See JENA-938). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552729#comment-14552729 ] ASF GitHub Bot commented on JENA-938: - Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/69 Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552728#comment-14552728 ] ASF GitHub Bot commented on JENA-938: - Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/70 Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jena-text multilingual implementation
Hi, This proposal aims to integrate language-specific support in jena-text. It summarizes changes (and several discussions) done in https://github.com/apache/jena/pull/64 (JENA-928) and previously in https://github.com/apache/jena/pull/52. The forked branch is available at https://github.com/LICEF/jena/tree/jena-text-ml-single-index. A single patch file in also in attachement. Below are the changes and new features made : 1) LocalizedAnalyzer A new analyzer can now be specified (for indexation or query phases) to take advantage of Lucene language specific analyzers (stemming, stop words,...). Like other existent analyzers (SimpleAnalyzer, KeywordAnalyzer,..), it can be used in assembler specifications with the related language : text:queryAnalyzer [ a text:LocalizedAnalyzer ; text:language en ] In java code, it can be instantiated with the getLocalizedAnalyzer(lang) static method from org.apache.jena.query.text.analyzer.Util class. 2) TextIndexLuceneMultilingualThis new subclass of TextIndexLucene selects dynamically the right localized analyzer depending on literal's language. The selected analyzer is used for indexing and querying the index. Also, the lang is added by default in the index.To enable the multilingual support, just set the following option in the index assembler spec : #indexLucene a text:TextIndexLucene ; text:directory mem ;text:multilingualSupport true; . 3) Explicit language field in the index Even if there is no need of linguistic analyzers, literal's languages can be stored in the index to extend query capabilities. For that, the new langField param must be set in the EntityMap assembler : #entMap a text:EntityMap ; text:entityField uri ; text:defaultField text ;text:langField lang ; . 4) UsageOnce langField is present in the index, in order to take it into account in sparql queries, set clauses like : ?s text:query (rdfs:label 'word' 'lang:en' ) //target english literals?s text:query (rdfs:label 'word' 'lang:none') //target unlocalized literals?s text:query (rdfs:label 'word') //ignore language The lang:xx parameter is removed from the arg list before the objectToStruct treatment to avoid possible conflicts.Extra params should be generalized in the same manner, ex: limit:10, score:x,... Hence it would allow params to be optional and would remove the order and size constraints. 5) RefactorizationTo simplify the TextDatasetFactory class, the TextIndexConfig class has been introduced. It avoids increasing the number of methods for each new parameter. This class provides a setter for each desired variable.EntityDefinition has changed in the same way.Example code and unit tests have changed accordingly. However, old methods could be re-introduced for backward compatibility.Saisissez du texte, l'adresse d'un site Web ou importez un document à traduire.AnnulerLangue source : Français Alexis MiaraAnalyst ProgrammerCentre de recherche LICEFTélé-université (TÉLUQ)Montréal (Québec), Canada
Re: Jena-text multilingual implementation
20.05.2015, 18:40, Alexis Miara wrote: Hi, This proposal aims to integrate language-specific support in jena-text. I've been coaching this along, as you can see on GitHub. I think Alex has done a lot of good work here and I'm in favor of merging this contribution. Backward compatibility for text index configuration by Java code is potentially an issue, but I've understood that there is also other API churn going on at the moment with the Jena3 transition, so this might be a good moment to clean up the API and get rid of old methods. -Osma -- Osma Suominen D.Sc. (Tech), Information Systems Specialist National Library of Finland P.O. Box 26 (Teollisuuskatu 23)
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552724#comment-14552724 ] ASF subversion and git services commented on JENA-938: -- Commit 1267edd363db227290e242697e07302c0cb17817 in jena's branch refs/heads/master from [~andy.seaborne] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=1267edd ] JENA-938: Code cleaning provided in PR#69 and use of Java8 features. This closes #69. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552726#comment-14552726 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-103970036 Changes based the ideas here have been applied to the codebase (See JENA-938). Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: Kill dead things
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-fuseki*
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552727#comment-14552727 ] ASF subversion and git services commented on JENA-938: -- Commit 7926cec16178614270b917a77c0aa13dcb4f4c66 in jena's branch refs/heads/master from [~andy.seaborne] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=7926cec ] JENA-938: Code cleaning provided in PR#70 and use of Java8 features. This closes #70. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JENA-949) DISTINCT spilling to disk leads to twrong answers.
[ https://issues.apache.org/jira/browse/JENA-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-949: --- Attachment: Jena949_1.java DISTINCT spilling to disk leads to twrong answers. -- Key: JENA-949 URL: https://issues.apache.org/jira/browse/JENA-949 Project: Apache Jena Issue Type: Bug Components: ARQ Affects Versions: Jena 3.0.0 Reporter: Andy Seaborne Attachments: Jena949_1.java [email 2015-05-20|http://mail-archives.apache.org/mod_mbox/jena-users/201505.mbox/%3C34B3B313-EAE4-4498-875F-A9674A8B3B2D%40interition.net%3E] reports a situation at scale. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved JENA-945. Resolution: Fixed Fix Version/s: Jena 3.0.0 fixed by adding Query.setGroupBy( VarExprList) Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor Fix For: Jena 3.0.0 The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (JENA-949) DISTINCT spilling to disk leads to twrong answers.
Andy Seaborne created JENA-949: -- Summary: DISTINCT spilling to disk leads to twrong answers. Key: JENA-949 URL: https://issues.apache.org/jira/browse/JENA-949 Project: Apache Jena Issue Type: Bug Components: ARQ Affects Versions: Jena 3.0.0 Reporter: Andy Seaborne [email 2015-05-20|http://mail-archives.apache.org/mod_mbox/jena-users/201505.mbox/%3C34B3B313-EAE4-4498-875F-A9674A8B3B2D%40interition.net%3E] reports a situation at scale. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (JENA-948) Remove the dependency on reflection to access Query variables.
[ https://issues.apache.org/jira/browse/JENA-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved JENA-948. Resolution: Fixed Fix Version/s: Jena 3.0.0 Assignee: Claude Warren Build has succeeded so this is being closed Remove the dependency on reflection to access Query variables. -- Key: JENA-948 URL: https://issues.apache.org/jira/browse/JENA-948 Project: Apache Jena Issue Type: Improvement Components: Jena Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor Fix For: Jena 3.0.0 QueryBuilder depends on reflection to access some variables that are otherwise hidden. This change is to take advantage of the changes to Query and a better understanding of the Query code to remove the dependencies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren closed JENA-945. -- Build succeeds so this is being closed Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor Fix For: Jena 3.0.0 The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552742#comment-14552742 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103971350 No problemo. Because it was a single commit, it was no harder than a `git reset` to before that commit and then some tap dancing between `git add`ing changes, committing them and making PRs from the commits. Does it seem reasonable to you to go forward to making some module-by-module PRs that remove unused `private` methods? Then people familiar with each module in question could decide whether the removed code was really dead or whether it has some potential future use. I would expect that at least some of it will be genuinely removable, right? Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103971350 No problemo. Because it was a single commit, it was no harder than a `git reset` to before that commit and then some tap dancing between `git add`ing changes, committing them and making PRs from the commits. Does it seem reasonable to you to go forward to making some module-by-module PRs that remove unused `private` methods? Then people familiar with each module in question could decide whether the removed code was really dead or whether it has some potential future use. I would expect that at least some of it will be genuinely removable, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103970644 Thanks for the splitting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552733#comment-14552733 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103970644 Thanks for the splitting. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: contract tests
parallel for now, but I expect we would move a fair number of tests to it as a replacement. On Wed, May 20, 2015 at 10:25 AM, Andy Seaborne a...@apache.org wrote: On 19/05/15 20:25, Claude Warren wrote: There is a set of contract tests (and test helpers) on the add-contract-tests branch. That branch works and has minimal change from the current tests. Those changes are adding the junit-contract runner and plugins. It makes no change to the execution. The problem that I am having is keeping it up to date with the current change rate of the Jena packages. Granted the contract tests are only implemented for the jena-core module, we have been keeing the entire suite up to date. Is there anyone that has any objection to moving the contract tests to the main code branch? Seems like a good idea - would this be in parallel to the existing tests, or a partial replacement? Andy Claude -- I like: Like Like - The likeliest place on the web http://like-like.xenei.com LinkedIn: http://www.linkedin.com/in/claudewarren
[jira] [Commented] (JENA-941) Upgrade code quality reports in Jena build to versions for Java 8
[ https://issues.apache.org/jira/browse/JENA-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552775#comment-14552775 ] ASF GitHub Bot commented on JENA-941: - Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/65 Upgrade code quality reports in Jena build to versions for Java 8 - Key: JENA-941 URL: https://issues.apache.org/jira/browse/JENA-941 Project: Apache Jena Issue Type: Improvement Components: Jena Reporter: A. Soroka Priority: Minor Fix For: Jena 3.0.0 Several code quality reporting tools are available for Maven, including: FindBugs: http://gleclaire.github.io/findbugs-maven-plugin/ and PMD: http://maven.apache.org/plugins/maven-pmd-plugin/ This ticket is to add support for these tools as reports to the Jena build process. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-941: Upgrading code quality plugin version...
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553222#comment-14553222 ] Andy Seaborne commented on JENA-945: Replacing the call of {{Query.setGroupBy}} by: {noformat} query.getGroupBy().clear() query.getGroupBy().addAll(...) {noformat} works -- I don't undertand why {{setGroupBy}} is needed. Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor Fix For: Jena 3.0.0 The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553230#comment-14553230 ] Andy Seaborne commented on JENA-945: Replacing the call of {{Query.setGroupBy}} in {{SolutionModifierHandler}}, that is. Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor Fix For: Jena 3.0.0 The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)