[GitHub] jena pull request #464: NodeUtils convert: set and list versions
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/464 ---
[GitHub] jena pull request #463: Cleanup
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r211266636 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/DynamicDatasets.java --- @@ -56,8 +55,8 @@ public static DatasetGraph dynamicDataset(DatasetDescription description, Datase if (description.isEmpty() ) return dsg; -Set defaultGraphs = NodeUtils.convertToNodes(description.getDefaultGraphURIs()) ; -Set namedGraphs = NodeUtils.convertToNodes(description.getNamedGraphURIs()) ; +Collection defaultGraphs = NodeUtils.convertToNodes(description.getDefaultGraphURIs()) ; --- End diff -- There are various places duplicate removal may happen but it is confusing and with all the routes may be depending on here. Better to maintain compatibility. PR #464 restores the explicit behaviour by having "to list" and "to set" versions and a deprecated "NodeUtils.convertToNodes" with the Set semantics. Does that look good? ---
[GitHub] jena pull request #464: NodeUtils convert: set and list versions
GitHub user afs opened a pull request: https://github.com/apache/jena/pull/464 NodeUtils convert: set and list versions In response to PR #463 where a [comment](https://github.com/apache/jena/pull/463#discussion_r211191248) mentions set/collections issues. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena cleanup2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/464.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #464 commit 70222c7500346e0e85050f4718b44af953ccb6e2 Author: Andy Seaborne Date: 2018-08-20T13:34:09Z NodeUtils convert: set and list versions ---
[GitHub] jena pull request #463: Cleanup
Github user rvesse commented on a diff in the pull request: https://github.com/apache/jena/pull/463#discussion_r211191248 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/DynamicDatasets.java --- @@ -56,8 +55,8 @@ public static DatasetGraph dynamicDataset(DatasetDescription description, Datase if (description.isEmpty() ) return dsg; -Set defaultGraphs = NodeUtils.convertToNodes(description.getDefaultGraphURIs()) ; -Set namedGraphs = NodeUtils.convertToNodes(description.getNamedGraphURIs()) ; +Collection defaultGraphs = NodeUtils.convertToNodes(description.getDefaultGraphURIs()) ; --- End diff -- Isn't the point of using sets here to remove duplicates or is that now done in the `NodeUtils.convertToNodes()` method? ---
[jira] [Updated] (JENA-1592) Query over graphs from TDB2 do not invoke the TDB solver
[ https://issues.apache.org/jira/browse/JENA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-1592: Description: If a graph from a TDB2 dataset is queried, it is supposed (via TDB2's StageGeneratorDirectTDB), becomes a call to the TDB2 solver with the whole basic graph pattern. This then does the BGP step inside TDB2, more efficiently and with the possibility of a security filter. > Query over graphs from TDB2 do not invoke the TDB solver > > > Key: JENA-1592 > URL: https://issues.apache.org/jira/browse/JENA-1592 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.9.0 > > > If a graph from a TDB2 dataset is queried, it is supposed (via TDB2's > StageGeneratorDirectTDB), becomes a call to the TDB2 solver with the whole > basic graph pattern. This then does the BGP step inside TDB2, more > efficiently and with the possibility of a security filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JENA-1592) Query over graphs from TDB2 do not invoke the TDB solver
[ https://issues.apache.org/jira/browse/JENA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-1592: Affects Version/s: Jena 3.8.0 > Query over graphs from TDB2 do not invoke the TDB solver > > > Key: JENA-1592 > URL: https://issues.apache.org/jira/browse/JENA-1592 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Priority: Major > Fix For: Jena 3.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JENA-1592) Query over graphs from TDB2 do not invoke the TDB solver
[ https://issues.apache.org/jira/browse/JENA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-1592: Component/s: TDB2 > Query over graphs from TDB2 do not invoke the TDB solver > > > Key: JENA-1592 > URL: https://issues.apache.org/jira/browse/JENA-1592 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Priority: Major > Fix For: Jena 3.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JENA-1592) Query over graphs from TDB2 do not invoke the TDB solver
[ https://issues.apache.org/jira/browse/JENA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-1592: Fix Version/s: Jena 3.9.0 > Query over graphs from TDB2 do not invoke the TDB solver > > > Key: JENA-1592 > URL: https://issues.apache.org/jira/browse/JENA-1592 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Priority: Major > Fix For: Jena 3.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (JENA-1592) Query over graphs from TDB2 do not invoke the TDB solver
[ https://issues.apache.org/jira/browse/JENA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne reassigned JENA-1592: --- Assignee: Andy Seaborne > Query over graphs from TDB2 do not invoke the TDB solver > > > Key: JENA-1592 > URL: https://issues.apache.org/jira/browse/JENA-1592 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Assignee: Andy Seaborne >Priority: Major > Fix For: Jena 3.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (JENA-1592) Query over raphs from TDB2 do not
Andy Seaborne created JENA-1592: --- Summary: Query over raphs from TDB2 do not Key: JENA-1592 URL: https://issues.apache.org/jira/browse/JENA-1592 Project: Apache Jena Issue Type: Improvement Reporter: Andy Seaborne -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JENA-1592) Query over graphs from TDB2 do not invoke the TDB solver
[ https://issues.apache.org/jira/browse/JENA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-1592: Summary: Query over graphs from TDB2 do not invoke the TDB solver (was: Query over raphs from TDB2 do not ) > Query over graphs from TDB2 do not invoke the TDB solver > > > Key: JENA-1592 > URL: https://issues.apache.org/jira/browse/JENA-1592 > Project: Apache Jena > Issue Type: Improvement > Components: TDB2 >Affects Versions: Jena 3.8.0 >Reporter: Andy Seaborne >Priority: Major > Fix For: Jena 3.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jena pull request #463: Cleanup
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/463 ---
