Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/406
I agree with you @osma. I have made the changes to use QueryParserBase
instead of custom logic. Let me know if it is OK.
---
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/406#discussion_r183642709
--- Diff:
jena-text-es/src/main/java/org/apache/jena/query/text/es/TextIndexES.java ---
@@ -422,6 +422,27 @@ public EntityDefinition getDocDef
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/406#discussion_r183512768
--- Diff:
jena-text-es/src/main/java/org/apache/jena/query/text/es/TextIndexES.java ---
@@ -422,6 +422,27 @@ public EntityDefinition getDocDef
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/406#discussion_r183507712
--- Diff:
jena-text-es/src/main/java/org/apache/jena/query/text/es/TextIndexES.java ---
@@ -422,6 +422,27 @@ public EntityDefinition getDocDef
GitHub user anujgandharv opened a pull request:
https://github.com/apache/jena/pull/406
Jena Text ES | Added support for escaping special characters in search
strings
Added support for escaping special characters in search strings
You can merge this pull request into a Git
Github user anujgandharv closed the pull request at:
https://github.com/apache/jena/pull/405
---
GitHub user anujgandharv opened a pull request:
https://github.com/apache/jena/pull/405
JENA-1532 | fix for date based text query search
Added fix for Date based searching in Jena Elasticsearch text Index.
You can merge this pull request into a Git repository by running:
$ git
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Thanks Osma for incorporating the changes into master. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Thanks @osma . Can you point me to the SNAPSHOT repo please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
@osma I have merged the changes from Master into my branch.
I am fine with merging the code on Monday/Tuesday. Can you also let me know
when will 3.3.0 be released? Currently, to not stop us
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Cool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
@osma @ajs6f I have made the necessary changes to the ES TextIndex based on
changes in #226
I want to bring one thing to notice:
If the query string is: `?s text:query ('word' 'lang:en
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/226
Thanks @osma . I learned from you that: _It's always good to have Unit
Tests for the changes to make sure we are not missing any corner cases :)_
So just to clarify, if the Sparql
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107701838
--- Diff: jena-text/pom.xml ---
@@ -112,11 +141,73 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/226
@osma I do not see any Unit/Integration tests updated for Lucene for the
changes you have done in this PR. Do they come in a separate PR? In the mean
time, can you provide me some examples
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
@osma Let me try to merge your changes in #226 to my code and see if I can
turn it around today.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107681374
--- Diff: jena-text/src/main/java/examples/JenaESTextExample.java ---
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107681126
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/assembler/TextIndexESAssembler.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107681054
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,435 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107681154
--- Diff: jena-text/src/main/resources/text-config-es.ttl ---
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107681019
--- Diff: jena-text/pom.xml ---
@@ -112,11 +141,73 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107681104
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/assembler/TextIndexESAssembler.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107680990
--- Diff: jena-text/pom.xml ---
@@ -81,6 +81,35 @@
lucene-queryparser
+
+ org.elasticsearch
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107680962
--- Diff: jena-parent/pom.xml ---
@@ -275,6 +276,27 @@
${ver.spatial4j
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107437003
--- Diff: jena-text/pom.xml ---
@@ -112,11 +141,77 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
@osma @ajs6f I have added integration tests for ES based Indexing Strategy.
Could you guys please review and let me know if they are fine and if I missed
anything.
I do not have any more
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Great. Thanks @Osma. I misunderstood your previous comment. I will
implement the integration tests for the above scenarios.
---
If your project is set up for it, you can reply to this email
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Thanks @osma and @ajs6f for your inputs. Can I then suggest that instead of
moving TestTextIndexES to integration tests module, lets get rid of it
completely and instead have the same tests
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
This is the error I am getting
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.253 sec
<<< FAILURE! - in org.apache.jena.query.text.it.Text
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
@osma spring-elasticsearch IT is throwing exactly the same error that I am
getting on my setup. What they have done is they are ignoring all the errors
and assuming there are no errors, thus
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
@osma @ajs6f I have tried the ES Maven plugin but it is throwing me lots of
errors. I suspect that it is just a wrapper around the embedded elasticsearch.
I asked the creator to provide a more
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106870357
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106869941
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106869330
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106641289
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106636373
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106624906
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Thanks @ajs6f for the Maven ElasticSearch Plugin link. Looks like this
would enable us to spin up a fully functional Single Node ES for our
integration tests. Can you share some more light
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106431068
--- Diff: jena-text/text-config.ttl ---
@@ -50,6 +50,7 @@ text:TextIndexLucene rdfs:subClassOf text:TextIndex .
<#indexLuc
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106431036
--- Diff: jena-text/testing/TextQuery/text-config.ttl ---
@@ -31,6 +31,7 @@ text:TextIndexLucene rdfs:subClassOf text:TextIndex
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106430285
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106429946
--- Diff: jena-text/pom.xml ---
@@ -81,6 +81,51 @@
lucene-queryparser
+
+ org.elasticsearch
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106429891
--- Diff: jena-parent/pom.xml ---
@@ -275,6 +276,75 @@
${ver.spatial4j
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106429678
--- Diff: jena-text/pom.xml ---
@@ -115,6 +160,7 @@
**/TS_*.java
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106429631
--- Diff: jena-text/src/main/java/examples/JenaESTextExample.java ---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106429441
--- Diff: jena-text/src/main/java/examples/JenaESTextExample.java ---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106428753
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106428563
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106428124
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106428015
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106427299
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,394 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106420753
--- Diff:
jena-text/src/test/java/org/apache/jena/query/text/TestTextIndexES.java ---
@@ -0,0 +1,184 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Thanks @osma. I think the Index will becoe much simpler if we remove the
non-used methods
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
Hi @osma I need one more favour from you. I need to understand the scenario
when the 'get' method of TextIndex gets called. Can you provide me an example
Sparql query which I can run from my
Github user anujgandharv commented on the issue:
https://github.com/apache/jena/pull/227
@osma Can you review now. I have made the changes to the Add and Delete API
so that they are executed as a single REST call. I think we already have
consensus on the Multilingual aspect
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106198915
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106199137
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106199017
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106158114
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106156794
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106156573
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106155260
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106153769
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106154731
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106154642
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106154483
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106154421
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,427 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106152321
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/assembler/TextAssembler.java
---
@@ -29,14 +29,15 @@ public static void init
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106151647
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/ESSettings.java ---
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106151289
--- Diff: jena-text/src/main/java/examples/JenaESTextExample.java ---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106153318
--- Diff:
jena-text/src/test/java/org/apache/jena/query/text/TestTextIndexES.java ---
@@ -0,0 +1,184 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106151436
--- Diff: jena-text/src/main/java/examples/JenaTextExample1.java ---
@@ -41,9 +41,9 @@
public static void main(String ... argv
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106151951
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextDatasetFactory.java ---
@@ -27,7 +27,7 @@
import org.apache.jena.system.JenaSystem
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106152482
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/assembler/TextIndexESAssembler.java
---
@@ -0,0 +1,129 @@
+/**
+ * Licensed
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106153611
--- Diff: jena-text/pom.xml ---
@@ -81,39 +81,50 @@
lucene-queryparser
-
-
- solr-solrj
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106151618
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/ESSettings.java ---
@@ -0,0 +1,177 @@
+/**
+ * Licensed to the Apache Software
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r106145497
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/TextIndexES.java ---
@@ -0,0 +1,425 @@
+/**
+ * Licensed to the Apache Software
GitHub user anujgandharv opened a pull request:
https://github.com/apache/jena/pull/227
JENA-1305 | Elastic search support for Jena Text
Implemented ES support for Jena Text Indexing capability
You can merge this pull request into a Git repository by running:
$ git pull https
78 matches
Mail list logo
