[GitHub] [jmeter] vlsi commented on pull request #628: Add a boolean property to choose if we want to propagate the state of…

2020-10-21 Thread GitBox
vlsi commented on pull request #628: URL: https://github.com/apache/jmeter/pull/628#issuecomment-713544056 Frankly speaking, I don't know how to display "disabled item" vs "enabled but located under a disabled item", so let's revert 558 for now.

[GitHub] [jmeter] pmouawad commented on pull request #628: Add a boolean property to choose if we want to propagate the state of…

2020-10-21 Thread GitBox
pmouawad commented on pull request #628: URL: https://github.com/apache/jmeter/pull/628#issuecomment-713530070 Hello @vlsi , unless you have time to implement your proposal, I would suggest to revert #558 as you suggested. Current behaviour is indeed problematic whenever you use some

[GitHub] [jmeter] pmouawad commented on pull request #615: Add: ElasticSearch backend listener

2020-10-21 Thread GitBox
pmouawad commented on pull request #615: URL: https://github.com/apache/jmeter/pull/615#issuecomment-713529253 Thanks for your answer. I'll close this PR for now. Thanks This is an automated message from the Apache Git

[GitHub] [jmeter] pmouawad closed pull request #615: Add: ElasticSearch backend listener

2020-10-21 Thread GitBox
pmouawad closed pull request #615: URL: https://github.com/apache/jmeter/pull/615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [jmeter] vlsi commented on a change in pull request #544: Add BackendListener that sends "raw" results to InfluxDB

2020-10-21 Thread GitBox
vlsi commented on a change in pull request #544: URL: https://github.com/apache/jmeter/pull/544#discussion_r509226219 ## File path: src/components/src/test/groovy/org/apache/jmeter/visualizers/backend/influxdb/InfluxDBRawBackendListenerClientSpec.groovy ## @@ -0,0 +1,97 @@

Re: Release JMeter 5.4

2020-10-21 Thread Philippe Mouawad
Hello Felix, Thanks for your answer. Yes all pending issues I am aware of have now been fixed. The two things we need to decide relate to whether we want to merge: - Autocorrelation in Alpha: https://github.com/apache/jmeter/pull/499 - Raw InfluxDB BackendListener client:

[GitHub] [jmeter] vlsi commented on pull request #632: Add Error Prone code style verification

2020-10-21 Thread GitBox
vlsi commented on pull request #632: URL: https://github.com/apache/jmeter/pull/632#issuecomment-713468232 > if it doesn't break the build when running with Java 8 All the previous CI jobs pass, so it works. In practice, it is activated only in case `-PenableErrorprone` is added

Re: Pacing Iteration Timer or Sampler, what the impact to change

2020-10-21 Thread Felix Schumacher
Hi Vincent, what were you trying to tell us, with the picture of that action? Felix Am 05.10.20 um 19:28 schrieb Vincent Daburon:

Re: Release JMeter 5.4

2020-10-21 Thread Felix Schumacher
Am 17.10.20 um 15:18 schrieb Philippe Mouawad: > Hello, > I hope you’re all doing well. > > I am starting a new thread as the old one related to 5.3.1 seems to keep us > in a stuck state :) and we are now more in a position for a 5.4. > > So, what about releasing a 5.4 ? My last information

[GitHub] [jmeter] FSchumacher commented on pull request #632: Add Error Prone code style verification

2020-10-21 Thread GitBox
FSchumacher commented on pull request #632: URL: https://github.com/apache/jmeter/pull/632#issuecomment-713433154 My biggest concern with this PR at the moment is its size. Could we add the feature (errorprone) without changing every nag it shows? I tend to get bored when looking at big