Re: Release 5.3

2020-05-09 Thread Felix Schumacher
Am 09.05.20 um 18:25 schrieb Milamber: > > I can do the release. When you prefer ? I committed the fix for 64267, so I think we are ready to go. Feel free to prepare a release candidate. Thanks for your work  Felix > > On 5/8/20 7:41 PM, Philippe Mouawad wrote: >> Hello, >> I approved PR

Re: Release 5.3

2020-05-09 Thread Milamber
I can do the release. When you prefer ? On 5/8/20 7:41 PM, Philippe Mouawad wrote: Hello, I approved PR also. Any volunteer for Release ? Regards On Fri, May 8, 2020 at 5:25 PM Felix Schumacher < felix.schumac...@internetallee.de> wrote: Am 05.05.20 um 21:22 schrieb Philippe Mouawad:

Re: Release 5.3

2020-05-09 Thread Felix Schumacher
I will commit the PR. On the other hand, I think we should take a deeper look at bug 64267, even if we didn't get any earlier bug report on this. Felix Am 08.05.20 um 21:41 schrieb Philippe Mouawad: > Hello, > I approved PR also. > > Any volunteer for Release ? > > Regards > > On Fri, May 8,

Re: Release 5.3

2020-05-08 Thread Philippe Mouawad
Hello, I approved PR also. Any volunteer for Release ? Regards On Fri, May 8, 2020 at 5:25 PM Felix Schumacher < felix.schumac...@internetallee.de> wrote: > > Am 05.05.20 um 21:22 schrieb Philippe Mouawad: > > Hello, > > Good catch, yes it is required. > > > > Shall we release or do this

Re: Release 5.3

2020-05-05 Thread Philippe Mouawad
Hello, Good catch, yes it is required. Shall we release or do this before ? Thanks Regards On Sun, May 3, 2020 at 2:20 PM Felix Schumacher < felix.schumac...@internetallee.de> wrote: > > Am 07.04.20 um 13:18 schrieb Vladimir Sitnikov: > >> Let's update to Groovy 3. > > I see that we currently

Re: Release 5.3

2020-05-03 Thread Felix Schumacher
Am 07.04.20 um 13:18 schrieb Vladimir Sitnikov: >> Let's update to Groovy 3. > I see that we currently use groovy-all dependency. > Unfortunately, it is unpredictable, as it adds new transitive dependencies > as Groovy evolves. > > I guess we need to specify which dependencies we include

Re: Release 5.3

2020-05-02 Thread Philippe Mouawad
Hello, Just a little update to say, the last issue seems to be also fixed by 2.1.1 Regards On Saturday, May 2, 2020, Philippe Mouawad wrote: > Hello all, > I hope you're fine. > > I upgraded to 2.1.1 of Darklaf (Thanks Jannis for reactivity) and it fixed > 2 issues seen: > >- NPE when

Re: Release 5.3

2020-05-02 Thread Philippe Mouawad
Hello all, I hope you're fine. I upgraded to 2.1.1 of Darklaf (Thanks Jannis for reactivity) and it fixed 2 issues seen: - NPE when saving file (https://github.com/weisJ/darklaf/issues/157) - https://github.com/weisJ/darklaf/issues/155 But I am still facing this one, do you also confirm

Re: Release 5.3

2020-04-30 Thread Philippe Mouawad
Thanks Jannis Upgraded to 2.1.0, issue is fixed. But I see 2 new blocking issues: https://github.com/weisJ/darklaf/issues/156 (not sure it's a new one) https://github.com/weisJ/darklaf/issues/155 (it's a new one for sure) Regards On Wed, Apr 29, 2020 at 5:49 PM wrote: > Hello, > > the issue is

Re: Release 5.3

2020-04-29 Thread weisj
Hello, the issue is already fixed in the current upstream version of Darklaf. I’ll probably release the next version tomorrow or on Friday. The setting to render/edit booleans as checkboxes can also be disabled manually using the “darklaf.tableBooleanRenderer=false” and

Re: Release 5.3

2020-04-29 Thread Philippe Mouawad
Hello, Another issue related to DarkLaf I think. Checkboxes "encode?" is not checkable in HTTP Request That's a blocker one Regards On Sun, Apr 26, 2020 at 6:26 PM Philippe Mouawad wrote: > Hello, > Regression seen here: > https://bz.apache.org/bugzilla/show_bug.cgi?id=64382 > > Regards > > On

Add Pull Request #571 to the Release 5.3

2020-04-27 Thread Vincent Daburon
I send a pull request #571 about : Add prefix or suffix sampler numbering for HTTP Test Script Recorder #571 https://github.com/apache/jmeter/pull/571 Does this pull request could be merge in the Release 5.3 ? I can send the documentation upgrade this day if you merge this pool request. Regards

Re: Release 5.3

2020-04-26 Thread Philippe Mouawad
Hello, Regression seen here: https://bz.apache.org/bugzilla/show_bug.cgi?id=64382 Regards On Sat, Apr 25, 2020 at 3:09 PM Philippe Mouawad wrote: > Hello, > The two issues are now fixed. > I guess we can start a release. > > Regards > > On Sat, Apr 11, 2020 at 12:14 PM Philippe Mouawad < >

Re: Release 5.3

2020-04-25 Thread Philippe Mouawad
Hello, The two issues are now fixed. I guess we can start a release. Regards On Sat, Apr 11, 2020 at 12:14 PM Philippe Mouawad < philippe.moua...@gmail.com> wrote: > Hello, > 2 other issues: > >- https://bz.apache.org/bugzilla/show_bug.cgi?id=64340 >-

Re: Release 5.3

2020-04-11 Thread Philippe Mouawad
Hello, 2 other issues: - https://bz.apache.org/bugzilla/show_bug.cgi?id=64340 - https://github.com/weisJ/darklaf/issues/135 Regards On Thu, Apr 9, 2020 at 3:31 PM Philippe Mouawad wrote: > Hello, > I have found a blocker issue with release. > See: >

Re: Release 5.3

2020-04-09 Thread Philippe Mouawad
Hello, I have found a blocker issue with release. See: https://github.com/weisJ/darklaf/issues/133 Regards On Wed, Apr 8, 2020 at 7:25 PM Antonio Gomes Rodrigues wrote: > Hi > > i have tested JMeter-Plugins in the latest nightly build of JMeter in Linux > Ubuntu and it's ok (no more errors) >

Re: Release 5.3

2020-04-08 Thread Antonio Gomes Rodrigues
Hi i have tested JMeter-Plugins in the latest nightly build of JMeter in Linux Ubuntu and it's ok (no more errors) Le mer. 8 avr. 2020 à 17:17, Philippe Mouawad a écrit : > Hello, > JMeter-Plugins has been released. Can somebody else test if it's ok ? > > Thanks > > On Tue, Apr 7, 2020 at 8:46

Re: Release 5.3

2020-04-08 Thread Philippe Mouawad
Hello, JMeter-Plugins has been released. Can somebody else test if it's ok ? Thanks On Tue, Apr 7, 2020 at 8:46 PM Philippe Mouawad wrote: > > > On Tue, Apr 7, 2020 at 8:37 PM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > >> Philippe>I would add those 2: >> Philippe> -

Re: Release 5.3

2020-04-07 Thread Philippe Mouawad
On Tue, Apr 7, 2020 at 8:37 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Philippe>I would add those 2: > Philippe> - org.codehaus.groovy:groovy-templates : > Philippe> > > https://docs.groovy-lang.org/docs/next/html/documentation/template-engines.html > Philippe> -

Re: Release 5.3

2020-04-07 Thread Vladimir Sitnikov
Philippe>I would add those 2: Philippe> - org.codehaus.groovy:groovy-templates : Philippe> https://docs.groovy-lang.org/docs/next/html/documentation/template-engines.html Philippe> - org.codehaus.groovy:groovy-xml : XmlSlurper The libraries were on my list as well: Vladimir> How about

Re: Release 5.3

2020-04-07 Thread Philippe Mouawad
Thanks for analysis. I would add those 2: - org.codehaus.groovy:groovy-templates : https://docs.groovy-lang.org/docs/next/html/documentation/template-engines.html - org.codehaus.groovy:groovy-xml : XmlSlurper I'm sure I've used them in tests I built. Don't we also need: -

RE: Release 5.3

2020-04-06 Thread 井元 崇之
nal Message- From: Alexander Podelko Sent: Saturday, April 4, 2020 5:42 AM To: dev@jmeter.apache.org Subject: Re: Release 5.3 Yes, I am. On Friday, April 3, 2020, 4:25:45 PM EDT, Philippe Mouawad wrote: Kon'nichiwa IMOTO-san, Thank you for your big contribution ! I see now that it d

Re: Release 5.3

2020-04-03 Thread Alexander Podelko
der merge this feature. If so we want to support it. > > Thanks. > > -Original Message- > From: Alexander Podelko > Sent: Friday, April 3, 2020 12:52 AM > To: ApacheJMeter dev list > Subject: Re: Release 5.3 > >  My user view after trying it once: > -Some co

Re: Release 5.3

2020-04-03 Thread Philippe Mouawad
inal Message- > From: Alexander Podelko > Sent: Friday, April 3, 2020 12:52 AM > To: ApacheJMeter dev list > Subject: Re: Release 5.3 > > My user view after trying it once: > -Some correlation help functionality is needed-That functionality is > complex and will neve

RE: Release 5.3

2020-04-03 Thread 井元 崇之
So can you consider merge this feature. If so we want to support it. Thanks. -Original Message- From: Alexander Podelko Sent: Friday, April 3, 2020 12:52 AM To: ApacheJMeter dev list Subject: Re: Release 5.3 My user view after trying it once: -Some correlation help functionality i

Re: Release 5.3

2020-04-03 Thread Philippe Mouawad
Hello, PR has been merged but version is not released yet. See my answers inline below. Regards On Fri, Apr 3, 2020 at 10:57 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > >3) What about upgrade to groovy ? Do we skip it for this release ? > > Let's update to Groovy 3. > > >2) I

Re: Release 5.3

2020-04-03 Thread Vladimir Sitnikov
>3) What about upgrade to groovy ? Do we skip it for this release ? Let's update to Groovy 3. >2) I upgraded some dependencies, but github is facing an incident so we >didn't get the mail Thanks. I suggest we stop adding lines like "Updated equalsverifier to 3.1.9 (from 3.1.12)" to

Re: Release 5.3

2020-04-02 Thread Philippe Mouawad
Hello , 1) I submitted a PR for JMP 2) I upgraded some dependencies, but github is facing an incident so we didn't get the mail 3) What about upgrade to groovy ? Do we skip it for this release ? Thanks On Thu, Apr 2, 2020 at 6:55 PM Felix Schumacher < felix.schumac...@internetallee.de> wrote:

Re: Release 5.3

2020-04-02 Thread Felix Schumacher
Am 02.04.20 um 11:32 schrieb Vladimir Sitnikov: > Hi, > > It's been a long since JMeter 5.2.1, so I guess 5.3 is long overdue. > > How about we release JMeter 5.3? Apart from the objection from Philippe, I am fine with a release. Felix > > Vladimir >

Re: Release 5.3

2020-04-02 Thread Alexander Podelko
My user view after trying it once: -Some correlation help functionality is needed-That functionality is complex and will never be perfect -That project definitely provides some correlation help-My understanding is that there is no other competing projects [I saw some other projects/proposals

Re: Release 5.3

2020-04-02 Thread Vladimir Sitnikov
>I didn't have opportunity to review it more deeply or test it on real life >case. Same for me :-( >Should we request users to test it and give feedback ? >I have seen 2 or 3 very interested. My understanding is we have a chicken and egg problem here. JMeter releases are very rare, so features

Re: Release 5.3

2020-04-02 Thread Philippe Mouawad
Hello, I don't think it is. There are pending remarks done on PR that have not been taken into account yet. I didn't have opportunity to review it more deeply or test it on real life case. Should we request users to test it and give feedback ? I have seen 2 or 3 very interested. Regards On

Re: Release 5.3

2020-04-02 Thread Vladimir Sitnikov
Alexander> What about auto-correlation https://github.com/apache/jmeter/pull/499 ? Do you think it is ready for merge as is? Vladimir

Re: Release 5.3

2020-04-02 Thread Alexander Podelko
What about auto-correlation  https://github.com/apache/jmeter/pull/499 ? On Thursday, April 2, 2020, 5:55:11 AM EDT, Philippe Mouawad wrote: Hello I didn't have time yet to contribute a fix to jmeter-plugins-manager Regards On Thu, Apr 2, 2020 at 11:48 AM Antonio Gomes Rodrigues

Re: Release 5.3

2020-04-02 Thread Vladimir Sitnikov
>if the work about improve UX is done There's always room for UX, however, the further improvements might come with upcoming versions. For instance, upcoming Darklaf would have high contrast theme, and it would support OS notifications for UI preferences (e.g. switch JMeter between light-dark as

Re: Release 5.3

2020-04-02 Thread Philippe Mouawad
Hello I didn't have time yet to contribute a fix to jmeter-plugins-manager Regards On Thu, Apr 2, 2020 at 11:48 AM Antonio Gomes Rodrigues wrote: > Hi, > > +1 if the work about improve UX is done > > > Le jeu. 2 avr. 2020 à 11:32, Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> > a écrit : >

Re: Release 5.3

2020-04-02 Thread Antonio Gomes Rodrigues
Hi, +1 if the work about improve UX is done Le jeu. 2 avr. 2020 à 11:32, Vladimir Sitnikov a écrit : > Hi, > > It's been a long since JMeter 5.2.1, so I guess 5.3 is long overdue. > > How about we release JMeter 5.3? > > Vladimir >

Release 5.3

2020-04-02 Thread Vladimir Sitnikov
Hi, It's been a long since JMeter 5.2.1, so I guess 5.3 is long overdue. How about we release JMeter 5.3? Vladimir