Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73691076
--- Diff: src/core/org/apache/jmeter/util/ScriptingTestElement.java ---
@@ -36,6 +36,8 @@
private String script = ""; // script (if file not provided)
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
Hi vladimir,
Can you give me more details to avoid logging a warning on each sampler
execution?
I don't know how to implement
Thanks
Antonio
---
If your project is set up
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
>I don't know how to implement
For instance, a boolean flag that is cleared after the fist warning is
printed.
---
If your project is set up for it, you can reply to this email and have your
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/224
Hi,
HTML render display the HTML and not the source code of HTML
If we add a checkbox, it can be only for Text render (and not for the
other)?
In my opinion, it will be
Github user ubikloadpack commented on the issue:
https://github.com/apache/jmeter/pull/223
Hello,
Thanks for PR.
My notes:
- defaultScriptLanguage should be uppercase being a constant.
- use StringUtils.isEmpty to avoid spaces breaking the control
-
Github user ubikloadpack commented on the issue:
https://github.com/apache/jmeter/pull/224
Hello,
Thanks for PR.
Wouldn't it be more user friendly to add a checkbox on the existing HTML
viewer to format or not the HTML ?
Regards
@ubikloadpack
---
If your project
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/224
Yes you're correct, I meant Text renderer but in that case formatting does
not really make sense as it can be anything (not only html)
---
If your project is set up for it, you can reply to this
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
Hi ubikloadpack,
Your solution seem good
I will implement it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
-1 for logging a warning on each sampler execution.
Typical user would never open log files, and get bad performance results
(or even log overflow of some kind)
---
If your project is set up for
Github user ra0077 commented on the issue:
https://github.com/apache/jmeter/pull/223
It's don't work :-(
protected ScriptEngine getScriptEngine() throws ScriptException {
String lang = getScriptLanguage();
if (StringUtils.isEmpty(lang))
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/224
+1 for commiting it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Hello,
I tend to follow Vladimir's reasoning on this.
Next release would support Java7 , I suppose it would be released around
september (which is more than 4 month after 3.0), based on this speed,
Java8 would concern a release made on january or february.
I believe maintaining a new branch for
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/225
Hello,
I find it interesting to have the version of libraries .
So I am not keen on changing it.
Regards
---
If your project is set up for it, you can reply to this email and have
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/223
Hello,
In my opinion, you should commit it and we can improve it with further
commits.
I agree with @vlsi on the performance involvement of warn logging , but
we'll find a solution if you
GitHub user ra0077 opened a pull request:
https://github.com/apache/jmeter/pull/225
BUG59951_BetterScriptLanguageChooseDisplayJSR223
Hi,
In my opinion, bundle don't need to be display in "script language
choice" list in JSR223 elements
It's useless for the majority
15 matches
Mail list logo
