[GitHub] [jmeter] wkurniawan07 commented on a diff in pull request #708: Add necessary fixes for passing CI build

2022-04-12 Thread GitBox
wkurniawan07 commented on code in PR #708: URL: https://github.com/apache/jmeter/pull/708#discussion_r848992665 ## src/protocol/tcp/src/main/java/org/apache/jmeter/protocol/tcp/sampler/TCPClientImpl.java: ## @@ -115,11 +116,15 @@ public String read(InputStream is, SampleResult

[GitHub] [jmeter] FSchumacher commented on pull request #708: Add necessary fixes for passing CI build

2022-04-13 Thread GitBox
FSchumacher commented on PR #708: URL: https://github.com/apache/jmeter/pull/708#issuecomment-1097725078 > Not that I disagree about it, but this catch block here is unavoidable. It is thrown because `w.toString(CHARSET)` is called from within `throw new ReadException(...)`. This is avoi

[GitHub] [jmeter] asfgit closed pull request #708: Add necessary fixes for passing CI build

2022-04-13 Thread GitBox
asfgit closed pull request #708: Add necessary fixes for passing CI build URL: https://github.com/apache/jmeter/pull/708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [jmeter] FSchumacher commented on pull request #708: Add necessary fixes for passing CI build

2022-04-13 Thread GitBox
FSchumacher commented on PR #708: URL: https://github.com/apache/jmeter/pull/708#issuecomment-1098118302 Thanks again for the PR, error prone will be happier now and I haven't added any bigger issues with my changes to your code. -- This is an automated message from the Apache Git Service

[GitHub] [jmeter] pmouawad opened a new pull request, #709: Revert Bugfix 65885

2022-05-01 Thread GitBox
pmouawad opened a new pull request, #709: URL: https://github.com/apache/jmeter/pull/709 ## Description ## Motivation and Context Fixes regression introduced by bugfix to 65885 ## How Has This Been Tested? - JUnit test update - Manual testing by running

[GitHub] [jmeter] codecov-commenter commented on pull request #709: Revert Bugfix 65885

2022-05-01 Thread GitBox
codecov-commenter commented on PR #709: URL: https://github.com/apache/jmeter/pull/709#issuecomment-1114314588 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/709?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] rollno748 opened a new pull request, #710: Added Shortcut key event for Reset search - 66053

2022-05-06 Thread GitBox
rollno748 opened a new pull request, #710: URL: https://github.com/apache/jmeter/pull/710 ## Description Shortcut key to Reset Search ## Motivation and Context This shortcut will help to Reset Search while enhancing or debugging the script ## How Has This Been Tested?

[GitHub] [jmeter] codecov-commenter commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-06 Thread GitBox
codecov-commenter commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1120077529 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/710?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] Tinywan opened a new pull request, #711: Update get-started.xml

2022-05-07 Thread GitBox
Tinywan opened a new pull request, #711: URL: https://github.com/apache/jmeter/pull/711 ## Description ## Motivation and Context ## How Has This Been Tested? ## Screenshots (if appropriate): ## Types of changes - Bug fix (non-brea

[GitHub] [jmeter] codecov-commenter commented on pull request #711: Update get-started.xml

2022-05-07 Thread GitBox
codecov-commenter commented on PR #711: URL: https://github.com/apache/jmeter/pull/711#issuecomment-1120172976 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/711?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-07 Thread GitBox
rollno748 commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1120185917 @vlsi - can you please review and approve Its just a minor change in adding shortcut -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jmeter] vlsi opened a new pull request, #712: Use kotlinx-coroutines for UI launcher

2022-05-09 Thread GitBox
vlsi opened a new pull request, #712: URL: https://github.com/apache/jmeter/pull/712 ## Description This PR moves `startGui` from `class JMeter` to another class. ## Motivation and Context a) It is nice to factor UI from non-UI code b) Current code fails to update prog

[GitHub] [jmeter] vlsi commented on a diff in pull request #712: Use kotlinx-coroutines for UI launcher

2022-05-09 Thread GitBox
vlsi commented on code in PR #712: URL: https://github.com/apache/jmeter/pull/712#discussion_r867880630 ## src/core/src/main/java/org/apache/jmeter/JMeterGuiLauncher.kt: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [jmeter] vlsi commented on a diff in pull request #712: Use kotlinx-coroutines for UI launcher

2022-05-09 Thread GitBox
vlsi commented on code in PR #712: URL: https://github.com/apache/jmeter/pull/712#discussion_r867881621 ## src/core/src/main/java/org/apache/jmeter/JMeterGuiLauncher.kt: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [jmeter] vlsi opened a new pull request, #713: Update Kotlin to 1.6.21

2022-05-09 Thread GitBox
vlsi opened a new pull request, #713: URL: https://github.com/apache/jmeter/pull/713 See https://kotlinlang.org/docs/whatsnew1620.html ## Motivation and Context Note: Kotlin is a new dependency in JMeter 5.5, so let's start with an up-to-date version. ## Checklist:

[GitHub] [jmeter] vlsi commented on a diff in pull request #711: Update get-started.xml

2022-05-09 Thread GitBox
vlsi commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r868368164 ## xdocs/usermanual/get-started.xml: ## @@ -279,7 +279,7 @@ jmeter -t test.jmx … DDRAWJVM options to influence usage of direct draw, e.g. -Dsun.java2d.ddscale=true. Defaul

[GitHub] [jmeter] pmouawad commented on a diff in pull request #711: Update get-started.xml

2022-05-09 Thread GitBox
pmouawad commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r868371345 ## xdocs/usermanual/get-started.xml: ## @@ -279,7 +279,7 @@ jmeter -t test.jmx … DDRAWJVM options to influence usage of direct draw, e.g. -Dsun.java2d.ddscale=true. De

[GitHub] [jmeter] pmouawad merged pull request #709: Revert Bugfix 65885

2022-05-09 Thread GitBox
pmouawad merged PR #709: URL: https://github.com/apache/jmeter/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.or

[GitHub] [jmeter] pmouawad commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-09 Thread GitBox
pmouawad commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121507626 Hello @rollno748 , Thanks for contributing. Can you run ./gradlew autostyleApply and commit the result please ? Thank you -- This is an automated message from the Apache Git S

[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-09 Thread GitBox
rollno748 commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121514349 Thanks for reviewing it @pmouawad I have applied the autostyle and committed it -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jmeter] vlsi merged pull request #713: Update Kotlin to 1.6.21

2022-05-09 Thread GitBox
vlsi merged PR #713: URL: https://github.com/apache/jmeter/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org F

[GitHub] [jmeter] vlsi commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-09 Thread GitBox
vlsi commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121541948 Am I right the suggested shortcut is `ctrl+alt+f` to reset the search? Does it come from a standard? Have you considered using `esc` shortcut to reset the search? -- This is an autom

[GitHub] [jmeter] vlsi commented on a diff in pull request #713: Update Kotlin to 1.6.21

2022-05-09 Thread GitBox
vlsi commented on code in PR #713: URL: https://github.com/apache/jmeter/pull/713#discussion_r868421320 ## checksum.xml: ## @@ -35,6 +35,7 @@ + Review Comment: In case you wonder, the same key has already been listed for other Google groups. -- Thi

[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-09 Thread GitBox
rollno748 commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121550885 Yes the current shortcut is assigned to ctrl+alt+f to reset the search. I haven't considered the esc to set it as reset search. I thought, It would be easier for us to remember to go

[GitHub] [jmeter] codecov-commenter commented on pull request #712: Use kotlinx-coroutines for UI launcher

2022-05-09 Thread GitBox
codecov-commenter commented on PR #712: URL: https://github.com/apache/jmeter/pull/712#issuecomment-1121605827 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] Tinywan commented on a diff in pull request #711: Update get-started.xml

2022-05-09 Thread GitBox
Tinywan commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r868776856 ## xdocs/usermanual/get-started.xml: ## @@ -279,7 +279,7 @@ jmeter -t test.jmx … DDRAWJVM options to influence usage of direct draw, e.g. -Dsun.java2d.ddscale=true. Def

[GitHub] [jmeter] vlsi commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-10 Thread GitBox
vlsi commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1122159237 Frankly speaking, I think we should try using `ESC` shortcut for "resetting the search" -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053

2022-05-10 Thread GitBox
rollno748 commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1122210750 Cool, Thanks for the inputs. I will make that change and commit it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [jmeter] vlsi commented on pull request #712: Use kotlinx-coroutines for UI launcher

2022-05-11 Thread GitBox
vlsi commented on PR #712: URL: https://github.com/apache/jmeter/pull/712#issuecomment-1123799975 @pmouawad , @FSchumacher , team. do you have any thoughts/comments? I think this is pretty much mergeable, except I would like to make `JMeterGuiLauncher` private or something like that. I r

[GitHub] [jmeter] zisding opened a new pull request, #714: Fix to Bug 66061 - Refine the log message in DefaultSamplerCreator from the state of in progress to complete

2022-05-11 Thread GitBox
zisding opened a new pull request, #714: URL: https://github.com/apache/jmeter/pull/714 ## Description and Motivation Hello, While viewing the https://issues.apache.org/jira/browse/MAPREDUCE-4262, I found that the logging statements might give inaccurate messages. I als

[GitHub] [jmeter] nddipiazza opened a new pull request, #715: push jmeter changes

2022-05-12 Thread GitBox
nddipiazza opened a new pull request, #715: URL: https://github.com/apache/jmeter/pull/715 ## Description See https://bz.apache.org/bugzilla/show_bug.cgi?id=66062 we need a way to control sub-results in the summary report from jmeter's GUI. ## Motivation and Context Cannot

[GitHub] [jmeter] nddipiazza commented on pull request #715: Address 66062 - summary report support for sub-results

2022-05-13 Thread GitBox
nddipiazza commented on PR #715: URL: https://github.com/apache/jmeter/pull/715#issuecomment-1126083245 awesome looks like there are already messages so i can switch over to using JMeter ui elements sample_scope_all=Main sample and sub-samples sample_scope_children=Sub-samples only

[GitHub] [jmeter] codecov-commenter commented on pull request #715: Address 66062 - summary report support for sub-results

2022-05-15 Thread GitBox
codecov-commenter commented on PR #715: URL: https://github.com/apache/jmeter/pull/715#issuecomment-1126983277 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/715?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] josemiguel-chvz opened a new pull request, #716: Create build.yml

2022-06-02 Thread GitBox
josemiguel-chvz opened a new pull request, #716: URL: https://github.com/apache/jmeter/pull/716 ## Description ## Motivation and Context ## How Has This Been Tested? ## Screenshots (if appropriate): ## Types of changes - Bug fix (

[GitHub] [jmeter] josemiguel-chvz closed pull request #716: Create build.yml

2022-06-02 Thread GitBox
josemiguel-chvz closed pull request #716: Create build.yml URL: https://github.com/apache/jmeter/pull/716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [jmeter] pmouawad closed pull request #711: Update get-started.xml

2022-06-03 Thread GitBox
pmouawad closed pull request #711: Update get-started.xml URL: https://github.com/apache/jmeter/pull/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [jmeter] FSchumacher commented on a diff in pull request #711: Update get-started.xml

2022-06-03 Thread GitBox
FSchumacher commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r40898 ## xdocs/usermanual/get-started.xml: ## @@ -279,7 +279,7 @@ jmeter -t test.jmx … DDRAWJVM options to influence usage of direct draw, e.g. -Dsun.java2d.ddscale=true.

[GitHub] [jmeter] vlsi merged pull request #712: Use kotlinx-coroutines for UI launcher

2022-06-03 Thread GitBox
vlsi merged PR #712: URL: https://github.com/apache/jmeter/pull/712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org F

[GitHub] [jmeter] zisding commented on pull request #714: Fix to Bug 66061 - Refine the log message in DefaultSamplerCreator from the state of in progress to complete

2022-06-03 Thread GitBox
zisding commented on PR #714: URL: https://github.com/apache/jmeter/pull/714#issuecomment-1146292194 Hi @pmouawad @FSchumacher , Thanks for approving the comments. Really hope my contribution can make Jmeter more perfect, though the contribution is incremental. Based on the fee

[GitHub] [jmeter] pmouawad merged pull request #714: Fix to Bug 66061 - Refine the log message in DefaultSamplerCreator from the state of in progress to complete

2022-06-03 Thread GitBox
pmouawad merged PR #714: URL: https://github.com/apache/jmeter/pull/714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.or

[GitHub] [jmeter] vlsi opened a new pull request, #717: [66139] Ensure Open Model Thread Group initializes config elements only once

2022-06-23 Thread GitBox
vlsi opened a new pull request, #717: URL: https://github.com/apache/jmeter/pull/717 See https://bz.apache.org/bugzilla/show_bug.cgi?id=66139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [jmeter] codecov-commenter commented on pull request #718: doc: add load profile samples to Open Model Thread Group documentation

2022-06-29 Thread GitBox
codecov-commenter commented on PR #718: URL: https://github.com/apache/jmeter/pull/718#issuecomment-1170765893 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/718?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] codecov-commenter commented on pull request #717: [66139] Ensure Open Model Thread Group initializes config elements only once

2022-06-30 Thread GitBox
codecov-commenter commented on PR #717: URL: https://github.com/apache/jmeter/pull/717#issuecomment-1171225061 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/717?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] FSchumacher commented on a diff in pull request #717: [66139] Ensure Open Model Thread Group initializes config elements only once

2022-07-05 Thread GitBox
FSchumacher commented on code in PR #717: URL: https://github.com/apache/jmeter/pull/717#discussion_r913805737 ## src/core/src/main/java/org/apache/jmeter/engine/StandardJMeterEngine.java: ## @@ -84,6 +91,14 @@ public class StandardJMeterEngine implements JMeterEngine, Runnable

[GitHub] [jmeter] FSchumacher commented on a diff in pull request #718: doc: add load profile samples to Open Model Thread Group documentation

2022-07-05 Thread GitBox
FSchumacher commented on code in PR #718: URL: https://github.com/apache/jmeter/pull/718#discussion_r913822764 ## xdocs/usermanual/component_reference.xml: ## @@ -6521,17 +6521,39 @@ See JMeter's Classpath and The users are generated according to the schedule.

[GitHub] [jmeter] vlsi commented on a diff in pull request #717: [66139] Ensure Open Model Thread Group initializes config elements only once

2022-07-05 Thread GitBox
vlsi commented on code in PR #717: URL: https://github.com/apache/jmeter/pull/717#discussion_r913832043 ## src/core/src/main/java/org/apache/jmeter/engine/StandardJMeterEngine.java: ## @@ -84,6 +91,14 @@ public class StandardJMeterEngine implements JMeterEngine, Runnable {

[GitHub] [jmeter] FSchumacher opened a new pull request, #719: Enable darklaf on rsyntaxtextarea again

2022-07-05 Thread GitBox
FSchumacher opened a new pull request, #719: URL: https://github.com/apache/jmeter/pull/719 ## Description SyntaxTextAreas look bad on dark mode with Darklaf, as the id of the theme has been changed to all lowercase and we didn't recognize it anymore. [Bugzilla Id: 66157](https:

[GitHub] [jmeter] vlsi commented on a diff in pull request #719: Enable darklaf on rsyntaxtextarea again

2022-07-05 Thread GitBox
vlsi commented on code in PR #719: URL: https://github.com/apache/jmeter/pull/719#discussion_r913883223 ## src/core/src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java: ## @@ -200,7 +200,7 @@ public LookAndFeelCommand() { } public static boolean isDark

[GitHub] [jmeter] FSchumacher commented on a diff in pull request #719: Enable darklaf on rsyntaxtextarea again

2022-07-05 Thread GitBox
FSchumacher commented on code in PR #719: URL: https://github.com/apache/jmeter/pull/719#discussion_r913895403 ## src/core/src/main/java/org/apache/jmeter/gui/action/LookAndFeelCommand.java: ## @@ -200,7 +200,7 @@ public LookAndFeelCommand() { } public static boolean

[GitHub] [jmeter] asfgit closed pull request #719: Enable darklaf on rsyntaxtextarea again

2022-07-07 Thread GitBox
asfgit closed pull request #719: Enable darklaf on rsyntaxtextarea again URL: https://github.com/apache/jmeter/pull/719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [jmeter] vlsi commented on pull request #717: [66139] Ensure Open Model Thread Group initializes config elements only once

2022-07-07 Thread GitBox
vlsi commented on PR #717: URL: https://github.com/apache/jmeter/pull/717#issuecomment-1177762798 The test keeps failing at Travis. I'm inclined to disable the test and commit the code. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [jmeter] vlsi merged pull request #718: doc: add load profile samples to Open Model Thread Group documentation

2022-07-08 Thread GitBox
vlsi merged PR #718: URL: https://github.com/apache/jmeter/pull/718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org F

[GitHub] [jmeter] alexe187 opened a new pull request, #720: integrate sonarcube

2022-07-18 Thread GitBox
alexe187 opened a new pull request, #720: URL: https://github.com/apache/jmeter/pull/720 ## Description ## Motivation and Context ## How Has This Been Tested? ## Screenshots (if appropriate): ## Types of changes - Bug fix (non-bre

[GitHub] [jmeter] alexe187 commented on pull request #720: integrate sonarcube

2022-07-18 Thread GitBox
alexe187 commented on PR #720: URL: https://github.com/apache/jmeter/pull/720#issuecomment-1187603914 This is a private test of sonarcube with jmeter code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [jmeter] alexe187 commented on pull request #720: integrate sonarcube

2022-07-18 Thread GitBox
alexe187 commented on PR #720: URL: https://github.com/apache/jmeter/pull/720#issuecomment-1187604717 as private change in my fork => self approved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [jmeter] alexe187 closed pull request #720: integrate sonarcube

2022-07-18 Thread GitBox
alexe187 closed pull request #720: integrate sonarcube URL: https://github.com/apache/jmeter/pull/720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [jmeter] vlsi commented on pull request #720: integrate sonarcube

2022-07-18 Thread GitBox
vlsi commented on PR #720: URL: https://github.com/apache/jmeter/pull/720#issuecomment-1187624584 Have you checked https://sonarcloud.io/project/overview?id=JMeter ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [jmeter] pjfanning opened a new pull request, #721: WIP: reduce use of xalan

2022-07-23 Thread GitBox
pjfanning opened a new pull request, #721: URL: https://github.com/apache/jmeter/pull/721 ## Description https://bz.apache.org/bugzilla/show_bug.cgi?id=66171 * This is a POC - if the changes look like a valid way forward, I can put more effort in. * There is still one use of

[GitHub] [jmeter] FSchumacher commented on pull request #721: WIP: reduce use of xalan

2022-07-23 Thread GitBox
FSchumacher commented on PR #721: URL: https://github.com/apache/jmeter/pull/721#issuecomment-1193127964 Ant is still used to generate our docs. I think all xalan related stuff can be deleted safely. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [jmeter] FSchumacher commented on a diff in pull request #721: WIP: reduce use of xalan

2022-07-23 Thread GitBox
FSchumacher commented on code in PR #721: URL: https://github.com/apache/jmeter/pull/721#discussion_r928133582 ## src/core/src/test/java/org/apache/jmeter/util/XPathUtilTest.java: ## @@ -276,4 +278,19 @@ public void testPutValuesForXPathInList() throws ParserConfigurationExcept

[GitHub] [jmeter] pjfanning opened a new pull request, #722: Master tests

2022-07-23 Thread GitBox
pjfanning opened a new pull request, #722: URL: https://github.com/apache/jmeter/pull/722 ## Description ## Motivation and Context ## How Has This Been Tested? ## Screenshots (if appropriate): ## Types of changes - Bug fix (non-br

[GitHub] [jmeter] FSchumacher merged pull request #722: Master tests

2022-07-23 Thread GitBox
FSchumacher merged PR #722: URL: https://github.com/apache/jmeter/pull/722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache

[GitHub] [jmeter] codecov-commenter commented on pull request #721: WIP: reduce use of xalan

2022-07-23 Thread GitBox
codecov-commenter commented on PR #721: URL: https://github.com/apache/jmeter/pull/721#issuecomment-1193143156 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] pjfanning commented on pull request #721: WIP: reduce use of xalan

2022-07-23 Thread GitBox
pjfanning commented on PR #721: URL: https://github.com/apache/jmeter/pull/721#issuecomment-1193148578 @FSchumacher thanks for reviewing the changes. The build is now working. I've had to make a few changes to get a few existing tests to pass. Would you be able to review the test changes to

[GitHub] [jmeter] pjfanning commented on pull request #721: WIP: reduce use of xalan

2022-07-24 Thread GitBox
pjfanning commented on PR #721: URL: https://github.com/apache/jmeter/pull/721#issuecomment-1193353721 I raised https://github.com/JetBrains/lets-plot/issues/576 - I'm not sure if that blocks us from making progress here. -- This is an automated message from the Apache Git Service. To res

[GitHub] [jmeter] FSchumacher commented on pull request #721: WIP: reduce use of xalan

2022-07-30 Thread GitBox
FSchumacher commented on PR #721: URL: https://github.com/apache/jmeter/pull/721#issuecomment-1200128245 Thanks for your work so far on this. Hopefully I will get time to look more into this. So far it looks good to me. In my tests, I added code to look at the actual used TransformerFacto

[GitHub] [jmeter] andreaslind01 opened a new pull request, #723: [65318] JSON Assertion: Use correct number format

2022-08-08 Thread GitBox
andreaslind01 opened a new pull request, #723: URL: https://github.com/apache/jmeter/pull/723 ## Description See https://bz.apache.org/bugzilla/show_bug.cgi?id=65318 ## Motivation and Context This PR fixes the issues with JSON Assertions mentioned here: https://bz.apache.org/bug

[GitHub] [jmeter] arthur-zhang opened a new pull request, #724: do code clean up

2022-08-11 Thread GitBox
arthur-zhang opened a new pull request, #724: URL: https://github.com/apache/jmeter/pull/724 ## Description Do some code clean up ## Motivation and Context some code do not match name convention or code style ## Checklist: - [x] My code follows the [cod

[GitHub] [jmeter] vlsi commented on a diff in pull request #724: do code clean up

2022-08-11 Thread GitBox
vlsi commented on code in PR #724: URL: https://github.com/apache/jmeter/pull/724#discussion_r944131847 ## src/core/src/main/java/org/apache/jmeter/engine/DistributedRunner.java: ## @@ -262,21 +262,21 @@ private void println(String s) { private void errln(String s) {

[GitHub] [jmeter] arthur-zhang commented on a diff in pull request #724: do code clean up

2022-08-12 Thread GitBox
arthur-zhang commented on code in PR #724: URL: https://github.com/apache/jmeter/pull/724#discussion_r944204638 ## src/core/src/main/java/org/apache/jmeter/engine/DistributedRunner.java: ## @@ -262,21 +262,21 @@ private void println(String s) { private void errln(String s

[GitHub] [jmeter] vlsi commented on a diff in pull request #724: do code clean up

2022-08-12 Thread GitBox
vlsi commented on code in PR #724: URL: https://github.com/apache/jmeter/pull/724#discussion_r944205050 ## src/core/src/main/java/org/apache/jmeter/engine/DistributedRunner.java: ## @@ -60,7 +60,7 @@ public class DistributedRunner { private final int retriesDelay; priv

[GitHub] [jmeter] arthur-zhang commented on a diff in pull request #724: do code clean up

2022-08-12 Thread GitBox
arthur-zhang commented on code in PR #724: URL: https://github.com/apache/jmeter/pull/724#discussion_r944273600 ## src/core/src/main/java/org/apache/jmeter/engine/DistributedRunner.java: ## @@ -60,7 +60,7 @@ public class DistributedRunner { private final int retriesDelay;

[GitHub] [jmeter] codecov-commenter commented on pull request #724: do code clean up

2022-08-14 Thread GitBox
codecov-commenter commented on PR #724: URL: https://github.com/apache/jmeter/pull/724#issuecomment-1214536289 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] vlsi commented on a diff in pull request #724: do code clean up

2022-08-14 Thread GitBox
vlsi commented on code in PR #724: URL: https://github.com/apache/jmeter/pull/724#discussion_r945444163 ## src/core/src/main/java/org/apache/jmeter/report/dashboard/ReportGenerator.java: ## @@ -352,7 +352,6 @@ private void addGraphConsumer(FilterConsumer nameFilter,

[GitHub] [jmeter] kaola89 opened a new pull request, #725: Add Chinese Simplified Translation for Open Model Thread Group

2022-08-17 Thread GitBox
kaola89 opened a new pull request, #725: URL: https://github.com/apache/jmeter/pull/725 ## Description Add Chinese Simplified Translation for Open Model Thread Group ## Motivation and Context Add Chinese Simplified Translation for new component ## Checklist:

[GitHub] [jmeter] SampathKumarAmex opened a new pull request, #726: SyncTimerTest | Used Junit 5 assertions to keep it consistent

2022-08-25 Thread GitBox
SampathKumarAmex opened a new pull request, #726: URL: https://github.com/apache/jmeter/pull/726 ## Description Used JUnit 5 assertions in the test to keep it consistent with @Test annotation (JUnit 5) ## Motivation and Context Used JUnit 5 assertions in the test to keep it cons

[GitHub] [jmeter] codecov-commenter commented on pull request #723: [65318] JSON Assertion: Use correct number format

2022-08-30 Thread GitBox
codecov-commenter commented on PR #723: URL: https://github.com/apache/jmeter/pull/723#issuecomment-1232243166 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] haideralii commented on pull request #660: 65108: Support JMeter variables in GraphQL HTTP Request

2022-09-02 Thread GitBox
haideralii commented on PR #660: URL: https://github.com/apache/jmeter/pull/660#issuecomment-1235306623 @woonsan can you describe how can I use the jmete variable in graphQL variables? like I have below variable how can I use groupId as integer, same like topic Id which is currently stat

[GitHub] [jmeter] woonsan commented on pull request #660: 65108: Support JMeter variables in GraphQL HTTP Request

2022-09-05 Thread GitBox
woonsan commented on PR #660: URL: https://github.com/apache/jmeter/pull/660#issuecomment-1237631660 @haideralii , this was originally to fix the problem reported at https://bz.apache.org/bugzilla/show_bug.cgi?id=65108. Please see the example in the ticket. And if needed, please continue di

[GitHub] [jmeter] vlsi opened a new pull request, #727: Add NoThreadClone to HeaderManager to reduce heap utilization

2022-09-19 Thread GitBox
vlsi opened a new pull request, #727: URL: https://github.com/apache/jmeter/pull/727 ## Motivation and Context HeaderManager consumes heap, and it looks it can be reused between threads. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [jmeter] vlsi opened a new pull request, #728: Add .asf.yaml, enable GitHub Issues

2022-09-23 Thread GitBox
vlsi opened a new pull request, #728: URL: https://github.com/apache/jmeter/pull/728 ## Description See https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories This change is needed for activating GitHub issues. -- This is an automated m

[GitHub] [jmeter-bugzilla-attachments] dependabot[bot] opened a new pull request, #1: Bump snakeyaml from 1.23 to 1.31 in /88/65688/38093

2022-09-23 Thread GitBox
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/jmeter-bugzilla-attachments/pull/1 Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.23 to 1.31. Commits https://bitbucket.org/snakeyaml/snakeyaml/commits/a3e641b8d6337d9916b5d709278

[GitHub] [jmeter] vlsi merged pull request #728: Add .asf.yaml, enable GitHub Issues

2022-09-23 Thread GitBox
vlsi merged PR #728: URL: https://github.com/apache/jmeter/pull/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org F

[GitHub] [jmeter] asfimport commented on issue #3565: SampleEvent for TransactionSampler: isTransactionSampleEvent return false with parent mode

2022-09-24 Thread GitBox
asfimport commented on issue #3565: URL: https://github.com/apache/jmeter/issues/3565#issuecomment-1256925933 **Fei Luan** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=57730&redirect=false#c3)): Please fix this bug. I use 5.4.3 and it is still there. I'm affec

[GitHub] [jmeter] asfimport commented on issue #5507: Response Body is not formatted correctly (View Results Tree) v5.4.1

2022-09-24 Thread GitBox
asfimport commented on issue #5507: URL: https://github.com/apache/jmeter/issues/5507#issuecomment-1256926060 **Brian Tully** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=65187&redirect=false#c16)): With the recent fix to Darklaf and rsyntaxtextarea (https://

[GitHub] [jmeter] asfimport commented on issue #5687: Code Textbox Text Colour

2022-09-24 Thread GitBox
asfimport commented on issue #5687: URL: https://github.com/apache/jmeter/issues/5687#issuecomment-1256926074 **Brian Tully** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=66157&redirect=false#c7)): I had posted several related bugs related to Darklaf and dark

[GitHub] [jmeter] asfimport commented on issue #5539: Incorrect display of decimal numbers in JSON related elements

2022-09-24 Thread GitBox
asfimport commented on issue #5539: URL: https://github.com/apache/jmeter/issues/5539#issuecomment-1256926068 **andreaslind01** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=65318&redirect=false#c4)): Created attachment [jsonassertion_bug.jmx](https://apache.g

[GitHub] [jmeter] asfimport commented on issue #5507: Response Body is not formatted correctly (View Results Tree) v5.4.1

2022-09-24 Thread GitBox
asfimport commented on issue #5507: URL: https://github.com/apache/jmeter/issues/5507#issuecomment-1256926047 **Brian Tully** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=65187&redirect=false#c14)): Hi again Felix - I'm hoping you might point me in the

[GitHub] [jmeter] asfimport commented on issue #5507: Response Body is not formatted correctly (View Results Tree) v5.4.1

2022-09-24 Thread GitBox
asfimport commented on issue #5507: URL: https://github.com/apache/jmeter/issues/5507#issuecomment-1256926054 **Brian Tully** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=65187&redirect=false#c15)): Can the rsyntaxtextarea class be used for the Response Body t

[GitHub] [jmeter] asfimport commented on issue #5136: Auto-Correlation as core functionality in JMeter

2022-09-24 Thread GitBox
asfimport commented on issue #5136: URL: https://github.com/apache/jmeter/issues/5136#issuecomment-1256926045 **Michael Johnson** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=63640&redirect=false#c1)): Blazemeter came out with a plugin that did the same and wo

[GitHub] [jmeter] asfimport commented on issue #5539: Incorrect display of decimal numbers in JSON related elements

2022-09-24 Thread GitBox
asfimport commented on issue #5539: URL: https://github.com/apache/jmeter/issues/5539#issuecomment-1256926063 **andreaslind01** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=65318&redirect=false#c3)): Hello, I created a PR that should fix the issues with

[GitHub] [jmeter] asfimport commented on issue #5687: Code Textbox Text Colour

2022-09-24 Thread GitBox
asfimport commented on issue #5687: URL: https://github.com/apache/jmeter/issues/5687#issuecomment-1256926078 **Brian Tully** ([migrated from Bugzilla](https://bz.apache.org/bugzilla//show_bug.cgi?id=66157&redirect=false#c8)): I'm confirming that it is fixed for me as well, on my Mac, wit

[GitHub] [jmeter] vlsi opened a new pull request, #5710: Add GitHub Issue templates

2022-09-24 Thread GitBox
vlsi opened a new pull request, #5710: URL: https://github.com/apache/jmeter/pull/5710 ## Description Configure issue templates -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [jmeter] pmouawad commented on a diff in pull request #5710: Add GitHub Issue templates

2022-09-24 Thread GitBox
pmouawad commented on code in PR #5710: URL: https://github.com/apache/jmeter/pull/5710#discussion_r979264187 ## .github/ISSUE_TEMPLATE/feature_request.yaml: ## @@ -0,0 +1,58 @@ +name: Feature Request +description: Suggest an idea +labels: + - enhancement + - to-triage +body:

[GitHub] [jmeter] vlsi opened a new pull request, #5711: doc: handle markup in documentation

2022-09-24 Thread GitBox
vlsi opened a new pull request, #5711: URL: https://github.com/apache/jmeter/pull/5711 ## Motivation and Context input: ```xml 5709 fixed 570757085709 fixed 5707571057085709 fixed test 5707 fixed ``` Rendered doc: ![xsl rendering](http

[GitHub] [jmeter] vlsi commented on a diff in pull request #5710: Add GitHub Issue templates

2022-09-24 Thread GitBox
vlsi commented on code in PR #5710: URL: https://github.com/apache/jmeter/pull/5710#discussion_r979270150 ## .github/ISSUE_TEMPLATE/feature_request.yaml: ## @@ -0,0 +1,58 @@ +name: Feature Request +description: Suggest an idea +labels: + - enhancement + - to-triage +body: + -

[GitHub] [jmeter] vlsi merged pull request #5710: Add GitHub Issue templates

2022-09-24 Thread GitBox
vlsi merged PR #5710: URL: https://github.com/apache/jmeter/pull/5710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

[GitHub] [jmeter] vlsi merged pull request #5711: doc: handle markup in documentation

2022-09-24 Thread GitBox
vlsi merged PR #5711: URL: https://github.com/apache/jmeter/pull/5711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

[GitHub] [jmeter] codecov-commenter commented on pull request #5712: Update Bugzilla -> GitHub issues in the contribution documentation

2022-09-25 Thread GitBox
codecov-commenter commented on PR #5712: URL: https://github.com/apache/jmeter/pull/5712#issuecomment-1257149871 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/5712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[GitHub] [jmeter-bugzilla-attachments] dependabot[bot] commented on pull request #1: Bump snakeyaml from 1.23 to 1.31 in /88/65688/38093

2022-09-25 Thread GitBox
dependabot[bot] commented on PR #1: URL: https://github.com/apache/jmeter-bugzilla-attachments/pull/1#issuecomment-1257156845 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependab

  1   2   3   4   5   6   7   8   9   10   >