[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395375#comment-16395375
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/71
  
Close this one off @tteofili ?


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
> Fix For: 6.2
>
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395376#comment-16395376
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/71
  
Or port to master?


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
> Fix For: 6.2
>
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839892#comment-15839892
 ] 

ASF GitHub Bot commented on JOSHUA-324:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/79


> Address Apache Joshua 6.1 RC#2 Issues
> -
>
> Key: JOSHUA-324
> URL: https://issues.apache.org/jira/browse/JOSHUA-324
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.1
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows
> {code}
> ==
> - Your missing incubating in the release artifacts name. [1]
> - There are a number of binary files in the source release that look to be
> compiled source code.
> I checked:
> - name doesn’t include incubating
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE is missing a few things (see below)
> - a source file is missing an Apache header [7]
> - Several unexpected binary files are contained in the source release
> [8][9][10][11]
> - Can compile from source
> License is missing:
> - MIT licensed normalize.css v3.0.3 bundled in [5]
> - glyph icon fonts [6]
> Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually
> both are bare or both have .txt extension.
> Also while looking at your site I noticed that the download links of you
> incubating site [2] points to github, please change to point to the offical
> release area.
> Also the 6.1 release has already been tagged and it available for public
> download on github [4]  before this vote is finished. This is IMO against
> Apache release policy [3] please remove.
> I also notice you recently released the language packs (18th Nov) but there
> doesn’t seem to have been a vote for that? Any reason for this?
> ===
> [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> [2] 
> https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home
> [3] http://www.apache.org/dev/release.html#what
> [4] https://github.com/apache/incubator-joshua/releases
> [5] ./demo/bootstrap/css/bootstrap.min.css
> [6] apache-joshua-6.1/demo/bootstrap/fonts/*
> [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java
> [8] ./bin/GIZA++
> [9] ./bin/mkcls
> [10 ]./bin/snt2cooc.out
> [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz
> [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html
> [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html
> {code}
> This is a blocking issue and until addressed we cannot release 6.1-incubating



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838344#comment-15838344
 ] 

ASF GitHub Bot commented on JOSHUA-324:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/79
  
travis fails because of a much earlier error where the download-deps.sh 
script causes things to hang indefinitely. Fixing that first, then will re-test 
this.


> Address Apache Joshua 6.1 RC#2 Issues
> -
>
> Key: JOSHUA-324
> URL: https://issues.apache.org/jira/browse/JOSHUA-324
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.1
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows
> {code}
> ==
> - Your missing incubating in the release artifacts name. [1]
> - There are a number of binary files in the source release that look to be
> compiled source code.
> I checked:
> - name doesn’t include incubating
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE is missing a few things (see below)
> - a source file is missing an Apache header [7]
> - Several unexpected binary files are contained in the source release
> [8][9][10][11]
> - Can compile from source
> License is missing:
> - MIT licensed normalize.css v3.0.3 bundled in [5]
> - glyph icon fonts [6]
> Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually
> both are bare or both have .txt extension.
> Also while looking at your site I noticed that the download links of you
> incubating site [2] points to github, please change to point to the offical
> release area.
> Also the 6.1 release has already been tagged and it available for public
> download on github [4]  before this vote is finished. This is IMO against
> Apache release policy [3] please remove.
> I also notice you recently released the language packs (18th Nov) but there
> doesn’t seem to have been a vote for that? Any reason for this?
> ===
> [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> [2] 
> https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home
> [3] http://www.apache.org/dev/release.html#what
> [4] https://github.com/apache/incubator-joshua/releases
> [5] ./demo/bootstrap/css/bootstrap.min.css
> [6] apache-joshua-6.1/demo/bootstrap/fonts/*
> [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java
> [8] ./bin/GIZA++
> [9] ./bin/mkcls
> [10 ]./bin/snt2cooc.out
> [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz
> [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html
> [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html
> {code}
> This is a blocking issue and until addressed we cannot release 6.1-incubating



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838085#comment-15838085
 ] 

ASF GitHub Bot commented on JOSHUA-324:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/79
  
Thanks for catching this, Kellen. I'll pull this in as soon as travis 
completes.


> Address Apache Joshua 6.1 RC#2 Issues
> -
>
> Key: JOSHUA-324
> URL: https://issues.apache.org/jira/browse/JOSHUA-324
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.1
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows
> {code}
> ==
> - Your missing incubating in the release artifacts name. [1]
> - There are a number of binary files in the source release that look to be
> compiled source code.
> I checked:
> - name doesn’t include incubating
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE is missing a few things (see below)
> - a source file is missing an Apache header [7]
> - Several unexpected binary files are contained in the source release
> [8][9][10][11]
> - Can compile from source
> License is missing:
> - MIT licensed normalize.css v3.0.3 bundled in [5]
> - glyph icon fonts [6]
> Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually
> both are bare or both have .txt extension.
> Also while looking at your site I noticed that the download links of you
> incubating site [2] points to github, please change to point to the offical
> release area.
> Also the 6.1 release has already been tagged and it available for public
> download on github [4]  before this vote is finished. This is IMO against
> Apache release policy [3] please remove.
> I also notice you recently released the language packs (18th Nov) but there
> doesn’t seem to have been a vote for that? Any reason for this?
> ===
> [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> [2] 
> https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home
> [3] http://www.apache.org/dev/release.html#what
> [4] https://github.com/apache/incubator-joshua/releases
> [5] ./demo/bootstrap/css/bootstrap.min.css
> [6] apache-joshua-6.1/demo/bootstrap/fonts/*
> [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java
> [8] ./bin/GIZA++
> [9] ./bin/mkcls
> [10 ]./bin/snt2cooc.out
> [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz
> [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html
> [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html
> {code}
> This is a blocking issue and until addressed we cannot release 6.1-incubating



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838043#comment-15838043
 ] 

ASF GitHub Bot commented on JOSHUA-324:
---

GitHub user KellenSunderland opened a pull request:

https://github.com/apache/incubator-joshua/pull/79

JOSHUA-324 renamed LICENSE, removed minification of license in bootst…

…rap.min.css

Small patch to make detection of the license easier in this minified file.  
I believe this was flagged during our release review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/KellenSunderland/incubator-joshua master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79






> Address Apache Joshua 6.1 RC#2 Issues
> -
>
> Key: JOSHUA-324
> URL: https://issues.apache.org/jira/browse/JOSHUA-324
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.1
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows
> {code}
> ==
> - Your missing incubating in the release artifacts name. [1]
> - There are a number of binary files in the source release that look to be
> compiled source code.
> I checked:
> - name doesn’t include incubating
> - signatures and hashes correct
> - DISCLAIMER exists
> - LICENSE is missing a few things (see below)
> - a source file is missing an Apache header [7]
> - Several unexpected binary files are contained in the source release
> [8][9][10][11]
> - Can compile from source
> License is missing:
> - MIT licensed normalize.css v3.0.3 bundled in [5]
> - glyph icon fonts [6]
> Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually
> both are bare or both have .txt extension.
> Also while looking at your site I noticed that the download links of you
> incubating site [2] points to github, please change to point to the offical
> release area.
> Also the 6.1 release has already been tagged and it available for public
> download on github [4]  before this vote is finished. This is IMO against
> Apache release policy [3] please remove.
> I also notice you recently released the language packs (18th Nov) but there
> doesn’t seem to have been a vote for that? Any reason for this?
> ===
> [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases
> [2] 
> https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home
> [3] http://www.apache.org/dev/release.html#what
> [4] https://github.com/apache/incubator-joshua/releases
> [5] ./demo/bootstrap/css/bootstrap.min.css
> [6] apache-joshua-6.1/demo/bootstrap/fonts/*
> [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java
> [8] ./bin/GIZA++
> [9] ./bin/mkcls
> [10 ]./bin/snt2cooc.out
> [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz
> [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html
> [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html
> {code}
> This is a blocking issue and until addressed we cannot release 6.1-incubating



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-316) run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a bytes-like object is required, not 'str'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687450#comment-15687450
 ] 

ASF GitHub Bot commented on JOSHUA-316:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/73


> run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a 
> bytes-like object is required, not 'str'
> -
>
> Key: JOSHUA-316
> URL: https://issues.apache.org/jira/browse/JOSHUA-316
> Project: Joshua
>  Issue Type: Bug
>  Components: bundler
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.2
>
>
> {code}
> [glue-tune] rebuilding...
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/grammar.packed/slice_0.source
>  [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>  [NOT FOUND]
>   cmd=/usr/local/incubator-joshua/scripts/support/create_glue_grammar.sh 
> /usr/local/joshua_resources/russian_experiments/exp2/grammar.packed > 
> /usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>   took 1 seconds (1s)
> [tune-bundle] rebuilding...
>   
> dep=/usr/local/incubator-joshua/scripts/training/templates/tune/joshua.config 
> [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/grammar.packed/slice_0.source
>  [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/tune/model/run-joshua.sh
>  [NOT FOUND]
>   cmd=/usr/local/incubator-joshua/scripts/support/run_bundler.py --force 
> --symlink --absolute --verbose -T /usr/local/hadoop-2.5.2/hadoop_tmp_dir 
> /usr/local/incubator-joshua/scripts/training/templates/tune/joshua.config 
> /usr/local/joshua_resources/russian_experiments/exp2/tune/model 
> --copy-config-options '-top-n 300 -output-format "%i ||| %s ||| %f ||| %c" 
> -mark-oovs false -search cky -weights "lm_0 1 tm_pt_0 1 tm_pt_1 1 tm_pt_2 1 
> tm_pt_3 1 tm_pt_4 1 tm_pt_5 1 tm_glue_0 1 " -feature-function 
> "StateMinimizingLanguageModel -lm_order 5 -lm_file 
> /usr/local/joshua_resources/russian_experiments/exp2/lm.kenlm"  -tm0/type 
> hiero -tm0/owner pt -tm0/maxspan 20 -tm1/owner glue' --pack-tm 
> /usr/local/joshua_resources/russian_experiments/exp2/grammar.packed --tm 
> /usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>   JOB FAILED (return code 1)
> * Running the copy-config.pl script with the command: 
> /usr/local/incubator-joshua/scripts/copy-config.pl -top-n 300 -output-format 
> "%i ||| %s ||| %f ||| %c" -mark-oovs false -search cky -weights "lm_0 1 
> tm_pt_0 1 tm_pt_1 1 tm_pt_2 1 tm_pt_3 1 tm_pt_4 1 tm_pt_5 1 tm_glue_0 1 " 
> -feature-function "StateMinimizingLanguageModel -lm_order 5 -lm_file 
> /usr/local/joshua_resources/russian_experiments/exp2/lm.kenlm"  -tm0/type 
> hiero -tm0/owner pt -tm0/maxspan 20 -tm1/owner glue
> Traceback (most recent call last):
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 748, in main
> operations = collect_operations(opts)
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 637, in collect_operations
> opts.copy_config_options
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 202, in filter_through_copy_config_script
> result, err = p.communicate(config_text)
>   File "/Users/lmcgibbn/miniconda3/lib/python3.5/subprocess.py", line 1072, 
> in communicate
> stdout, stderr = self._communicate(input, endtime, timeout)
>   File "/Users/lmcgibbn/miniconda3/lib/python3.5/subprocess.py", line 1700, 
> in _communicate
> input_view = memoryview(self._input)
> TypeError: memoryview: a bytes-like object is required, not 'str'
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 760, in 
> main(sys.argv)
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 751, in main
> error_quit(e.message)
> AttributeError: 'TypeError' object has no attribute 'message'
> * WARNING: no key 'outputformat' found in config file (appending to end)
> * WARNING: no key 'search' found in config file (appending to end)
> * WARNING: no key 'topn' found in config file (appending to end)
> * WARNING: no key 'markoovs' found in config file (appending to end)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-323) Joshua 6.1 Release Management

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656719#comment-15656719
 ] 

ASF GitHub Bot commented on JOSHUA-323:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/76


> Joshua 6.1 Release Management
> -
>
> Key: JOSHUA-323
> URL: https://issues.apache.org/jira/browse/JOSHUA-323
> Project: Joshua
>  Issue Type: Task
>  Components: build, release
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> This is a governing ticket for reference more than anything else. We need to 
> add all release specific build additions to parent pom.xml which enable us to 
> roll a release candidate.
> The process is also being documented over at 
> https://cwiki.apache.org/confluence/display/JOSHUA/Joshua+Release+Management+Procedure



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-323) Joshua 6.1 Release Management

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656191#comment-15656191
 ] 

ASF GitHub Bot commented on JOSHUA-323:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/76

Release

This issue addresses https://issues.apache.org/jira/browse/JOSHUA-323

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua release

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #76


commit f45c3fd39ae74604a40046a97b98bb3154ca5ba7
Author: Lewis John McGibbney 
Date:   2016-11-11T04:32:22Z

JOSHUA-323 Joshua 6.1 Release Management

commit 7f2ef263cbaee94ba82cff4e8145a288180a3afa
Author: Lewis John McGibbney 
Date:   2016-11-11T04:53:47Z

JOSHUA-323 Joshua 6.1 Release Management

commit 10bfa31993a8859adc06b200fa173fb5f18e7919
Author: Lewis John McGibbney 
Date:   2016-11-11T04:54:59Z

JOSHUA-323 Joshua 6.1 Release Management

commit c733f45a020034bd05318a8dd31ff4d84aebe19a
Author: Lewis John McGibbney 
Date:   2016-11-11T04:59:23Z

JOSHUA-323 Joshua 6.1 Release Management

commit c2c59d8435ebb8d7d5dd8191ff2dec24352a4838
Author: Lewis John McGibbney 
Date:   2016-11-11T05:06:26Z

JOSHUA-323 Joshua 6.1 Release Management

commit eb994e311a0c7593ad1899df6153b65585760cc8
Author: Lewis John McGibbney 
Date:   2016-11-11T05:20:32Z

JOSHUA-323 Joshua 6.1 Release Management




> Joshua 6.1 Release Management
> -
>
> Key: JOSHUA-323
> URL: https://issues.apache.org/jira/browse/JOSHUA-323
> Project: Joshua
>  Issue Type: Task
>  Components: build, release
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> This is a governing ticket for reference more than anything else. We need to 
> add all release specific build additions to parent pom.xml which enable us to 
> roll a release candidate.
> The process is also being documented over at 
> https://cwiki.apache.org/confluence/display/JOSHUA/Joshua+Release+Management+Procedure



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-322) extract-1best script references non-existent execution paths

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652422#comment-15652422
 ] 

ASF GitHub Bot commented on JOSHUA-322:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/75


> extract-1best script references non-existent execution paths
> 
>
> Key: JOSHUA-322
> URL: https://issues.apache.org/jira/browse/JOSHUA-322
> Project: Joshua
>  Issue Type: Bug
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Trivial
> Fix For: 6.1
>
>
> The extract-1best script has simply not been updated to accommodate the 
> Mavenization of the Joshua codebase (woops!!!), this issue will fix that.
> https://github.com/apache/incubator-joshua/blob/master/bin/extract-1best



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-322) extract-1best script references non-existent execution paths

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652420#comment-15652420
 ] 

ASF GitHub Bot commented on JOSHUA-322:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/75

JOSHUA-322 extract-1best script references non-existent execution paths

This issue addresses https://issues.apache.org/jira/browse/JOSHUA-322

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-322

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #75


commit bc50c94ebf657314e09d880ae0bb297bf9e205fc
Author: Lewis John McGibbney 
Date:   2016-11-09T23:50:02Z

JOSHUA-322 extract-1best script references non-existent execution paths




> extract-1best script references non-existent execution paths
> 
>
> Key: JOSHUA-322
> URL: https://issues.apache.org/jira/browse/JOSHUA-322
> Project: Joshua
>  Issue Type: Bug
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Trivial
> Fix For: 6.1
>
>
> The extract-1best script has simply not been updated to accommodate the 
> Mavenization of the Joshua codebase (woops!!!), this issue will fix that.
> https://github.com/apache/incubator-joshua/blob/master/bin/extract-1best



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-321) Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652378#comment-15652378
 ] 

ASF GitHub Bot commented on JOSHUA-321:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/74

JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts

This issue addresses https://issues.apache.org/jira/browse/JOSHUA-321

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-321

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit 2f3e752969a2bacc17aa029595c9a56b93331e9e
Author: Lewis John McGibbney 
Date:   2016-11-09T23:31:30Z

JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts




> Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts
> -
>
> Key: JOSHUA-321
> URL: https://issues.apache.org/jira/browse/JOSHUA-321
> Project: Joshua
>  Issue Type: Bug
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Trivial
> Fix For: 6.1
>
>
> Right now both bleu and extract-1best do not have the required $JOSHUA env 
> variable which will result in an error if it is not set within the users 
> environment. This currently breaks the Homebrew install amongst other things 
> so we should add it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-316) run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a bytes-like object is required, not 'str'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610450#comment-15610450
 ] 

ASF GitHub Bot commented on JOSHUA-316:
---

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/73
  
The most recent commit I submitted here also addresses 
[JOSHUA-317](https://issues.apache.org/jira/browse/JOSHUA-317) and 
[JOSHUA-318](https://issues.apache.org/jira/browse/JOSHUA-318) as well.


> run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a 
> bytes-like object is required, not 'str'
> -
>
> Key: JOSHUA-316
> URL: https://issues.apache.org/jira/browse/JOSHUA-316
> Project: Joshua
>  Issue Type: Bug
>  Components: bundler
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> {code}
> [glue-tune] rebuilding...
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/grammar.packed/slice_0.source
>  [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>  [NOT FOUND]
>   cmd=/usr/local/incubator-joshua/scripts/support/create_glue_grammar.sh 
> /usr/local/joshua_resources/russian_experiments/exp2/grammar.packed > 
> /usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>   took 1 seconds (1s)
> [tune-bundle] rebuilding...
>   
> dep=/usr/local/incubator-joshua/scripts/training/templates/tune/joshua.config 
> [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/grammar.packed/slice_0.source
>  [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/tune/model/run-joshua.sh
>  [NOT FOUND]
>   cmd=/usr/local/incubator-joshua/scripts/support/run_bundler.py --force 
> --symlink --absolute --verbose -T /usr/local/hadoop-2.5.2/hadoop_tmp_dir 
> /usr/local/incubator-joshua/scripts/training/templates/tune/joshua.config 
> /usr/local/joshua_resources/russian_experiments/exp2/tune/model 
> --copy-config-options '-top-n 300 -output-format "%i ||| %s ||| %f ||| %c" 
> -mark-oovs false -search cky -weights "lm_0 1 tm_pt_0 1 tm_pt_1 1 tm_pt_2 1 
> tm_pt_3 1 tm_pt_4 1 tm_pt_5 1 tm_glue_0 1 " -feature-function 
> "StateMinimizingLanguageModel -lm_order 5 -lm_file 
> /usr/local/joshua_resources/russian_experiments/exp2/lm.kenlm"  -tm0/type 
> hiero -tm0/owner pt -tm0/maxspan 20 -tm1/owner glue' --pack-tm 
> /usr/local/joshua_resources/russian_experiments/exp2/grammar.packed --tm 
> /usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>   JOB FAILED (return code 1)
> * Running the copy-config.pl script with the command: 
> /usr/local/incubator-joshua/scripts/copy-config.pl -top-n 300 -output-format 
> "%i ||| %s ||| %f ||| %c" -mark-oovs false -search cky -weights "lm_0 1 
> tm_pt_0 1 tm_pt_1 1 tm_pt_2 1 tm_pt_3 1 tm_pt_4 1 tm_pt_5 1 tm_glue_0 1 " 
> -feature-function "StateMinimizingLanguageModel -lm_order 5 -lm_file 
> /usr/local/joshua_resources/russian_experiments/exp2/lm.kenlm"  -tm0/type 
> hiero -tm0/owner pt -tm0/maxspan 20 -tm1/owner glue
> Traceback (most recent call last):
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 748, in main
> operations = collect_operations(opts)
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 637, in collect_operations
> opts.copy_config_options
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 202, in filter_through_copy_config_script
> result, err = p.communicate(config_text)
>   File "/Users/lmcgibbn/miniconda3/lib/python3.5/subprocess.py", line 1072, 
> in communicate
> stdout, stderr = self._communicate(input, endtime, timeout)
>   File "/Users/lmcgibbn/miniconda3/lib/python3.5/subprocess.py", line 1700, 
> in _communicate
> input_view = memoryview(self._input)
> TypeError: memoryview: a bytes-like object is required, not 'str'
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 760, in 
> main(sys.argv)
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 751, in main
> error_quit(e.message)
> AttributeError: 'TypeError' object has no attribute 'message'
> * WARNING: no key 'outputformat' found in config file (appending to end)
> * WARNING: no key 'search' found in config file (appending to end)
> * WARNING: no key 'topn' found in config file (appending to end)
> * WARNING: no key 'markoovs' found in config file (appending to end)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-316) run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a bytes-like object is required, not 'str'

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607165#comment-15607165
 ] 

ASF GitHub Bot commented on JOSHUA-316:
---

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/73
  
BTW I am using Python 3.5 here.


> run_bundler.py returning JOB FAILED (return code 1) TypeError: memoryview: a 
> bytes-like object is required, not 'str'
> -
>
> Key: JOSHUA-316
> URL: https://issues.apache.org/jira/browse/JOSHUA-316
> Project: Joshua
>  Issue Type: Bug
>  Components: bundler
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.2
>
>
> {code}
> [glue-tune] rebuilding...
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/grammar.packed/slice_0.source
>  [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>  [NOT FOUND]
>   cmd=/usr/local/incubator-joshua/scripts/support/create_glue_grammar.sh 
> /usr/local/joshua_resources/russian_experiments/exp2/grammar.packed > 
> /usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>   took 1 seconds (1s)
> [tune-bundle] rebuilding...
>   
> dep=/usr/local/incubator-joshua/scripts/training/templates/tune/joshua.config 
> [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/grammar.packed/slice_0.source
>  [CHANGED]
>   
> dep=/usr/local/joshua_resources/russian_experiments/exp2/tune/model/run-joshua.sh
>  [NOT FOUND]
>   cmd=/usr/local/incubator-joshua/scripts/support/run_bundler.py --force 
> --symlink --absolute --verbose -T /usr/local/hadoop-2.5.2/hadoop_tmp_dir 
> /usr/local/incubator-joshua/scripts/training/templates/tune/joshua.config 
> /usr/local/joshua_resources/russian_experiments/exp2/tune/model 
> --copy-config-options '-top-n 300 -output-format "%i ||| %s ||| %f ||| %c" 
> -mark-oovs false -search cky -weights "lm_0 1 tm_pt_0 1 tm_pt_1 1 tm_pt_2 1 
> tm_pt_3 1 tm_pt_4 1 tm_pt_5 1 tm_glue_0 1 " -feature-function 
> "StateMinimizingLanguageModel -lm_order 5 -lm_file 
> /usr/local/joshua_resources/russian_experiments/exp2/lm.kenlm"  -tm0/type 
> hiero -tm0/owner pt -tm0/maxspan 20 -tm1/owner glue' --pack-tm 
> /usr/local/joshua_resources/russian_experiments/exp2/grammar.packed --tm 
> /usr/local/joshua_resources/russian_experiments/exp2/data/tune/grammar.glue
>   JOB FAILED (return code 1)
> * Running the copy-config.pl script with the command: 
> /usr/local/incubator-joshua/scripts/copy-config.pl -top-n 300 -output-format 
> "%i ||| %s ||| %f ||| %c" -mark-oovs false -search cky -weights "lm_0 1 
> tm_pt_0 1 tm_pt_1 1 tm_pt_2 1 tm_pt_3 1 tm_pt_4 1 tm_pt_5 1 tm_glue_0 1 " 
> -feature-function "StateMinimizingLanguageModel -lm_order 5 -lm_file 
> /usr/local/joshua_resources/russian_experiments/exp2/lm.kenlm"  -tm0/type 
> hiero -tm0/owner pt -tm0/maxspan 20 -tm1/owner glue
> Traceback (most recent call last):
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 748, in main
> operations = collect_operations(opts)
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 637, in collect_operations
> opts.copy_config_options
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 202, in filter_through_copy_config_script
> result, err = p.communicate(config_text)
>   File "/Users/lmcgibbn/miniconda3/lib/python3.5/subprocess.py", line 1072, 
> in communicate
> stdout, stderr = self._communicate(input, endtime, timeout)
>   File "/Users/lmcgibbn/miniconda3/lib/python3.5/subprocess.py", line 1700, 
> in _communicate
> input_view = memoryview(self._input)
> TypeError: memoryview: a bytes-like object is required, not 'str'
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 760, in 
> main(sys.argv)
>   File "/usr/local/incubator-joshua/scripts/support/run_bundler.py", line 
> 751, in main
> error_quit(e.message)
> AttributeError: 'TypeError' object has no attribute 'message'
> * WARNING: no key 'outputformat' found in config file (appending to end)
> * WARNING: no key 'search' found in config file (appending to end)
> * WARNING: no key 'topn' found in config file (appending to end)
> * WARNING: no key 'markoovs' found in config file (appending to end)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561926#comment-15561926
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

GitHub user tteofili opened a pull request:

https://github.com/apache/incubator-joshua/pull/71

JOSHUA-290 - separate OSGi artifact for Joshua, based on 7 branch



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-joshua JOSHUA-290-branch7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #71


commit 7fa72ed49d0d0acb98d27115161464d450a6930d
Author: Tommaso Teofili 
Date:   2016-10-10T10:28:07Z

JOSHUA-290 - separate OSGi artifact for Joshua, based on 7 branch




> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561829#comment-15561829
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user tteofili commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r82572784
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

sounds good to me, I'll close this one and create a new PR for merging into 
7 branch.


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561831#comment-15561831
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user tteofili closed the pull request at:

https://github.com/apache/incubator-joshua/pull/69


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551971#comment-15551971
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user mjpost commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r82191791
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

Yes, 7 maven-multi-module is merged into 7, so that's the best place for it.


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551238#comment-15551238
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user KellenSunderland commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r8215
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

I would vote for putting it in the 7 branch actually.  @mjpost what do you 
think?


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547161#comment-15547161
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r81881247
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

This should go to `maven-multi-module` branch I suppose?


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535817#comment-15535817
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user tteofili commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r81326566
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

Sure, creating a separate module for OSGi sounds good to me. Note however 
that the annotation dependency is at compile time, that shouldn't be needed at 
runtime,


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535807#comment-15535807
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user KellenSunderland commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r81325749
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

Would it be possible create a separate module for OSGI rather than adding 
it to Core?  If possible we'd like to keep as few dependancies as we can in the 
core library.  This will make it easier for organizations to pick up the Joshua 
core library and not add a bunch of dependancies that they might not make use 
of (but which then need to get deployed to their build and runtime 
environments).


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532704#comment-15532704
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

GitHub user tteofili opened a pull request:

https://github.com/apache/incubator-joshua/pull/69

JOSHUA-290 - provide Joshua as a bundle



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/incubator-joshua JOSHUA-290

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #69


commit f0596b4efe63ccbb1ff9748b7d6d826d52218484
Author: Tommaso Teofili 
Date:   2016-09-29T12:39:32Z

JOSHUA-290 - provide Joshua as a bundle




> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529492#comment-15529492
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/67


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510410#comment-15510410
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/67
  
ack ;)


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510376#comment-15510376
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user KellenSunderland commented on the issue:

https://github.com/apache/incubator-joshua/pull/67
  
Looks good to me.  Some nice cleanup there as well.  I can't comment on the 
change to the output format except to say that i don't really understand what 
was there previously. #


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>  Time Spent: 2m
>  Remaining Estimate: 0h
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510179#comment-15510179
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/67

JOSHUA-299 Move regression tests to proper unit tests

Hi folks, this is one stage closer to us addressing 
https://issues.apache.org/jira/browse/JOSHUA-299

Of note here, I manually constructed the decoder output from essentially 
concatenating various output from a StructuredTranslation. What should be noted 
here is that we actually seem to loose some accuracy note the old file 
provided decoder output of ```0 ||| help ||| tm_glue_0=1.000 ||| 0.000``` 
whereas now we provide ```0 ||| help ||| tm_glue_0=1.0 ||| 0.0```

Any comments?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-299

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/67.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #67


commit 5dd80a37217f4f61ca00aedd256947a412e13771
Author: Lewis John McGibbney 
Date:   2016-09-21T14:53:21Z

JOSHUA-299 Move regression tests to proper unit tests




> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-299) Move regression tests to proper unit tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490103#comment-15490103
 ] 

ASF GitHub Bot commented on JOSHUA-299:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/54
  
Progress on JOSHUA-299.


> Move regression tests to proper unit tests
> --
>
> Key: JOSHUA-299
> URL: https://issues.apache.org/jira/browse/JOSHUA-299
> Project: Joshua
>  Issue Type: Bug
>Reporter: Matt Post
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Many of the regression tests (test*.sh under src/test/resources) have been 
> moved to proper unit tests, but this move should be completed, and the 
> regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-301) Add findbugs plugin to maven build

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432052#comment-15432052
 ] 

ASF GitHub Bot commented on JOSHUA-301:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/39


> Add findbugs plugin to maven build
> --
>
> Key: JOSHUA-301
> URL: https://issues.apache.org/jira/browse/JOSHUA-301
> Project: Joshua
>  Issue Type: Sub-task
>  Components: build
>Reporter: Max Thomas
>Priority: Minor
> Fix For: 6.1
>
>
> Add the findbugs maven plugin to the build. This will allow the build to 
> report on issues found via the popular Findbugs static analysis tool. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-265) Refactor key interfaces and core code for a future release.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426428#comment-15426428
 ] 

ASF GitHub Bot commented on JOSHUA-265:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/41
  
This looks great. I put it on a new branch off 7 so that we can Travis-CI 
it (on the idea that 7 is its own master). Once we get all the regression tests 
removed and merged in from master, I'll merge this back into 7.

Tagging this on JOSHUA-265 and JOSHUA-273.


> Refactor key interfaces and core code for a future release. 
> 
>
> Key: JOSHUA-265
> URL: https://issues.apache.org/jira/browse/JOSHUA-265
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>Priority: Minor
> Fix For: 6.2
>
>
> We've discussed making some modifications to the key interfaces.  This ticket 
> can focus on making large changes to the codebase for a future release.  This 
> work will likely take some time and some collaboration.  I'd suggest some the 
> code for this be a separate release branch.
> Some issues we can work on:
> *  I'd propose we conform to the SOLID principles for our major interfaces.  
> https://en.wikipedia.org/wiki/SOLID_(object-oriented_design)  . 
> *  We can look at Sparse / Dense feature vectors and how to handle them 
> naturally in Joshua.
> *  Refactor objects that may now be used more broadly than was originally 
> intended (for example Vocabulary class).
> *  We should have a general discussion around what parts of the codebase are 
> responsible for what functions.  We should clearly define what logic should 
> be a part of the Grammar versus the Feature Functions for example, and make 
> sure logic doesn't leak from one of these objects to the others.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-302) Remove concurrent package and replace with builtins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425173#comment-15425173
 ] 

ASF GitHub Bot commented on JOSHUA-302:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/40


> Remove concurrent package and replace with builtins
> ---
>
> Key: JOSHUA-302
> URL: https://issues.apache.org/jira/browse/JOSHUA-302
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Minor
>
> According to this site:
> http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html
> this package is essentially replaced by SDK builtins from JDK5.0+. 
> Is there a reason this is still a dependency and cannot be replaced with 
> default library code (which, according to the site, "includes improved, more 
> efficient, standardized versions of the main components in this package")? 
> It seems to only be used in 2 places, one of which is  about 3000 lines of 
> copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-302) Remove concurrent package and replace with builtins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425171#comment-15425171
 ] 

ASF GitHub Bot commented on JOSHUA-302:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/40
  
I actually think this might have been auto-inserted by Eclipse somehow 
(resolving to the wrong version of a library). So, good find, and thanks for 
submitting.


> Remove concurrent package and replace with builtins
> ---
>
> Key: JOSHUA-302
> URL: https://issues.apache.org/jira/browse/JOSHUA-302
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Minor
>
> According to this site:
> http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html
> this package is essentially replaced by SDK builtins from JDK5.0+. 
> Is there a reason this is still a dependency and cannot be replaced with 
> default library code (which, according to the site, "includes improved, more 
> efficient, standardized versions of the main components in this package")? 
> It seems to only be used in 2 places, one of which is  about 3000 lines of 
> copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-302) Remove concurrent package and replace with builtins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424749#comment-15424749
 ] 

ASF GitHub Bot commented on JOSHUA-302:
---

GitHub user maxthomas opened a pull request:

https://github.com/apache/incubator-joshua/pull/40

JOSHUA-302 - Remove dependency on concurrent/concurrent package



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maxthomas/incubator-joshua JOSHUA-302

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 19fe7561aa516b1a7eba63473e8d26111a708c33
Author: Max Thomas 
Date:   2016-08-17T15:32:20Z

JOSHUA-302 - Remove dependency on concurrent/concurrent package; replace 
instances with JDK library builtins




> Remove concurrent package and replace with builtins
> ---
>
> Key: JOSHUA-302
> URL: https://issues.apache.org/jira/browse/JOSHUA-302
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Minor
>
> According to this site:
> http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html
> this package is essentially replaced by SDK builtins from JDK5.0+. 
> Is there a reason this is still a dependency and cannot be replaced with 
> default library code (which, according to the site, "includes improved, more 
> efficient, standardized versions of the main components in this package")? 
> It seems to only be used in 2 places, one of which is  about 3000 lines of 
> copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-294) Remove CommandLineParser class

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420075#comment-15420075
 ] 

ASF GitHub Bot commented on JOSHUA-294:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/38


> Remove CommandLineParser class
> --
>
> Key: JOSHUA-294
> URL: https://issues.apache.org/jira/browse/JOSHUA-294
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Trivial
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The CommandLineParser class is a couple hundred of lines of untested code, 
> with inner classes, that is never called anywhere else in the project. 
> Perhaps it should be removed, especially given its similarity to ArgsParser 
> in the decoder package. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-294) Remove CommandLineParser class

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420020#comment-15420020
 ] 

ASF GitHub Bot commented on JOSHUA-294:
---

GitHub user maxthomas opened a pull request:

https://github.com/apache/incubator-joshua/pull/38

JOSHUA-294 - Remove CommandLineParser class

Removes CommandLineParser class which was untested and unused, and similar 
to ArgsParser, which is actually used.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maxthomas/incubator-joshua JOSHUA-294

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #38


commit fcaf0bf8e4ad487ee26c5276ddbecd0ef323eed7
Author: Max Thomas 
Date:   2016-08-13T17:59:51Z

JOSHUA-294 - Remove CommandLineParser class, which was untested and unused, 
and similar to ArgsParser, which is actually used.




> Remove CommandLineParser class
> --
>
> Key: JOSHUA-294
> URL: https://issues.apache.org/jira/browse/JOSHUA-294
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Trivial
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The CommandLineParser class is a couple hundred of lines of untested code, 
> with inner classes, that is never called anywhere else in the project. 
> Perhaps it should be removed, especially given its similarity to ArgsParser 
> in the decoder package. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-292) Add travis CI build status badge to README.md

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419345#comment-15419345
 ] 

ASF GitHub Bot commented on JOSHUA-292:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/37


> Add travis CI build status badge to README.md
> -
>
> Key: JOSHUA-292
> URL: https://issues.apache.org/jira/browse/JOSHUA-292
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Trivial
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Would be nice to see the status of the latest master branch build from the 
> README - many projects do this already. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-292) Add travis CI build status badge to README.md

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15419344#comment-15419344
 ] 

ASF GitHub Bot commented on JOSHUA-292:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/37
  
Thanks!


> Add travis CI build status badge to README.md
> -
>
> Key: JOSHUA-292
> URL: https://issues.apache.org/jira/browse/JOSHUA-292
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Trivial
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Would be nice to see the status of the latest master branch build from the 
> README - many projects do this already. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-292) Add travis CI build status badge to README.md

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418165#comment-15418165
 ] 

ASF GitHub Bot commented on JOSHUA-292:
---

GitHub user maxthomas opened a pull request:

https://github.com/apache/incubator-joshua/pull/37

JOSHUA-292 - Add travis CI badge to README.md



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maxthomas/incubator-joshua JOSHUA-292

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit d0e43a6586cb501fa1d7053e4f313409aa373608
Author: Max Thomas 
Date:   2016-08-12T00:19:16Z

JOSHUA-292 - Add travis CI badge to README.md




> Add travis CI build status badge to README.md
> -
>
> Key: JOSHUA-292
> URL: https://issues.apache.org/jira/browse/JOSHUA-292
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Trivial
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> Would be nice to see the status of the latest master branch build from the 
> README - many projects do this already. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397497#comment-15397497
 ] 

ASF GitHub Bot commented on JOSHUA-286:
---

Github user mjpost commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/32#discussion_r72616102
  
--- Diff: scripts/support/make-release.sh ---
@@ -40,7 +40,7 @@ echo "Bundling up joshua-$version"
 [[ ! -d release ]] && mkdir release
 rm -f joshua-$version && ln -s $JOSHUA joshua-$version
 
-wget -r http://joshua-decoder.org/
+wget -r http://joshua.apache.org/6.0/
--- End diff --

This was intended to bundle a crawl of the website with the release. It 
should be removed. Joshua is now hosted on Confluence, so the directory paths 
now longer work. Also, Confluence has better tools for documentation export if 
we should decide to use them in the future.


> Remove presence of all joshua-decoder.org links in codebase
> ---
>
> Key: JOSHUA-286
> URL: https://issues.apache.org/jira/browse/JOSHUA-286
> Project: Joshua
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
> Fix For: 6.1
>
>
> Right now, joshua-decoder.org exists in the following files, we should remove 
> it and replace it with joshua.apache.org
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr 
> "joshua-decoder.org" .
> ./.gitignore
> ./CHANGELOG
> ./doc/mainpage.md
> ./scripts/support/make-release.sh
> ./src/main/java/org/apache/joshua/decoder/Decoder.java
> ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397495#comment-15397495
 ] 

ASF GitHub Bot commented on JOSHUA-286:
---

Github user mjpost commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/32#discussion_r72615877
  
--- Diff: .gitignore ---
@@ -42,6 +42,7 @@ doxygen_*.tmp
 .cachepipe
 
 joshua-decoder.org
+joshua.apache.org
--- End diff --

Yeah, agreed. I used to bundle a crawl of the website with the repo, but am 
no longer going to do so.


> Remove presence of all joshua-decoder.org links in codebase
> ---
>
> Key: JOSHUA-286
> URL: https://issues.apache.org/jira/browse/JOSHUA-286
> Project: Joshua
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
> Fix For: 6.1
>
>
> Right now, joshua-decoder.org exists in the following files, we should remove 
> it and replace it with joshua.apache.org
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr 
> "joshua-decoder.org" .
> ./.gitignore
> ./CHANGELOG
> ./doc/mainpage.md
> ./scripts/support/make-release.sh
> ./src/main/java/org/apache/joshua/decoder/Decoder.java
> ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396920#comment-15396920
 ] 

ASF GitHub Bot commented on JOSHUA-286:
---

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/32#discussion_r72566150
  
--- Diff: src/main/java/org/apache/joshua/decoder/Decoder.java ---
@@ -496,7 +496,7 @@ public Decoder initialize(String configFile) {
   errMsg.append("FATAL: Invalid feature weight line found in 
config file.\n");
   errMsg.append(String.format("The line was '%s'\n", pairStr));
   errMsg.append("You might be using an old version of the config 
file that is no longer supported\n");
-  errMsg.append("Check joshua-decoder.org or email 
joshua_supp...@googlegroups.com for help\n");
+  errMsg.append("Check joshua.apache.org or email 
joshua_supp...@googlegroups.com for help\n");
--- End diff --

The email should be d...@joshua.apache.org


> Remove presence of all joshua-decoder.org links in codebase
> ---
>
> Key: JOSHUA-286
> URL: https://issues.apache.org/jira/browse/JOSHUA-286
> Project: Joshua
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
> Fix For: 6.1
>
>
> Right now, joshua-decoder.org exists in the following files, we should remove 
> it and replace it with joshua.apache.org
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr 
> "joshua-decoder.org" .
> ./.gitignore
> ./CHANGELOG
> ./doc/mainpage.md
> ./scripts/support/make-release.sh
> ./src/main/java/org/apache/joshua/decoder/Decoder.java
> ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396916#comment-15396916
 ] 

ASF GitHub Bot commented on JOSHUA-286:
---

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/32#discussion_r72566047
  
--- Diff: CHANGELOG ---
@@ -139,7 +139,7 @@ They include:
 
 - Significantly improved and expanded documentation (both user and 
developer)
 
-  See http://joshua-decoder.org/4.0 or ./joshua-decoder.org/4.0/index.html 
(local mirror)
+  See http://apache.joshua.org/4.0 or ./apache.joshua.org/4.0/index.html 
(local mirror)
--- End diff --

There is no such site as http://apache.joshua.org, it should be 
http://joshua.apache.org, also the CHANGELOG should not be altered at all as 
this indicates changes to previous releases.


> Remove presence of all joshua-decoder.org links in codebase
> ---
>
> Key: JOSHUA-286
> URL: https://issues.apache.org/jira/browse/JOSHUA-286
> Project: Joshua
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
> Fix For: 6.1
>
>
> Right now, joshua-decoder.org exists in the following files, we should remove 
> it and replace it with joshua.apache.org
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr 
> "joshua-decoder.org" .
> ./.gitignore
> ./CHANGELOG
> ./doc/mainpage.md
> ./scripts/support/make-release.sh
> ./src/main/java/org/apache/joshua/decoder/Decoder.java
> ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396917#comment-15396917
 ] 

ASF GitHub Bot commented on JOSHUA-286:
---

Github user lewismc commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/32#discussion_r72566062
  
--- Diff: scripts/support/make-release.sh ---
@@ -40,7 +40,7 @@ echo "Bundling up joshua-$version"
 [[ ! -d release ]] && mkdir release
 rm -f joshua-$version && ln -s $JOSHUA joshua-$version
 
-wget -r http://joshua-decoder.org/
+wget -r http://joshua.apache.org/6.0/
--- End diff --

Again, this site does not exist.


> Remove presence of all joshua-decoder.org links in codebase
> ---
>
> Key: JOSHUA-286
> URL: https://issues.apache.org/jira/browse/JOSHUA-286
> Project: Joshua
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
> Fix For: 6.1
>
>
> Right now, joshua-decoder.org exists in the following files, we should remove 
> it and replace it with joshua.apache.org
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr 
> "joshua-decoder.org" .
> ./.gitignore
> ./CHANGELOG
> ./doc/mainpage.md
> ./scripts/support/make-release.sh
> ./src/main/java/org/apache/joshua/decoder/Decoder.java
> ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396840#comment-15396840
 ] 

ASF GitHub Bot commented on JOSHUA-286:
---

GitHub user john-hewitt opened a pull request:

https://github.com/apache/incubator-joshua/pull/32

JOSHUA-286 - Replace old joshua-decoder.org links with joshua.apache.org

- Update links to documentation and support to reflect the 
move to Apache. 
- keep Gitignore entry for old website was kept to keep the 
repo clean. 
- Update links to the git repo as well.
- old pages in the `docs` folder unchanged. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/john-hewitt/incubator-joshua JOSHUA-286

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit 36a58e75e5deb71bdeed2980e740502fe3d516c2
Author: John Hewitt 
Date:   2016-07-28T02:57:04Z

Replace old joshua-decoder.org links with joshua.apache.org

Updating links to documentation and support to reflect the
move to Apache. Gitignore entry was kept to keep the repo
clean. References to the old git repo were updated as well.




> Remove presence of all joshua-decoder.org links in codebase
> ---
>
> Key: JOSHUA-286
> URL: https://issues.apache.org/jira/browse/JOSHUA-286
> Project: Joshua
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
> Fix For: 6.1
>
>
> Right now, joshua-decoder.org exists in the following files, we should remove 
> it and replace it with joshua.apache.org
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr 
> "joshua-decoder.org" .
> ./.gitignore
> ./CHANGELOG
> ./doc/mainpage.md
> ./scripts/support/make-release.sh
> ./src/main/java/org/apache/joshua/decoder/Decoder.java
> ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-279) Cannot build Joshua master branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373586#comment-15373586
 ] 

ASF GitHub Bot commented on JOSHUA-279:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/30


> Cannot build Joshua master branch
> -
>
> Key: JOSHUA-279
> URL: https://issues.apache.org/jira/browse/JOSHUA-279
> Project: Joshua
>  Issue Type: Bug
>  Components: build, documentation, tests
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> Hi Folks,
> We need to be cautious of whatever is committed to master branch... the build 
> has been broken for quite some time and there are constant Javadoc issues 
> which make the build unstable as well.
> For example, when i make an attempt to build master branch we have failing 
> tests
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(master) $ mvn clean install
> ...
> ---
>  T E S T S
> ---
> Running TestSuite
> tm_pt_0=-2.000 tm_glue_0=3.000 lm_0=-206.718 lm_0_oov=2.000 
> OOVPenalty=-200.000 | -198.000
> ERROR - * FATAL: Can't find libken.so (libken.dylib on OS X) in $JOSHUA/lib
> ERROR - *This probably means that the KenLM library didn't compile.
> ERROR - *Make sure that BOOST_ROOT is set to the root of your boost
> ERROR - *installation (it's not /opt/local/, the default), change to
> ERROR - *$JOSHUA, and type 'ant kenlm'. If problems persist, see the
> ERROR - *website (joshua-decoder.org).
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> %
> %
> %
> %
> %
> %
> %
> %
> %
> Tests run: 126, Failures: 1, Errors: 0, Skipped: 6, Time elapsed: 1.818 sec 
> <<< FAILURE! - in TestSuite
> setUp(org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest)  
> Time elapsed: 0.075 sec  <<< FAILURE!
> java.lang.ExceptionInInitializerError
>   at 
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(ClassBasedLanguageModelTest.java:52)
> Caused by: java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: no ken 
> in java.library.path
>   at 
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(ClassBasedLanguageModelTest.java:52)
> Caused by: java.lang.UnsatisfiedLinkError: no ken in java.library.path
>   at 
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(ClassBasedLanguageModelTest.java:52)
> Results :
> Failed tests:
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest)
>   Run 1: ClassBasedLanguageModelTest.setUp:52 » ExceptionInInitializer
>   Run 2: PASS
> Tests run: 124, Failures: 1, Errors: 0, Skipped: 4
> [INFO] 
> 
> [INFO] BUILD FAILURE
> {code}
> As a workaround I thought I will try to build the project without running the 
> test suite, however now Javadoc issues prevent me from doing so!
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(master) $ mvn clean install 
> -DskipTests
> ...
> 1 error
> 14 warnings
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 28.144 s
> [INFO] Finished at: 2016-07-01T14:11:42-07:00
> [INFO] Final Memory: 37M/303M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:2.8:jar (attach-javadocs) on 
> project joshua: MavenReportException: Error while creating archive:
> [ERROR] Exit code: 1 - 
> /usr/local/incubator-joshua/src/main/java/org/apache/joshua/decoder/ff/lm/LanguageModelFF.java:217:
>  warning: no @param for rule
> [ERROR] public int[] getRuleIds(final Rule rule) {
> [ERROR] ^
> [ERROR] 
> 

[jira] [Commented] (JOSHUA-279) Cannot build Joshua master branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372519#comment-15372519
 ] 

ASF GitHub Bot commented on JOSHUA-279:
---

GitHub user KellenSunderland opened a pull request:

https://github.com/apache/incubator-joshua/pull/30

JOSHUA-279 Skip tests that rely on KenLM when KenLM is not present.

For unit tests that rely on KenLM I'm going to try and convert them all to 
follow this pattern.  We'll initialize the unit of work in the setup, and catch 
the usual exception kenlm throws when the library is not found.  We'll then 
swallow the exception and rethrow an exception indicating to testng that the 
test should be skipped.  This way on systems that don't have the KenLM binaries 
the test will be skipped without failing, and on systems that do have KenLM the 
test will be properly run.

I've run this with 'mvn' and 'mvn clean install' and both are working for 
me with/without KenLM.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/KellenSunderland/incubator-joshua master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #30


commit 7326befe556f8ab0a744dd2a7718e9af097bfbf4
Author: Kellen Sunderland 
Date:   2016-07-11T16:21:54Z

JOSHUA-279 Skip tests that rely on KenLM when KenLM is not present.




> Cannot build Joshua master branch
> -
>
> Key: JOSHUA-279
> URL: https://issues.apache.org/jira/browse/JOSHUA-279
> Project: Joshua
>  Issue Type: Bug
>  Components: build, documentation, tests
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Blocker
> Fix For: 6.1
>
>
> Hi Folks,
> We need to be cautious of whatever is committed to master branch... the build 
> has been broken for quite some time and there are constant Javadoc issues 
> which make the build unstable as well.
> For example, when i make an attempt to build master branch we have failing 
> tests
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-joshua(master) $ mvn clean install
> ...
> ---
>  T E S T S
> ---
> Running TestSuite
> tm_pt_0=-2.000 tm_glue_0=3.000 lm_0=-206.718 lm_0_oov=2.000 
> OOVPenalty=-200.000 | -198.000
> ERROR - * FATAL: Can't find libken.so (libken.dylib on OS X) in $JOSHUA/lib
> ERROR - *This probably means that the KenLM library didn't compile.
> ERROR - *Make sure that BOOST_ROOT is set to the root of your boost
> ERROR - *installation (it's not /opt/local/, the default), change to
> ERROR - *$JOSHUA, and type 'ant kenlm'. If problems persist, see the
> ERROR - *website (joshua-decoder.org).
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - sentence 0 too long 401, truncating to length 200
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> WARN - no grammars supplied!  Supplying dummy glue grammar.
> %
> %
> %
> %
> %
> %
> %
> %
> %
> Tests run: 126, Failures: 1, Errors: 0, Skipped: 6, Time elapsed: 1.818 sec 
> <<< FAILURE! - in TestSuite
> setUp(org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest)  
> Time elapsed: 0.075 sec  <<< FAILURE!
> java.lang.ExceptionInInitializerError
>   at 
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(ClassBasedLanguageModelTest.java:52)
> Caused by: java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: no ken 
> in java.library.path
>   at 
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(ClassBasedLanguageModelTest.java:52)
> Caused by: java.lang.UnsatisfiedLinkError: no ken in java.library.path
>   at 
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(ClassBasedLanguageModelTest.java:52)
> Results :
> Failed tests:
> org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest.setUp(org.apache.joshua.decoder.ff.lm.class_lm.ClassBasedLanguageModelTest)
>   Run 1: ClassBasedLanguageModelTest.setUp:52 

[jira] [Commented] (JOSHUA-273) Joshua API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339419#comment-15339419
 ] 

ASF GitHub Bot commented on JOSHUA-273:
---

Github user mjpost commented on the pull request:


https://github.com/apache/incubator-joshua/commit/6d2213a20b74432fc7cb131c732f7507b74053e9#commitcomment-17933088
  
In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java:
In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java on 
line 57:
Hi Felix — I guess I probably don't. I put this in so as to have the 
convenience functions of querying the maps (that are in FeatureVector), and 
didn't realize why you guys had stuck with just a HashMap. I'll revert it.

In general, this relates to JOSHUA-273: I want to remove all the output 
code from KBestExtractor and place it in StructuredTranslation (and then, in 
turn, to collapse Translation and StructuredTranslation). There are at least 
two ways to do this; do you have a preference?

- StructuredTranslationFactory could be called to create the necessary 
entries in StructuredTranslation, which would then just be stored as strings. 
This approach makes StructuredTranslation basically just a container that is 
operated on.

- StructuredTranslation can do its own computation, formatting the 
"outputFormat" line from the config file. This view makes StructuredTranslation 
itself a bit smarter.

matt


> Joshua API
> --
>
> Key: JOSHUA-273
> URL: https://issues.apache.org/jira/browse/JOSHUA-273
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Matt Post
> Fix For: 7
>
>
> We have a lot of work to do to clean up the decoder's internal object 
> pipeline in order to create a nice, clean API.
> (This is just a stub for this issue; I will return soon with a better 
> description and roadmap. Others feel free to edit, as well).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309134#comment-15309134
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/12


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308852#comment-15308852
 ] 

ASF GitHub Bot commented on JOSHUA-258:
---

Github user lewismc closed the pull request at:

https://github.com/apache/incubator-joshua/pull/8


> Add back penn-treebank-(de)tokenizer perl scripts
> -
>
> Key: JOSHUA-258
> URL: https://issues.apache.org/jira/browse/JOSHUA-258
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> I've been working with the 
> [joshua_translation_engine|https://github.com/joshua-decoder/joshua_translation_engine]
>  (which is friggin excellent, we will definately be standing this up on 
> something more heavyweight in the near future) and recently reported [issue 
> 15|https://github.com/joshua-decoder/joshua_translation_engine/issues/15]
> This issue therefore proposes to add back in penn-treebank-(de)tokenizer perl 
> scripts which were removed between 6.0.4 and 6.0.5 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308818#comment-15308818
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Actually @chrismattmann it's just a fast-forward at this point — all is 
merged on JOSHUA-252, it's just not showing up on this PR.

https://github.com/apache/incubator-joshua/tree/JOSHUA-252


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308680#comment-15308680
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user chrismattmann commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
+1 great work! watch out there are conflicts to resolve before merging 
@mjpost 


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308719#comment-15308719
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Ho @mjpost can you point me at the latest BerkeleyLM codebase? I can 
Mavenize it and get it in to Maven Central so we can use it as a dependency in 
pom.xml


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308675#comment-15308675
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12
  
Unless there are any objections, I'd like to merge this branch back into 
master. There are a few small issues, but none that can't be addressed with 
documentation. I'd love to do this either tonight or tomorrow, so please voice 
any objections as soon as possible.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-273) Joshua API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307694#comment-15307694
 ] 

ASF GitHub Bot commented on JOSHUA-273:
---

Github user fhieber commented on the pull request:

https://github.com/apache/incubator-joshua/pull/20
  
You are right, the structural changes in this PR are subsumed by JOSHUA-273 
mostly. However, the changes to the alignment code would still be beneficial.


> Joshua API
> --
>
> Key: JOSHUA-273
> URL: https://issues.apache.org/jira/browse/JOSHUA-273
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Matt Post
> Fix For: 7
>
>
> We have a lot of work to do to clean up the decoder's internal object 
> pipeline in order to create a nice, clean API.
> (This is just a stub for this issue; I will return soon with a better 
> description and roadmap. Others feel free to edit, as well).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-273) Joshua API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307688#comment-15307688
 ] 

ASF GitHub Bot commented on JOSHUA-273:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/20
  
So it seems this isn't compatible with JOSHUA-273 (which is fine), but 
provides some of its functionality.

One concern I have is the complexity of juggling the master branch, 
JOSHUA-252, JOSHUA-273, and these changes in my head right now. I'd really like 
to get JOSHUA-252 merged in to help simplify things. 

We would then want to merge either (a) JOSHUA-273, after having 
Decoder.decodeAll() return Translations, (b) merge this PR, or both. The reason 
I'm pushing a bit for JOSHUA-273 is because I also removed a lot of the 
redundancies in k-best extraction and so on, collapsed Translation and 
StructuredTranslation, and did some other things. It seems that it subsumes 
this PR? In which case, it might be less complex to go that route. But correct 
me if I'm wrong, or if JOSHUA-273 is headed in the wrong direction, or if this 
PR has some short-term advantage that can help us out in the meantime.


> Joshua API
> --
>
> Key: JOSHUA-273
> URL: https://issues.apache.org/jira/browse/JOSHUA-273
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Matt Post
> Fix For: 7
>
>
> We have a lot of work to do to clean up the decoder's internal object 
> pipeline in order to create a nice, clean API.
> (This is just a stub for this issue; I will return soon with a better 
> description and roadmap. Others feel free to edit, as well).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-273) Joshua API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307682#comment-15307682
 ] 

ASF GitHub Bot commented on JOSHUA-273:
---

Github user fhieber commented on the pull request:

https://github.com/apache/incubator-joshua/pull/20
  
These changes would not be immediately compatible with JOSHUA-273. The 
latter is unlikely to be immediately merged, right? 
Basically, the KBestExtractor now may return StructuredTranslations so that 
you can return them if Joshua is used as a library.


> Joshua API
> --
>
> Key: JOSHUA-273
> URL: https://issues.apache.org/jira/browse/JOSHUA-273
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Matt Post
> Fix For: 7
>
>
> We have a lot of work to do to clean up the decoder's internal object 
> pipeline in order to create a nice, clean API.
> (This is just a stub for this issue; I will return soon with a better 
> description and roadmap. Others feel free to edit, as well).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-273) Joshua API

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307640#comment-15307640
 ] 

ASF GitHub Bot commented on JOSHUA-273:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/20
  
I plan to look at this this morning. One question: how does this relate to 
the changes in JOSHUA-273? Are they more or less along the same lines, or do 
they do different things? If I changed JOSHUA-273 so that Decoder.decodeAll() 
returns a Translation object, would that accomplish what you've done here? If 
you have any notes on this (or even an I don't know) that will inform my review.


> Joshua API
> --
>
> Key: JOSHUA-273
> URL: https://issues.apache.org/jira/browse/JOSHUA-273
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Matt Post
> Fix For: 7
>
>
> We have a lot of work to do to clean up the decoder's internal object 
> pipeline in order to create a nice, clean API.
> (This is just a stub for this issue; I will return soon with a better 
> description and roadmap. Others feel free to edit, as well).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305067#comment-15305067
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-81985
  
ack


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305054#comment-15305054
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-80223
  
yes @thammegowda the process is welcome and appreciated Sir. on a side note 
hove you tried th Docker containersTZ?


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304788#comment-15304788
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-54428
  
@mjpost 
> Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean 
that eclipse compiled files will override the jar? So I can do fast development 
in Eclipse?

Seems like you have hard-time with eclipse maven integration.
last time when I used eclipse there was a eclipse plugin that recognized 
maven projects. That plugin took care of all the complexities under the hood. 
If you have proper setup, you can just go to "JoshuaDecoder" (or whichever 
class you want to run) and "Run main" (no need to package, because that takes 
time)

P.S. I use Intellij Idea opensource edition and the maven integration is a 
breeze.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304655#comment-15304655
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-37297
  
Okay, great! That worked. I assume the edits to $JOSHUA/bin/joshua mean 
that eclipse compiled files will override the jar? So I can do fast development 
in Eclipse?

We still have to solve the KenLM problem. My tests ran because I linked 
$JOSHUA/ext and $JOSHUA/lib to directories on master. Do we have ideas for how 
to pull in KenLM and compile it? And BerkeleyLM? I think that's the big thing 
remaining.

After that, I'll have to go over the log messages in a bit more detail.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304582#comment-15304582
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-29485
  
These are the logs I am getting when the level is OFF, WARN, INFO and DEBUG.

I ran `echo "Subject is not object" | bin/joshua > file.txt`

[off.txt](https://github.com/apache/incubator-joshua/files/287205/off.txt)
[warn.txt](https://github.com/apache/incubator-joshua/files/287204/warn.txt)
[info.txt](https://github.com/apache/incubator-joshua/files/287202/info.txt)

[debug.txt](https://github.com/apache/incubator-joshua/files/287201/debug.txt)



> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304410#comment-15304410
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-06844
  
@lewismc @mjpost  Just looked into this. I will debug this issue and come 
back with my findings soon.

+1 for rethinking about log levels.  we can lower some frequent INFO 
messages to DEBUG level.



> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304344#comment-15304344
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-3
  
Just to be clear, not sure it needs to be reverted. We just need to find a 
way to make sure the config file gets read and that logging gets set to INFO by 
default. And logging should all go to STDERR, I think, not STDOUT.

In general, too, having INFO prepended to all informative lines is a bit 
ugly. Is this a useful convention for reasons I can't understand? It's often 
useful to see the decoder working with just these high-level labels, and I 
don't mind debug lines being prepended with DEBUG.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15304340#comment-15304340
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222199387
  
@thammegowda please revert logging patch. 


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303924#comment-15303924
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222118458
  
On a hunch, I went through and removed all the calls LOG.*() in Decoder, 
DecoderThread, JoshuaDecoder, Translation, Chart, DotChart, and 
ComputeNodeResult. This fixed the problem; the decoder now runs as fast as 
before.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303101#comment-15303101
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222016079
  
Okay, I have merged. The handful of test cases I checked passed, but there 
is bad news: the decoder is *significantly* slower, like by an order of 
magnitude. Tests that returned instantly before or took just a second or two 
now take 10–20. This is with log levels turned off. Those of you who have 
worked on this branch, do you have any guesses what the problem might be?



> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303077#comment-15303077
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222012667
  
@mjpost as you pointed out, you need to edit log4j settings.

The other way is to edit `src/main/resources/log4j.properties`


If you dont want to rebuild the jar after editing the file, you can create 
an updated log4j.properties and  prefix  its path to the class path (so that it 
gets priority over the one inside jar)


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303068#comment-15303068
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011444
  
Okay, the answer is that our slfj4 is using log4j12 as the backend. I had 
to add

-Dlog4j.configuration=$JOSHUA/logging.properties

to the invocation, and then put

log4j.rootLogger=OFF

(or info, etc).




> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303061#comment-15303061
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user KellenSunderland commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222011143
  
Does setting it to error instead of info help?
On May 27, 2016 12:04 AM, "Matt Post"  wrote:

> Can someone tell me how to turn off logging in slf4j? I have tried passing
>
> -Dorg.slf4j.Logger.defaultLogLevel=info
>
> but this does not seem to work. Extensive googling around and walking
> through the manual have not turned up anything. I've probably missed
> something.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> 

>



> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303038#comment-15303038
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222008424
  
Can someone tell me how to turn off logging in slf4j? I have tried passing

-Dorg.slf4j.Logger.defaultLogLevel=info

but this does not seem to work. Extensive googling around and walking 
through the manual have not turned up anything. I've probably missed something.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302967#comment-15302967
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-222000585
  
Nevermind, found Thamme's [old 
instructions](https://github.com/apache/incubator-joshua/pull/14#issue-155139645).


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302750#comment-15302750
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221969513
  
Okay, cool, I got this merged and compiling. First, THANK YOU for all of 
this amazing work! This feels like a real milestone and it was fun to work 
through the merge.

Before I push, I need to run the tests, though, and am not sure how to 
invoke the decoder. Can you provide some assistance here? I don't know maven 
very well, so if there are any maven commands to type first, that would also 
help to know. Basically, if you can get me to the point where I can type

$ echo test | joshua

and it returns

0 ||| test ||| tm_glue_0=1.000 ||| 0.000

then I can run my regression tests and push up.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302465#comment-15302465
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221933542
  
Hi @mjpost thanks for response
```
Do you want me to be the one to merge master into JOSHUA-252? Then we can 
test and merge back into master. I think this might be our 6.1 release?
```
Yes please if you could take care of merging your work on master into 
JOSHUA-252 then that would be grand. I am not overly familiar with the work 
done so I don't want to botch it. Thanks Matt.

```
Is it possible to have Maven do git checkouts (on specific versions?) 
That's one route
```
I was thinking the exact same thing and I am actively investigating here. 
```
Otherwise, we should just rely on the user to set them up. The only real 
problem is for BerkeleyLM and KenLM, since those are runtime. I don't have much 
experience in how to do this. But we could have a maven target that does a git 
checkout of a specific version, kind of like a submodule.
```
Hopefully I can provide insight and input into this. Give me a wee bit of 
time and I can get around to answering in due course. 
```
Thrax and GIZA (and fast_align) we can tell the user to set up.
```
Agreed. I sent a PR for Thrax (which is incomplete due to changes in the 
underlying API) which Mavenies the entire build 
https://github.com/joshua-decoder/thrax/pull/12 we could then pull Thrax as a 
dependency within Joshua.
For GIZA we will get the user to set up.

Thanks


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302396#comment-15302396
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221928486
  
There have been changes on master (JOSHUA-271 and JOSHUA-272), will try to 
get to this soon, probably not till tomorrow.

Do you want me to be the one to merge master into JOSHUA-252? Then we can 
test and merge back into master. I think this might be our 6.1 release?

For packages:

- Is it possible to have Maven do git checkouts (on specific versions?) 
That's one route
- Otherwise, we should just rely on the user to set them up. The only real 
problem is for BerkeleyLM and KenLM, since those are runtime. I don't have much 
experience in how to do this. But we could have a maven target that does a git 
checkout of a specific version, kind of like a submodule.
- Thrax and GIZA (and fast_align) we can tell the user to set up.

matt


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301637#comment-15301637
 ] 

ASF GitHub Bot commented on JOSHUA-262:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/17


> Implement all logging as Slf4j over Log4j
> -
>
> Key: JOSHUA-262
> URL: https://issues.apache.org/jira/browse/JOSHUA-262
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Thamme Gowda N
> Fix For: 6.1
>
>
> [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If 
> we use [parameterized logging 
> notation|http://www.slf4j.org/faq.html#logging_performance] we can have good 
> logging in place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301568#comment-15301568
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/15#issuecomment-221782749
  
#17 has been created to make the merging job easy by targeting to 
JOSHUA-252.
 So closing this PR.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301542#comment-15301542
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/13


> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301535#comment-15301535
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221778184
  
@lewismc thanks for the reply.

rebased #13 , it is ready for merge!


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301530#comment-15301530
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221776975
  
hi @thammegowda thanks for reply

 *  #13 should be able to merge with this branch (have conflicts now, but i 
can resolve them)
Please rebase the above against this branch

*  #14 can be merged with this, no conflicts
I will merge this

#15 is targetted to branch named maven . Probably I need to raise a new PR 
targeted to this JOSHUA-252 branch ? 

Yes please do. All branches should be named after the associated Jira 
ticket. That way we have full blown provenance tracking for individual issues. 

Thanks, I'll merge #14 now


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301519#comment-15301519
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-221776421
  
great work @lewismc . 

All my activity is branched off from this branch

* #13  should be able to merge with this branch (have conflicts now, but i 
can resolve them)
* #14 can be merged with this, no conflicts
* #15 is targetted to branch named `maven` . Probably I need to raise a new 
PR targeted to this `JOSHUA-252` branch ? 


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300621#comment-15300621
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:


https://github.com/apache/incubator-joshua/commit/76eb9587a9c321d45a9560481429e2dffd918e4e#commitcomment-17618558
  
In src/joshua/decoder/ff/tm/Rule.java:
In src/joshua/decoder/ff/tm/Rule.java on line 201:
Yes, definitely, will do. I was originally trying to limit the impact of 
the merge given the huge impending merge with JOSHUA-252, but by now, with the 
other stuff, it's too late :)


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294936#comment-15294936
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user KellenSunderland commented on the pull request:

https://github.com/apache/incubator-joshua/pull/13#issuecomment-220772283
  
Hey Thamme, thanks for the great PR.  Haven't checked the build yet myself 
but the commit looks good to me.


> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294648#comment-15294648
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753345
  
@mjpost Sorry for my previous incomplete comment.
 The problem I see with that line is, now we have new package 
`org.apache.joshua.decoder.ff` instead of old `joshua.decoder.ff`.
Since lewis is currently working on this, I didnt dare to raise a new PR to 
fix a single line :-) 


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294643#comment-15294643
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-220753066
  
What's problematic about that? FYI, that line is part of the code that lets 
feature functions be loaded by reflection, e.g., so you can write a new feature 
function and call it directly from the command line without having to add stub 
code to check for and load it.


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-252) Make it possible to use Maven to build Joshua

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285713#comment-15285713
 ] 

ASF GitHub Bot commented on JOSHUA-252:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/12#issuecomment-219586976
  
I didn't see your JOSHUA-252 branch. I just created a "maven" branch that 
pulls PRs 4 and 5 into this one. However, I don't see these on github / 
incubator. It seems that Apache is not pushing branches down to github.

Everything seems to compile for me when I type [the commands @thammegowda 
provided](https://github.com/apache/incubator-joshua/pull/13#issuecomment-219570096).
 However, I don't really know how to use Maven, and eclipse is totally broken. 
Can you add a BUILD file that describes how to compile and how to get things 
set up in eclipse?


> Make it possible to use Maven to build Joshua
> -
>
> Key: JOSHUA-252
> URL: https://issues.apache.org/jira/browse/JOSHUA-252
> Project: Joshua
>  Issue Type: Improvement
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> As per discussion on the dev@ list for now Ant is the official build tool for 
> Joshua however we would like to possibly switch to Maven if / when someone is 
> able to do so.
> Assigning to me for now as I could be able to look into this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285712#comment-15285712
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/13#issuecomment-219586971
  
Nice, I've been working on the eats for the last hour or so, so I'll update 
feature branch once this is done. 
@matt did you merge this PR into feature branch? If so then thanks very 
much. 


> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285703#comment-15285703
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/14#issuecomment-219586064
  
Okay, I have merged this into a JOSHUA-264 branch.


> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285587#comment-15285587
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/13#issuecomment-219571959
  
@mjpost Added `maven-assembly-plugin` to make the build cycle easy: 
https://github.com/apache/incubator-joshua/pull/14


> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285569#comment-15285569
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/13#issuecomment-219570096
  
My maven version

$ mvn --version
Apache Maven 3.0.5
Maven home: /usr/share/maven
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.19.0-32-generic", arch: "amd64", family: 
"unix"


To compile : 

mvn clean compile

To package 

mvn clean package # this fails if there are test failures
mvn clean package -DskipTests # to skip tests

To run main method in a class:

mvn compile exec:java 
-Dexec.mainClass=org.apache.joshua.decoder.JoshuaDecoder


> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285563#comment-15285563
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/13#issuecomment-219568967
  
Can you describe the maven build process? What version do you use, and what 
command do you type?


> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-264) Remove system exits and replace with RuntimeExceptions

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285557#comment-15285557
 ] 

ASF GitHub Bot commented on JOSHUA-264:
---

Github user thammegowda commented on the pull request:

https://github.com/apache/incubator-joshua/pull/13#issuecomment-219568358
  
This is based on Maven build.
Since the files are moved to new location in maven build, I branched off  
from JOSHUA-252 to avoid merge conflicts later time. 




> Remove system exits and replace with RuntimeExceptions
> --
>
> Key: JOSHUA-264
> URL: https://issues.apache.org/jira/browse/JOSHUA-264
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Kellen Sunderland
>
> When Joshua is used a library it's much more convenient to get 
> RuntimeExceptions when a fatal error happens.  This way the host process can 
> possibly handle the error or take some appropriate action (alarm, log, etc).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-257) Add license headers to all Python scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263259#comment-15263259
 ] 

ASF GitHub Bot commented on JOSHUA-257:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/7


> Add license headers to all Python scripts
> -
>
> Key: JOSHUA-257
> URL: https://issues.apache.org/jira/browse/JOSHUA-257
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> Simple case of adding license headers to all Python scripts as below
> {code}
> ./ext/kenlm/python/example.py
> ./ext/kenlm/setup.py
> ./scripts/features/addSparseFeatures.py
> ./scripts/lm/compile_berkeley.py
> ./scripts/samt/filterGrammar.py
> ./scripts/samt/lexprob2samt.py
> ./scripts/samt/selectFeatures.py
> ./scripts/support/merge_lms.py
> ./scripts/support/run_bundler.py
> ./scripts/toolkit/chunki.py
> ./scripts/toolkit/extract_references.py
> ./scripts/toolkit/joini.py
> ./scripts/toolkit/shorti.py
> ./scripts/training/class-lm/replaceTokensWithClasses.py
> ./scripts/training/run_thrax.py
> ./scripts/training/run_tuner.py
> ./test/prune-equivalent-translations.py
> ./test/scripts/merge_lms_test.py
> ./test/scripts/run_bundler_test.py
> ./thrax/scripts/berant_to_reference.py
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263253#comment-15263253
 ] 

ASF GitHub Bot commented on JOSHUA-258:
---

Github user mjpost commented on the pull request:

https://github.com/apache/incubator-joshua/pull/8#issuecomment-215592405
  
As noted there, this was moved to $JOSHUA/scripts/preparation/tokenize.pl 
(detokenize.pl), for the 6.1 release (part of an attempt to impose some 
organization on the scripts under scripts/training, which is getting unwieldy). 
I'll fix it there.


> Add back penn-treebank-(de)tokenizer perl scripts
> -
>
> Key: JOSHUA-258
> URL: https://issues.apache.org/jira/browse/JOSHUA-258
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> I've been working with the 
> [joshua_translation_engine|https://github.com/joshua-decoder/joshua_translation_engine]
>  (which is friggin excellent, we will definately be standing this up on 
> something more heavyweight in the near future) and recently reported [issue 
> 15|https://github.com/joshua-decoder/joshua_translation_engine/issues/15]
> This issue therefore proposes to add back in penn-treebank-(de)tokenizer perl 
> scripts which were removed between 6.0.4 and 6.0.5 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263079#comment-15263079
 ] 

ASF GitHub Bot commented on JOSHUA-258:
---

Github user lewismc commented on the pull request:

https://github.com/apache/incubator-joshua/pull/8#issuecomment-215571337
  
I also noted this issue over on 
https://github.com/joshua-decoder/joshua_translation_engine/issues/15


> Add back penn-treebank-(de)tokenizer perl scripts
> -
>
> Key: JOSHUA-258
> URL: https://issues.apache.org/jira/browse/JOSHUA-258
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> I've been working with the 
> [joshua_translation_engine|https://github.com/joshua-decoder/joshua_translation_engine]
>  (which is friggin excellent, we will definately be standing this up on 
> something more heavyweight in the near future) and recently reported [issue 
> 15|https://github.com/joshua-decoder/joshua_translation_engine/issues/15]
> This issue therefore proposes to add back in penn-treebank-(de)tokenizer perl 
> scripts which were removed between 6.0.4 and 6.0.5 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-258) Add back penn-treebank-(de)tokenizer perl scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263078#comment-15263078
 ] 

ASF GitHub Bot commented on JOSHUA-258:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/8

JOSHUA-258 Add back penn-treebank-(de)tokenizer perl scripts

This issue addresses https://issues.apache.org/jira/browse/JOSHUA-258

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-258

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit c43b8b023f4380159812ffa1ab03d6a0c646aaee
Author: Lewis John McGibbney 
Date:   2016-04-28T21:44:02Z

JOSHUA-258 Add back penn-treebank-(de)tokenizer perl scripts




> Add back penn-treebank-(de)tokenizer perl scripts
> -
>
> Key: JOSHUA-258
> URL: https://issues.apache.org/jira/browse/JOSHUA-258
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> I've been working with the 
> [joshua_translation_engine|https://github.com/joshua-decoder/joshua_translation_engine]
>  (which is friggin excellent, we will definately be standing this up on 
> something more heavyweight in the near future) and recently reported [issue 
> 15|https://github.com/joshua-decoder/joshua_translation_engine/issues/15]
> This issue therefore proposes to add back in penn-treebank-(de)tokenizer perl 
> scripts which were removed between 6.0.4 and 6.0.5 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-257) Add license headers to all Python scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262913#comment-15262913
 ] 

ASF GitHub Bot commented on JOSHUA-257:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/7

JOSHUA-257 Add license headers to all Python scripts

This issues addresses https://issues.apache.org/jira/browse/JOSHUA-257 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit 051cc489d0bce3ad928f3383f2b57f0193ae6a0d
Author: Lewis John McGibbney 
Date:   2016-04-28T20:26:16Z

JOSHUA-257 Add license headers to all Python scripts




> Add license headers to all Python scripts
> -
>
> Key: JOSHUA-257
> URL: https://issues.apache.org/jira/browse/JOSHUA-257
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> Simple case of adding license headers to all Python scripts as below
> {code}
> ./ext/kenlm/python/example.py
> ./ext/kenlm/setup.py
> ./scripts/features/addSparseFeatures.py
> ./scripts/lm/compile_berkeley.py
> ./scripts/samt/filterGrammar.py
> ./scripts/samt/lexprob2samt.py
> ./scripts/samt/selectFeatures.py
> ./scripts/support/merge_lms.py
> ./scripts/support/run_bundler.py
> ./scripts/toolkit/chunki.py
> ./scripts/toolkit/extract_references.py
> ./scripts/toolkit/joini.py
> ./scripts/toolkit/shorti.py
> ./scripts/training/class-lm/replaceTokensWithClasses.py
> ./scripts/training/run_thrax.py
> ./scripts/training/run_tuner.py
> ./test/prune-equivalent-translations.py
> ./test/scripts/merge_lms_test.py
> ./test/scripts/run_bundler_test.py
> ./thrax/scripts/berant_to_reference.py
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-256) Note that Joshua builds and runs with >= Java 1.8

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260529#comment-15260529
 ] 

ASF GitHub Bot commented on JOSHUA-256:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/5


> Note that Joshua builds and runs with >= Java 1.8
> -
>
> Key: JOSHUA-256
> URL: https://issues.apache.org/jira/browse/JOSHUA-256
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Critical
> Fix For: 6.1
>
>
> Since the Joshua code was transitioned into the Incubator, code has been 
> committed which requires Java 1.8 minimum to compile and run. 
> We should note this within the README and also on the Website once we move 
> towards out first 6.1 Incubating release. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-255) License headers for all bash scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260221#comment-15260221
 ] 

ASF GitHub Bot commented on JOSHUA-255:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/4

JOSHUA-255 License headers for all bash scripts

This issue addresses https://issues.apache.org/jira/browse/JOSHUA-255

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-255

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4


commit 3f55fe9e719ed578f417801c7abbeaca48e79e9d
Author: Lewis John McGibbney 
Date:   2016-04-27T14:15:13Z

JOSHUA-255 License headers for all bash scripts




> License headers for all bash scripts
> 
>
> Key: JOSHUA-255
> URL: https://issues.apache.org/jira/browse/JOSHUA-255
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
> Fix For: 6.1
>
>
> Add license headers to all bash scripts in master branch



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-254) Update README with correct branding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258675#comment-15258675
 ] 

ASF GitHub Bot commented on JOSHUA-254:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/3

JOSHUA-254 Update README with correct branding

This issue addresses https://issues.apache.org/jira/browse/JOSHUA-254

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-254

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3


commit 506264b571cd4a17284ba27e86cf98421fed1b84
Author: Lewis John McGibbney 
Date:   2016-04-26T18:49:05Z

JOSHUA-254 Update README with correct branding




> Update README with correct branding
> ---
>
> Key: JOSHUA-254
> URL: https://issues.apache.org/jira/browse/JOSHUA-254
> Project: Joshua
>  Issue Type: Task
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Trivial
> Fix For: 6.1
>
>
> This issue is trivial and involves updating the project README to direct all 
> links to the correct place as well as address branding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)