[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...
Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/58 Ah, right. Note that the test works from the command line: cd $JOSHUA/joshua-core cat src/test/resources/bn-en/hiero/input.bn | $JOSHUA/bin/joshua-decoder -c src/test/resources/bn-en/hiero/joshua.config > output diff output src/test/resources/bn-en/hiero/output.gold --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...
Github user fhieber commented on the issue: https://github.com/apache/incubator-joshua/pull/58 Depends whether we had any end-to-end tests like this already in 7. For the existing unit tests I already made the necessary changes to pass in 7. Quote from my commit for the featureFector refactoring: > This commit also updates all existing (and enabled) Unit tests which also pass. Existing regression tests do NOT work in this commit since many of the grammars are packed and would need to be re-packed. [Commit](https://github.com/apache/incubator-joshua/commit/20afddf85263f3def242f721728ac148ef143ad5) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua issue #58: Moved new unit tests (former regression tests) t...
Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/58 My guess is that grammar weights need reversing, but then I wonder why we haven't had to do that for other tests. I'll check this out later in the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
