Re: [jruby-dev] Recursive array eql

2009-08-07 Thread Charles Oliver Nutter
On Fri, Aug 7, 2009 at 4:38 PM, Martin Traverso wrote: > There's a related jira dealing with recursive hashes, too: > http://jira.codehaus.org/browse/JRUBY-3653 > > I've uploaded a patch that fixes eql and == for recursive hashes & arrays > (and combinations of them). Hey great! I'm in the process

Re: [jruby-dev] Recursive array eql

2009-08-07 Thread Thomas E Enebo
On Fri, Aug 7, 2009 at 3:31 PM, Charles Oliver Nutter wrote: > On Fri, Aug 7, 2009 at 4:18 PM, Ola Bini wrote: >> Yep, I want a large debate on this. I just didn't want to make the choice >> without the debate! > > Eeesh, big spec. > > Well I suppose that since ruby-core has acknowledged it and fix

Re: [jruby-dev] Recursive array eql

2009-08-07 Thread Martin Traverso
> Well I suppose that since ruby-core has acknowledged it and fixed it > in Ruby 1.9.1, we should just go ahead with a fix for it on our end. > We'll also want it to be fixed for our own 1.9 mode, after all. > > So...I vote fix. > There's a related jira dealing with recursive hashes, too: http://j

Re: [jruby-dev] Recursive array eql

2009-08-07 Thread Charles Oliver Nutter
On Fri, Aug 7, 2009 at 4:18 PM, Ola Bini wrote: > Yep, I want a large debate on this. I just didn't want to make the choice > without the debate! Eeesh, big spec. Well I suppose that since ruby-core has acknowledged it and fixed it in Ruby 1.9.1, we should just go ahead with a fix for it on our e

Re: [jruby-dev] Recursive array eql

2009-08-07 Thread Ola Bini
Charles Oliver Nutter wrote: On Fri, Aug 7, 2009 at 8:00 AM, Ola Bini wrote: You misunderstood my meaning. I explained this in the JIRA I closed for this. These specs are failing right now because they need to - to make them pass would be incompatible compared to 1.8.7. Since I didn't get an

Re: [jruby-dev] Recursive array eql

2009-08-07 Thread Charles Oliver Nutter
On Fri, Aug 7, 2009 at 8:00 AM, Ola Bini wrote: > You misunderstood my meaning. I explained this in the JIRA I closed for > this. > > These specs are failing right now because they need to - to make them pass > would be incompatible compared to 1.8.7. Since I didn't get any good > consensus on whet

Re: [jruby-dev] Recursive array eql

2009-08-07 Thread Ola Bini
Lars Westergren wrote: Hi, I thought Ola mentioned that he had fixed all the recursive array.eql? bugs, when I check out and update ruby-187 with "git pull", build, and then run the following command - ./bin/jruby spec/mspec/bin/mspec spec/ruby/core/array/ It still fails for me at exactly the s

[jruby-dev] Recursive array eql

2009-08-07 Thread Lars Westergren
Hi, I thought Ola mentioned that he had fixed all the recursive array.eql? bugs, when I check out and update ruby-187 with "git pull", build, and then run the following command - ./bin/jruby spec/mspec/bin/mspec spec/ruby/core/array/ It still fails for me at exactly the same places as before, for