Re: Review Request 24196: Patch for KAFKA-1567

On Aug. 13, 2014, 4:28 a.m., Jun Rao wrote: core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, lines 61-68 https://reviews.apache.org/r/24196/diff/5/?file=658862#file658862line61 Do we need to do the pattern matching here? Can we just remove based on

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 13, 2014, 3:26 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567_2014-08-13_08:25:57.patch Metric memory leaking after closing the clients

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095581#comment-14095581 ] Jiangjie Qin commented on KAFKA-1567: - Updated reviewboard

Review Request 24653: Patch for KAFKA-1577

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24653/ --- Review request for kafka. Bugs: KAFKA-1577

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095655#comment-14095655 ] Sriharsha Chintalapani commented on KAFKA-1577: --- Created reviewboard

[jira] [Updated] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1577: -- Attachment: KAFKA-1577.patch Exception in ConnectionQuotas while shutting

[jira] [Assigned] (KAFKA-1588) Offset response does not support two requests for the same topic/partition combo

[ https://issues.apache.org/jira/browse/KAFKA-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-1588: - Assignee: Sriharsha Chintalapani Offset response does not support two

Re: [Kafka MirrorMaker] Message with Custom Partition Logic

Bhavesh, I'd rephrase that a little bit. The new producer absolutely does allow the user to use any partitioning strategy. However, the mirror maker currently does not expose that functionality and uses only hash based partitioning. It will be helpful to understand the specific use case for

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/#review50462 ---

Re: Review Request 24196: Patch for KAFKA-1567

On Aug. 13, 2014, 4:51 p.m., Jun Rao wrote: core/src/main/scala/kafka/consumer/FetchRequestAndResponseStats.scala, lines 60-61 https://reviews.apache.org/r/24196/diff/6/?file=659346#file659346line60 Should we rename it to removeConsumerFetchRequestAndResponseStats()? Yes, that

Re: Review Request 24196: Patch for KAFKA-1567

On Aug. 13, 2014, 4:51 p.m., Jun Rao wrote: core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala, line 163 https://reviews.apache.org/r/24196/diff/6/?file=659348#file659348line163 This trace message is going to be a bit hard to understand. It's not clear what those two

Re: Review Request 24196: Patch for KAFKA-1567

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24196/ --- (Updated Aug. 13, 2014, 6:24 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1567: Attachment: KAFKA-1567_2014-08-13_11:24:29.patch Metric memory leaking after closing the clients

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095870#comment-14095870 ] Jiangjie Qin commented on KAFKA-1567: - Updated reviewboard

Re: Review Request 24411: Patch for KAFKA-1524

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24411/#review50095 --- Thank you for rebasing.

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095940#comment-14095940 ] Joel Koshy commented on KAFKA-1510: --- After some discussion with [~guozhang] and

Protocol specification: who handles partial messages?

From kafka spec of Fetch API: As an optimization the server is allowed to return a partial message at the end of the message set. Clients should handle this case. What does client mean? Client's application, or kafka's communication driver? Also, what partial message means? Does it mean, that

[jira] [Updated] (KAFKA-1588) Offset response does not support two requests for the same topic/partition combo

[ https://issues.apache.org/jira/browse/KAFKA-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1588: - Labels: newbie (was: ) Offset response does not support two requests for the same

Re: Review Request 24653: Patch for KAFKA-1577

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24653/#review50495 --- I saw a bunch of whitespaces diffs. Do you know why those were

[jira] [Resolved] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1567. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Jiangjie Qin Thanks for the patch. +1 and

[jira] [Commented] (KAFKA-1588) Offset response does not support two requests for the same topic/partition combo

[ https://issues.apache.org/jira/browse/KAFKA-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096038#comment-14096038 ] Sriharsha Chintalapani commented on KAFKA-1588: --- [~toddpalino]

[jira] [Commented] (KAFKA-1588) Offset response does not support two requests for the same topic/partition combo

[ https://issues.apache.org/jira/browse/KAFKA-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096083#comment-14096083 ] Todd Palino commented on KAFKA-1588: When working with this, I am sending my requests

Re: Protocol specification: who handles partial messages?

Client means client library. Basically, the bytes returned to the consumer may not include all the bytes of the last message. The consumer client library will figure out the boundary of the last complete message and use that info to initiate the next fetch request. Thanks, Jun On Wed, Aug 13,

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096159#comment-14096159 ] Joel Koshy commented on KAFKA-1567: --- Although this is in the old consumer and will be

Re: Protocol specification: who handles partial messages?

Ah, I see. This makes sense now. Just ignore the last trimmed message. I was afraid that I'd have to do some complex buffer continuation manipulations. Thanks a lot for your explanation! Vadim. On Wed, Aug 13, 2014 at 1:52 PM, Jun Rao jun...@gmail.com wrote: Client means client library.

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096233#comment-14096233 ] Jun Rao commented on KAFKA-1567: Joel, We thought about that. The issue is that (1) the

[jira] [Updated] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1507: - Assignee: Jay Kreps (was: Sriharsha Chintalapani) Using GetOffsetShell against non-existent

Re: Review Request 24621: Patch for KAFKA-1507

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24621/#review50500 ---

[jira] [Commented] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096283#comment-14096283 ] Neha Narkhede commented on KAFKA-1507: -- Reviewed most of the patch, didn't get a

Review Request 24676: WIP for KAFKA-1583

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676/ --- Review request for kafka. Bugs: KAFKA-1583

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1583: - Attachment: KAFKA-1583.patch Kafka API Refactoring -

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096287#comment-14096287 ] Guozhang Wang commented on KAFKA-1583: -- Created reviewboard

[jira] [Commented] (KAFKA-1496) Using batch message in sync producer only sends the first message if we use a Scala Stream as the argument

[ https://issues.apache.org/jira/browse/KAFKA-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096294#comment-14096294 ] Neha Narkhede commented on KAFKA-1496: -- Thanks for the patch, [~gliao]. Do you think

Build failed in Jenkins: Kafka-trunk #247

See https://builds.apache.org/job/Kafka-trunk/247/changes Changes: [junrao] kafka-1567; Metric memory leaking after closing the clients; patched by Jiangjie Qin; reviewed by Guozhang Wang and Jun Rao -- Started by an SCM change Started by an SCM change

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096310#comment-14096310 ] Sriharsha Chintalapani commented on KAFKA-1577: --- [~jjkoshy] Can you please

[jira] [Comment Edited] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096283#comment-14096283 ] Neha Narkhede edited comment on KAFKA-1507 at 8/14/14 12:53 AM:

[jira] [Created] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

Alexis Midon created KAFKA-1594: --- Summary: new metrics: ResponseQueueSize and BeingSentResponses Key: KAFKA-1594 URL: https://issues.apache.org/jira/browse/KAFKA-1594 Project: Kafka Issue

[jira] [Created] (KAFKA-1593) new metrics: ResponseQueueSize and BeingSentResponses

Alexis Midon created KAFKA-1593: --- Summary: new metrics: ResponseQueueSize and BeingSentResponses Key: KAFKA-1593 URL: https://issues.apache.org/jira/browse/KAFKA-1593 Project: Kafka Issue

[jira] [Updated] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

[ https://issues.apache.org/jira/browse/KAFKA-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1594: Description: This patch adds two metrics: h3. ResponseQueueSize As of 0.8.1, the sizes of the

[jira] [Updated] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

[ https://issues.apache.org/jira/browse/KAFKA-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1594: Description: This patch adds two metrics: h3. ResponseQueueSize As of 0.8.1, the sizes of the

[jira] [Updated] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

[ https://issues.apache.org/jira/browse/KAFKA-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1594: Attachment: KAFKA-1594_ResponseQueueSize.patch KAFKA-1594_BeingSentResponses.patch

[jira] [Updated] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

[ https://issues.apache.org/jira/browse/KAFKA-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1594: Description: This patch adds two metrics: h3. ResponseQueueSize As of 0.8.1, the sizes of the

[jira] [Updated] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

[ https://issues.apache.org/jira/browse/KAFKA-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Midon updated KAFKA-1594: Description: This patch adds two metrics: h3. ResponseQueueSize As of 0.8.1, the sizes of the

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096408#comment-14096408 ] Joel Koshy commented on KAFKA-1577: --- Unfortunately I don't have reliable steps to

[jira] [Created] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

Jagbir created KAFKA-1595: - Summary: Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount Key: KAFKA-1595 URL: https://issues.apache.org/jira/browse/KAFKA-1595 Project: Kafka

[jira] [Updated] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1595: - Labels: newbie (was: ) Remove deprecated and slower scala JSON parser from

[jira] [Updated] (KAFKA-1576) Make deleteTopic a bit more user friendly

[ https://issues.apache.org/jira/browse/KAFKA-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1576: - Labels: newbie (was: ) Make deleteTopic a bit more user friendly

[jira] [Updated] (KAFKA-1439) transient unit test failure in testDeleteTopicDuringAddPartition

[ https://issues.apache.org/jira/browse/KAFKA-1439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1439: - Fix Version/s: 0.8.2 transient unit test failure in testDeleteTopicDuringAddPartition

[jira] [Updated] (KAFKA-1177) DeleteTopics gives Successful message even if the specified Topic is not present

[ https://issues.apache.org/jira/browse/KAFKA-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1177: - Labels: newbie (was: ) DeleteTopics gives Successful message even if the specified Topic is

[jira] [Updated] (KAFKA-1558) AdminUtils.deleteTopic does not work

[ https://issues.apache.org/jira/browse/KAFKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1558: - Fix Version/s: 0.8.2 AdminUtils.deleteTopic does not work

[jira] [Updated] (KAFKA-1576) Make deleteTopic a bit more user friendly

[ https://issues.apache.org/jira/browse/KAFKA-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1576: - Fix Version/s: 0.8.2 Make deleteTopic a bit more user friendly

[jira] [Closed] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

[ https://issues.apache.org/jira/browse/KAFKA-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1594. new metrics: ResponseQueueSize and BeingSentResponses

[jira] [Resolved] (KAFKA-1594) new metrics: ResponseQueueSize and BeingSentResponses

[ https://issues.apache.org/jira/browse/KAFKA-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1594. -- Resolution: Duplicate Duplicate of KAFKA-1593 new metrics: ResponseQueueSize and

[jira] [Updated] (KAFKA-1590) Binarize trace level request logging along with debug level text logging

[ https://issues.apache.org/jira/browse/KAFKA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1590: - Labels: newbie (was: ) Binarize trace level request logging along with debug level text

[jira] [Updated] (KAFKA-1592) Some INFO level logging needs to be DEBUG

[ https://issues.apache.org/jira/browse/KAFKA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1592: - Labels: newbie (was: ) Some INFO level logging needs to be DEBUG

[jira] [Updated] (KAFKA-1591) Clean-up Unnecessary stack trace in error/warn logs

[ https://issues.apache.org/jira/browse/KAFKA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1591: - Labels: newbie (was: ) Clean-up Unnecessary stack trace in error/warn logs