---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30547/#review70911
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 3, 2015, 5:17 p.m., Jay
See https://builds.apache.org/job/Kafka-trunk/387/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27391/#review70836
---
Aditya Auradkar created KAFKA-1917:
--
Summary: Add unit tests for BrokerTopicMetrics set through
ReplicaManager
Key: KAFKA-1917
URL: https://issues.apache.org/jira/browse/KAFKA-1917
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304596#comment-14304596
]
Honghai Chen commented on KAFKA-1646:
-
Jay Kreps Jun Rao Neha NarkhedeThe Kafka
I just committed the checkstyle patch (KAFKA-1915). This will do the
checkstyle evaluation when you run the unit tests and error on style
inconsistencies. It can be hard to say which checks are more trouble than
they are worth or are two pedantic. Let's give this a try and see if it is
annoying or
How come we added this? Is it better than the linked list in java and
scala? Also it was added with only one test which is actually put inside
UtilsTest.scala which is meant to house tests for Utils.scala.
-Jay
After checkstyle is tuned, maybe we can add that as part of pre-commit
testing, KAFKA-1856.
On Tue, Feb 3, 2015 at 8:59 PM, Jay Kreps jay.kr...@gmail.com wrote:
I just committed the checkstyle patch (KAFKA-1915). This will do the
checkstyle evaluation when you run the unit tests and error on
I am also +1 on Neha's suggestion that At some point, if we find ourselves
fiddling too much with ZkClient, it wouldn't hurt to write our own little
zookeeper client wrapper. since we have accumulated a bunch of issues with
zkClient which takes long time be resolved if ever, so we ended up have
[
https://issues.apache.org/jira/browse/KAFKA-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304701#comment-14304701
]
Guozhang Wang commented on KAFKA-620:
-
Is this a duplicate of KAFKA-1082?
[
https://issues.apache.org/jira/browse/KAFKA-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira resolved KAFKA-1916.
-
Resolution: Duplicate
Missed the dup.
Kafka unit tests need to choose random port
[
https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Honghai Chen updated KAFKA-1646:
Comment: was deleted
(was: Jay Kreps Jun Rao Neha NarkhedeThe Kafka performance issue on
Any reason not to go with apache curator http://curator.apache.org/ .
-Harsha
On Tue, Feb 3, 2015, at 09:55 PM, Guozhang Wang wrote:
I am also +1 on Neha's suggestion that At some point, if we find
ourselves
fiddling too much with ZkClient, it wouldn't hurt to write our own little
zookeeper
I think we should consider to moving to apache curator (KAFKA-873).
Curator is now more mature and a apache top-level project.
On Wed, Feb 4, 2015 at 11:29 AM, Harsha ka...@harsha.io wrote:
Any reason not to go with apache curator http://curator.apache.org/ .
-Harsha
On Tue, Feb 3, 2015, at
Gwen Shapira created KAFKA-1916:
---
Summary: Kafka unit tests need to choose random port
Key: KAFKA-1916
URL: https://issues.apache.org/jira/browse/KAFKA-1916
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304690#comment-14304690
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] I have tried the
[
https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304697#comment-14304697
]
Guozhang Wang commented on KAFKA-1737:
--
Sorry for getting late on this [~vivekpm].
+1 on using curator.
On Tue, Feb 3, 2015 at 10:09 PM, Manikumar Reddy ku...@nmsworks.co.in
wrote:
I think we should consider to moving to apache curator (KAFKA-873).
Curator is now more mature and a apache top-level project.
On Wed, Feb 4, 2015 at 11:29 AM, Harsha ka...@harsha.io wrote:
On Feb. 3, 2015, 7:44 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java,
line 45
https://reviews.apache.org/r/30547/diff/1/?file=845037#file845037line45
Wondering why LOCK needs to be all-capitalized while Log above does not
need
[
https://issues.apache.org/jira/browse/KAFKA-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304514#comment-14304514
]
Joel Koshy commented on KAFKA-1916:
---
Dup of KAFKA-1501 ?
Kafka unit tests need to
Yes, that's the plan :)
-Jaikiran
On Wednesday 04 February 2015 12:33 AM, Gwen Shapira wrote:
So I think the current plan is:
1. Add timeout in zkclient
2. Ask zkclient to release new version (we need it for few other things too)
3. Rebase on new zkclient
4. Fix this jira and the few others
Now may be a good time.
We could verify if Curator has fixed the known issues we have seen so far,
an incomplete list would be:
KAFKA-1082 https://issues.apache.org/jira/browse/KAFKA-1082
KAFKA-1155 https://issues.apache.org/jira/browse/KAFKA-1155
KAFKA-1907
We added this because in redesigned mirror maker we need a raw linked list
so we can removed an acked offset from a linked list in O(1). Java and
Scala linked list won¹t work in that case. It was initially put in side
mirror maker as a private class, but later on we also want to have unit
test for
[
https://issues.apache.org/jira/browse/KAFKA-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Stein updated KAFKA-1904:
-
Priority: Blocker (was: Major)
run sanity failed test
--
Key:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30126/#review70747
---
core/src/main/scala/kafka/server/KafkaConfig.scala
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303446#comment-14303446
]
Jun Rao commented on KAFKA-1729:
[~jjkoshy], for 0.8.2, we can probably just update the
I updated the RB changing some of the HIGH to MEDIUM and LOW.
There might be other or different opinions and they may change over time so
I don't really see h/m/l as a blocker to the patch going in.
It would be great to take all the rb feedback from today and then tomorrow
rebase and include
[
https://issues.apache.org/jira/browse/KAFKA-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1915:
-
Attachment: KAFKA-1915_2015-02-03_09:17:34.patch
Integrate checkstyle for java code
On Feb. 3, 2015, 7:20 a.m., Joel Koshy wrote:
build.gradle, line 387
https://reviews.apache.org/r/30547/diff/1/?file=845008#file845008line387
Is the consequence of violations this going to be a warning or an error
or a report? Either way is there a way to suppress it via an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30547/
---
(Updated Feb. 3, 2015, 5:17 p.m.)
Review request for kafka.
Bugs: KAFKA-1915
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30126/#review70748
---
core/src/main/scala/kafka/server/KafkaConfig.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28769/
---
(Updated Feb. 3, 2015, 6:45 p.m.)
Review request for kafka.
Bugs: KAFKA-1809
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1809:
Attachment: KAFKA-1809_2015-02-03_10:45:31.patch
Refactor brokers to allow listening on multiple
[
https://issues.apache.org/jira/browse/KAFKA-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303746#comment-14303746
]
Aditya A Auradkar commented on KAFKA-1914:
--
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30570/
---
(Updated Feb. 3, 2015, 6:50 p.m.)
Review request for kafka.
Bugs: KAFKA-1914
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303699#comment-14303699
]
Gwen Shapira commented on KAFKA-1856:
-
Once KAFKA-1915 is in, will be nice to include
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1809:
Attachment: KAFKA-1809_2015-02-03_10:46:42.patch
Refactor brokers to allow listening on multiple
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28769/
---
(Updated Feb. 3, 2015, 6:46 p.m.)
Review request for kafka.
Bugs: KAFKA-1809
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303740#comment-14303740
]
Gwen Shapira commented on KAFKA-1809:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303708#comment-14303708
]
Gwen Shapira commented on KAFKA-1904:
-
Looking at the logs:
{code}
2015-01-28
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303738#comment-14303738
]
Gwen Shapira commented on KAFKA-1809:
-
Updated reviewboard
So I think the current plan is:
1. Add timeout in zkclient
2. Ask zkclient to release new version (we need it for few other things too)
3. Rebase on new zkclient
4. Fix this jira and the few others than were waiting for the new zkclient
Does that make sense?
Gwen
On Mon, Feb 2, 2015 at 8:33 PM,
When's the party?
:)
On Mon, Feb 2, 2015 at 8:13 PM, Jay Kreps jay.kr...@gmail.com wrote:
Yay!
-Jay
On Mon, Feb 2, 2015 at 2:23 PM, Neha Narkhede n...@confluent.io wrote:
Great! Thanks Jun for helping with the release and everyone involved for
your contributions.
On Mon, Feb 2, 2015 at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29301/#review70790
---
Looks good overall. Some comments below, which did not cover the
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1809:
Attachment: KAFKA-1809_2015-02-03_10:52:36.patch
Refactor brokers to allow listening on multiple
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303750#comment-14303750
]
Gwen Shapira commented on KAFKA-1809:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28769/
---
(Updated Feb. 3, 2015, 6:52 p.m.)
Review request for kafka.
Bugs: KAFKA-1809
Lithium Technologies would love to host you guys for a release party in SF
if you guys want.
:)
On Tue, Feb 3, 2015 at 11:04 AM, Gwen Shapira gshap...@cloudera.com wrote:
When's the party?
:)
On Mon, Feb 2, 2015 at 8:13 PM, Jay Kreps jay.kr...@gmail.com wrote:
Yay!
-Jay
On Mon,
It'd be great to have it on trunk.
As I mentioned under jira ticket (KAFKA-1845) current implementation lacks
correct Importance settings.
I'd be grateful if somebody could help me with it (a simple mapping between
config setting and importance or comments right in the review board would
suffice).
On Jan. 21, 2015, 10:55 p.m., Eric Olander wrote:
core/src/main/scala/kafka/server/KafkaConfig.scala, line 130
https://reviews.apache.org/r/30126/diff/1/?file=828512#file828512line130
It seems that by convention there is a ...Prop and a ...Doc constant,
but nothing enforces that.
50 matches
Mail list logo
