[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513061#comment-14513061
]
Jay Kreps commented on KAFKA-2132:
--
Hey [~singhashish], I think I may have caused
[
https://issues.apache.org/jira/browse/KAFKA-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513111#comment-14513111
]
Neha Narkhede commented on KAFKA-1748:
--
[~ewencp] With the ducktape work, I guess we
[
https://issues.apache.org/jira/browse/KAFKA-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2034:
-
Resolution: Fixed
Reviewer: Ewen Cheslack-Postava
Assignee: Ismael Juma
[
https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513096#comment-14513096
]
Neha Narkhede commented on KAFKA-1351:
--
Not sure that this is still a concern. I was
[
https://issues.apache.org/jira/browse/KAFKA-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede resolved KAFKA-1293.
--
Resolution: Fixed
Closing based on [~mwarhaftig]'s latest comment.
Mirror maker housecleaning
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513110#comment-14513110
]
Joe Stein commented on KAFKA-2132:
--
+1 - make a stand-alone module called log4j/ that has
[
https://issues.apache.org/jira/browse/KAFKA-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede resolved KAFKA-1277.
--
Resolution: Incomplete
Closing due to inactivity.
Keep the summery/description when updating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33342/#review81617
---
Ship it!
See https://builds.apache.org/job/Kafka-trunk/473/changes
Changes:
[neha.narkhede] KAFKA-2034 sourceCompatibility not set in Kafka build.gradle;
reviewed by Neha Narkhede and Ewen Cheslack-Postava
[nehanarkhede] KAFKA-2140 Improve code readability; reviewed by Neha Narkhede
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513094#comment-14513094
]
Neha Narkhede commented on KAFKA-2140:
--
+1
Improve code readability
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513128#comment-14513128
]
Ismael Juma commented on KAFKA-2140:
Thank you for merging. :)
Improve code
[
https://issues.apache.org/jira/browse/KAFKA-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513312#comment-14513312
]
Neha Narkhede commented on KAFKA-1737:
--
[~vivekpm] Makes sense. Would you like to
[
https://issues.apache.org/jira/browse/KAFKA-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2080:
-
Component/s: tools
quick cleanup of producer performance scripts
[
https://issues.apache.org/jira/browse/KAFKA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2041:
-
Status: Patch Available (was: Open)
Add ability to specify a KeyClass for KafkaLog4jAppender
[
https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2003:
-
Component/s: system tests
Add upgrade tests
-
Key: KAFKA-2003
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32937/
---
(Updated April 27, 2015, 12:26 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede resolved KAFKA-2108.
--
Resolution: Incomplete
Closing due to inactivity. [~slimunholyone], [~becket_qin] feel free to
[
https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513318#comment-14513318
]
Neha Narkhede commented on KAFKA-2101:
--
[~timbrooks] To clarify your question - we
[
https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2100:
-
Component/s: clients
Client Error doesn't preserve or display original server error code when it
[
https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513324#comment-14513324
]
Neha Narkhede commented on KAFKA-1621:
--
[~rekhajoshm] Sorry for the delay, reviewed
[
https://issues.apache.org/jira/browse/KAFKA-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1904:
-
Component/s: system tests
run sanity failed test
--
Key:
[
https://issues.apache.org/jira/browse/KAFKA-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2080:
-
Labels: newbie (was: )
quick cleanup of producer performance scripts
[
https://issues.apache.org/jira/browse/KAFKA-1858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1858:
-
Reviewer: Jun Rao
Status: Patch Available (was: Open)
Make ServerShutdownTest a bit less
[
https://issues.apache.org/jira/browse/KAFKA-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2014:
-
Component/s: system tests
Chaos Monkey / Failure Inducer for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513346#comment-14513346
]
Tim Brooks commented on KAFKA-2102:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Brooks updated KAFKA-2102:
--
Attachment: KAFKA-2102_2015-04-26_17:25:21.patch
Remove unnecessary synchronization when managing
[
https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513316#comment-14513316
]
Neha Narkhede commented on KAFKA-2103:
--
[~becket_qin] Is this still an issue? If so,
Andrii,
Another thing. We decided not to add the lag info in TMR. To be consistent,
we probably also want to remove ISR from TMR since only the leader knows
it. We can punt on adding any new request from getting ISR. ISR is mostly
useful for monitoring. Currently, one can determine if a replica
[
https://issues.apache.org/jira/browse/KAFKA-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2100:
-
Labels: newbie (was: )
Client Error doesn't preserve or display original server error code when
[
https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2118:
---
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
Thanks for
On Feb. 7, 2015, 4:22 p.m., Neha Narkhede wrote:
core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala, line 295
https://reviews.apache.org/r/30196/diff/2/?file=844610#file844610line295
Why do you need the sleep here? We try to avoid blindly sleeping in
Kafka tests
[
https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1758:
-
Reviewer: Neha Narkhede
corrupt recovery file prevents startup
[
https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513186#comment-14513186
]
Neha Narkhede commented on KAFKA-1758:
--
[~omkreddy] I took a quick look and left a
[
https://issues.apache.org/jira/browse/KAFKA-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2150:
-
Reviewer: Guozhang Wang
[~guozhang] This was introduced in KAFKA-1461, so assigning to you for
Andrii,
Thanks for the update.
For your second point, I agree that if a single AlterTopicRequest can make
multiple changes, there is no need to support the same topic included more
than once in the request.
Now about the semantics in your first question. I was thinking that we can
do the
See https://builds.apache.org/job/Kafka-trunk/475/changes
Changes:
[nehanarkhede] KAFKA-2140 follow up, checking in newly renamed file
ConsumerRebalanceFailedException
[nehanarkhede] KAFKA-2128 kafka.Kafka should return non-zero exit code when
caught exception; reviewed by Neha
A few more minor comments.
100. To make it clear, perhaps we should rename the resource group to
consumer-group. We can probably make the same change in CLI as well so that
it's not confused with user group.
101. Currently, create is only at the cluster level. Should it also be at
topic level?
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513265#comment-14513265
]
Neha Narkhede commented on KAFKA-1367:
--
[~jkreps] Yup, issue still exists and the
See https://builds.apache.org/job/Kafka-trunk/476/changes
Jun,
I like your approach to AlterTopicReques semantics! Sounds like
we linearize all request fields to ReplicaAssignment - I will definitely
try this out to ensure there are no other pitfalls.
With regards to multiple instructions in one batch per topic. For me
this sounds reasonable too. We
[
https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-1054:
---
Attachment: KAFKA-1054-20150426-V1.patch
This is a rebased patch with an additional commit for fixing
[
https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-1054:
---
Attachment: KAFKA-1054-20150426-V2.patch
This is the same as `KAFKA-1054-20150426-V1.patch
[
https://issues.apache.org/jira/browse/KAFKA-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513151#comment-14513151
]
Neha Narkhede commented on KAFKA-2027:
--
Can you describe the end user behavior that
Github user ijuma closed the pull request at:
https://github.com/apache/kafka/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513203#comment-14513203
]
Ismael Juma commented on KAFKA-2140:
Yes, I'd be happy to help with that. It would
[
https://issues.apache.org/jira/browse/KAFKA-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2105:
-
Status: Patch Available (was: Open)
NullPointerException in client on MetadataRequest
See https://builds.apache.org/job/KafkaPreCommit/87/changes
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513129#comment-14513129
]
Ashish K Singh commented on KAFKA-2132:
---
Sounds good to me. Will have a patch up for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30801/#review81622
---
core/src/main/scala/kafka/log/LogManager.scala
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2140:
---
Attachment: KAFKA-2140-fix.patch
[~nehanarkhede], I attached a patch that restores the file that was
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33421/#review81634
---
Ship it!
Ship It!
- Neha Narkhede
On April 22, 2015, 12:10
See https://builds.apache.org/job/Kafka-trunk/474/changes
Changes:
[nehanarkhede] KAFKA-2122 Remove controller.message.queue.size Config; reviewed
by Neha Narkhede, Jun Rao, Onur
--
[...truncated 451 lines...]
org.apache.kafka.common.record.RecordTest
[
https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513138#comment-14513138
]
Neha Narkhede commented on KAFKA-2029:
--
[~jkreps] That's somewhat right. When the
[
https://issues.apache.org/jira/browse/KAFKA-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2029:
-
Reviewer: Neha Narkhede
Improving controlled shutdown for rolling updates
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513187#comment-14513187
]
Ismael Juma commented on KAFKA-2140:
It looks like something weird happened in the
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513202#comment-14513202
]
Neha Narkhede commented on KAFKA-2140:
--
Fixed and pushed.
Improve code readability
[
https://issues.apache.org/jira/browse/KAFKA-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513159#comment-14513159
]
Neha Narkhede commented on KAFKA-1887:
--
[~sriharsha] The patch is waiting for a
[
https://issues.apache.org/jira/browse/KAFKA-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1940:
-
Status: Patch Available (was: Open)
Initial checkout and build failing
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513374#comment-14513374
]
Ewen Cheslack-Postava commented on KAFKA-2140:
--
Not sure if it's changed at
See https://builds.apache.org/job/Kafka-trunk/477/changes
Changes:
[junrao] kafka-2118; Cleaner cannot clean after shutdown during
replaceSegments; patched by Rajini Sivaram; reviewed by Jun Rao
--
[...truncated 667 lines...]
kafka.log.LogTest
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513387#comment-14513387
]
Ashish K Singh commented on KAFKA-1367:
---
[~nehanarkhede] If no one has already
[
https://issues.apache.org/jira/browse/KAFKA-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513408#comment-14513408
]
Sasaki Toru commented on KAFKA-2128:
Thanks [~gwenshap] and [~aauradkar] for reviews.
[
https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513420#comment-14513420
]
Jun Rao commented on KAFKA-1595:
[~ijuma], we discussed the json library in the context of
[
https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513503#comment-14513503
]
Dong Lin commented on KAFKA-1936:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-1936:
Attachment: KAFKA-1936_2015-04-26_21:20:28.patch
Track offset commit requests separately from produce
[
https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513558#comment-14513558
]
Dong Lin commented on KAFKA-2103:
-
Of course. Let me work on this ticket.
[
https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513571#comment-14513571
]
Ismael Juma commented on KAFKA-2140:
Thanks Ewen, useful reference. We already receive
[
https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513540#comment-14513540
]
Gwen Shapira commented on KAFKA-2139:
-
Thanks.
Good point about separate port not
[
https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2103:
---
Assignee: Dong Lin
kafka.producer.AsyncProducerTest failure.
On April 27, 2015, 4 a.m., Jiangjie Qin wrote:
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala, line 107
https://reviews.apache.org/r/33557/diff/1/?file=941740#file941740line107
Typo, larger.
Thanks for noticing the bytes-out-rate and the typo. I missed that metric.
[
https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-1936:
Attachment: KAFKA-1936_2015-04-26_21:26:34.patch
Track offset commit requests separately from produce
[
https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513534#comment-14513534
]
Jiangjie Qin commented on KAFKA-2139:
-
Hey Gwen, thanks for this really quick review!
[
https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-2103:
Issue Type: Sub-task (was: Bug)
Parent: KAFKA-2054
kafka.producer.AsyncProducerTest
[
https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513511#comment-14513511
]
Gwen Shapira commented on KAFKA-2139:
-
Thanks for the nice doc. Two questions /
[
https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513499#comment-14513499
]
Jiangjie Qin commented on KAFKA-2103:
-
[~nehanarkhede] Yes, it is still failing. I'll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33557/
---
(Updated April 27, 2015, 4:20 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513564#comment-14513564
]
Ismael Juma commented on KAFKA-1595:
Ok, understood about the clients. I guess this
[
https://issues.apache.org/jira/browse/KAFKA-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513448#comment-14513448
]
Steven Zhen Wu commented on KAFKA-2151:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Zhen Wu updated KAFKA-2151:
--
Attachment: KAFKA-2151.patch
make MockMetricsReporter a little more generic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33574/
---
Review request for kafka.
Bugs: KAFKA-2151
[
https://issues.apache.org/jira/browse/KAFKA-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Zhen Wu updated KAFKA-2151:
--
Status: Patch Available (was: Open)
make MockMetricsReporter a little more generic
[
https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513453#comment-14513453
]
Jiangjie Qin commented on KAFKA-2139:
-
Hi
Hi Parth
The design looks good, a few minor comments below. Since I just started looking
into the discussion and many previous discussions I may missed, I'm sorry if
these comments had be discussed.
1. About SimpleAclAuthorizer (SimpleAuthorizer):
a. As my understanding, I think there should
Lior Gonnen created KAFKA-2152:
--
Summary: Console producer fails to start when server running with
broker.id != 0
Key: KAFKA-2152
URL: https://issues.apache.org/jira/browse/KAFKA-2152
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14513482#comment-14513482
]
Gwen Shapira commented on KAFKA-2152:
-
When you created the topic at first, the
[
https://issues.apache.org/jira/browse/KAFKA-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira resolved KAFKA-2152.
-
Resolution: Not A Problem
Console producer fails to start when server running with broker.id !=
86 matches
Mail list logo
