[jira] [Commented] (KAFKA-2140) Improve code readability

2015-04-27 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516542#comment-14516542 ] Ewen Cheslack-Postava commented on KAFKA-2140: -- Ok, so it sounds like we migh

[jira] [Commented] (KAFKA-1451) Broker stuck due to leader election race

2015-04-27 Thread Marcus Aidley (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516532#comment-14516532 ] Marcus Aidley commented on KAFKA-1451: -- I have also hit this issue on version 0.8.2.0

[jira] [Commented] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516450#comment-14516450 ] ASF GitHub Bot commented on KAFKA-1054: --- Github user ijuma closed the pull request a

[GitHub] kafka pull request: KAFKA-1054; Eliminate Scala Compilation Warnin...

2015-04-27 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

Re: [VOTE] KIP-11- Authorization design for kafka security

2015-04-27 Thread Gwen Shapira
While I see the advantage of being able to say something like: "deny user X from hosts h1...h200" also "allow user X from host h189", there are two issues here: 1. Complex rule systems can be difficult to reason about and therefore end up being less secure. The rule "Deny always wins" is very easy

RE: [VOTE] KIP-11- Authorization design for kafka security

2015-04-27 Thread Sun, Dapeng
Attach the image. https://raw.githubusercontent.com/sundapeng/attachment/master/kafka-acl1.png Regards Dapeng From: Sun, Dapeng [mailto:dapeng@intel.com] Sent: Tuesday, April 28, 2015 11:44 AM To: dev@kafka.apache.org Subject: RE: [VOTE] KIP-11- Authorization design for kafka security Thank

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516298#comment-14516298 ] Neha Narkhede commented on KAFKA-1367: -- [~jjkoshy] That would work too but looks like

Jenkins build is back to normal : KafkaPreCommit #92

2015-04-27 Thread Apache Jenkins Server
See

[jira] [Assigned] (KAFKA-2153) kafka-patch-review tool uploads a patch even if it is empty

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh reassigned KAFKA-2153: - Assignee: Ashish K Singh > kafka-patch-review tool uploads a patch even if it is empty >

[jira] [Updated] (KAFKA-2153) kafka-patch-review tool uploads a patch even if it is empty

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2153: -- Description: kafka-patch-review tool is great and a big help. However, sometimes one forgets to

[jira] [Updated] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-27 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1054: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks. Merged the github PR.

Jenkins build is back to normal : Kafka-trunk #479

2015-04-27 Thread Apache Jenkins Server
See

[jira] [Commented] (KAFKA-2101) Metric metadata-age is reset on a failed update

2015-04-27 Thread Tim Brooks (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516263#comment-14516263 ] Tim Brooks commented on KAFKA-2101: --- Okay. Well I made a number of changes related to Me

[jira] [Created] (KAFKA-2153) kafka-patch-review tool uploads a patch even if it is empty

2015-04-27 Thread Ashish K Singh (JIRA)
Ashish K Singh created KAFKA-2153: - Summary: kafka-patch-review tool uploads a patch even if it is empty Key: KAFKA-2153 URL: https://issues.apache.org/jira/browse/KAFKA-2153 Project: Kafka

Re: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-27 Thread Jay Kreps
Hey Joel/Aditya, Yeah, that's what I meant. I agree it is easy to do. Just wanted to make sure folks had thought about that case. -Jay On Fri, Apr 24, 2015 at 5:34 PM, Joel Koshy wrote: > I think Jay meant a catch-all request/sec limit on all requests > per-client. That makes sense. > > On Fri

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Attachment: (was: KAFKA-2132_2015-04-27_19:58:49.patch) > Move Log4J appender to clients mod

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Attachment: KAFKA-2132_2015-04-27_19:59:46.patch > Move Log4J appender to clients module > -

[jira] [Commented] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516245#comment-14516245 ] Ashish K Singh commented on KAFKA-2132: --- Updated reviewboard https://reviews.apache.

[jira] [Issue Comment Deleted] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Comment: was deleted (was: Updated reviewboard https://reviews.apache.org/r/33614/ against bran

Re: Review Request 33614: Patch for KAFKA-2132

2015-04-27 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated April 28, 2015, 3 a.m.) Review request for kafka. Bugs: KAFKA-2132

[jira] [Commented] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516243#comment-14516243 ] Ashish K Singh commented on KAFKA-2132: --- Updated reviewboard https://reviews.apache.

Re: Review Request 33614: Patch for KAFKA-2132

2015-04-27 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated April 28, 2015, 2:58 a.m.) Review request for kafka. Bugs: KAFKA-213

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Attachment: KAFKA-2132_2015-04-27_19:58:49.patch > Move Log4J appender to clients module > -

Build failed in Jenkins: KafkaPreCommit #91

2015-04-27 Thread Apache Jenkins Server
See Changes: [junrao] kafka-1940; Initial checkout and build failing; patched by Martin Lemanski; reviewed by Jun Rao -- [...truncated 2171 lines...] kafka.log.LogManagerTest > testCleanupExpiredSe

[jira] [Commented] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516232#comment-14516232 ] Ashish K Singh commented on KAFKA-2132: --- Created reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Status: Patch Available (was: Open) > Move Log4J appender to clients module > -

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Attachment: KAFKA-2132.patch > Move Log4J appender to clients module > -

Review Request 33614: Patch for KAFKA-2132

2015-04-27 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- Review request for kafka. Bugs: KAFKA-2132 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1940) Initial checkout and build failing

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1940: --- Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Martin Lemanski Status: Resolved (

[jira] [Updated] (KAFKA-2132) Move Log4J appender to clients module

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Reviewer: Gwen Shapira > Move Log4J appender to clients module > ---

Build failed in Jenkins: KafkaPreCommit #90

2015-04-27 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-2121 Follow-up: minor bug fix as pointed out by Sean Lydon -- [...truncated 1294 lines...] kafka.api.ProducerFailureHandlingTest > testInvalidPartition PASSED kafka.ap

Build failed in Jenkins: Kafka-trunk #478

2015-04-27 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-2121 Follow-up: minor bug fix as pointed out by Sean Lydon -- [...truncated 1245 lines...] kafka.log.LogSegmentTest > testTruncate PASSED kafka.log.LogSegmentTest > tes

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-04-27 Thread Thomas Omans (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516102#comment-14516102 ] Thomas Omans commented on KAFKA-1387: - I am seeing similar behavior in my consumer, us

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-27 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516097#comment-14516097 ] Jiangjie Qin commented on KAFKA-2139: - [~jjkoshy] that is a good point. There are tons

Re: [DISCUSS] New consumer offset commit API

2015-04-27 Thread Guozhang Wang
Thanks Ewen, 1. I agree with you as for the pros of Future; my argument for pure Callback, as I mentioned, is that it sounds to me unlikely users would usually want to explicitly set timeout. That said, if people think this scenario is actually common like in graceful shutdown, then I am OK with F

[DISCUSSION] java.io.Closeable in KAFKA-2121

2015-04-27 Thread Guozhang Wang
Folks, In a recent commit I made regarding KAFKA-2121, there is an omitted API change which makes Serializer / Deserializer extending from Closeable, whose close() call could throw IOException by declaration. Hence now some scenario like: - Serializer keySerializer = ... Seri

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-27 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516064#comment-14516064 ] Ewen Cheslack-Postava commented on KAFKA-2121: -- [~stevenz3wu] Interesting. Lo

[jira] [Commented] (KAFKA-2151) make MockMetricsReporter a little more generic

2015-04-27 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516063#comment-14516063 ] Steven Zhen Wu commented on KAFKA-2151: --- [~guozhang] can you review and merge this t

RE: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-27 Thread Aditya Auradkar
So, are we all in agreement on this approach? If so, I can start working on a patch for it. Also, there are a couple of patches for quotas in need of review. I think we need a couple of reviewers, so I've added Jun as a reviewer in addition to Joel. https://reviews.apache.org/r/33049/ https:/

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516054#comment-14516054 ] Guozhang Wang commented on KAFKA-2121: -- Thanks [~slydon] for pointing out the bug, wi

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-27 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516034#comment-14516034 ] Jiangjie Qin commented on KAFKA-2139: - [~junrao], I'm actually very interested in this

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-27 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516028#comment-14516028 ] Steven Zhen Wu commented on KAFKA-2121: --- [~ewencp] [~guozhang] I would like to hear

Re: Review Request 33088: add heartbeat to coordinator

2015-04-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33088/#review81743 --- clients/src/main/java/org/apache/kafka/common/protocol/Errors.java

[jira] [Updated] (KAFKA-1940) Initial checkout and build failing

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1940: --- Reviewer: Jun Rao > Initial checkout and build failing > -- > >

[jira] [Updated] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1660: --- Reviewer: Jay Kreps > Ability to call close() with a timeout on the Java Kafka Producer. > --

[jira] [Updated] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1835: --- Reviewer: Jun Rao > Kafka new producer needs options to make blocking behavior explicit >

[jira] [Updated] (KAFKA-2142) Follow-up patch for KAFKA-2138 Refactor the drain message logic in new producer

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2142: --- Reviewer: Jun Rao > Follow-up patch for KAFKA-2138 Refactor the drain message logic in new > producer > -

[jira] [Updated] (KAFKA-2105) NullPointerException in client on MetadataRequest

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2105: --- Reviewer: Jun Rao > NullPointerException in client on MetadataRequest > --

[jira] [Updated] (KAFKA-2041) Add ability to specify a KeyClass for KafkaLog4jAppender

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2041: --- Reviewer: Jun Rao > Add ability to specify a KeyClass for KafkaLog4jAppender > ---

[jira] [Updated] (KAFKA-2102) Remove unnecessary synchronization when managing metadata

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2102: --- Reviewer: Jun Rao > Remove unnecessary synchronization when managing metadata > --

[jira] [Updated] (KAFKA-1936) Track offset commit requests separately from produce requests

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1936: --- Reviewer: Joel Koshy > Track offset commit requests separately from produce requests > ---

[jira] [Assigned] (KAFKA-1508) Scripts Break When Path Has Spaces

2015-04-27 Thread Rekha Joshi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned KAFKA-1508: -- Assignee: Rekha Joshi > Scripts Break When Path Has Spaces > --

[jira] [Updated] (KAFKA-2114) Unable to change min.insync.replicas default

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2114: --- Fix Version/s: (was: 0.8.2.1) 0.8.3 > Unable to change min.insync.replicas default > --

[jira] [Updated] (KAFKA-2128) kafka.Kafka should return non-zero exit code when caught exception.

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2128: --- Resolution: Fixed Assignee: Sasaki Toru Status: Resolved (was: Patch Available) > kafka.Kafka s

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515818#comment-14515818 ] Joel Koshy commented on KAFKA-2139: --- [~becket_qin] thanks for the write-up. With this (s

[jira] [Updated] (KAFKA-1054) Eliminate Compilation Warnings for 0.8 Final Release

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1054: --- Assignee: Ismael Juma Status: Patch Available (was: Open) > Eliminate Compilation Warnings for 0.8 Fina

Re: Request to be added as Contributor

2015-04-27 Thread Guozhang Wang
Neelesh, I have just added you to the Kafka project. Cheers, Guozhang On Mon, Apr 27, 2015 at 2:52 PM, Neelesh Salian wrote: > Hello, > > Could you please add me as a Contributor to help be a part of the Kafka > project? > > Thank you. > > Regards, > > Neelesh Srinivas Salian > -- -- Guozh

Re: [VOTE] KIP-11- Authorization design for kafka security

2015-04-27 Thread Parth Brahmbhatt
* We are not supporting regex matching to any of the strings (host,resource,principal) yet but this can be added. We have a special wild card (*) to refer to ALL but there is no other regex matching going on right now. We can associate CREATE with topics as you are proposing once KIP-4 is merged I

[jira] [Commented] (KAFKA-1993) Enable topic deletion as default

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515138#comment-14515138 ] Jun Rao commented on KAFKA-1993: Currently, there are still a few issues with topic deleti

Request to be added as Contributor

2015-04-27 Thread Neelesh Salian
Hello, Could you please add me as a Contributor to help be a part of the Kafka project? Thank you. Regards, Neelesh Srinivas Salian

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-27 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515101#comment-14515101 ] Jiangjie Qin commented on KAFKA-2103: - Personally, I think the tests should not assume

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515097#comment-14515097 ] Jun Rao commented on KAFKA-2139: [~gwenshap], when starting up a broker, the broker regist

[jira] [Commented] (KAFKA-2139) Add a separate controller messge queue with higher priority on broker side

2015-04-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515079#comment-14515079 ] Jun Rao commented on KAFKA-2139: [~becket_qin], thanks for taking the initiative to redesi

[jira] [Resolved] (KAFKA-1284) Received -1 when reading from channel, socket has likely been closed.

2015-04-27 Thread Rekha Joshi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi resolved KAFKA-1284. Resolution: Cannot Reproduce > Received -1 when reading from channel, socket has likely been closed.

[jira] [Commented] (KAFKA-1284) Received -1 when reading from channel, socket has likely been closed.

2015-04-27 Thread Rekha Joshi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515069#comment-14515069 ] Rekha Joshi commented on KAFKA-1284: Hi [~darion] The -1 error will be thrown only if

[jira] [Work started] (KAFKA-1284) Received -1 when reading from channel, socket has likely been closed.

2015-04-27 Thread Rekha Joshi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1284 started by Rekha Joshi. -- > Received -1 when reading from channel, socket has likely been closed. > ---

[jira] [Assigned] (KAFKA-1284) Received -1 when reading from channel, socket has likely been closed.

2015-04-27 Thread Rekha Joshi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rekha Joshi reassigned KAFKA-1284: -- Assignee: Rekha Joshi > Received -1 when reading from channel, socket has likely been closed. >

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-27 Thread Jun Rao
Yes, to verify if a partition reassignment completes or not, we just need to make sure AR == RAR. So, we don't need ISR for this. It's probably still useful to know ISR for monitoring in general though. Thanks, Jun On Mon, Apr 27, 2015 at 4:15 AM, Andrii Biletskyi < andrii.bilets...@stealth.ly>

Re: [VOTE] KIP-11- Authorization design for kafka security

2015-04-27 Thread Jun Rao
Parth, I was thinking that in a multi-tenant environment, an admin may want to carve out some topic space to a user. For example, allow user X to create any topic of X_*. Not sure how critical it is though. Also, with the current api, what would the admin do to replicate the acls from one cluster

[jira] [Commented] (KAFKA-1621) Standardize --messages option in perf scripts

2015-04-27 Thread Rekha Joshi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515003#comment-14515003 ] Rekha Joshi commented on KAFKA-1621: No worries [~nehanarkhede] Thanks for your review

[GitHub] kafka pull request: KAFKA-1621 : Standardize --messages option

2015-04-27 Thread rekhajoshm
GitHub user rekhajoshm opened a pull request: https://github.com/apache/kafka/pull/58 KAFKA-1621 : Standardize --messages option As per review comments from @nehanarkhede Thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rek

[jira] [Commented] (KAFKA-1621) Standardize --messages option in perf scripts

2015-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514991#comment-14514991 ] ASF GitHub Bot commented on KAFKA-1621: --- GitHub user rekhajoshm opened a pull reques

[jira] [Commented] (KAFKA-2103) kafka.producer.AsyncProducerTest failure.

2015-04-27 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514983#comment-14514983 ] Dong Lin commented on KAFKA-2103: - This test case fails because a local process on Jiangji

Re: Review Request 33574: Patch for KAFKA-2151

2015-04-27 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33574/#review81724 --- Ship it! Ship It! - Ewen Cheslack-Postava On April 27, 2015, 2:4

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't require ISR

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't require ISR

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't require ISR

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't require ISR

[jira] [Issue Comment Deleted] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1367: Comment: was deleted (was: [~jjkoshy] Yes, it appears that topic commands don't require ISR

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514762#comment-14514762 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that topic c

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514764#comment-14514764 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that topic c

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514760#comment-14514760 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that topic c

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514763#comment-14514763 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that topic c

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514761#comment-14514761 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that topic c

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514765#comment-14514765 ] Andrii Biletskyi commented on KAFKA-1367: - [~jjkoshy] Yes, it appears that topic c

[jira] [Reopened] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-27 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava reopened KAFKA-2121: -- Reopening since there's a trivial follow up patch that still needs to be applied. [

Re: Review Request 33551: Patch for KAFKA-2150

2015-04-27 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33551/#review81693 --- Ship it! Ship It! - Aditya Auradkar On April 25, 2015, 8:35 p.m.

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514481#comment-14514481 ] Joel Koshy commented on KAFKA-1367: --- I'm a bit wary of the watch approach. I believe at

[jira] [Assigned] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-27 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh reassigned KAFKA-1367: - Assignee: Ashish K Singh > Broker topic metadata not kept in sync with ZooKeeper > --

Re: [VOTE] KIP-11- Authorization design for kafka security

2015-04-27 Thread Parth Brahmbhatt
Hi Sun, thanks for the comments, my answers are below: * I think the wiki already describes the precedence order as Deny taking precedence over allow when conflicting acls are found https://cwiki.apache.org/confluence/display/KAFKA/KIP-11+-+Authorization+In terface#KIP-11-AuthorizationInterface-Pe

Re: [VOTE] KIP-11- Authorization design for kafka security

2015-04-27 Thread Parth Brahmbhatt
Thanks for your comments Jun. * Renamed the resource to consumer-group in wiki. * I don’t see a use case where admins/users would want to reserve topic names in advance. Can you describe why this would be needed. Thanks Parth On 4/26/15, 2:01 PM, "Jun Rao" wrote: >A few more minor comments. >

[jira] [Updated] (KAFKA-2089) MetadataTest transient failure

2015-04-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2089: - Status: In Progress (was: Patch Available) > MetadataTest transient failure > ---

[jira] [Comment Edited] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

2015-04-27 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514302#comment-14514302 ] Evan Huus edited comment on KAFKA-2147 at 4/27/15 3:38 PM: --- h5.

[jira] [Comment Edited] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

2015-04-27 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514302#comment-14514302 ] Evan Huus edited comment on KAFKA-2147 at 4/27/15 3:35 PM: --- h5.

[jira] [Commented] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

2015-04-27 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514302#comment-14514302 ] Evan Huus commented on KAFKA-2147: -- h5. Case 3 - Second Cluster As I mentioned above, we

[jira] [Commented] (KAFKA-2147) Unbalanced replication can cause extreme purgatory growth

2015-04-27 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514225#comment-14514225 ] Evan Huus commented on KAFKA-2147: -- Ah, OK. We are running with entirely default replicat

[jira] [Updated] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-04-27 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated KAFKA-2055: -- Attachment: KAFKA-2055.patch > ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-04-27 Thread Andrii Biletskyi
Okay, I had some doubts in terms of reassign-partitions case. I was not sure whether we need ISR to check post condition of partition reassignment. But I think we can rely on assigned replicas - the workflow in reassignPartitions is the following: 1. Update AR in ZK with OAR + RAR. ... 10. Update A

[jira] [Commented] (KAFKA-2106) Partition balance tool between borkers

2015-04-27 Thread chenshangan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513653#comment-14513653 ] chenshangan commented on KAFKA-2106: if new assignment start from the original startin

[jira] [Comment Edited] (KAFKA-2106) Partition balance tool between borkers

2015-04-27 Thread chenshangan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513575#comment-14513575 ] chenshangan edited comment on KAFKA-2106 at 4/27/15 7:20 AM: -

  1   2   >