Re: Review Request 34789: Patch for KAFKA-2168

2015-06-10 Thread Ewen Cheslack-Postava
On June 9, 2015, 7:58 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java, line 16 https://reviews.apache.org/r/34789/diff/8/?file=980077#file980077line16 Do we need NONE? Jason Gustafson wrote: It was there before, but I

[VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread Honghai Chen
Hi Kafka, After a long discussion, please help vote again for the KIP. Thanks. I wrote a KIP for this after some discussion on KAFKA-1646. https://issues.apache.org/jira/browse/KAFKA-1646

Re: KIP Call Notes

2015-06-10 Thread Jayesh Thakrar
Our company (Conversant Media) became a Kafka user pretty recently (about 3 months ago) and I have been following the user and dev group for the past month, so could have missed the discussions on KIP-4. In looking up the current command line capabilities in Kafka 0.8.2.1 (not the latest

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-10 Thread Jun Rao
On June 9, 2015, 6:49 p.m., Jay Kreps wrote: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, line 322 https://reviews.apache.org/r/34789/diff/8/?file=980075#file980075line322 Do we need this? There is no real guarantee on the poll time, so it seems

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-10 Thread Jun Rao
On June 9, 2015, 7:58 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, line 1212 https://reviews.apache.org/r/34789/diff/8/?file=980075#file980075line1212 -1 makes the pollClient block forever. So, we don't get a chance to do the

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-10 Thread Jason Gustafson
On June 9, 2015, 6:49 p.m., Jay Kreps wrote: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, line 322 https://reviews.apache.org/r/34789/diff/8/?file=980075#file980075line322 Do we need this? There is no real guarantee on the poll time, so it seems

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread Sriram Subramanian
+1 On Jun 10, 2015, at 9:38 AM, Jay Kreps j...@confluent.io wrote: +1 On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen honghai.c...@microsoft.com wrote: Hi Kafka, After a long discussion, please help vote again for the KIP. Thanks. I wrote a KIP for this after

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-10 Thread Jun Rao
On June 9, 2015, 7:58 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, line 1212 https://reviews.apache.org/r/34789/diff/8/?file=980075#file980075line1212 -1 makes the pollClient block forever. So, we don't get a chance to do the

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-10 Thread Jason Gustafson
On June 9, 2015, 7:58 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, line 1212 https://reviews.apache.org/r/34789/diff/8/?file=980075#file980075line1212 -1 makes the pollClient block forever. So, we don't get a chance to do the

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread Jay Kreps
+1 On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen honghai.c...@microsoft.com wrote: Hi Kafka, After a long discussion, please help vote again for the KIP. Thanks. I wrote a KIP for this after some discussion on KAFKA-1646. https://issues.apache.org/jira/browse/KAFKA-1646

Build failed in Jenkins: Kafka-trunk #506

2015-06-10 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/506/changes Changes: [wangguoz] KAFKA-2253; fix deadlock between removeWatchersLock and watcher operations list lock; reviewed by Onur Karaman and Jiangjie Qin -- [...truncated 419 lines...]

Re: KIP Call Notes

2015-06-10 Thread Jun Rao
Jayesh, Most of the metadata you mentioned already exist. For example, ISR is already in the TopicMetadataResponse and the high water mark can be returned from the OffsetRequest. The details of the current wire protocol can be found at

[jira] [Commented] (KAFKA-2253) Deadlock in delayed operation purgatory

2015-06-10 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580837#comment-14580837 ] Mayuresh Gharat commented on KAFKA-2253: Thanks [~guozhang] for this patch. I

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread Jakob Homan
+1 On Jun 10, 2015, at 10:36 AM, JG Homan jgho...@gmail.com wrote: +1 On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira gshap...@cloudera.com wrote: +1 (non-binding) On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen honghai.c...@microsoft.com wrote: Hi Kafka, After a long

Re: Review Request 34789: Patch for KAFKA-2168

2015-06-10 Thread Jun Rao
On June 9, 2015, 7:58 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java, line 1212 https://reviews.apache.org/r/34789/diff/8/?file=980075#file980075line1212 -1 makes the pollClient block forever. So, we don't get a chance to do the

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread Neha Narkhede
+1 On Wed, Jun 10, 2015 at 11:45 AM, Jakob Homan jgho...@gmail.com wrote: +1 On Jun 10, 2015, at 10:36 AM, JG Homan jgho...@gmail.com wrote: +1 On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira gshap...@cloudera.com wrote: +1 (non-binding) On Tue, Jun 9, 2015 at 11:24 PM,

[jira] [Updated] (KAFKA-2253) Deadlock in delayed operation purgatory

2015-06-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2253: - Resolution: Fixed Status: Resolved (was: Patch Available) Deadlock in delayed operation

[jira] [Commented] (KAFKA-2253) Deadlock in delayed operation purgatory

2015-06-10 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580921#comment-14580921 ] Guozhang Wang commented on KAFKA-2253: -- Thanks for all the reviews! Committed to

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread JG Homan
+1 On Wed, Jun 10, 2015 at 10:12 AM, Gwen Shapira gshap...@cloudera.com wrote: +1 (non-binding) On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen honghai.c...@microsoft.com wrote: Hi Kafka, After a long discussion, please help vote again for the KIP. Thanks. I wrote a KIP for this after

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread Gwen Shapira
+1 (non-binding) On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen honghai.c...@microsoft.com wrote: Hi Kafka, After a long discussion, please help vote again for the KIP. Thanks. I wrote a KIP for this after some discussion on KAFKA-1646.

[jira] [Created] (KAFKA-2261) Provide a configurable timeout for NetworkClient.send

2015-06-10 Thread Glenn Sontheimer (JIRA)
Glenn Sontheimer created KAFKA-2261: --- Summary: Provide a configurable timeout for NetworkClient.send Key: KAFKA-2261 URL: https://issues.apache.org/jira/browse/KAFKA-2261 Project: Kafka

Re: Review Request 33204: Patch for KAFKA-1646 merge to latest trunk

2015-06-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/#review87450 --- Ship it! Thanks for the patch. +1. Just some minor comments below.

Re: [VOTE] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-06-10 Thread Jun Rao
+1 Thanks, Jun On Tue, Jun 9, 2015 at 11:24 PM, Honghai Chen honghai.c...@microsoft.com wrote: Hi Kafka, After a long discussion, please help vote again for the KIP. Thanks. I wrote a KIP for this after some discussion on KAFKA-1646.

[jira] [Created] (KAFKA-2262) LogSegmentSize validation should be consistent

2015-06-10 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-2262: -- Summary: LogSegmentSize validation should be consistent Key: KAFKA-2262 URL: https://issues.apache.org/jira/browse/KAFKA-2262 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-2261) Provide a configurable timeout for NetworkClient.send

2015-06-10 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin resolved KAFKA-2261. - Resolution: Duplicate This is duplicate to KAFKA-2120 and KIP-19 addressed it. Provide a

[VOTE] KIP-25 System test improvements

2015-06-10 Thread Geoffrey Anderson
Hi Kafka, After a few rounds of discussion on KIP-25, there doesn't seem to be opposition, so I'd like to propose a vote. Thanks, Geoff On Mon, Jun 8, 2015 at 10:56 PM, Geoffrey Anderson ge...@confluent.io wrote: Hi KIP-25 thread, I consolidated some of the questions from this thread and

Re: Review Request 35201: Fix KAFKA-2253

2015-06-10 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35201/#review87495 --- core/src/main/scala/kafka/server/DelayedOperation.scala

Re: [VOTE] KIP-25 System test improvements

2015-06-10 Thread Gwen Shapira
+1 (non-binding. Actually, since this is non-binding anyway, lets make it +100. I'm so so excited about having a usable testing framework) On Wed, Jun 10, 2015 at 6:10 PM, Geoffrey Anderson ge...@confluent.io wrote: Hi Kafka, After a few rounds of discussion on KIP-25, there doesn't seem to be

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-06-10 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581292#comment-14581292 ] Ashish K Singh commented on KAFKA-1367: --- [~junrao] and [~jjkoshy], correct me if my

[jira] [Commented] (KAFKA-2022) simpleconsumer.fetch(req) throws a java.nio.channels.ClosedChannelException: null exception when the original leader fails instead of being trapped in the fetchResponse

2015-06-10 Thread Jinder Aujla (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581473#comment-14581473 ] Jinder Aujla commented on KAFKA-2022: - Hi I also noticed this, here is part of the

Re: [VOTE] KIP-25 System test improvements

2015-06-10 Thread Joe Stein
+1 ~ Joestein On Jun 10, 2015 10:21 PM, Neha Narkhede n...@confluent.io wrote: +1. Thanks Geoff! On Wed, Jun 10, 2015 at 6:20 PM -0700, Gwen Shapira gshap...@cloudera.com wrote: +1 (non-binding. Actually, since this is non-binding anyway, lets make it +100. I'm so so excited

[jira] [Updated] (KAFKA-1882) Create extendable channel interface and default implementations

2015-06-10 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1882: Fix Version/s: (was: 0.8.3) Create extendable channel interface and default implementations

[jira] [Resolved] (KAFKA-1882) Create extendable channel interface and default implementations

2015-06-10 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-1882. - Resolution: Duplicate I believe this is already handled in the SSL patches Create extendable

[jira] [Commented] (KAFKA-1792) change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments

2015-06-10 Thread manpreet singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581419#comment-14581419 ] manpreet singh commented on KAFKA-1792: --- Integrated the patch and tested this new

Re: [VOTE] KIP-25 System test improvements

2015-06-10 Thread Neha Narkhede
+1. Thanks Geoff! On Wed, Jun 10, 2015 at 6:20 PM -0700, Gwen Shapira gshap...@cloudera.com wrote: +1 (non-binding. Actually, since this is non-binding anyway, lets make it +100. I'm so so excited about having a usable testing framework) On Wed, Jun 10, 2015 at 6:10 PM, Geoffrey