[
https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620659#comment-14620659
]
Flavio Junqueira commented on KAFKA-2300:
-
My assessment so far focused on the
Of course you're right -- my bad, I scanned the log too quickly and misread
the cause of the error.
On Wed, Jul 8, 2015 at 10:30 PM, Joel Koshy jjkosh...@gmail.com wrote:
Agreed that we should change it to exclude build/** - however, build 142
failure does not seem to be rat-related is it?
Steve Tian created KAFKA-2326:
-
Summary: KafkaProducer - the this reference escapes during
construction
Key: KAFKA-2326
URL: https://issues.apache.org/jira/browse/KAFKA-2326
Project: Kafka
On July 9, 2015, 1:42 a.m., Guozhang Wang wrote:
Browsed through the patch, overall looks very promising.
I am not very clear on a few detailed changes though:
1. The request future adapter / handler modifications.
2. Retry backoff implementation seems not correct.
Could you
On July 9, 2015, 4:58 p.m., Ewen Cheslack-Postava wrote:
Just FYI, this was also noticed in the patch for KAFKA-2123 (which is
moving quite a bit of code around). The solution was a bit different (the
condition is different and keeps the existing generation ID increment
location).
[
https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-2298:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Client Selector can drop
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Anderson updated KAFKA-2327:
-
Description:
To reproduce locally, in server.properties, define advertised.host and
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621085#comment-14621085
]
ASF GitHub Bot commented on KAFKA-2327:
---
GitHub user granders opened a pull request:
GitHub user granders opened a pull request:
https://github.com/apache/kafka/pull/73
KAFKA-2327
Added unit tests as well. These fail without the fix, but pass with the fix.
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621045#comment-14621045
]
Gwen Shapira commented on KAFKA-2327:
-
Oops. My bug :)
Do you have a patch, or shall
Geoffrey Anderson created KAFKA-2327:
Summary: broker doesn't start if config defines advertised.host
but not advertised.port
Key: KAFKA-2327
URL: https://issues.apache.org/jira/browse/KAFKA-2327
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geoffrey Anderson updated KAFKA-2327:
-
Description:
To reproduce locally, in server.properties, define advertised.host and
On July 9, 2015, 3:53 a.m., Ewen Cheslack-Postava wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java,
line 121
https://reviews.apache.org/r/36333/diff/1/?file=1002923#file1002923line121
Is this the behavior we want? Both timeout
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621091#comment-14621091
]
Geoffrey Anderson commented on KAFKA-2327:
--
Oh quick reply! Yup I just opened a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34492/
---
(Updated July 10, 2015, 1 a.m.)
Review request for kafka.
Bugs: KAFKA-2210
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt updated KAFKA-2210:
Attachment: KAFKA-2210_2015-07-09_18:00:34.patch
KafkaAuthorizer: Add all public entities,
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621561#comment-14621561
]
Guozhang Wang commented on KAFKA-1740:
--
Committed to trunk, thanks.
Merge Offset
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt updated KAFKA-2210:
Status: Patch Available (was: In Progress)
KafkaAuthorizer: Add all public entities,
On June 9, 2015, 7:13 a.m., Dapeng Sun wrote:
core/src/main/scala/kafka/common/ErrorMapping.scala, line 57
https://reviews.apache.org/r/34492/diff/4/?file=979556#file979556line57
Why not use 23 here?
I have changed it so it now uses 23.
On June 9, 2015, 7:13 a.m., Dapeng Sun
On June 11, 2015, 7:19 a.m., Dapeng Sun wrote:
core/src/main/scala/kafka/server/KafkaConfig.scala, line 160
https://reviews.apache.org/r/34492/diff/4/?file=979565#file979565line160
Why add a new config file path? could authorization related config
options be merged into Kafka
On June 3, 2015, 11:36 p.m., Parth Brahmbhatt wrote:
core/src/main/scala/kafka/security/auth/Acl.scala, lines 57-62
https://reviews.apache.org/r/34492/diff/1/?file=965651#file965651line57
I tried exactly that but it tunrs out our current Json parser does not
work when a json
[
https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621546#comment-14621546
]
Parth Brahmbhatt commented on KAFKA-2210:
-
Updated reviewboard
See https://builds.apache.org/job/Kafka-trunk/538/changes
Changes:
[wangguoz] KAFKA-1740 follow-up: add state checking in handling heartbeat
request; reviewed by Onur Karaman, Ewen Cheslack-Postavam and Guozhang Wang
[jjkoshy] Trivial commit - explicitly exclude build/** from rat check
[
https://issues.apache.org/jira/browse/KAFKA-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2322:
---
Status: Patch Available (was: Open)
Use Java 7 features to improve code quality
[
https://issues.apache.org/jira/browse/KAFKA-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-2322:
---
Attachment: KAFKA-2322.patch
Use Java 7 features to improve code quality
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36345/
---
(Updated July 9, 2015, 9:05 a.m.)
Review request for kafka.
Bugs: KAFKA-2322
I've skimmed through a source code of Mirror Maker and I see that it relies
on raw threads
https://github.com/apache/kafka/blob/7df39e0394a6fd2f26e8f12768ebf7fecd56e3da/core/src/main/scala/kafka/tools/MirrorMaker.scala#L285-L287,
as opposed to Runnable + Thread pool combination. While former
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620038#comment-14620038
]
Onur Karaman commented on KAFKA-1740:
-
There's a discrepancy between
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36345/
---
Review request for kafka.
Bugs: KAFKA-2322
[
https://issues.apache.org/jira/browse/KAFKA-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620153#comment-14620153
]
Ismael Juma commented on KAFKA-2322:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620158#comment-14620158
]
Ismael Juma commented on KAFKA-2322:
These changes are mechanical but affect a lot of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36346/
---
Review request for kafka.
Bugs: KAFKA-1740
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620190#comment-14620190
]
Onur Karaman commented on KAFKA-1740:
-
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36346/
---
(Updated July 9, 2015, 9:42 a.m.)
Review request for kafka.
Bugs: KAFKA-1740
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Onur Karaman updated KAFKA-1740:
Attachment: KAFKA-1740.patch
Merge Offset manager into Coordinator
[
https://issues.apache.org/jira/browse/KAFKA-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620469#comment-14620469
]
Ismael Juma commented on KAFKA-2322:
[~sriharsha], sure. :)
Use Java 7 features to
[
https://issues.apache.org/jira/browse/KAFKA-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620465#comment-14620465
]
Sriharsha Chintalapani commented on KAFKA-2322:
---
[~ijuma] can this be merged
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621217#comment-14621217
]
Gwen Shapira commented on KAFKA-2187:
-
I think that per Apache, we need to acknowledge
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621228#comment-14621228
]
Ismael Juma commented on KAFKA-2187:
It is mentioned in the script itself (near the
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621239#comment-14621239
]
Gwen Shapira commented on KAFKA-2187:
-
Sorry, I missed that. I think its good and I
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621243#comment-14621243
]
Gwen Shapira commented on KAFKA-2187:
-
One more thing:
If I start a merge and cancel
On July 9, 2015, 1:42 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java,
line 775
https://reviews.apache.org/r/36333/diff/1/?file=1002921#file1002921line775
I think KAFKA-1894 is already fixed in this patch + KAFKA-2168?
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621257#comment-14621257
]
Ismael Juma commented on KAFKA-2187:
Thanks for checking regarding the license.
Good
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621260#comment-14621260
]
Ismael Juma commented on KAFKA-2187:
In the meantime `git checkout -` should take you
On July 9, 2015, 3:53 a.m., Ewen Cheslack-Postava wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkClient.java,
line 91
https://reviews.apache.org/r/36333/diff/1/?file=1002923#file1002923line91
Is the retryBackoffMs here because that's how
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34965/#review91159
---
core/src/main/scala/kafka/server/AbstractFetcherThread.scala (line
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621174#comment-14621174
]
Onur Karaman commented on KAFKA-1740:
-
Sounds good. Just a heads up, KAFKA-2123 checks
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621176#comment-14621176
]
Edward Ribeiro commented on KAFKA-2327:
---
Left some minor review comments, hope you
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-1740:
---
Attachment: KAFKA-1740.patch
Merge Offset manager into Coordinator
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621193#comment-14621193
]
Jason Gustafson commented on KAFKA-1740:
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36368/#review91184
---
Ship it!
Ship It!
- Onur Karaman
On July 9, 2015, 8:23 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36368/#review91187
---
Could you add some unit test for this fix?
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621144#comment-14621144
]
Guozhang Wang commented on KAFKA-1740:
--
Thanks for the findings [~onurkaraman]! And
[
https://issues.apache.org/jira/browse/KAFKA-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-2303:
-
Fix Version/s: 0.8.3
Fix for KAFKA-2235 LogCleaner offset map overflow causes another compaction
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36368/
---
Review request for kafka.
Bugs: KAFKA-1740
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14620788#comment-14620788
]
Onur Karaman commented on KAFKA-1740:
-
Here are two scenarios from
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36346/#review91118
---
Just FYI, this was also noticed in the patch for KAFKA-2123 (which
[
https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-2241:
Attachment: KAFKA-2241_2015-07-09_15:35:49.patch
AbstractFetcherThread.shutdown() should not block on
[
https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621396#comment-14621396
]
Dong Lin commented on KAFKA-2241:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34965/
---
(Updated July 9, 2015, 10:35 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-2241:
Status: Patch Available (was: In Progress)
AbstractFetcherThread.shutdown() should not block on
On July 9, 2015, 7:19 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 71
https://reviews.apache.org/r/34965/diff/2/?file=977751#file977751line71
As you probably noticed synchronization in the
AbstractFetcherManager/Thread classes are
See https://builds.apache.org/job/KafkaPreCommit/143/changes
On July 9, 2015, 8:40 p.m., Guozhang Wang wrote:
Could you add some unit test for this fix?
Done. The test case depends on timing like the other response tests, but it
should test what we want most of the time and succeed even if there is an
unexpected delay in execution.
On July 9,
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/73
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621352#comment-14621352
]
ASF GitHub Bot commented on KAFKA-2327:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/KAFKA-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira resolved KAFKA-2327.
-
Resolution: Fixed
Fix Version/s: 0.8.3
Merged PR.
broker doesn't start if config defines
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621387#comment-14621387
]
Ismael Juma commented on KAFKA-2187:
OK, thank you.
Introduce merge-kafka-pr.py
See https://builds.apache.org/job/Kafka-trunk/537/changes
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621329#comment-14621329
]
Jason Gustafson commented on KAFKA-1740:
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36368/
---
(Updated July 9, 2015, 9:41 p.m.)
Review request for kafka.
Bugs: KAFKA-1740
[
https://issues.apache.org/jira/browse/KAFKA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-1740:
---
Attachment: KAFKA-1740_2015-07-09_14:41:31.patch
Merge Offset manager into Coordinator
[
https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621336#comment-14621336
]
Bob Cotton commented on KAFKA-2300:
---
Which logs would you like? server, controller,
[
https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621344#comment-14621344
]
Flavio Junqueira commented on KAFKA-2300:
-
controller logs, please.
Error in
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-2187:
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14621384#comment-14621384
]
Gwen Shapira commented on KAFKA-2187:
-
I accidentally committed this script as part of
On July 9, 2015, 7:19 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76
https://reviews.apache.org/r/34965/diff/2/?file=977751#file977751line76
You could get around the above by retaining this call to
simpleConsumer.close (although it
On July 9, 2015, 7:19 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76
https://reviews.apache.org/r/34965/diff/2/?file=977751#file977751line76
You could get around the above by retaining this call to
simpleConsumer.close (although it
78 matches
Mail list logo
