[GitHub] kafka pull request: Fixed ConsumerRecord constructor javadoc

2015-07-18 Thread sslavic
GitHub user sslavic opened a pull request: https://github.com/apache/kafka/pull/85 Fixed ConsumerRecord constructor javadoc Refactoring of ConsumerRecord made in https://github.com/apache/kafka/commit/0699ff2ce60abb466cab5315977a224f1a70a4da#diff-fafe8d3a3942f3c6394927881a9389b2

Re: Official Kafka Gitter Room?

2015-07-18 Thread Ismael Juma
Hi Grant, I have been considering proposing the same thing myself for similar reasons, but I also have some doubts. More comments inline. On Fri, Jul 17, 2015 at 7:28 PM, Grant Henke ghe...@cloudera.com wrote: I think it could be useful to have a place to chat that is associated with the

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-18 Thread Ben Kirwin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632537#comment-14632537 ] Ben Kirwin commented on KAFKA-2260: --- Ah, clever! Thanks for sharing this -- I've linked

Re: Merge improvements back into Kafka Metrics?

2015-07-18 Thread Neha Narkhede
Felix, That sounds great and thanks for volunteering to submit the patch. We are happy to take the change above pending review. I also like the idea of releasing the kafka-metrics as a separate artifact as part of every Kafka release. Again, thanks for your help and look forward to the patch.

[jira] [Updated] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

2015-07-18 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2347: -- Attachment: KAFKA-2347_2015-07-18_15:14:26.patch Add setConsumerRebalanceListener method to

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92190 --- Ship it! Ship It! - Ismael Juma On July 18, 2015, 10:14 p.m.,

[jira] [Commented] (KAFKA-2347) Add setConsumerRebalanceListener method to ZookeeperConsuemrConnector java api.

2015-07-18 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632621#comment-14632621 ] Ashish K Singh commented on KAFKA-2347: --- Updated reviewboard

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/ --- (Updated July 18, 2015, 10:14 p.m.) Review request for kafka. Bugs:

Re: Review Request 33620: Patch for KAFKA-1690

2015-07-18 Thread Sriharsha Chintalapani
On May 15, 2015, 10:54 p.m., Joel Koshy wrote: clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, line 321 https://reviews.apache.org/r/33620/diff/5/?file=957065#file957065line321 Actually, can you describe how this would be done (say, for dealing

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-07-18 Thread Ben Kirwin
Just wanted to flag a little discussion that happened on the ticket: https://issues.apache.org/jira/browse/KAFKA-2260?focusedCommentId=14632259page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14632259 In particular, Yasuhiro Matsuda proposed an interesting variant on

Re: Review Request 33620: Patch for KAFKA-1690

2015-07-18 Thread Sriharsha Chintalapani
On June 30, 2015, 3:03 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, line 602 https://reviews.apache.org/r/33620/diff/10/?file=990783#file990783line602 Not sure if we should do the flip here. The caller may not be able to

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92178 --- Ship it! LGTM. Thanks. - Jiangjie Qin On July 18, 2015, 5:02

Re: Official Kafka Gitter Room?

2015-07-18 Thread Neha Narkhede
FWIW, if the apache-kafka channel was on Slack, I'd hang out there :-) On Sat, Jul 18, 2015 at 7:20 AM, Ismael Juma ism...@juma.me.uk wrote: Hi Grant, I have been considering proposing the same thing myself for similar reasons, but I also have some doubts. More comments inline. On Fri, Jul

Re: Review Request 36593: Patch for KAFKA-2347

2015-07-18 Thread Ismael Juma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36593/#review92179 --- There is a typo in the commit message: ZookeeperConsuemrConnector.

[GitHub] kafka pull request: Addresses Jira Kafka-2236 to eliminate an arra...

2015-07-18 Thread jhspaybar
GitHub user jhspaybar opened a pull request: https://github.com/apache/kafka/pull/86 Addresses Jira Kafka-2236 to eliminate an array index out of bounds e… …xception when segments are appended between checks First pull request, so if I did this incorrectly, let me know.

Re: Official Kafka Gitter Room?

2015-07-18 Thread Gwen Shapira
FYI: Joining Slack requires an invitation. We can take invite-requests in the mailing lists (like we do for KIP hangout). I wanted to point this out as this may be considered non-Apache (although I didn't find any specific wording against invite-only channels in addition to the mailing list). So,

New Producer and acks configuration

2015-07-18 Thread Gwen Shapira
Hi, I was looking into the different between acks = 0 and acks = 1 in the new producer, and was a bit surprised at what I found. Basically, if I understand correctly, the only difference is that with acks = 0, if the leader fails to append locally, it closes the network connection silently and

Re: Official Kafka Gitter Room?

2015-07-18 Thread Gwen Shapira
Slack sounds good and I'm not a fan of gitter (we use it for Apache Sqoop, I dislike the GUI and the guilt-inducing emails about all the messages I missed...) Do they have free rooms for open source projects? On Sat, Jul 18, 2015 at 6:10 PM, Andrew Psaltis psaltis.and...@gmail.com wrote: +1 for

Re: Official Kafka Gitter Room?

2015-07-18 Thread Andrew Psaltis
+1 for slack On Saturday, July 18, 2015, Neha Narkhede n...@confluent.io wrote: FWIW, if the apache-kafka channel was on Slack, I'd hang out there :-) On Sat, Jul 18, 2015 at 7:20 AM, Ismael Juma ism...@juma.me.uk javascript:; wrote: Hi Grant, I have been considering proposing the

Re: Review Request 36590: Patch for KAFKA-2275

2015-07-18 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36590/#review92194 ---

Re: Official Kafka Gitter Room?

2015-07-18 Thread Gwen Shapira
So, as an experiment, I created: https://apachekafka.slack.com I figured we'll give it a whirl for a week or two for dev discussions, see how it goes and if we have activity we can add this to the website and announce on the lists. Gwen On Sat, Jul 18, 2015 at 6:18 PM, Gwen Shapira