Wiki permissions

2017-01-04 Thread Dongjin Lee
Hello. I just completed a KIP for KAFKA-4514[^1] but can not create any page on the wiki. Could anyone can give me the permission? Regards, Dongjin [^1]: https://issues.apache.org/jira/browse/KAFKA-4514 -- *Dongjin Lee* *Software developer in Line+.So interested in massive-scale machine

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800617#comment-15800617 ] Michael Andre Pearce (IG) commented on KAFKA-4497: -- Hi [~becket_qin] Sorry we thought

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800498#comment-15800498 ] Jiangjie Qin commented on KAFKA-4497: - [~michael.andre.pearce] Sorry for the late response, just got

[jira] [Reopened] (KAFKA-4295) kafka-console-consumer.sh does not delete the temporary group in zookeeper

2017-01-04 Thread huxi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huxi reopened KAFKA-4295: - > kafka-console-consumer.sh does not delete the temporary group in zookeeper >

[jira] [Commented] (KAFKA-3264) Mark the old Scala consumer and related classes as deprecated

2017-01-04 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800447#comment-15800447 ] Ewen Cheslack-Postava commented on KAFKA-3264: -- Seems reasonable to me -- the new consumer

[jira] [Commented] (KAFKA-4558) throttling_test fails if the producer starts too fast.

2017-01-04 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800434#comment-15800434 ] Ewen Cheslack-Postava commented on KAFKA-4558: -- Number of partitions probably isn't reliable

[jira] [Created] (KAFKA-4594) Annotate integration tests and provide gradle build targets to run subsets of tests

2017-01-04 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-4594: Summary: Annotate integration tests and provide gradle build targets to run subsets of tests Key: KAFKA-4594 URL: https://issues.apache.org/jira/browse/KAFKA-4594

[GitHub] kafka pull request #2315: MINOR: Update JavaDoc for KTable helper interfaces

2017-01-04 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/2315 MINOR: Update JavaDoc for KTable helper interfaces You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka javaDocImprovements2

Re: 0.10.2.0 release planning

2017-01-04 Thread Ewen Cheslack-Postava
Just to clarify this a bit, the additions made so far add the server-side handling of the new protocols. But it does not include any user-facing API changes to enable use of these features. Because of this, it's not particularly useful to users and not really worth mentioning. It'd mostly be

[jira] [Commented] (KAFKA-1908) Split brain

2017-01-04 Thread Lixing (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15800084#comment-15800084 ] Lixing commented on KAFKA-1908: --- Is the problem resolved in the version 0.9.X or later? Does the split

[GitHub] kafka pull request #2314: MINOR: cleanup Kafka Streams exception classes

2017-01-04 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/kafka/pull/2314 MINOR: cleanup Kafka Streams exception classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/mjsax/kafka javaDocImprovements Alternatively you

[jira] [Commented] (KAFKA-4477) Node reduces its ISR to itself, and doesn't recover. Other nodes do not take leadership, cluster remains sick until node is restarted.

2017-01-04 Thread Sandokan Dias (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799988#comment-15799988 ] Sandokan Dias commented on KAFKA-4477: -- We have been running 0.10.1.1 (in production) since 12/28 and

[jira] [Updated] (KAFKA-4592) Kafka Producer Metrics Invalid Value

2017-01-04 Thread AJ Jwair (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AJ Jwair updated KAFKA-4592: Description: Producer metrics Metric name: record-size-max When no records are produced during the

[GitHub] kafka pull request #2111: throw exception when the connection is error.

2017-01-04 Thread huyanping
Github user huyanping closed the pull request at: https://github.com/apache/kafka/pull/2111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Created] (KAFKA-4593) Task migration during rebalance callback process could lead the obsoleted task's IllegalStateException

2017-01-04 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-4593: Summary: Task migration during rebalance callback process could lead the obsoleted task's IllegalStateException Key: KAFKA-4593 URL:

Re: [VOTE] Vote for KIP-101 - Leader Epochs

2017-01-04 Thread Jun Rao
Hi, Ben, Thanks for the proposal. Looks good overall. A few comments below. 1. For LeaderEpochRequest, we need to include topic right? We probably want to follow other requests by nesting partition inside topic? For LeaderEpochResponse, do we need to return leader_epoch? I was thinking that we

[jira] [Commented] (KAFKA-4575) Transient failure in ConnectDistributedTest.test_pause_and_resume_sink in consuming messages after resuming sink connector

2017-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799820#comment-15799820 ] ASF GitHub Bot commented on KAFKA-4575: --- GitHub user shikhar opened a pull request:

[GitHub] kafka pull request #2313: KAFKA-4575: ensure topic created before starting s...

2017-01-04 Thread shikhar
GitHub user shikhar opened a pull request: https://github.com/apache/kafka/pull/2313 KAFKA-4575: ensure topic created before starting sink for ConnectDistributedTest.test_pause_resume_sink Otherwise in this test the sink task goes through the pause/resume cycle with 0 assigned

[jira] [Commented] (KAFKA-3264) Mark the old Scala consumer and related classes as deprecated

2017-01-04 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799810#comment-15799810 ] Vahid Hashemian commented on KAFKA-3264: [~ijuma] [~ewencp] Just want to confirm if this is still

[jira] [Work started] (KAFKA-4547) Consumer.position returns incorrect results for Kafka 0.10.1.0 client

2017-01-04 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4547 started by Vahid Hashemian. -- > Consumer.position returns incorrect results for Kafka 0.10.1.0 client >

[jira] [Commented] (KAFKA-4575) Transient failure in ConnectDistributedTest.test_pause_and_resume_sink in consuming messages after resuming source connector

2017-01-04 Thread Shikhar Bhushan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799807#comment-15799807 ] Shikhar Bhushan commented on KAFKA-4575: By the way, the error message is misleading, it should

[jira] [Updated] (KAFKA-4575) Transient failure in ConnectDistributedTest.test_pause_and_resume_sink in consuming messages after resuming sink connector

2017-01-04 Thread Shikhar Bhushan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shikhar Bhushan updated KAFKA-4575: --- Summary: Transient failure in ConnectDistributedTest.test_pause_and_resume_sink in consuming

[jira] [Updated] (KAFKA-4591) Create Topic Policy

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4591: --- Description: It would be useful to be able to validate create topics requests. More details in the

Re: KIP-103: Separation of Internal and External traffic

2017-01-04 Thread Ismael Juma
I updated the KIP to cover point 1 as well. If there are no additional comments, I intend to start a vote thread within a day or two. Thanks, Ismael On Wed, Jan 4, 2017 at 11:30 PM, Ismael Juma wrote: > Thanks for the review Jun. Replies follow. > > 1. That's a very good

[jira] [Comment Edited] (KAFKA-4477) Node reduces its ISR to itself, and doesn't recover. Other nodes do not take leadership, cluster remains sick until node is restarted.

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799732#comment-15799732 ] Michael Andre Pearce (IG) edited comment on KAFKA-4477 at 1/4/17 11:44 PM:

[jira] [Commented] (KAFKA-4477) Node reduces its ISR to itself, and doesn't recover. Other nodes do not take leadership, cluster remains sick until node is restarted.

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799732#comment-15799732 ] Michael Andre Pearce (IG) commented on KAFKA-4477: -- We haven't seen this re-occur, though

[jira] [Commented] (KAFKA-4477) Node reduces its ISR to itself, and doesn't recover. Other nodes do not take leadership, cluster remains sick until node is restarted.

2017-01-04 Thread Tom DeVoe (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799720#comment-15799720 ] Tom DeVoe commented on KAFKA-4477: -- We have been running 0.10.1.1 since 12/22 and have not seen this

Re: KIP-103: Separation of Internal and External traffic

2017-01-04 Thread Ismael Juma
Thanks for the review Jun. Replies follow. 1. That's a very good point. Adding a prefix to the JAAS entry name with a fallback to the name without the prefix is consistent with how the other configs are handled, so I'll update the KIP to mention that. 2. That was a typo, thanks for catching it.

[jira] [Work started] (KAFKA-4575) Transient failure in ConnectDistributedTest.test_pause_and_resume_sink in consuming messages after resuming source connector

2017-01-04 Thread Shikhar Bhushan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4575 started by Shikhar Bhushan. -- > Transient failure in ConnectDistributedTest.test_pause_and_resume_sink in

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799617#comment-15799617 ] Ismael Juma commented on KAFKA-4497: Yes, the plan is to include the fix in Confluent 3.1.2. > log

[GitHub] kafka pull request #2312: Kafka 960 metrics upgrade

2017-01-04 Thread andreinechaev
GitHub user andreinechaev opened a pull request: https://github.com/apache/kafka/pull/2312 Kafka 960 metrics upgrade Replaced outdated yammer.metrics with codahale.metrics 3.0.0. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799599#comment-15799599 ] Michael Andre Pearce (IG) commented on KAFKA-4497: -- Btw, we are using actually normally

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799594#comment-15799594 ] Michael Andre Pearce (IG) commented on KAFKA-4497: -- [~junrao] just attached, with

[jira] [Updated] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Andre Pearce (IG) updated KAFKA-4497: - Attachment: com_ig_trade_v1_order_event--demo--compacted-7.tar.bz2

Re: [VOTE] KIP-66: Single Message Transforms for Kafka Connect

2017-01-04 Thread Shikhar Bhushan
I do plan on introducing a new `connect:transforms` module (which `connect:runtime` will depend on), so they will live in a separate module in the source tree and output. ( https://github.com/apache/kafka/pull/2299 ) On Wed, Jan 4, 2017 at 2:28 PM Ewen Cheslack-Postava wrote:

Re: [VOTE] KIP-66: Single Message Transforms for Kafka Connect

2017-01-04 Thread Gwen Shapira
The concern is maintaining a potentially unbounded list of add-ons as part of Kafka. I think the pros/cons were well discussed, I am happy we added a provision specifically excluding transformations that depend on specific data sources, and I'd much rather get SMT than continuing to debate how

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799565#comment-15799565 ] Jun Rao commented on KAFKA-4497: [~michael.andre.pearce], if you could attach the problematic .log file to

[jira] [Commented] (KAFKA-4547) Consumer.position returns incorrect results for Kafka 0.10.1.0 client

2017-01-04 Thread Vahid Hashemian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799561#comment-15799561 ] Vahid Hashemian commented on KAFKA-4547: So here's what I've found so far. The inconsistency in

Re: [VOTE] KIP-66: Single Message Transforms for Kafka Connect

2017-01-04 Thread Ewen Cheslack-Postava
+1 Gwen, re: bundling transformations, would it help at all to isolate them to a separate jar or is the concern purely about maintaining them as part of Kafka? -Ewen On Wed, Jan 4, 2017 at 1:31 PM, Sriram Subramanian wrote: > +1 > > On Wed, Jan 4, 2017 at 1:29 PM, Gwen

Re: KIP-103: Separation of Internal and External traffic

2017-01-04 Thread Jun Rao
Hi, Ismael, Thanks for the proposal. Looks good to me overall. Just a couple of minor comments. 1. Sasl also has some properties provided through the login context in the jaas file. Do we want to extend that to allow different login context for different protocol labels on the server side (e.g.

[jira] [Comment Edited] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799490#comment-15799490 ] Michael Andre Pearce (IG) edited comment on KAFKA-4497 at 1/4/17 10:09 PM:

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799490#comment-15799490 ] Michael Andre Pearce (IG) commented on KAFKA-4497: -- [~junrao]We had this occur now in our

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-04 Thread James Cheng
+1 I agree with Gwen that this needs to be well communicated to users. Anyone who is using the current default may see their brokers start to go exit when they upgrade to this new version. On a somewhat related subject, occasionally I'll need to look up how my Kafka brokers are configured.

[jira] [Commented] (KAFKA-4558) throttling_test fails if the producer starts too fast.

2017-01-04 Thread Apurva Mehta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799448#comment-15799448 ] Apurva Mehta commented on KAFKA-4558: - That sounds like a good idea in general, to make metrics easier

Re: [VOTE] KIP-66: Single Message Transforms for Kafka Connect

2017-01-04 Thread Sriram Subramanian
+1 On Wed, Jan 4, 2017 at 1:29 PM, Gwen Shapira wrote: > I would have preferred not to bundle transformations, but since SMT > capability is a much needed feature, I'll take it in its current form. > > +1 > > On Wed, Jan 4, 2017 at 10:47 AM, Shikhar Bhushan

Re: [VOTE] KIP-66: Single Message Transforms for Kafka Connect

2017-01-04 Thread Gwen Shapira
I would have preferred not to bundle transformations, but since SMT capability is a much needed feature, I'll take it in its current form. +1 On Wed, Jan 4, 2017 at 10:47 AM, Shikhar Bhushan wrote: > Hi all, > > I'd like to start voting on KIP-66: >

Re: [DISCUSS] KIP-98: Exactly Once Delivery and Transactional Messaging

2017-01-04 Thread Jay Kreps
Hey Jun, We had a proposal like this previously. The suppression scheme was slightly different. Rather than than attempting to recopy or swap, there was instead an aborted offset index maintained along with each segment containing a sequential list of aborted offsets. The filtering would happen

[jira] [Updated] (KAFKA-4523) Controlled shutdown fails if consumer group restabilizes during shutdown

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4523: --- Fix Version/s: 0.10.2.0 > Controlled shutdown fails if consumer group restabilizes during shutdown >

[jira] [Updated] (KAFKA-4523) Controlled shutdown fails if consumer group restabilizes during shutdown

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4523: --- Status: Patch Available (was: Open) > Controlled shutdown fails if consumer group restabilizes

[jira] [Commented] (KAFKA-4523) Controlled shutdown fails if consumer group restabilizes during shutdown

2017-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799183#comment-15799183 ] ASF GitHub Bot commented on KAFKA-4523: --- GitHub user steveniemitz opened a pull request:

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799192#comment-15799192 ] Jun Rao commented on KAFKA-4497: [~michael.andre.pearce], sorry for the production issue this is causing.

[GitHub] kafka pull request #2311: KAFKA-4523; Fix crash at shutdown due to the group...

2017-01-04 Thread steveniemitz
GitHub user steveniemitz opened a pull request: https://github.com/apache/kafka/pull/2311 KAFKA-4523; Fix crash at shutdown due to the group coordinator attemp… …ting to write to a closed log. Solution: shut down the group manager before shutting down the log manager

Re: [DISCUSS] KIP-106 - Change Default unclean.leader.election.enabled from True to False

2017-01-04 Thread Rajini Sivaram
+1 On Wed, Jan 4, 2017 at 1:49 AM, Becket Qin wrote: > +1 > > On Tue, Jan 3, 2017 at 5:41 PM, Joel Koshy wrote: > > > +1 > > > > On Tue, Jan 3, 2017 at 10:54 AM, Ben Stopford wrote: > > > > > Hi All > > > > > > Please find the

Re: [DISCUSS] KIP-102 - Add close with timeout for consumers

2017-01-04 Thread Rajini Sivaram
Hi Jason, Yes, we do potentially timeout even before sending pending commits after the request timeout (default is > 5 minutes, so this should only happen when there are real issues or when brokers are shutdown). I have updated the KIP to use a default timeout of 30 seconds for the existing

[jira] [Commented] (KAFKA-4436) Provide builder pattern for StreamsConfig

2017-01-04 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15799096#comment-15799096 ] Matthias J. Sax commented on KAFKA-4436: I guess we would need a KIP for this anyway -- should we

Re: [DISCUSS] KIP-98: Exactly Once Delivery and Transactional Messaging

2017-01-04 Thread Jun Rao
Thanks for the proposal. A few more detailed comments. 100. Security: It seems that if an app is mistakenly configured with the appId of an existing producer, it can take over the pid and prevent the existing app from publishing. So, I am wondering if it makes sense to add ACLs at the

[VOTE] KIP-66: Single Message Transforms for Kafka Connect

2017-01-04 Thread Shikhar Bhushan
Hi all, I'd like to start voting on KIP-66: https://cwiki.apache.org/confluence/display/KAFKA/KIP-66%3A+Single+Message+Transforms+for+Kafka+Connect Best, Shikhar

[jira] [Updated] (KAFKA-4592) Kafka Producer Metrics Invalid Value

2017-01-04 Thread AJ Jwair (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] AJ Jwair updated KAFKA-4592: Summary: Kafka Producer Metrics Invalid Value (was: Kafka Producer Metrics Invalid Valu) > Kafka Producer

[jira] [Created] (KAFKA-4592) Kafka Producer Metrics Invalid Valu

2017-01-04 Thread AJ Jwair (JIRA)
AJ Jwair created KAFKA-4592: --- Summary: Kafka Producer Metrics Invalid Valu Key: KAFKA-4592 URL: https://issues.apache.org/jira/browse/KAFKA-4592 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-105: Addition of Record Level for Sensors

2017-01-04 Thread Aarti Gupta
Thanks for the review, Guozhang, Addressed 2 out of the three comments, 1. Fixed and updated KIP (swapped code variable name METRICS_RECORD_LEVEL_CONFIG with config name metrics.record.level) 3. >>Could you elaborate on the "shouldRecord()" function, e.g. which class it will be added to? Does

[jira] [Commented] (KAFKA-4573) Producer sporadic timeout

2017-01-04 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798862#comment-15798862 ] Jason Gustafson commented on KAFKA-4573: [~maverick2202] Do you know if the under-replicated

[jira] [Comment Edited] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798847#comment-15798847 ] Michael Andre Pearce (IG) edited comment on KAFKA-4497 at 1/4/17 5:43 PM:

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798847#comment-15798847 ] Michael Andre Pearce (IG) commented on KAFKA-4497: -- [~junrao] This is causing us a

Re: [DISCUSS] KIP-104: Granular Sensors for Streams

2017-01-04 Thread Aarti Gupta
Thanks for the review, Guozhang, addressed comment 1, 3 on the KIP and left 2 for Eno to comment on. (He is back tomorrow) -aarti On Tue, Jan 3, 2017 at 11:12 AM, Guozhang Wang wrote: > Thanks for the proposed KIP. Overall LGTM. > > A few comments: > > 1. "at the

Re: [DISCUSS] KIP-102 - Add close with timeout for consumers

2017-01-04 Thread Jason Gustafson
Hi Rajini, Thanks for the clarification. I looked again at the patch and I see what you're saying now. I was confused because I assumed the request timeout was being enforced on the requests themselves, but it is more that the request timeout bounds the attempt to send them in addition to the

Re: [VOTE] Vote for KIP-101 - Leader Epochs

2017-01-04 Thread Tom Crayford
+1 On Wed, Jan 4, 2017 at 5:28 PM, Gwen Shapira wrote: > +1 - thanks for tackling those old and painful bugs! > > On Wed, Jan 4, 2017 at 9:24 AM, Ben Stopford wrote: > > Hi All > > > > We’re having some problems with this thread being subsumed by the >

[jira] [Commented] (KAFKA-4582) KStream job fails in multi-thread mode

2017-01-04 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798809#comment-15798809 ] Matthias J. Sax commented on KAFKA-4582: IIRC (and the JIRA also indicates it, as it is marked

Re: [VOTE] Vote for KIP-101 - Leader Epochs

2017-01-04 Thread Gwen Shapira
+1 - thanks for tackling those old and painful bugs! On Wed, Jan 4, 2017 at 9:24 AM, Ben Stopford wrote: > Hi All > > We’re having some problems with this thread being subsumed by the [Discuss] > thread. Hopefully this one will appear distinct. If you see more than one, >

[VOTE] Vote for KIP-101 - Leader Epochs

2017-01-04 Thread Ben Stopford
Hi All We’re having some problems with this thread being subsumed by the [Discuss] thread. Hopefully this one will appear distinct. If you see more than one, please use this one. KIP-101 should now be ready for a vote. As a reminder the KIP proposes a change to the replication protocol to

Re: [VOTE] Vote for KIP-101 - Leader Epochs

2017-01-04 Thread Apurva Mehta
Looks good to me! +1 (non-binding) On Wed, Jan 4, 2017 at 9:24 AM, Ben Stopford wrote: > Hi All > > We’re having some problems with this thread being subsumed by the > [Discuss] thread. Hopefully this one will appear distinct. If you see more > than one, please use this one.

[jira] [Updated] (KAFKA-4507) The client should send older versions of requests to the broker if necessary

2017-01-04 Thread Colin P. McCabe (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin P. McCabe updated KAFKA-4507: --- Status: Patch Available (was: In Progress) > The client should send older versions of

[jira] [Commented] (KAFKA-4566) Can't Symlink to Kafka bins

2017-01-04 Thread Colin P. McCabe (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798750#comment-15798750 ] Colin P. McCabe commented on KAFKA-4566: The MacOS version of readlink does not have an {{\-e}}

[jira] [Created] (KAFKA-4591) Create Topic Policy

2017-01-04 Thread Ismael Juma (JIRA)
Ismael Juma created KAFKA-4591: -- Summary: Create Topic Policy Key: KAFKA-4591 URL: https://issues.apache.org/jira/browse/KAFKA-4591 Project: Kafka Issue Type: Improvement Reporter:

[jira] [Commented] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798702#comment-15798702 ] Jun Rao commented on KAFKA-4497: [~michael.andre.pearce], thanks for reporting this. It would be good to

[jira] [Commented] (KAFKA-4573) Producer sporadic timeout

2017-01-04 Thread Ankur C (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798700#comment-15798700 ] Ankur C commented on KAFKA-4573: Outgage lasted 5 hours and after we restarted broker the problem was

Jenkins build is back to normal : kafka-trunk-jdk8 #1148

2017-01-04 Thread Apache Jenkins Server
See

Re: 0.10.2.0 release planning

2017-01-04 Thread Ismael Juma
0.10.1.0 was the release with partial KIP-4 functionality: we added create topics and delete topics to the Kafka protocol. 0.10.2.0 doesn't improve things so far. Ismael On Wed, Jan 4, 2017 at 4:28 PM, Tom Crayford wrote: > Ismael, > > Thanks. Does this mean there's

Re: 0.10.2.0 release planning

2017-01-04 Thread Tom Crayford
Ismael, Thanks. Does this mean there's partially implemented KIP-4 functionality landing in 0.10.2.0? It seems like having release notes for that functionality would be quite important. On Wed, Jan 4, 2017 at 4:16 PM, Ismael Juma wrote: > Hi Tom, > > Thanks for the heads-up.

Re: [DISCUSS] KIP-102 - Add close with timeout for consumers

2017-01-04 Thread Rajini Sivaram
Hi Jason, Thank you for the review. During close(), if there is a rebalance and the coordinator has to be rediscovered, close terminates without trying to find the coordinator. The poll() loop within close terminates if the coordinator is not known (as it does now) or if the timeout expires. At

Re: 0.10.2.0 release planning

2017-01-04 Thread Ismael Juma
Hi Tom, Thanks for the heads-up. Most of KIP-35 was included in 0.10.0.0. The remaining PR was merged to trunk (will be in 0.10.2.0), so I closed the JIRA (and changed KAFKA-3308 to be a standalone task as it wasn't part of KIP-35). About KIP-4, that's a big KIP and it will continue to be open

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-04 Thread radai
one more example of complicated config - mirror maker. we definitely cant trust each and every topic owner to configure their topics not to purge before they've been mirrored. which would mean there's a per-topic config (set by the owner) and a "global" config (where mirror makers are specified)

[jira] [Updated] (KAFKA-3308) Use ProtocolVersion during rolling upgrades to decide on a mutually agreed protocol version between brokers, eliminating the need of inter.broker.protocol.version.

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3308: --- Issue Type: Improvement (was: Sub-task) Parent: (was: KAFKA-3304) > Use ProtocolVersion

[jira] [Commented] (KAFKA-4582) KStream job fails in multi-thread mode

2017-01-04 Thread Manuel Romero (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798610#comment-15798610 ] Manuel Romero commented on KAFKA-4582: -- Hi again. The error continues happening using the release

[jira] [Resolved] (KAFKA-3304) KIP-35 - Retrieving protocol version

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-3304. Resolution: Fixed > KIP-35 - Retrieving protocol version > > >

Re: 0.10.2.0 release planning

2017-01-04 Thread Tom Crayford
Thanks for running the release and being so transparent around plans, it's a great boon to the community. Looking at the plan ( https://cwiki.apache.org/confluence/display/KAFKA/Release+Plan+0.10.2.0), I see KIP-4 and KIP-35 under "Open Issues", but not under "Planned KIP Content". Are those KIPs

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-04 Thread radai
in summary - i'm not opposed to the idea of a per-topic clean up config that tracks some set of consumer groups' offsets (which would probably work for 80% of use cases), but i definitely see a need to expose a simple API for the more advanced/obscure/custom use cases (the other 20%). On Wed, Jan

Re: [DISCUSS] KIP-107: Add purgeDataBefore() API in AdminClient

2017-01-04 Thread radai
a major motivation for this KIP is cost savings. lots of internal systems at LI use kafka as an intermediate pipe, and set the topic retention period to a "safe enough" amount of time to be able to recover from crashes/downtime and catch up to "now". this results in a few days' worth of retention

[jira] [Updated] (KAFKA-4582) KStream job fails in multi-thread mode

2017-01-04 Thread Manuel Romero (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manuel Romero updated KAFKA-4582: - Affects Version/s: 0.10.1.1 > KStream job fails in multi-thread mode >

Build failed in Jenkins: kafka-trunk-jdk8 #1147

2017-01-04 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-4583; Fix KafkaConsumerTest.testGracefulClose transient failure -- [...truncated 17670 lines...] org.apache.kafka.streams.KafkaStreamsTest >

[jira] [Updated] (KAFKA-4508) Create system tests that run client against older versions of the broker

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-4508: --- Summary: Create system tests that run client against older versions of the broker (was: Create

[jira] [Resolved] (KAFKA-4508) Create system tests that run newer versions of the client against older versions of the broker

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-4508. Resolution: Fixed Fix Version/s: 0.10.2.0 Issue resolved by pull request 2263

[jira] [Commented] (KAFKA-4508) Create system tests that run newer versions of the client against older versions of the broker

2017-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798318#comment-15798318 ] ASF GitHub Bot commented on KAFKA-4508: --- Github user asfgit closed the pull request at:

[GitHub] kafka pull request #2263: KAFKA-4508. Create system tests that run newer ver...

2017-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (KAFKA-3155) Transient Failure in kafka.api.PlaintextProducerSendTest.testFlush

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798157#comment-15798157 ] Ismael Juma commented on KAFKA-3155: Some logs in https://issues.apache.org/jira/browse/KAFKA-4550 >

[jira] [Resolved] (KAFKA-4550) current trunk unstable

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-4550. Resolution: Duplicate For the flush issue, there's https://issues.apache.org/jira/browse/KAFKA-3155

Build failed in Jenkins: kafka-trunk-jdk8 #1146

2017-01-04 Thread Apache Jenkins Server
See Changes: [ismael] KAFKA-4434; KafkaProducer configuration is logged twice -- [...truncated 33052 lines...] org.apache.kafka.streams.KafkaStreamsTest >

Re: KIP-103: Separation of Internal and External traffic

2017-01-04 Thread Ismael Juma
Hi Colin, Thanks for the feedback. It's a good question regarding the name `protocol label`. It was an easy starting name given that the security protocol was replaced by a label in the listener string. However, I agree that it's perhaps not as clear as it could be. Maybe `listener key` would be

[jira] [Reopened] (KAFKA-4497) log cleaner breaks on timeindex

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reopened KAFKA-4497: Reopening then. > log cleaner breaks on timeindex > --- > >

[jira] [Resolved] (KAFKA-4583) KafkaConsumerTest.testGracefulClose transient failure

2017-01-04 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-4583. Resolution: Fixed Issue resolved by pull request 2309 [https://github.com/apache/kafka/pull/2309]

[jira] [Commented] (KAFKA-4583) KafkaConsumerTest.testGracefulClose transient failure

2017-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15798055#comment-15798055 ] ASF GitHub Bot commented on KAFKA-4583: --- Github user asfgit closed the pull request at:

  1   2   >